[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

[rodrigo93]

GitHub user rodrigo93 opened a pull request:

    https://github.com/apache/cloudstack/pull/854

    Fixed return type Void to void in DataMotionStrategy.

    The main changes are:
    -   Changing methods “Void” to “void”.
    -   Removal of the method “Void copyAsync(DataObject srcData, DataObject
    destData, AsyncCompletionCallback<CopyCommandResult> callback)” that was
    never used.
    We noticed that methods form that class are using the return type Void
    with capital V. This way that method has to return a null value at the
    end.
    
    The alterations were made at the following classes and their respective 
methods:
    1.  
/cloud-plugin-hypervisor-hyperv/src/org/apache/cloudstack/storage/motion/HypervStorageMotionStrategy.java
    2.  
/cloud-engine-api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataMotionStrategy.java
    3.  
/cloud-engine-storage-datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
    4.  
/cloud-engine-storage-datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
    5.  
/cloud-plugin-hypervisor-simulator/src/org/apache/cloudstack/storage/motion/SimulatorDataMotionStrategy.java
    6.  
/cloud-plugin-hypervisor-xenserver/src/org/apache/cloudstack/storage/motion/XenServerStorageMotionStrategy.java
    We also removed the following method from the class 
“org.apache.cloudstack.engine.subsystem.api.storage.DataMotionStrategy” 
because it was never called nor used.
    Method:  “Void copyAsync(DataObject srcData, DataObject destData, 
AsyncCompletionCallback<CopyCommandResult> callback)”


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rafaelweingartner/cloudstack 
master-lrg-cs-hackday-002

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/854.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #854
    
----
commit 82bf6c0058ed5d9bf7a732a66f7cbcfd3a3cc22a
Author: Rodrigo Marques <rodrigomarques1...@gmail.com>
Date:   2015-09-19T19:57:20Z

    Fixed return type Void to void in  DataMotionStrategy.
    
    The main changes are:
    -   Changing methods “Void” to “void”.
    -   Removal of the method “Void copyAsync(DataObject srcData, DataObject
    destData, AsyncCompletionCallback<CopyCommandResult> callback)” that was
    never used.
    We noticed that methods form that class are using the return type Void
    with capital V. This way that method has to return a null value at the
    end.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---