Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1360#issuecomment-177348201
Hi @ProjectMoon,
What a great work you did here.
Splitting the PR in two seems a good idea, in my point of view, since you
create two tests cases for distinct classes and edited each one.
Consider squashing the commits as well after that.
I would suggest you to make a JIRA and add it's tag to the title of this
PR. So it would be something like: CLOUDSTACK-(number): Refactor system VM
default network creation.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
