Re: SNAT iptable entry on VirtualRouter

2014-06-08 Thread Sachchidanand Vaidya
ailto:dev@cloudstack.apache.org>>" mailto:dev@cloudstack.apache.org>>, Sachchidanand Vaidya mailto:vaidy...@juniper.net>> Subject: Re: SNAT iptable entry on VirtualRouter Hi Sachin, The nicDevId() you see is coming from prepareNetworkElementCommand(IpAssocCommand cmd)

Re: SNAT iptable entry on VirtualRouter

2014-06-06 Thread Sachchidanand Vaidya
Hi, I'm seeing the same issue with 4.4 code. After further debug, I see that CS mgmt server is sending following command to XenHost, xensource.log: /opt/cloud/bin/ipassoc.sh -A -s -f -l 10.84.59.131/24 -c eth0 -g 10.84.59.254 VirtualRouter's public interface is eth2. Also as per dump of VIF l

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-05-20 Thread Sachchidanand Vaidya
Hi Rajesh, Can you pls review the updated diff. Thanks, Sachin On 5/7/14 3:44 PM, "Sachchidanand Vaidya" wrote: > >--- >This is an automatically generated e-mail. To reply, visit: >https://revi

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-05-16 Thread Sachchidanand Vaidya
/ServiceManagerImpl.java f34eacc plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c Diff: https://reviews.apache.org/r/19270/diff/ Testing --- Unit tests passed and additional testing done locally. Thanks, Sachchidanand Vaidya

Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.

2014-05-15 Thread Sachchidanand Vaidya
ck/network/contrail/management/ContrailVSrxElementImpl.java, > > line 206 > > <https://reviews.apache.org/r/19758/diff/1/?file=539139#file539139line206> > > > > missed formatting fixed. - Sachchidanand --

Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.

2014-05-15 Thread Sachchidanand Vaidya
rg/r/19758/diff/1/?file=539139#file539139line206>(Diff revision 1) 206 @Override missed formatting [SACHIN] Will take care. - Rajesh Battala On May 3rd, 2014, 7:30 a.m. UTC, Sachchidanand Vaidya wrote: Review request for cloudstack and Rajesh Battala. By Sachchidanand Vaidya.

Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.

2014-05-15 Thread Sachchidanand Vaidya
9060f1 Diff: https://reviews.apache.org/r/19758/diff/ Testing --- Performed unit tests with vSRX network service provider. Also other unit tests pass in local testbed. Thanks, Sachchidanand Vaidya

SNAT iptable entry on VirtualRouter

2014-05-15 Thread Sachchidanand Vaidya
Hi, I have an isolated network (192.168.3.x/24) being served by VirtualRouter, where 10.84.59.131 is SourceNAT address and eth0 is VN interface of VirtualRouter & eth2 is the public interface of VirtualRouter. When I look at the nat table entries on the VirtualRouter, it shows following :

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-05-14 Thread Sachchidanand Vaidya
instance VM creation and destroy. - Sachchidanand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19270/#review42253 ------- On May 7, 2014, 3:44 p.m., Sachchidanand Vaidya wrote: > > ---

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-05-13 Thread Sachchidanand Vaidya
ly, visit: https://reviews.apache.org/r/19270/#review42254 --- On May 7, 2014, 3:44 p.m., Sachchidanand Vaidya wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.

2014-05-03 Thread Sachchidanand Vaidya
ts with vSRX network service provider. Also other unit tests pass in local testbed. Thanks, Sachchidanand Vaidya

Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-05-03 Thread Sachchidanand Vaidya
f34eacc plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c Diff: https://reviews.apache.org/r/19270/diff/ Testing --- Unit tests passed and additional testing done locally. Thanks, Sachchidanand Vaidya

Re: Review Request 19892: Add Juniper Contrail support to devCloud environment

2014-05-02 Thread Sachchidanand Vaidya
Hi Daan, I uploaded a diff (ACS4.4-0004-Add-OpenContrail-support-to-devCloud-environment.patch) based on ACS4.4 code base. Thanks, Sachin From: Daan Hoogland mailto:daan.hoogl...@gmail.com>> Date: Friday, May 2, 2014 11:03 AM To: Sachchidanand Vaidya mailto:vaidy...@juniper.ne

Re: Review Request 19892: Add Juniper Contrail support to devCloud environment

2014-05-02 Thread Sachchidanand Vaidya
Testing --- Unit tested with devCloud2 and ACS4.3 code base. Thanks, Sachchidanand Vaidya

Re: Review Request 19892: Add Juniper Contrail support to devCloud environment

2014-05-01 Thread Sachchidanand Vaidya
Thanks Daan. Can it be committed to 4.4 as well. Best Regards, Sachin From: daan Hoogland mailto:daan.hoogl...@gmail.com>> Reply-To: daan Hoogland mailto:daan.hoogl...@gmail.com>> Date: Thursday, May 1, 2014 4:11 AM To: daan Hoogland mailto:daan.hoogl...@gmail.com>>, Sa

Re: Review Request 19892: Add Juniper Contrail support to devCloud environment

2014-04-30 Thread Sachchidanand Vaidya
rvin/deployDataCenter.py 31f663e Diff: https://reviews.apache.org/r/19892/diff/ Testing --- Unit tested with devCloud2 and ACS4.3 code base. Thanks, Sachchidanand Vaidya

Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.

2014-04-17 Thread Sachchidanand Vaidya
. Thanks, Sachchidanand Vaidya

Re: Review Request 19912: [CLOUDSTACK-6322] Fixed Contrail: Params validation is missing while launching a service instance thru cloudmonkey

2014-04-16 Thread Sachchidanand Vaidya
an.hoogl...@gmail.com>>, Sachchidanand Vaidya mailto:vaidy...@juniper.net>>, cloudstack mailto:dev@cloudstack.apache.org>> Subject: Re: Review Request 19912: [CLOUDSTACK-6322] Fixed Contrail: Params validation is missing while launching a service instance thru cloudmonkey This is an a

Re: Review Request 19912: [CLOUDSTACK-6322] Fixed Contrail: Params validation is missing while launching a service instance thru cloudmonkey

2014-04-15 Thread Sachchidanand Vaidya
a good idea from usability/debugability point of view. Thanks & Regards, Sachin - Sachchidanand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19912/#review40393 ------

Re: Review Request 19892: Add Juniper Contrail support to devCloud environment

2014-04-15 Thread Sachchidanand Vaidya
/r/19892/diff/ Testing --- Unit tested with devCloud2 and ACS4.3 code base. Thanks, Sachchidanand Vaidya

Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.

2014-04-14 Thread Sachchidanand Vaidya
Hi, Can someone pls. review these changes. Thanks & Regards, Sachin From: Sachchidanand Vaidya mailto:vaidy...@juniper.net>> Reply-To: Sachchidanand Vaidya mailto:vaidy...@juniper.net>> Date: Thursday, March 27, 2014 4:38 PM To: Sachchidanand Vaidya mailto:vaid

Re: Review Request 19892: Add Juniper Contrail support to devCloud environment

2014-04-14 Thread Sachchidanand Vaidya
Hi, Can someone pls review these changes. Thanks & Regards, Sachin From: Sachchidanand Vaidya mailto:vaidy...@juniper.net>> Reply-To: Sachchidanand Vaidya mailto:vaidy...@juniper.net>> Date: Tuesday, April 1, 2014 3:05 PM To: Sachchidanand Vaidya mailto:vaidy...@juniper.ne

Re: Review Request 19912: [CLOUDSTACK-6322] Fixed Contrail: Params validation is missing while launching a service instance thru cloudmonkey

2014-04-14 Thread Sachchidanand Vaidya
Hi, Can someone pls review these changes. Thanks & Regards, Sachin On 4/2/14 2:14 AM, "Sachchidanand Vaidya" wrote: > >--- >This is an automatically generated e-mail. To reply, visit: >https://

Review Request 19912: [CLOUDSTACK-6322] Fixed Contrail: Params validation is missing while launching a service instance thru cloudmonkey

2014-04-02 Thread Sachchidanand Vaidya
diff/ Testing --- Unit tested for null and empty "name" parameter. Thanks, Sachchidanand Vaidya

Review Request 19892: Add Juniper Contrail support to devCloud environment

2014-04-01 Thread Sachchidanand Vaidya
quot; providers. Diffs - tools/devcloud/devcloud-advanced_juniper-contrail.cfg PRE-CREATION tools/marvin/marvin/deployDataCenter.py c4f6e1e Diff: https://reviews.apache.org/r/19892/diff/ Testing --- Unit tested with devCloud2 and ACS4.3 code base. Thanks, Sachchidanand Vaidya

devCloud2 and master

2014-03-31 Thread Sachchidanand Vaidya
Hi All, I'm trying to run devCloud2 with CS Management server running master code. Setup is: CS Mgmt Server: 192.168.56.1, XenHost ova:192.168.56.10 -> While trying to setup Basic networking using (devcloud.cfg), got "Cannot create directory /opt/cloud/bin on XenServer hosts" error during

Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.

2014-03-27 Thread Sachchidanand Vaidya
al testbed. Thanks, Sachchidanand Vaidya

Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes

2014-03-16 Thread Sachchidanand Vaidya
/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c Diff: https://reviews.apache.org/r/19270/diff/ Testing --- Unit tests passed and additional testing done locally. Thanks, Sachchidanand Vaidya

Re: Difference between "Guest Network" and "Isolated Network" under Advanced Networking

2014-02-14 Thread Sachchidanand Vaidya
p, which vm's traffic go through >>>switch >>> directly. >>> Isolated Network is a virtual network, all traffic go through VRouter. >>> And if you assigned tag on Physical Network, if so you should set same >>>tag >>> on n/w offering. >

Difference between "Guest Network" and "Isolated Network" under Advanced Networking

2014-02-12 Thread Sachchidanand Vaidya
Hi, Under "Networks" Tab in UI for Admin user, Cloudstack provides 2 options to create networks 1) Add guest network 2) Add Isolated Network. - What is the difference between these 2 networks. Also, I created and Enabled a new "Network Offering". But when I create an Isolated Ne

Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.

2014-02-05 Thread Sachchidanand Vaidya
://reviews.apache.org/r/16523/diff/ Testing --- All Juniper contrail plugin unit tests pass without any error. Thanks, Sachchidanand Vaidya

Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.

2014-02-03 Thread Sachchidanand Vaidya
--- All Juniper contrail plugin unit tests pass without any error. Thanks, Sachchidanand Vaidya

Review Request 17307: Juniper Contrail Plugin fixes

2014-01-24 Thread Sachchidanand Vaidya
Diff: https://reviews.apache.org/r/17307/diff/ Testing --- Passes unit tests. Thanks, Sachchidanand Vaidya

Re: Review Request 16974: (ACS4.3) Juniper Contrail Plugin fixes

2014-01-16 Thread Sachchidanand Vaidya
-mail. To reply, visit: https://reviews.apache.org/r/16974/ Are these fixes release blockers or can they go into 4.4? The release 4.3 is effectively closed by now. Cheers, Hugo - Hugo Trippaers On January 16th, 2014, 6:53 p.m. UTC, Sachchidanand Vaidya wrote: Review request for cloudstack. By Sachchid

Review Request 16974: (ACS4.3) Juniper Contrail Plugin fixes

2014-01-16 Thread Sachchidanand Vaidya
Diff: https://reviews.apache.org/r/16974/diff/ Testing --- Locally tested on centOS6.3 machine. Thanks, Sachchidanand Vaidya

Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-14 Thread Sachchidanand Vaidya
g/r/16258/#review31812 >--- > >Ship it! > > >Applied to MASTER. > >Thanks. > >- Sheng Yang > > >On Jan. 14, 2014, 9:44 p.m., Sachchidanand Vaidya wrote: >> >> --- >> This is an

Re: Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-14 Thread Sachchidanand Vaidya
> > Ship it! > > > Applied to 4.3 branch. > > Thanks. > > > - Sheng Yang > > > On Jan. 14, 2014, 1:54 a.m., Sachchidanand Vaidya wrote: >> >> --- >> This is an automatically gene

Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-14 Thread Sachchidanand Vaidya
To reply, visit: >https://reviews.apache.org/r/16258/#review31802 >--- > > >Looks good to me, but cannot applied to the latest MASTER branch(I >suppose that's the target). > >- Sheng Yang > >

Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-14 Thread Sachchidanand Vaidya
/ManagementServerMock.java 806dd21 ui/scripts/ui-custom/zoneWizard.js 99aa3b9 Diff: https://reviews.apache.org/r/16258/diff/ Testing --- Changes pass unit tests and complete centos63 package build. Thanks, Sachchidanand Vaidya

Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-13 Thread Sachchidanand Vaidya
/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java bbff466 ui/scripts/ui-custom/zoneWizard.js 28df193 Diff: https://reviews.apache.org/r/16841/diff/ Testing --- Unit testing done. Thanks, Sachchidanand Vaidya

Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2014-01-12 Thread Sachchidanand Vaidya
ui/scripts/ui-custom/zoneWizard.js 28df193 Diff: https://reviews.apache.org/r/16258/diff/ Testing --- Changes pass unit tests and complete centos63 package build. Thanks, Sachchidanand Vaidya

RE: CLOUDSTACK-5502 [Automation] createVlanIpRange API failing, if you pass VLAN

2014-01-07 Thread Sachchidanand Vaidya
Hi, Bug CS-5502 was fixed (12/20/13) and then reopened (12/26/13) again since for Vlan=UNTAGGED case, createVlanIpRange() API fails with "Vlan id is required when add ip range to the public network". Vlan ="untagged" can be a valid case for public networks (in advanced networking) as is t

Review Request 16523: Unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.

2013-12-30 Thread Sachchidanand Vaidya
/apache/cloudstack/network/contrail/management/VMInterfaceModelTest.java PRE-CREATION Diff: https://reviews.apache.org/r/16523/diff/ Testing --- All Juniper contrail plugin unit tests pass without any error. Thanks, Sachchidanand Vaidya

Re: Review Request 15825: Added unit tests for Juniper Contrail Virtual Network (VN) and Virtual Machine (VM) Model classes.

2013-12-30 Thread Sachchidanand Vaidya
g/r/15825/#review30945 >--- > >Ship it! > > >commit 7f9683af859224b4aa0cae037acda063a9d1536e >Author: Sachchidanand Vaidya >Date: Tue Dec 10 09:02:25 2013 -0800 > >Added Virtual-Network and Virtual-Machine Model unit test. > >Signed-off

Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

2013-12-13 Thread Sachchidanand Vaidya
--- Changes pass unit tests and complete centos63 package build. Thanks, Sachchidanand Vaidya

Re: Review Request 15825: Added unit tests for Juniper Contrail Virtual Network (VN) and Virtual Machine (VM) Model classes.

2013-12-10 Thread Sachchidanand Vaidya
iper contrail Unit Tests ran successfully as part of package build. Thanks, Sachchidanand Vaidya

Re: Review Request 15825: Added unit tests for Juniper Contrail Virtual Network (VN) and Virtual Machine (VM) Model classes.

2013-12-09 Thread Sachchidanand Vaidya
chidanand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15825/#review29367 --- On Nov. 24, 2013, 6:59 p.m., Sachchidanand Vai

Review Request 15825: Added unit tests for Juniper Contrail Virtual Network (VN) and Virtual Machine (VM) Model classes.

2013-11-24 Thread Sachchidanand Vaidya
work-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java 0938541 Diff: https://reviews.apache.org/r/15825/diff/ Testing --- Juniper contrail Unit Tests ran successfully as part of package build. Thanks, Sachchidanand Vaidya