Yes. It's a bug. Also can the fix be committed to 4.4 as well. Thanks & regards, Sachin
From: daan Hoogland <daan.hoogl...@gmail.com<mailto:daan.hoogl...@gmail.com>> Reply-To: daan Hoogland <daan.hoogl...@gmail.com<mailto:daan.hoogl...@gmail.com>> Date: Wednesday, April 16, 2014 5:59 AM To: daan Hoogland <daan.hoogl...@gmail.com<mailto:daan.hoogl...@gmail.com>>, Sachchidanand Vaidya <vaidy...@juniper.net<mailto:vaidy...@juniper.net>>, cloudstack <dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>> Subject: Re: Review Request 19912: [CLOUDSTACK-6322] Fixed Contrail: Params validation is missing while launching a service instance thru cloudmonkey This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19912/ On April 15th, 2014, 2:23 p.m. UTC, daan Hoogland wrote: It would seem that this is a behavioral change that would break backwards compatibility, is it? Right now empty service names are accepted. What is the consequence and why change the behavior, can you shed light on the subject? otherwise the change seems trivial enough and is applicable. On April 15th, 2014, 8:33 p.m. UTC, Sachchidanand Vaidya wrote: Hi Daan, If user passes "null" string during instance creation then it's an issue since we can't search service-instance with a null string as part of Fully Qualified Name lookup on Contrail Controller. Hence user can't delete a service-instance with "null" string. Passing empty string is functionally ok but we want to avoid both "null" and "empty" string since it's not a good idea from usability/debugability point of view. Thanks & Regards, Sachin ok, thanks. seems like a bug fix more then a behavioral change. - daan On April 2nd, 2014, 9:14 a.m. UTC, Sachchidanand Vaidya wrote: Review request for cloudstack. By Sachchidanand Vaidya. Updated April 2, 2014, 9:14 a.m. Repository: cloudstack-git Description Don't allow service instance creation with empty or null service-instance "name" Testing Unit tested for null and empty "name" parameter. Diffs * plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java (d2cb4de) View Diff<https://reviews.apache.org/r/19912/diff/>
