Re: Review Request 28691: Cloudstack records ids into events table instead of UUIDs for create snapshot command

descripton insted of UUIDs in event tbale. Diffs (updated) - api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java df7fe82 Diff: https://reviews.apache.org/r/28691/diff/ Testing --- Thanks, Damodar Reddy Talakanti

Review Request 28700: Attach volume events are not correctly shown in events.

torage/VolumeApiServiceImpl.java 785a95e Diff: https://reviews.apache.org/r/28700/diff/ Testing --- Tested by attaching volume to a VM Thanks, Damodar Reddy Talakanti

Review Request 28691: Cloudstack records ids into events table instead of UUIDs for create snapshot command

ack/api/command/user/snapshot/CreateSnapshotCmd.java df7fe82 Diff: https://reviews.apache.org/r/28691/diff/ Testing --- Thanks, Damodar Reddy Talakanti

Review Request 28325: Two "VOLUME.DELETE" Events are being registered instead of one - On Destroying a User VM belonging to a Project

: https://reviews.apache.org/r/28325/diff/ Testing --- Tested as a normal user Tested as a admin (With and with out pasing expunge flag) Tested by attaching Data disks Thanks, Damodar Reddy Talakanti

Review Request 28168: public_ip type resource count for an account is not decremented upon IP range deletion

/ConfigurationManagerImpl.java 2cb4203 Diff: https://reviews.apache.org/r/28168/diff/ Testing --- Tested on latest master with Xen Hypervisor. Tested with acquiring atleast an IP from that account and with out acquiring any IPs from that account. Thanks, Damodar Reddy Talakanti

Review Request 28114: RabbitMQ integration, make SSL protocol configurable rather than hard coded

. Diffs - plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java 2d389f2 Diff: https://reviews.apache.org/r/28114/diff/ Testing --- Tested against RabbitMQ server 3.3.5 Thanks, Damodar Reddy Talakanti

Review Request 27904: cloudstackoperations like deployvm, deleteNW are failing if CS fail to contact rabbit mq server

/com/cloud/api/ApiServer.java e29ddd3 Diff: https://reviews.apache.org/r/27904/diff/ Testing --- Tested against Xen for operations like deployVM and delete a network. Thanks, Damodar Reddy Talakanti

Review Request 27856: The NET.IPRELEASE events are not added to usage_event on IP range deletion from Physical Networks

- server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1f71c0f Diff: https://reviews.apache.org/r/27856/diff/ Testing --- Tested on Xen against the above use case and some other use cases. Thanks, Damodar Reddy Talakanti

Re: Review Request 27222: Usage Events to be captured based on Volume State Machine

. Upload Volume (Attach also) 4. Delete Volume 5. Deploy VM (With Data Disk and with out Data Disk) 6. Destroy VM (With Data Disk and with out Data Disk) 7. Recover VM 8. Restore VM 9. Resize Volume Thanks, Damodar Reddy Talakanti

Re: Review Request 27520: Usage Job fails with "Data too long for column 'user_name'"

s://reviews.apache.org/r/27520/diff/ Testing --- Tested on 4.5.0 by upgrading from 4.3.0 Thanks, Damodar Reddy Talakanti

Review Request 27671: MS does not start after the VM it is running on is rebooted

-management.rc eaabd30 Diff: https://reviews.apache.org/r/27671/diff/ Testing --- Tested on Centos 6.x and RHEL 7 Thanks, Damodar Reddy Talakanti

Review Request 27613: sync Job Failures always reported as success on Event Bus

- framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java 548182a Diff: https://reviews.apache.org/r/27613/diff/ Testing --- Thanks, Damodar Reddy Talakanti

Review Request 27520: Usage Job fails with "Data too long for column 'user_name'"

olumn 'user_name' at row 1 at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:4072) Diffs - setup/db/db/schema-441to450.sql 3deb8ad Diff: https://reviews.apache.org/r/27520/diff/ Testing --- Tested on 4.5.0 by upgrading from 4.3.0 Thanks, Damodar Reddy Talakanti

Re: Review Request 27222: Usage Events to be captured based on Volume State Machine

also) 4. Delete Volume 5. Deploy VM (With Data Disk and with out Data Disk) 6. Destroy VM (With Data Disk and with out Data Disk) 7. Recover VM 8. Restore VM 9. Resize Volume Thanks, Damodar Reddy Talakanti

Review Request 27222: Usage Events to be captured based on Volume State Machine

Disk and with out Data Disk) 7. Recover VM 8. Restore VM Thanks, Damodar Reddy Talakanti

Review Request 26738: listVMSnapshot API is not returning parent id in response

/response/VMSnapshotResponse.java 168c548 server/src/com/cloud/api/ApiResponseHelper.java 50376d2 Diff: https://reviews.apache.org/r/26738/diff/ Testing --- Tested on latest Master with XenServer Hypervisor. Thanks, Damodar Reddy Talakanti

Re: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events

erify that events are generated. Ran Simulator and used smoke tests against simulator to test it. Thanks, Damodar Reddy Talakanti

Re: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events

s are generated. Thanks, Damodar Reddy Talakanti

Re: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events

sting --- Tested on Simulator for all VM Lifecycle states and tested with Xenserver for VM Sync reatled actions. Ran Simulator for VM lifecycle realted tests. Currenly there is no API call listUsageEvents to verify that events are generated. Thanks, Damodar Reddy Talakanti

Re: Review Request 26356: [RHEL7] management server failed to start once machine is rebooted

/macros.spec 4b71092 Diff: https://reviews.apache.org/r/26356/diff/ Testing --- Tested on RHEL-7 and RHEL 6.2 servers. Installed and re booted the machines.. Thanks, Damodar Reddy Talakanti

Review Request 26356: [RHEL7] management server failed to start once machine is rebooted

--- Tested on RHEL-7 and RHEL 6.2 servers. Installed and re booted the machines.. Thanks, Damodar Reddy Talakanti

Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events

cycle states and tested with Xenserver for VM Sync reatled actions. Ran Simulator for VM lifecycle realted tests. Currenly there is no API call listUsageEvents to verify that events are generated. Thanks, Damodar Reddy Talakanti

Review Request 25240: Management Server setup doesn't proceed to completion

. Thanks, Damodar Reddy Talakanti

Re: Review Request 25228: hitting java.lang.reflect.InvocationTargetException while starting usage server

Tested on centos 6.3 and rhel 7 Thanks, Damodar Reddy Talakanti

Review Request 25228: hitting java.lang.reflect.InvocationTargetException while starting usage server

encryption enabled. Usage is server is unable to get "key" file from the classpath. Diffs - packaging/centos63/cloud.spec 790f57b Diff: https://reviews.apache.org/r/25228/diff/ Testing --- Tested on centos 6.3 and rhel 7 Thanks, Damodar Reddy Talakanti

Review Request 25057: package.sh was failing if we don to pass "-o" option but pass "-p" option

to not passing "-o" patch but passing "-p" option Diffs - packaging/centos63/package.sh d239d2e Diff: https://reviews.apache.org/r/25057/diff/ Testing --- Tested on cetnos6.3 and rhel7 with noredist mode and default mode. Thanks, Damodar Reddy Talakanti

Re: Review Request 24936: RPM build failing with RHEL7

To reply, visit: https://reviews.apache.org/r/24936/#review51500 ----------- On Aug. 26, 2014, 5:31 a.m., Damodar Reddy Talakanti wrote: > > --- > This is an automatical

Re: Review Request 24936: RPM build failing with RHEL7

/centos63/rhel7/macros.spec PRE-CREATION packaging/centos63/rhel7/tomcat.sh PRE-CREATION python/lib/cloudutils/serviceConfigServer.py 2c19d7e Diff: https://reviews.apache.org/r/24936/diff/ Testing --- Tested on RHEL7 and Centos 6.3 Thanks, Damodar Reddy Talakanti

Re: Review Request 24936: RPM build failing with RHEL7

RHEL7 and Centos 6.3 Thanks, Damodar Reddy Talakanti

Re: Review Request 24936: RPM build failing with RHEL7

packaging/centos63/rhel7/tomcat.sh PRE-CREATION python/lib/cloudutils/serviceConfigServer.py 2c19d7e Diff: https://reviews.apache.org/r/24936/diff/ Testing --- Tested on RHEL7 and Centos 6.3 Thanks, Damodar Reddy Talakanti

Re: Review Request 24936: RPM build failing with RHEL7

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24936/#review51250 ----------- On Aug. 21, 2014, 4:15 p.m., Damodar Reddy Talakanti wrote: > > --

Review Request 24936: RPM build failing with RHEL7

2c19d7e Diff: https://reviews.apache.org/r/24936/diff/ Testing --- Tested on RHEL7 and Centos 6.3 Thanks, Damodar Reddy Talakanti

Re: Review Request 24308: Enable Password Strength check for all users

branch. Tested the following scenarios 1. Enable the password checker 2. Enable the password enforce 3. Not enabled both above parameters. 4. Not putting the plugin into the deployment. Thanks, Damodar Reddy Talakanti

Review Request 24308: Enable Password Strength check for all users

parameters. 4. Not putting the plugin into the deployment. Thanks, Damodar Reddy Talakanti

Review Request 24300: listIsos call does not return isdynamicallyscalable in the response attributes as mentioned in API docs

- server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java 4c8ada1 Diff: https://reviews.apache.org/r/24300/diff/ Testing --- Tested by calling listIsos as admin and normal user on master branch Thanks, Damodar Reddy Talakanti

Re: Review Request 23924: Fixed some more Coverity issues in CitrixResourceBase.java

) - plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 775f5455 Diff: https://reviews.apache.org/r/23924/diff/ Testing --- Ran against marvin BVT. Thanks, Damodar Reddy Talakanti

Re: Review Request 23924: Fixed some more Coverity issues in CitrixResourceBase.java

, 1222185, 1222181, 1222180 Diffs (updated) - plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 775f5455 Diff: https://reviews.apache.org/r/23924/diff/ Testing (updated) --- Ran against marvin BVT. Thanks, Damodar Reddy Talakanti

Re: Review Request 23924: Fixed some more Coverity issues in CitrixResourceBase.java

- plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java e961250 Diff: https://reviews.apache.org/r/23924/diff/ Testing --- Thanks, Damodar Reddy Talakanti

Review Request 23924: Fixed some more Coverity issues in CitrixResourceBase.java

e961250 Diff: https://reviews.apache.org/r/23924/diff/ Testing --- Thanks, Damodar Reddy Talakanti

Re: Review Request 23915: Fixing some coverity reported issues

ource/CitrixResourceBase.java 71aa01e Diff: https://reviews.apache.org/r/23915/diff/ Testing --- Thanks, Damodar Reddy Talakanti

Re: Review Request 23915: Fixing some coverity reported issues

e returning null values as well. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23915/#review48713 --- On July 25, 2014, 6:1

Re: Review Request 23915: Fixing some coverity reported issues

/CitrixResourceBase.java 71aa01e Diff: https://reviews.apache.org/r/23915/diff/ Testing --- Thanks, Damodar Reddy Talakanti

Review Request 23915: Fixing some coverity reported issues

Reddy Talakanti

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

. Diffs (updated) - api/src/com/cloud/event/EventTypes.java 411f620 server/src/com/cloud/vm/UserVmManagerImpl.java 90f37ef Diff: https://reviews.apache.org/r/23617/diff/ Testing --- Tested against the following setup: 1. XenServer 6.2 2. Master Branch Thanks, Damodar Reddy

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

. Diffs - api/src/com/cloud/event/EventTypes.java 411f620 server/src/com/cloud/vm/UserVmManagerImpl.java 90f37ef Diff: https://reviews.apache.org/r/23617/diff/ Testing --- Tested against the following setup: 1. XenServer 6.2 2. Master Branch Thanks, Damodar Reddy Talakanti

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

cmd ? > > create=true should be added only when its invoked through the create() > > method of a BaseAyncCreate cmd > > Damodar Reddy Talakanti wrote: > We can not extend AddNicToVMCmd by BaseAsyncCreate cmd as it is doing > many checks before creating the entry NI

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

following setup: 1. XenServer 6.2 2. Master Branch Thanks, Damodar Reddy Talakanti

Re: Review Request 23723: Added the extra space in the error message which was having readability issue.

which was having readability issue. Diffs - api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java 90aed5e Diff: https://reviews.apache.org/r/23723/diff/ Testing --- Thanks, Damodar Reddy Talakanti

Re: Review Request 23723: Added the extra space in the error message which was having readability issue.

which was having readability issue. Diffs - api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java 90aed5e Diff: https://reviews.apache.org/r/23723/diff/ Testing --- Thanks, Damodar Reddy Talakanti

Review Request 23723: Added the extra space in the error message which was having readability issue.

, Damodar Reddy Talakanti

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

cmd ? > > create=true should be added only when its invoked through the create() > > method of a BaseAyncCreate cmd > > Damodar Reddy Talakanti wrote: > We can not extend AddNicToVMCmd by BaseAsyncCreate cmd as it is doing > many checks before creating the entry NI

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

id made create=true there. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/#review48016 ------- On July 17, 2

Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

71bfdb6 server/src/com/cloud/vm/UserVmManagerImpl.java d0bc186 Diff: https://reviews.apache.org/r/23617/diff/ Testing --- Tested against the following setup: 1. XenServer 6.2 2. Master Branch Thanks, Damodar Reddy Talakanti

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

--------- On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23192/ >

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

2012 Server Thanks, Damodar Reddy Talakanti

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

/23192/diff/ Testing --- Tested on Windows 2012 Server Thanks, Damodar Reddy Talakanti

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

, Damodar Reddy Talakanti

Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

scripts/installer/windows/readme.txt PRE-CREATION Diff: https://reviews.apache.org/r/23192/diff/ Testing --- Tested on Windows 2012 Server Thanks, Damodar Reddy Talakanti

Review Request 22865: [Automation] test_01_primary_storage_iscsi failed on "test_primary_storage.py" - Wrong iscsi path format - it should be /targetIQN/LUN

22865/diff/ Testing --- Tested with iSCSI primary storage with XenServer Thanks, Damodar Reddy Talakanti

Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

pshot creation from root disk 4. Snapshot creation from data disk 5. volume creation from (3) 6. template creation from(3) 7. Launch a VM after registering new template. Thanks, Damodar Reddy Talakanti

Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

modar Reddy Talakanti

Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

reviews.apache.org/r/22510/#review45720 --- On June 17, 2014, 6:34 a.m., Damodar Reddy Talakanti wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

d the following use cases. 1. Attach ISO 2. Detach ISO 3. Snapshot creation from root disk 4. Snapshot creation from data disk 5. volume creation from (3) 6. template creation from(3) 7. Launch a VM after registering new template. Thanks, Damodar Reddy Talakanti

Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

-------- On June 12, 2014, 12:32 p.m., Damodar Reddy Talakanti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22510/ > -

Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

fix will be done when we touch them. - Damodar Reddy Talakanti On June 12, 2014, 12:32 p.m., Damodar Reddy Talakanti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

ation from data disk 5. volume creation from (3) 6. template creation from(3) 7. Launch a VM after registering new template. Thanks, Damodar Reddy Talakanti

Re: Review Request 22453: [windows]Adding prot fields to the database creation wizard

://reviews.apache.org/r/22453/diff/ Testing --- Tested it on windows 2012 R2 Server as well as Centos server Thanks, Damodar Reddy Talakanti

Review Request 22453: [windows]Adding prot fields to the database creation wizard

--- Tested it on windows 2012 R2 Server as well as Centos server Thanks, Damodar Reddy Talakanti

Review Request 22260: [Windows] Due to progress bar changes mysql bin path was not getting read from the Path environment variable, fixing the same

://reviews.apache.org/r/22260/diff/ Testing --- Testing is done on Windows R2 Server as well as Linux environments. Thanks, Damodar Reddy Talakanti

Review Request 22126: [Windows]Integrate SystemSeed Template into installer and add progress bar messages to the installer so that admin can aware of changes happening to the system

: https://reviews.apache.org/r/22126/diff/ Testing --- Tested On Windows 2012 R2 Server Thanks, Damodar Reddy Talakanti

Review Request 21900: [Windows] Move all titles and descriptions to a property file or move to build properties

/windows/optionstheme.xml 527309f scripts/installer/windows/optionstheme_en-us.wxl PRE-CREATION Diff: https://reviews.apache.org/r/21900/diff/ Testing --- Tested on windows 2012 R2 server Thanks, Damodar Reddy Talakanti

Review Request 21855: Adding optionstheme.xml to enable checkbox selection to the installer for mysql

- scripts/installer/windows/optionstheme.xml PRE-CREATION Diff: https://reviews.apache.org/r/21855/diff/ Testing --- Tested on Windows 2012 R2 Servers Thanks, Damodar Reddy Talakanti

Review Request 21763: [Windows]Give Option to install or not MySql Server along with Main Installer on the same server

/installer/windows/dependencies.wxs 56ea2a4 Diff: https://reviews.apache.org/r/21763/diff/ Testing --- Tested on windows 2012 R2 server Thanks, Damodar Reddy Talakanti

Review Request 21621: Adding Setup tools for Python is integrated into Windows msi isntaller

Reddy Talakanti

Re: Review Request 21155: [Windows]Integrate dependencies into MSI Windows installer

Thanks, Damodar Reddy Talakanti

Review Request 21155: [Windows]Integrate dependencies into MSI Windows installer

/installer/windows/dependencies.wxs PRE-CREATION Diff: https://reviews.apache.org/r/21155/diff/ Testing --- These changes are specific windows files so tested on windows 2012 R2 server Thanks, Damodar Reddy Talakanti

Review Request 20774: Fixing some minor issues in cloud-setup-databases script and acs.wxs scripts

, Damodar Reddy Talakanti

Re: Review Request 20443: Integrate Deploy DB Into windows msi installer

lated to build process. Thanks, Damodar Reddy Talakanti

Re: Review Request 20445: Add new Command line options to setup/bindir/cloud-setup-databases.in and remove OS specific commands

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20445/#review40804 ----------- On April 17, 2014, 9:41 a.m., Damodar Reddy Talakanti wrote: > > ---

Re: Review Request 20443: Integrate Deploy DB Into windows msi installer

changes are related to build process. Thanks, Damodar Reddy Talakanti

Review Request 20445: Add new Command line options to setup/bindir/cloud-setup-databases.in and remove OS specific commands

s happened for template parameters during build) Thanks, Damodar Reddy Talakanti

Review Request 20443: Integrate Deploy DB Into windows msi installer

PRE-CREATION scripts/installer/windows/WixInstallerDialog.wxs PRE-CREATION scripts/installer/windows/acs.wxs 0e7dea7 Diff: https://reviews.apache.org/r/20443/diff/ Testing --- Tested against Windows 2008 R2 server as changes are related to build process. Thanks, Damodar Reddy

Re: Review Request 20366: Integrating Windows wix tool to maven

generated e-mail. To reply, visit: https://reviews.apache.org/r/20366/#review40380 --- On April 16, 2014, 9:57 a.m., Damodar Reddy Talakanti wrote: > > --- > This is an automatical

Re: Review Request 20366: Integrating Windows wix tool to maven

://reviews.apache.org/r/20366/diff/ Testing --- Build process has been Tested on Windows server. Regular profile Builds are tested Tested new profile "buildw" and verified msi file is getting created in target. Thanks, Damodar Reddy Talakanti

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

"\bin\candle.exe" client.wxs 3. The following command will be used to generate .msi file "\bin\light.exe" acs.wixobj client.wixobj -out acs.msi -ext "C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll" -dSourceClient=SourceDir\client Thanks, Damodar Reddy Talakanti

Review Request 20367: If already tmp directory exist inject Keys is failing while starting management server on windows

on management server start up. Diffs - scripts/vm/systemvm/injectkeys.py bd840f9 Diff: https://reviews.apache.org/r/20367/diff/ Testing --- Tested on windows 2008 server on fresh setup Thanks, Damodar Reddy Talakanti

Review Request 20366: Integrating Windows wix tool to maven

Tested on Windows server. Regular profile Builds are tested Tested new profile "buildw" and verified msi file is getting created in target. Thanks, Damodar Reddy Talakanti

Review Request 20152: In com.cloud.utils.crypt.EncryptionSecretKeyChecker the key file paths are hard coded

iff: https://reviews.apache.org/r/20152/diff/ Testing --- Tested with enabling ecnryption. Thanks, Damodar Reddy Talakanti

Review Request 19780: [Windows] Check dependencies are installed or not through registry instead of environment variables

--- Tested on windows 2008R2 instance. Tested for the following use cases 1. Java is not installed 2. tomcat is not installed 3. 7z is not installed. Thanks, Damodar Reddy Talakanti

Re: Review Request 19717: [Windows] enabled the SSL key generation part in windows installer

> On March 27, 2014, 10:23 a.m., Abhinandan Prateek wrote: > > It depends on pre-installed Java. DO we check early on in the installer if > > java SDK is installed ? > > Damodar Reddy Talakanti wrote: > Yes if JAVA_HOME is not set the installation will fail. Probab

Re: Review Request 19717: [Windows] enabled the SSL key generation part in windows installer

- On March 27, 2014, 6:55 a.m., Damodar Reddy Talakanti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19717/ > --

Re: Review Request 19604: [Windowsfication] fixing log issues on windows

isit: https://reviews.apache.org/r/19604/#review38578 ------- On March 25, 2014, 11:33 a.m., Damodar Reddy Talakanti wrote: > > --- > This is an automatically generated

Review Request 19717: [Windows] enabled the SSL key generation part in windows installer

desired place. Thanks, Damodar Reddy Talakanti

Review Request 19604: [Windowsfication] fixing log issues on windows

x27;s properties in MSI installer Diffs - scripts/installer/windows/acs.wxs 7967478 Diff: https://reviews.apache.org/r/19604/diff/ Testing --- As changes are related to windows tested whether log files are getting generated or not in windows. Thanks, Damodar Reddy Talakanti

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

"\bin\light.exe" acs.wixobj client.wixobj -out acs.msi -ext "C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll" -dSourceClient=SourceDir\client Thanks, Damodar Reddy Talakanti

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

tps://reviews.apache.org/r/18964/#review37703 ------- On March 18, 2014, 1:46 p.m., Damodar Reddy Talakanti wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 14, 2014, 12:14 p.m., Damodar Reddy Talakanti wrote: > > Hi Daan > > > > I have updated the FS in wiki regarding how to build and install using this > > code. The link to FS is > > > > https://cwiki.apache.org/confluence/displa

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

lowing command will be used to generate .msi file "\bin\light.exe" acs.wixobj client.wixobj -out acs.msi -ext "C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll" -dSourceClient=SourceDir\client Thanks, Damodar Reddy Talakanti

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

install using this code. The link to FS is https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Windowsfication#CloudstackWindowsfication-Installer - Damodar Reddy Talakanti On March 14, 2014, 12:10 p.m., Damodar Reddy Talakanti wrote

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

install using this code. The link to FS is https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Windowsfication#CloudstackWindowsfication-Installer - Damodar Reddy Talakanti On March 14, 2014, 12:10 p.m., Damodar Reddy Talakanti wrote

  1   2   >