----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22510/ -----------------------------------------------------------
(Updated June 17, 2014, 6:34 a.m.) Review request for cloudstack, edison su, Koushik Das, and Min Chen. Changes ------- Incorporated review comments from Koushik Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636 Repository: cloudstack-git Description ------- Due to File.separator on windows machine the template creation from snapshot is failing as it has mis-matched path separator which is windows path separator(\). Fixed the same by adding getPathSeparator() method to DataStoreTO.java and all it's implementations. Diffs (updated) ----- api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 api/src/com/cloud/agent/api/to/S3TO.java f64fe35 api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java 9c86fbe Diff: https://reviews.apache.org/r/22510/diff/ Testing ------- Tested on Windows 2012 R2 server and on centos. Tested the following use cases. 1. Attach ISO 2. Detach ISO 3. Snapshot creation from root disk 4. Snapshot creation from data disk 5. volume creation from (3) 6. template creation from(3) 7. Launch a VM after registering new template. Thanks, Damodar Reddy Talakanti
