-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26168/
-----------------------------------------------------------

Review request for cloudstack and Kishan Kavala.


Bugs: CLOUDSTACK-7648
    https://issues.apache.org/jira/browse/CLOUDSTACK-7648


Repository: cloudstack-git


Description
-------

There are new VM State Machine changes introduced while adding VM Sync changes 
and these were missed to capture the usage events. 

This is causing to get wrong usage statistics for a VM who's state is changed 
by VM sync


Diffs
-----

  api/src/com/cloud/vm/VirtualMachine.java 34387eb 
  engine/components-api/src/com/cloud/network/NetworkStateListener.java c86f782 
  
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java
 92163ea 
  
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java
 c998e3b 
  server/src/com/cloud/capacity/CapacityManagerImpl.java e5b7d19 
  server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java a40a7d7 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
1c80fea 
  server/src/com/cloud/network/security/SecurityGroupManagerImpl.java f60a746 
  server/src/com/cloud/storage/listener/SnapshotStateListener.java 8da71a6 
  server/src/com/cloud/storage/listener/VolumeStateListener.java 1911a48 
  server/src/com/cloud/vm/UserVmStateListener.java a0088b8 
  server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java 
8e606ca 
  utils/src/com/cloud/utils/fsm/StateListener.java 3d0a645 
  utils/src/com/cloud/utils/fsm/StateMachine2.java 4950a25cb 

Diff: https://reviews.apache.org/r/26168/diff/


Testing
-------

Tested on Simulator for all VM Lifecycle states and tested with Xenserver for 
VM Sync reatled actions. 

Ran Simulator for VM lifecycle realted tests.

Currenly there is no API call listUsageEvents to verify that events are 
generated.


Thanks,

Damodar Reddy Talakanti

Reply via email to