Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1572
Can I get a review on this one so it can be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1545
This one is still open, are we ready for a merge yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user wido closed the pull request at:
https://github.com/apache/cloudstack/pull/1541
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Kris,
Looking at the history of the PR, there appears to be one LGTM for testing the
PR scope. Given the size of the change, it seems appropriate to run a
regression test. However, there are no results indicating a regression test
has been run.
I also reviewed the code and left comments to m
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77756715
--- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py ---
@@ -631,195 +753,257 @@ def check_Router_state(self, router, state=None):
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77756445
--- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py ---
@@ -490,57 +581,75 @@ def execute_cmd(self, ssh_client, cmd):
self.debu
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77756386
--- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py ---
@@ -461,22 +547,27 @@ def create_NetworkAclRule(self, rule,
traffic_type="Ingress", net
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77756322
--- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py ---
@@ -360,60 +427,75 @@ def delete_VM(self, vm, expunge=True):
# get_Router
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77756212
--- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py ---
@@ -175,45 +234,44 @@ def tearDown(self):
return
# create_Vp
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77756102
--- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py ---
@@ -77,85 +117,104 @@ def setUpClass(cls, zone=None):
cls.test_data["virtua
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77755943
--- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py ---
@@ -77,85 +117,104 @@ def setUpClass(cls, zone=None):
cls.test_data["virtua
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77755898
--- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py ---
@@ -77,85 +117,104 @@ def setUpClass(cls, zone=None):
cls.test_data["virtua
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77755754
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -988,6 +1016,21 @@ public boolean addDhcpEntry(final Network network,
fi
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77755671
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -988,6 +1016,21 @@ public boolean addDhcpEntry(final Network network,
fi
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77755594
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -922,10 +921,56 @@ public boolean release(final Network network, final
N
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77755606
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -922,10 +921,56 @@ public boolean release(final Network network, final
N
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77755589
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -922,10 +921,56 @@ public boolean release(final Network network, final
N
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77755434
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -431,6 +448,17 @@ private Answer executeReques
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77755409
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -386,6 +392,17 @@ private Answer executeReques
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77755263
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -242,6 +256,44 @@ public void reserve(NicP
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77754965
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -403,4 +455,37 @@ private HostVO getNuageV
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77754766
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -242,6 +256,44 @@ public void reserve(NicP
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77754469
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
---
@@ -19,25 +19,29 @@
package
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77754362
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
---
@@ -56,7 +56,7 @@ public boolean equals(O
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77754300
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVspCommand.java
---
@@ -0,0 +1,73 @@
+//
+// Licensed to t
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77754323
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVspCommand.java
---
@@ -0,0 +1,73 @@
+//
+// Licensed to t
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77754184
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -2645,6 +2669,18 @@ public DhcpServicePro
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1578
@krissterckx could you please squash your commits and provide a clear
explanation of the motivations for the change?
---
If your project is set up for it, you can reply to this email and have
Hi Patrick,
I have tested updating console proxy with uploadsslcert with 4.3.x, 4.5.1, and
everything appeared to work ok for me.
URL Decoder/Encoder
You will need to encode your root SSL so the API call accepts it and stores it
in the database correctly.
http://meyerweb.com/eric/tools/dencode
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1666
@murali-reddy could you please either add or update a Marvin test case to
verify this fix? Also, please squash your commits and add a JIRA ticket
reference. Finally, could you please investig
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1578
The PR only contains test LGTM for PR/feature specific changes. Since the
PR brings with it several changes, a regression test LGTM is necessary i.e.
smoke test results against kvm/xen/vmware envi
Thanks Rajani
https://github.com/apache/cloudstack/pull/1578 has votes and tests pass.
What would be the next step ?
Best,
Kris
On 30 August 2016 at 07:24, Rajani Karuturi wrote:
> If you could get 2 LGTMs(any one from your team can also review
> and give LGTM) and if you can run BVT suite
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1578
LGTM
Code is good, tests are good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1672
LGTM
Let's get this one in quickly. Doesn't touch any code or will break
anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1604#discussion_r77684266
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsHelper.py ---
@@ -179,12 +179,12 @@ def get_hostname():
return line.strip()
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1604#discussion_r77684136
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -584,9 +584,11 @@ def hasIP(self, ip):
return ip in self.addre
Github user singalrahul commented on the issue:
https://github.com/apache/cloudstack/pull/1578
LGTM
Marvin test run:-
Verify InternalDns on Isolated Network ... === TestName:
test_01_Isolated_Network_with_zone | Status : SUCCESS ===
ok
Verify InternalDns on Is
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1671
Also, here's a (roughly) 30-minute video I made that demonstrates this PR
in action:
https://www.youtube.com/watch?v=_pbnvQxTAqw&list=PLqOXKM0Bt13DFnQnwUx8ZtJzoyDV0Uuye&index=17
---
If
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77635744
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixDeleteStoragePoolCommandWrapper.java
---
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77635639
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCreateStoragePoolCommandWrapper.java
---
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77635261
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xen610/XenServer610MigrateWithStorageReceiveCommandWrapper
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77634892
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -2045,62 +2045,74 @@ protected void migrate(final VMInstance
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77634349
--- Diff:
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java
---
@@ -25,6 +25,13 @@
import com.cl
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1671
@mike-tutkowski I've reviewed the code. it LGTM, my only concern is of
migrating between two different managed storage when they don't have same tags
(which would ideally be the default)
--
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77631682
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixDeleteStoragePoolCommandWrapper.java
---
@@ -32,2
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77631355
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCreateStoragePoolCommandWrapper.java
---
@@ -39,2
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77629961
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xen610/XenServer610MigrateWithStorageReceiveCommandWrapper.java
---
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77628932
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -2045,62 +2045,74 @@ protected void migrate(final VMInstanceVO vm, fin
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77626328
--- Diff:
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java
---
@@ -25,6 +25,13 @@
import com.cloud.storag
49 matches
Mail list logo
