Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r77755671
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -988,6 +1016,21 @@ public boolean addDhcpEntry(final Network network,
final NicProfile nic, final V
return result;
}
+ protected boolean deleteDhcpSupportForSubnet(Network network,
Network.Service service) throws ResourceUnavailableException {
+ if (canHandle(network, service)) {
+ final List<DomainRouterVO> routers =
_routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER);
+ if (routers == null || routers.size() == 0) {
--- End diff --
Minor nit: Please consider using ``isEmpty`` rather than a size check as it
is clearer intent and more idiomatic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
