Github user mike-tutkowski commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1671#discussion_r77634349
  
    --- Diff: 
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java
 ---
    @@ -25,6 +25,13 @@
     import com.cloud.storage.StoragePool;
     
     public interface PrimaryDataStoreDriver extends DataStoreDriver {
    +    String BASIC_CREATE = "basicCreate";
    +    String BASIC_DELETE = "basicDelete";
    +    String BASIC_DELETE_FAILURE = "basicDeleteFailure";
    +    String BASIC_GRANT_ACCESS = "basicGrantAccess";
    +    String BASIC_REVOKE_ACCESS = "basicRevokeAccess";
    +    String BASIC_IQN = "basicIqn";
    --- End diff --
    
    These are like what we did with snapshots and cloning in a previous PR: 
Ways of passing info into the storage driver to have it perform actions that 
aren't covered by the current interface.
    
    For example, to make this PR work, we need to have two backend volumes 
exist for the same CloudStack volume simultaneously (during the copy of the 
data).
    
    "basicCreate" in volume_details for a given CloudStack volume ID tells the 
storage driver to simply create a volume on the backend with the same 
characteristics as the existing volume on the backend (for this CloudStack 
volume).
    
    We then communicate info back to the storage framework (for 
XenMotion/vMotion purposes) by adding "basicIqn" to the volume details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to