Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-206710882
@swill sorry I will not, that is another issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Those failures are false positives.
Best Regards,
Sanjeev N
Chief Product Engineer, Accelerite
Off: +91 40 6722 9368 | EMail: sanjeev.neelar...@accelerite.com
-Original Message-
From: GabrielBrascher [mailto:g...@git.apache.org]
Sent: Wednesday, April 06, 2016 7:45 PM
To: dev@cloudstack.
Wow, a whole one page site dedicated to this endeavor :)
On 4/6/16 9:22 PM, Will Stevens wrote:
> FYI, It does still seem to be freely available: http://ccpdoctor.com/
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S
FYI, It does still seem to be freely available: http://ccpdoctor.com/
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Thu, Apr 7, 2016 at 12:11 AM, ilya wrote:
> Thanks for explanation Ian
Thanks for explanation Ian and Will.
Much appreciated.
On 4/5/16 8:33 PM, Ian Rae wrote:
> I don't believe this is freely available, rather is a tool Citrix developed
> for helping troubleshoot CCP customer deployments. I would imagine that
> Accelerite owns this tool now and it is likely availab
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1254#issuecomment-206684033
We have one LGTM and it is passing CI, is this ready to merge then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1363#discussion_r58813816
--- Diff:
api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java ---
@@ -77,7 +80,18 @@ public Long getServiceOfferingId() {
}
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1316#issuecomment-206664435
I am not sure how that tests this code though. I have that same setup, but
I don't think I have the ability to test this configuration. Am I wrong?
---
If your pro
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1254#discussion_r58807499
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaSummaryCmd.java
---
@@ -59,7 +59,7 @@ public QuotaSummaryCmd() {
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58803540
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1363#discussion_r58787775
--- Diff:
api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java ---
@@ -77,7 +80,18 @@ public Long getServiceOfferingId() {
}
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58787329
--- Diff: server/test/com/cloud/vm/UserVmManagerTest.java ---
@@ -928,4 +928,13 @@ public void testUpdateVmNicIpFailure3() throws
Exception {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58786157
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java ---
@@ -2137,7 +2141,8 @@ public int getScsiDiskControllerKey(String
dis
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58786110
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java ---
@@ -2137,7 +2141,8 @@ public int getScsiDiskControllerKey(String
dis
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58785773
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java ---
@@ -2118,8 +2118,12 @@ public int getScsiDiskControllerKey(String
di
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58785250
--- Diff:
utils/src/test/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfoTest.java
---
@@ -0,0 +1,46 @@
+//
+// Licensed to the A
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1316#issuecomment-206578492
real virtualized hardware (advanced zone with 2 kvm hosts, bubble style).
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58784849
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGues
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1323#issuecomment-206575399
@sanju1010 LGTM but can you force push the code again or close and open the
pr again to force a rebuild of the jenkins pr job? it has some weird failures.
I th
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1323#discussion_r58783340
--- Diff: test/integration/component/test_redundant_router_cleanups.py ---
@@ -666,3 +667,156 @@ def test_network_gc(self):
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58782658
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfo.java
---
@@ -39,4 +38,11 @@ public void setDiskDeviceBusName(St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58782564
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfo.java
---
@@ -39,4 +38,11 @@ public void setDiskDeviceBusName(St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58782481
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -5455,6 +5456,15 @@ private void encryptAndStorePassword(UserVmVO vm,
String password) {
Ok cool. I was jumping to conclusions. :P My bad...
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Wed, Apr 6, 2016 at 5:08 PM, Wido den Hollander wrote:
>
> > Op 6 april 2016 om 19:16
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58782174
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
> Op 6 april 2016 om 19:16 schreef Will Stevens :
>
>
> yes, for now. this is something I want to work towards, but we have to be
> patent and go one step at a time.
>
Yes. I never meant this to be implemented right now.
For me it seemed like a good thing so that we can prove where a commit
Ya, that is what I am doing... Thanks...
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Wed, Apr 6, 2016 at 4:53 PM, Daan Hoogland
wrote:
> basically this means you have to ask the submit
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58781801
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58780935
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -1363,24 +1363,17 @@ private Answer attachVolume
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58780807
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -1363,24 +1363,17 @@ private Answer attachVolume
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58780261
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
basically this means you have to ask the submitter, Will
On Wed, Apr 6, 2016 at 10:43 PM, Will Stevens wrote:
> ok, thanks...
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
>
> On
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58779767
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1461#issuecomment-206559157
@bhaisaab would you mind doing a `push -f` on this PR to kick off the
Jenkins job again so we can verify it is not failing before I merge. Thx.
---
If your project
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58778722
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGues
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58778373
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGues
ok, thanks...
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Wed, Apr 6, 2016 at 4:37 PM, Daan Hoogland
wrote:
> strangely the timeout wasn't reached on those jobs. I upped the timeout
> a
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58778117
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGues
strangely the timeout wasn't reached on those jobs. I upped the timeout
anyway. let's see what happens.
On Wed, Apr 6, 2016 at 10:30 PM, Daan Hoogland
wrote:
> you are right, there are three of those in the preserved history. I will
> look at the timeout configuration for the job.
>
> On Wed, Ap
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1254#discussion_r58776967
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaSummaryCmd.java
---
@@ -59,7 +59,7 @@ public QuotaSummaryCmd() {
publ
I believe the easiest way is to add a new commit or a push -f to the pr
On Wed, Apr 6, 2016 at 5:29 PM, Will Stevens wrote:
> Is there a way to kick off a new Jenkins run on a PR that it had failed on
> previously?
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
>
you are right, there are three of those in the preserved history. I will
look at the timeout configuration for the job.
On Wed, Apr 6, 2016 at 10:28 PM, Will Stevens wrote:
> I have been seeing it fail more often than usual with "timeout" errors.
>
> For example, this PR: https://github.com/apac
Is there a way to kick off a new Jenkins run on a PR that it had failed on
previously?
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Wed, Apr 6, 2016 at 4:29 PM, Will Stevens wrote:
> The
The reason I bring it up is because I don't want to '--force' PR merges,
but it wants PRs to have all green lights (obviously).
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Wed, Apr 6, 201
I have been seeing it fail more often than usual with "timeout" errors.
For example, this PR: https://github.com/apache/cloudstack/pull/1461
With this run:
https://builds.apache.org/job/cloudstack-pr-analysis/719/console
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 r
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-206544148
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1254#issuecomment-206542659
### ACS CI BVT Run
**Sumarry:**
Build Number 159
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=4
I've seen this one before:
Tests in error:
SecondaryStorageManagerTest.getDefaultNetworkForAdvancedNonSG:79
NoSuchMethod ...
SecondaryStorageManagerTest.getDefaultNetworkForAdvancedSG:102
NoSuchMethod or...
SecondaryStorageManagerTest.getDefaultNetworkForAdvancedWrongZoneType
? Unexp...
S
looking at the history in [1] this is not true. most are succeeding.
[1] https://builds.apache.org/view/All/job/cloudstack-pr-analysis/
On Wed, Apr 6, 2016 at 8:40 PM, Will Stevens
wrote:
> Hey All,
> Anyone know what is going on with Jenkins? It seems to be failing for most
> PRs. It seems
Github user mlsorensen commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-206540043
Let's merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58768337
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58767464
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58766497
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58763970
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGues
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58763620
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGues
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58763269
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58762975
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58762482
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -5455,6 +5456,15 @@ private void encryptAndStorePassword(UserVmVO vm,
String password) {
Hey All,
Anyone know what is going on with Jenkins? It seems to be failing for most
PRs. It seems to be timing out, but I am not a Jenkins wizard...
Cheers,
Will
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1332
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
yes, for now. this is something I want to work towards, but we have to be
patent and go one step at a time.
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Wed, Apr 6, 2016 at 1:06 PM, Daan
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58744278
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58743708
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -5455,6 +5456,15 @@ private void encryptAndStorePassword(UserVmVO vm,
String pa
On Wed, Apr 6, 2016 at 6:58 PM, Will Stevens wrote:
> but we have to work with the ASF
so we can not go there tomorrow but maybe the day after. Both we and the
foundation want signed commits so in the end we can be using github for
this as well. As long as there is no commit access to github
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58743442
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-206466138
Ok, I understand what is going on here better. @DaanHoogland would you
mind reviewing this for us? Thanks...
---
If your project is set up for it, you can reply to
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58743070
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
I am just trying to make sure we are all clear on what we are trying to
achieve.
No, we do not have committer access via Github, and in order for us to be
able to make the move the 'apache-cloudstack' org, we will need to keep it
that way (at least for now). I am still working on getting this to
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58742032
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-206462240
Ok, thanks @bhaisaab
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-206462142
I think all of the tests that fail regularly have been removed from that
test suite now. I believe we need all those tests passing, so we should review
the failures.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-206461873
@rafaelweingartner mea culpa, I used the older git pr tool and pushed it.
AFAIK our current process and details of reviewing, testing and merging PRs is
not voted
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-206461710
@swill As mentioned by @ustcweizhou in the first comment. I am not sure if
the current scale VM tests cover the dynamic offering scenario.
"This reverts
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-206460206
I don't have the ability to test this. Would you mind running the
following tests to verify there are no issues in the setup once the DC has been
deployed and then p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1464#issuecomment-206458563
I don't have the ability to test vcenter. Is there anyone else who has the
ability to test vcenter who can post the test results of a CI run?
---
If your project is
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1464#discussion_r58739597
--- Diff: tools/marvin/marvin/lib/vcenter.py ---
@@ -183,7 +192,157 @@ def get_clusters(self, dc, clus=None):
"""
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-206443694
yes, I can add that note. I will get CI run against this once I get
through my backlog a bit.
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1316#issuecomment-206441793
@DaanHoogland you ran this against real hardware correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-206438944
@koushik-das Can you specify which functionality tests were broken by which
PR? Thanks...
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-206440627
Just got my CI back up and running. I will be getting it running against a
few PRs ASAP.
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-206435758
I would like to get at least one code review with a LGTM before I merge. I
am pretty confident with the tests run. As long as we get 105 tests passing in
that CI en
Ah, ok
I had forgotten that, my bad.
On Wed, Apr 6, 2016 at 12:39 PM, Daan Hoogland
wrote:
> On Wed, Apr 6, 2016 at 5:37 PM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
>> Sorry, but I did not understand. We do not have commit access to Github,
>> right?
>>
> I think we are tal
On Wed, Apr 6, 2016 at 5:37 PM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:
> Sorry, but I did not understand. We do not have commit access to Github,
> right?
>
I think we are talking about the new to be cloudstack organisation, right
@Will?
>
> On Wed, Apr 6, 2016 at 12:35 PM,
Sorry, but I did not understand. We do not have commit access to Github,
right?
On Wed, Apr 6, 2016 at 12:35 PM, Daan Hoogland
wrote:
> hm, no ;) We can control access to the organisation right? so we can close
> it for committers that don't have a valid key. We just need to think of a
> procedu
hm, no ;) We can control access to the organisation right? so we can close
it for committers that don't have a valid key. We just need to think of a
procedure for checking and registration.
On Wed, Apr 6, 2016 at 5:33 PM, Will Stevens wrote:
> Yes, I agree with both of you. Maybe I am not being
Yes, I agree with both of you. Maybe I am not being clear. My point is
only that we can't allow commit access on Github because then we can not
limit it to only valid committers who COULD commit. Is that clearer?
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-206425673
Do you mean that the need for 2LGTMs was voted after this PR was open? It
seems that it was a direct commit. Why did you not use the merge tool?
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-206423048
@rafaelweingartner more of a guidelines, this was never voted on and this
does not apply for 4.5; there is an outstanding PR for recent branches
---
If your proje
I agree with Daan.
On Wed, Apr 6, 2016 at 11:42 AM, Daan Hoogland
wrote:
> Will, we only need to be sure about the key's of committers. Only merge
> commits we need to be sure of the signature and the merger needs to be
> verify the code. He can not assure that the origin of the code is authenti
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-206416810
LGTM thanks @sanju1010 for the addition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-206415115
@swill if this is ok to you you can add an extra comment line in the merge
commit stating
```
This closes #561
```
---
If your project is set u
On Wed, Apr 6, 2016 at 1:51 PM, Kris Sterckx wrote:
> krissterckx
is in
--
Daan
Will, we only need to be sure about the key's of committers. Only merge
commits we need to be sure of the signature and the merger needs to be
verify the code. He can not assure that the origin of the code is authentic
but he can at least assure that the code is unchanged since contribution
when it
Ok, that is half. But how do we verify that a Github user has a GPG key
that is matching what is registered in the ASF? Just because you have a
GPG key does not mean you are an ASF committer, so the check would have to
be made to verify the GPG is registered to an ASF committer before they
would
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-206391435
Based on the code LGTM.
However, I am not sure if should consider those failed tests
("integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRang"
There is a way to do that. When you become a committer, you can register a
key at [1], then that key (public key) is loaded to [2]. The key is
associated with the committer’s login. For instance, this is my public key
[3].
[1] id.apache.org
[2] https://people.apache.org/keys/committer/
[3] https:/
I don't think it is quite this simple. There would have to be a way for
the GPG key to be associated with a specific ASF identity and I don't think
that is in place at this time. Also, there would have to be verification
that the person who is committing has a GPG key AND that they are a
committe
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-206384893
I have an environment to test this PR which as been build from @jayapalu
branch, the managment-server and the systemVM template from:
http://jenkins.buildacloud.org
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-206358834
@bhaisaab, @swill,
Was this PR merge or closed?!?
I noticed a merge to the code base, but this PR did not have the 2LGTMs
that it would need to be
Hi ,
Can I please have edit access rights granted on the cwiki ?
my short name is krissterckx
Similarly, can i ask my colleague Frank Maximus (fmaximus) to get the same
access granted also ?
Thanks,
Kris Sterckx
Nuage Networks
Antwerp, Belgium
1 - 100 of 124 matches
Mail list logo
