[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155349621 The mess has been sorted and the code is ready for testing. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9047 rename enums

2015-11-09 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1049#issuecomment-155347860 Since all tests are still passing and based on the code a LGTM from me. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread davidamorimfaria
GitHub user davidamorimfaria reopened a pull request: https://github.com/apache/cloudstack/pull/1052 CLOUDSTACK-9049: fix Centos7 with Tomcat7 packaging and python libs CLOUDSTACK-9049: Fix Centos7 with Tomcat7 packaging and python libs You can merge this pull request into a Git re

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread davidamorimfaria
Github user davidamorimfaria closed the pull request at: https://github.com/apache/cloudstack/pull/1052 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-09 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1034#issuecomment-155309530 [UI] fix typo for user data field - verfied verified password dialog change [UI] Network names are not being displayed in Infra » VRs » router » NICS - C

Re: [ANNOUNCE] New committer: Boris Schrijver

2015-11-09 Thread Jayapal Reddy Uradi
Congrats Boris ! -Jayapal > On 09-Nov-2015, at 12:01 pm, Rajani Karuturi wrote: > > The Project Management Committee (PMC) for Apache CloudStack > has asked Boris Schrijver to become a committer and we are pleased to > announce that he has accepted. > > Boris is an active code contributor, tes

Re: New PMC member: Erik Weber

2015-11-09 Thread Jayapal Reddy Uradi
Congrats Erik ! Thanks, Jayapal > On 30-Oct-2015, at 7:31 pm, Giles Sirett wrote: > > All > The PMC is delighted to announce that we have asked Erik weber to join the > PMC and he has accepted > > Please join me in congratulating Erik > > Kind Regards > Giles > > D: +44 20 3603 0541 | M: +44

[GitHub] cloudstack pull request: Fix the new line bug (invalid char on UI)...

2015-11-09 Thread milamberspace
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/1053 Fix the new line bug (invalid char on UI), add some Spanish translati… …on from Transifex Some strings with invalid encoding has been fixed too (Thanks Nicolas Vazquez)

Re: New PMC member: Erik Weber

2015-11-09 Thread Erik Weber
Thanks all :-) -- Erik On Mon, Nov 9, 2015 at 11:31 PM, Somesh Naidu wrote: > Congratulations Erik! > > Regards, > Somesh > > > -Original Message- > From: John Burwell [mailto:john.burw...@shapeblue.com] > Sent: Saturday, November 07, 2015 12:12 PM > To: dev@cloudstack.apache.org; Bori

RE: New PMC member: Erik Weber

2015-11-09 Thread Somesh Naidu
Congratulations Erik! Regards, Somesh -Original Message- From: John Burwell [mailto:john.burw...@shapeblue.com] Sent: Saturday, November 07, 2015 12:12 PM To: dev@cloudstack.apache.org; Boris Schrijver Subject: Re: New PMC member: Erik Weber Congrats Erik. --- John Burwell (@john_burw

RE: [ANNOUNCE] New committer: Boris Schrijver

2015-11-09 Thread Somesh Naidu
Congratulations Boris! Regards, Somesh -Original Message- From: John Burwell [mailto:john.burw...@shapeblue.com] Sent: Monday, November 09, 2015 4:42 PM To: dev@cloudstack.apache.org Subject: Re: [ANNOUNCE] New committer: Boris Schrijver Congrats, Boris. --- John Burwell (@john_burwell

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

2015-11-09 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1046#issuecomment-155218538 I added a RBD pool using the ZoneWizard: ![screenshot from 2015-11-09 23 24 29](https://cloud.githubusercontent.com/assets/5996146/11048603/337ee0e8-8739

Re: Automatically trigger a new Jenkins build

2015-11-09 Thread Remi Bergsma
The one that does the PR builds indeed. Sent from my iPhone On 09 Nov 2015, at 20:04, Daan Hoogland mailto:daan.hoogl...@gmail.com>> wrote: On Mon, Nov 9, 2015 at 6:00 PM, David Nalley mailto:da...@gnsa.us>> wrote: Which Jenkins? ​preferably builds.a.o but whichever, no? ​ On Thu, Oct 29, 2

[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-09 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1034#discussion_r44337756 --- Diff: server/src/com/cloud/api/query/dao/DomainRouterJoinDaoImpl.java --- @@ -219,6 +219,7 @@ public DomainRouterResponse setDomainRouterRespons

Re: [ANNOUNCE] New committer: Boris Schrijver

2015-11-09 Thread John Burwell
Congrats, Boris. --- John Burwell (@john_burwell) VP of Software Engineering, ShapeBlue (571) 403-2411 | +44 20 3603 0542 http://www.shapeblue.com | @ShapeBlue 53 Chandos Place, Covent Garden, London, WC2N 4HS > On Nov 9, 2015, at 2:06 PM, Daan Hoogland wrote: > > now the real work starts, Bor

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155204620 @davidamorimfaria Ooops... something went wrong! You got like 10 commits of other people pushed and created conflicts. I'd suggest squashing your own commits an

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155204305 @davidamorimfaria Here's another glitch you may want to look at: ``` [root@cs2 x86_64]# cloudstack-setup-management File "/usr/bin/cloudstack-s

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155200220 @wilderrodrigues @davidamorimfaria RPM build now works properly: ``` + exit 0 RPM Build Done ``` --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-9048: Fix typo for public netw...

2015-11-09 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1051#issuecomment-155183148 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] cloudstack pull request: CLOUDSTACK-9048: Fix typo for public netw...

2015-11-09 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1051#issuecomment-155180036 lgtm. I am sure native english speaker appreciate this one. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

Re: [ANNOUNCE] New committer: Boris Schrijver

2015-11-09 Thread Ahmad Emneina
Congrats Boris! On Mon, Nov 9, 2015 at 11:06 AM, Daan Hoogland wrote: > now the real work starts, Boris. Go get'em. > > On Mon, Nov 9, 2015 at 7:36 PM, Mike Tutkowski < > mike.tutkow...@solidfire.com > > wrote: > > > Nice job, Boris! > > > > On Sunday, November 8, 2015, Rajani Karuturi wrote: >

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155161579 This PR needs fixes, I cannot even build the RPMs. I did: * git fetch origin pull/1052/head:pr/1052 * git checkout pr/1052 * cd pack

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155158399 @wilderrodrigues that would be a way, a problem that was identified is that tomcat as dependency will not be installed. I don't think that is arddessed in this

Re: [ANNOUNCE] New committer: Boris Schrijver

2015-11-09 Thread Daan Hoogland
now the real work starts, Boris. Go get'em. On Mon, Nov 9, 2015 at 7:36 PM, Mike Tutkowski wrote: > Nice job, Boris! > > On Sunday, November 8, 2015, Rajani Karuturi wrote: > > > The Project Management Committee (PMC) for Apache CloudStack > > has asked Boris Schrijver to become a committer and

Re: Automatically trigger a new Jenkins build

2015-11-09 Thread Daan Hoogland
On Mon, Nov 9, 2015 at 6:00 PM, David Nalley wrote: > Which Jenkins? > ​preferably builds.a.o but whichever, no? ​ > On Thu, Oct 29, 2015 at 10:11 AM, Remi Bergsma > wrote: > > Hi all, > > > > Just had a chat with Miguel. > > He showed me that if we setup Github to notify Jenkins on “issue > c

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155155882 I will build RPMs and try to install the management server form the RPM in a machine with tomcat7 installed. is that how it is supposed to work? --- If you

[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-09 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1034#issuecomment-155153401 @wilderrodrigues did you remove the .gz files? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

2015-11-09 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1046#issuecomment-155153126 I saw this in action today. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155152596 Ping @davidamorimfaria @remibergsma How can I help testing it? Steps...??? Cheers, Wilder --- If your project is set up for it, you c

[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-09 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1034#issuecomment-155152303 Ping @remibergsma @ustcweizhou 1. Deployed a DC with a KVM host 2. Created 1 VM under an Isolated Network 3. Create a single VPC with 1 tier

Re: [VOTE] Apache CloudStack 4.6.0

2015-11-09 Thread Remi Bergsma
Status update: Known issues from RC1: CLOUDSTACK-9046: Upgrade path (PR 1050) MERGED CLOUDSTACK-9040: Ubuntu packaging (PR 1040) MERGED CLOUDSTACK-9045: Debian mountpoint issue (PR 1047) MERGED CLOUDSTACK-9043: UI translation fixes (PR 1043) MERGED CLOUDSTACK-9049: CentOS 7 packaging issue (PR 105

Re: [ANNOUNCE] New committer: Boris Schrijver

2015-11-09 Thread Mike Tutkowski
Nice job, Boris! On Sunday, November 8, 2015, Rajani Karuturi wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Boris Schrijver to become a committer and we are pleased to > announce that he has accepted. > > Boris is an active code contributor, tester. > Helps re

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155143308 Thanks @davidamorimfaria will give it a go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155134956 I haven't tested these changes yet, hopefully will have time tomorrow to do it. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack/pull/1052 CLOUDSTACK-9049: fix Centos7 with Tomcat7 packaging and python libs CLOUDSTACK-9049: Fix Centos7 with Tomcat7 packaging and python libs You can merge this pull request into a Git repo

[GitHub] cloudstack pull request: CLOUDSTACK-9048: Fix typo for public netw...

2015-11-09 Thread Carles-Figuerola
GitHub user Carles-Figuerola opened a pull request: https://github.com/apache/cloudstack/pull/1051 CLOUDSTACK-9048: Fix typo for public network description You can merge this pull request into a Git repository by running: $ git pull https://github.com/Carles-Figuerola/cloudsta

[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-09 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1034#issuecomment-155129605 Ping @ustcweizhou @remibergsma Deploying DC with this PR now. Will submit tests in a moment. Cheers, Wilder --- If your project is se

Re: Automatically trigger a new Jenkins build

2015-11-09 Thread David Nalley
Which Jenkins? On Thu, Oct 29, 2015 at 10:11 AM, Remi Bergsma wrote: > Hi all, > > Just had a chat with Miguel. > He showed me that if we setup Github to notify Jenkins on “issue comments” > (next to “pull requests” we have now) and then set a “trigger phrase” in > Jenkins, we could automatically

[GitHub] cloudstack pull request: CLOUDSTACK-9040: Use Tomcat6 for Debian p...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1040 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9040: Use Tomcat6 for Debian p...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1040#issuecomment-155121434 Thanks Boris for posting the logs and such. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1039 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1050 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1050#issuecomment-155116207 LGTM :+1: Deployed 4.5.2 from DEB packages on Ubuntu 14.04. Deployed a zone, deployed the systemvm's and spawned a uservm. Upgraded to 4.6 with

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1039#issuecomment-155115419 OK, now these became a textual change in Python. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: [ANNOUNCE] New committer: Boris Schrijver

2015-11-09 Thread Rohit Yadav
Congrats Boris! On 09-Nov-2015, at 12:01 PM, Rajani Karuturi mailto:raj...@apache.org>> wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Boris Schrijver to become a committer and we are pleased to announce that he has accepted. Boris is an active code contributor, t

[GitHub] cloudstack pull request: Metrics views for CloudStack UI

2015-11-09 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1038#issuecomment-155104456 @DaanHoogland thanks, we can merge this once master is unfrozen and 4.6 branch is cut. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9029: Proper support to identi...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1033 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9029: Proper support to identi...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1033#issuecomment-155102893 To double check, I also verified the bug fix itself. List hosts in current master: ``` (local) 🐵 > list hosts id = 989be22d-7a04

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-11-09 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-155098762 I justed pushed a new commit which uses libvirt-java for the communication with the Guest Agent. The build will fail since this patch for libvirt-java has not b

[GitHub] cloudstack pull request: CLOUDSTACK-9029: Proper support to identi...

2015-11-09 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1033#issuecomment-155099155 @Carles-Figuerola Understood. Don't mind my comment. In that case, LGTM. Code seems good. --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: CLOUDSTACK-9045: Corrected mount point fo...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1047 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9045: Corrected mount point fo...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1047#issuecomment-155098505 LGTM, this path is also in use for other distributions: ``` grep -r "cloudstack" * | grep mnt centos63/replace.properties:MSMNTDIR=/var/cloudstac

[GitHub] cloudstack pull request: CLOUDSTACK-9029: Proper support to identi...

2015-11-09 Thread Carles-Figuerola
Github user Carles-Figuerola commented on the pull request: https://github.com/apache/cloudstack/pull/1033#issuecomment-155095658 @wido The problem with that is that lsb_release doesn't come preinstalled in base centos installs: [cfiguerola@cent6 ~]$ lsb_release -r -bash: lsb_r

Build failed in Jenkins: build-master-jdk18 #385

2015-11-09 Thread jenkins
See Changes: [ramamurti.subramanian] CLOUDSTACK-9038 - Infrastructure tab is slow because of synchronous API calls [milamber] Remove \n (new line) in German and Chinese translation -- [.

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1050#issuecomment-155084636 some unimportant nitpicking but otherwise lgtm (code inspection only) --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1050#discussion_r44282419 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -165,4 +171,173 @@ private void addIndexForVMInstance(Connection con

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1050#discussion_r44282316 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -165,4 +171,173 @@ private void addIndexForVMInstance(Connection conn)

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1050#discussion_r44282237 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -165,4 +171,173 @@ private void addIndexForVMInstance(Connection conn)

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1050#discussion_r44281293 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -165,4 +171,173 @@ private void addIndexForVMInstance(Connection conn)

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1050#discussion_r44281960 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -165,4 +171,173 @@ private void addIndexForVMInstance(Connection conn)

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1050#discussion_r44281795 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -165,4 +171,173 @@ private void addIndexForVMInstance(Connection conn)

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1050#discussion_r44281769 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -165,4 +171,173 @@ private void addIndexForVMInstance(Connection con

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1050#discussion_r44281597 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -165,4 +171,173 @@ private void addIndexForVMInstance(Connection conn)

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/1042 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1050#discussion_r44281534 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -165,4 +171,173 @@ private void addIndexForVMInstance(Connection con

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1050#issuecomment-155082167 LGTM, I worked with @wilderrodrigues to debug the issues over the weekend and today. Together we made it work and this PR is the result. I was there when we tes

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-155082318 ok, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1050#discussion_r44281448 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -165,4 +171,173 @@ private void addIndexForVMInstance(Connection conn)

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1050#issuecomment-155080182 Ping @remibergsma @borisroman @DaanHoogland @wido Tests were executed as described below: * Deploy 4.4.4 - KVM Host - Managemen

New Defects reported by Coverity Scan for cloudstack

2015-11-09 Thread scan-admin
Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. 1 new defect(s) introduced to cloudstack found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-155080030 @resmo After 4.6 we should then make a PR to remove all old bash scripts from the repo. --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

2015-11-09 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1050 CLOUDSTACK-9046 - Fix upgrade path from 4.4 and 4.5 to 4.6 This PR fixes the upgrade path from 4.4.x/4.5.x to 4.6.0. We introduced the logic to update the database with the correct info

[GitHub] cloudstack pull request: CLOUDSTACK-9043 Remove \n (new line) in G...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1043 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

2015-11-09 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1039#discussion_r44280237 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -107,7 +107,7 @@ def checkHostName(): bash("chown cloud.cloud /var/run/clo

[GitHub] cloudstack pull request: CLOUDSTACK-9043 Remove \n (new line) in G...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1043#issuecomment-155079219 LGTM, browsed around in UI in German and Chinese and didn't see Javascript errors. https://cloud.githubusercontent.com/assets/1630096/11036119/cefc118c-

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-155078020 @remibergsma since this buggy script is still there in master branch we should IMHO either merge this PR or remove the script from master branch. Remove it? --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9038 - Infrastructure tab is s...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1036 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9038 - Infrastructure tab is s...

2015-11-09 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1036#issuecomment-155071567 LGTM, deployed on Ubuntu 14.04 with Tomcat6. Working fine! :+1: ![screenshot from 2015-11-09 15 07 28](https://cloud.githubusercontent.com/assets/599614

[GitHub] cloudstack pull request: CLOUDSTACK-9038 - Infrastructure tab is s...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1036#issuecomment-155069789 LGTM, build the branch and the screen shows properly: https://cloud.githubusercontent.com/assets/1630096/11035419/c95ddd36-86f2-11e5-9369-ad5beecd9804.pn

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

2015-11-09 Thread borisroman
Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1039#discussion_r44275343 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -107,7 +107,7 @@ def checkHostName(): bash("chown cloud.cloud /var/run/cloud

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

2015-11-09 Thread borisroman
Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1039#discussion_r44275233 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -107,7 +107,7 @@ def checkHostName(): bash("chown cloud.cloud /var/run/cloud

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

2015-11-09 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1039#discussion_r44274922 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -107,7 +107,7 @@ def checkHostName(): bash("chown cloud.cloud /var/run/clou

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

2015-11-09 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1039#discussion_r44271548 --- Diff: python/lib/cloudutils/serviceConfig.py --- @@ -54,7 +54,7 @@ def configration(self): except: logging.debug(fo

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

2015-11-09 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1039#discussion_r44271484 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -107,7 +107,7 @@ def checkHostName(): bash("chown cloud.cloud /var/run/clo

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-155055433 @resmo Can you please close this PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

2015-11-09 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1039#discussion_r44271177 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -107,7 +107,7 @@ def checkHostName(): bash("chown cloud.cloud /var/run/clou

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

2015-11-09 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1039#discussion_r44270972 --- Diff: python/lib/cloudutils/serviceConfig.py --- @@ -54,7 +54,7 @@ def configration(self): except: logging.debug(for

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

2015-11-09 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-155054417 I've just send a patch upstream to libvirt-java so that we can use Libvirt for sending commands to Instances: https://www.redhat.com/archives/libvir-list/2015-November

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1039#issuecomment-155053983 @wido @ustcweizhou Can you look again here please, see @borisroman's comments. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9029: Proper support to identi...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1033#issuecomment-155053671 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s

Re: UI customization

2015-11-09 Thread Vadim Kimlaychuk
From my opinion better way is to write a plugin: http://docs.cloudstack.apache.org/en/latest/plugins.html#how-to-write-a-plugin-overview and follow UI customization guide: http://support.citrix.com/servlet/KbServlet/download/38315-102-714564/CloudPlatform_4.5_User_Interface_Customization.pdf D

Re: UI customization

2015-11-09 Thread Kshitij Kansal
Hi, You can find the scripts at the location "client/target/generated-webapp/scripts/". Make changes to cloudstack.js here. *Note: *First remove the corresponding gz file(in your case cloudstack.js.gz) otherwise the changes won't reflect. *The changes in generated-webapps are not saved and track

[GitHub] cloudstack pull request: Cloudstack 9047

2015-11-09 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1049 Cloudstack 9047 make enums adhere to best practice naming conventions You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/clou

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

2015-11-09 Thread cloudsadhu
GitHub user cloudsadhu opened a pull request: https://github.com/apache/cloudstack/pull/1048 CLOUDSTACK-8731-checking usage event for delete volume checking usage event for delete volume. I have incorporated all the suggested changes. You can merge this pull request into a Git

Re: [ANNOUNCE] New committer: Boris Schrijver

2015-11-09 Thread Wilder Rodrigues
Congratulations, Boris! Well deserved, dude! Cheers, Wilder > On 09 Nov 2015, at 11:07, Koushik Das wrote: > > Congrats Boris! > > -Original Message- > From: Rajani Karuturi [mailto:raj...@apache.org] > Sent: Monday, 9 November 2015 12:02 PM > To: dev@cloudstack.apache.org > Subject:

Build failed in Jenkins: build-systemvm64-4.6.0 #1

2015-11-09 Thread jenkins
See -- Started by user Wilder [EnvInject] - Loading node environment variables. Building remotely on coohq-slave-01 (cloudstack-buildslave-centos6 systemvmbuilder) in workspace

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

2015-11-09 Thread kevindierkx
Github user kevindierkx commented on the pull request: https://github.com/apache/cloudstack/pull/1046#issuecomment-155020178 @davidamorimfaria @borisroman Took the commit for a spin, looks like it does what it suppose to do. (Adding form elements when certain conditions are met.)

RE: [ANNOUNCE] New committer: Boris Schrijver

2015-11-09 Thread Koushik Das
Congrats Boris! -Original Message- From: Rajani Karuturi [mailto:raj...@apache.org] Sent: Monday, 9 November 2015 12:02 PM To: dev@cloudstack.apache.org Subject: [ANNOUNCE] New committer: Boris Schrijver The Project Management Committee (PMC) for Apache CloudStack has asked Boris Schrij

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

2015-11-09 Thread kevindierkx
Github user kevindierkx commented on the pull request: https://github.com/apache/cloudstack/pull/1046#issuecomment-155012289 The code looks fine to me. @DaanHoogland @borisroman I agree decoupling the UI from the main Cloudstack project would be the better choice. Development

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

2015-11-09 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1046#issuecomment-155010677 I will have a chance to test it this week --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

  1   2   >