Github user remibergsma commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1034#discussion_r44337756
  
    --- Diff: server/src/com/cloud/api/query/dao/DomainRouterJoinDaoImpl.java 
---
    @@ -219,6 +219,7 @@ public DomainRouterResponse 
setDomainRouterResponse(DomainRouterResponse vrData,
                 nicResponse.setGateway(vr.getGateway());
                 nicResponse.setNetmask(vr.getNetmask());
                 nicResponse.setNetworkid(vr.getNetworkUuid());
    +            nicResponse.setNetworkName(vr.getNetworkName());
    --- End diff --
    
    @ustcweizhou Just for my understanding: why do we need this line? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to