[GitHub] cloudstack pull request: CLOUDSTACK-8666: Put host in Alert state ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/621 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8666: Put host in Alert state ...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/621#issuecomment-124357139 Merging it as 2 LGTMs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[BlockerBug] VR creation fails in basic zone

Hi, In latest build with ACS master, VR creation fails in basic zone. Created a blocker bug for this. More details @ https://issues.apache.org/jira/browse/CLOUDSTACK-8668 Thanks, Sanjeev

secondary storage migrate to new one

Dear All, I have built with cloudstack 4.4.3 + kvm. Now, I add a new nfs as secondary storage, and I want to migrate the snapshot&volume&iso on the old secondary storage to the new one. How can I do that ? Thanks. J Best Regards, Star Guo

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/609 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8648: Do not configure the Ima...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/606#issuecomment-124334323 Thanks for the update. changes looks good :+1: Some unit/marvin tests would be good --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/609#issuecomment-124330906 2 LGTMs and travis is green. I am merging this to master in sometime --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Dereference NULL return value

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/618#issuecomment-124330473 instead of a notnull check everywhere, can you use a Non Nulllable ArrayList for tags or use CollectionUtils.addIgnoreNull() api? --- If your project is set up for

Re: [PROPOSAL] Snapshot Improvements

Please find my answers inline Regards, Anshul On 23-Jul-2015, at 8:39 pm, Somesh Naidu mailto:somesh.na...@citrix.com>> wrote: Couple of questions: 1. "In case backup snapshot process fails then user will be provided with alert that backup of snapshot fails." What user action required if this

[GitHub] cloudstack pull request: Fixed Coverity issue "Dereference null re...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/620#issuecomment-124323473 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8666: Put host in Alert state ...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/621#issuecomment-124323020 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Dockerfile

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/605#issuecomment-124282315 I'll squash, I've been told it was better for code review many small commits than one big fat ass commit that nobody want to understand. --- If your project is set

[GitHub] cloudstack pull request: Dockerfile

Github user pdion891 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/605#discussion_r35387474 --- Diff: tools/docker/Dockerfile.marvin --- @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Build failed in Jenkins: build-systemvm64-master #578

See Changes: [wrodrigues] CLOUDSTACK-8660 - Formatting test and utility classes [wrodrigues] CLOUDSTACK-8660 - Adding a method to check if UTF-8 is supported [wrodrigues] CLOUDSTACK-8660 - Adding new StringUtils.getDefault

[GitHub] cloudstack pull request: Dockerfile

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/605#issuecomment-124263885 come on guys, if this is what happened this is what we have got. Squash wht is not atomic and nothing else. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8648: Do not configure the Ima...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/606#issuecomment-124249061 @karuturi Fixed that. See the new commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Dockerfile

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/605#issuecomment-124246163 LGTM, but as @runseb says, please squash this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack pull request: CLOUDSTACK-8666: Put host in Alert state ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/621#issuecomment-124243179 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: [Proposal] CoreOS support

Right Somesh, so I didn't think adding a new OS would be necessary. If the calls are not fully functional some work is needed, but I remember adding a redhat version (7?) at some point. On Thu, Jul 23, 2015 at 4:46 PM, Somesh Naidu wrote: > "cloud administrator task" - I thought this functionalit

[GitHub] cloudstack pull request: Fixed Coverity issue "Dereference null re...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/620#issuecomment-124191945 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

RE: [PROPOSAL] Snapshot Improvements

Couple of questions: 1. "In case backup snapshot process fails then user will be provided with alert that backup of snapshot fails." What user action required if this happens? Or will the snapshot operation be treated as failed marking the DB entry as error and removed from primary storage? 2.

RE: [Proposal] CoreOS support

"cloud administrator task" - I thought this functionality already exists with APIs like, addGuestOs updateGuestOs removeGuestOs addGuestOsMapping updateGuestOsMapping removeGuestOsMapping Regards, Somesh -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Thurs

Re: [Proposal] Continuos Integration Testing on ACS master.

Hi Kishan, I am thinking we will use Citrix hardware until we find something in the acs lab. We will publish the results to acs by mails. However until we find something publicly accessible people can only see the list of tests that failed, for providing more info we will need some place to host

[GitHub] cloudstack pull request: CLOUDSTACK-8666: Put host in Alert state ...

GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/621 CLOUDSTACK-8666: Put host in Alert state only after alert.wait timeout Instead of putting the host to Alert state immediately, the investigators should be allowed to run for some time based

[GitHub] cloudstack pull request: Fixed Coverity issue "Dereference null re...

GitHub user manuiiit opened a pull request: https://github.com/apache/cloudstack/pull/620 Fixed Coverity issue "Dereference null return value" You can merge this pull request into a Git repository by running: $ git pull https://github.com/manuiiit/cloudstack master Alternativ

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/593 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/593#issuecomment-124075403 Creating 2 VMs via cloudmonkey (local) 🐵 > deploy virtualmachine displayname=isovm networkids=61fb9ffe-cf5e-4a09-9470-e0800685f74d templateid=285

[PROPOSAL] Support for non-US keyboards in Console Proxy

I am working on making easier to add non-US keyboards support in console proxy. WIP FS for same is available at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+non-US+keyboards+in+Console+Proxy. Please review and provide suggestions/comments. Thanks, Anshul

RE: [Proposal] Continuos Integration Testing on ACS master.

Bharat, I hope this will go a long way in improving product quality. How are you going to handle the handle the hardware requirement? What is the plan to publish the results to ML? -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: 23 July 2015 03:46 PM To: d

Re: [DISCUSS] Add at least test steps to PR

+1 for less trivial changes that have no clear instruction on testing I would say you would have to be very interested in the component to not just -1 from the start. We are not writing code for the experts. We are writing code for the whole world to use understand and enhance. point of a review

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/609#issuecomment-124053986 to run from eclipse, you need to install Groovy eclipse plugin https://code.google.com/p/spock/wiki/GettingStarted#Eclipse --- If your project is set up for it, yo

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/609#issuecomment-124052158 ran tests from command line. code looks good. I use eclipse and did not manage to run tests in the ide yet (no problem with the PR). HInts welcome :) :+1: wait

[DISCUSS] Add at least test steps to PR

Hi all, Although we have been through those PR related discussions a lot, I would like to add just 1 point: * When a PR hasn't been properly tested before submitted or when the Committer hasn’t added any test report, that at least the test steps are present in the PR description. If for every

[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...

Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/607#discussion_r35308653 --- Diff: test/integration/component/test_browse_templates.py --- @@ -1674,6 +1674,42 @@ def test_09_Browser_Upload_Volume_secondary_storage_resource_lim

[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/607#issuecomment-124051136 looks good :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/609#discussion_r35308521 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java --- @@ -0,0 +1,81 @@ +/* + * Licensed to th

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/609#discussion_r35308512 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java --- @@ -0,0 +1,81 @@ +/* + * Licensed to th

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/609#discussion_r35308492 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManagerFactory.java --- @@ -0,0 +1,55 @@ +/* + * Licensed to t

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/593#issuecomment-124048910 Okay, guys... never mind. I see now that I have to set 2 new values, not just one. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Added a null value exception in LibvirtBa...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/617 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: boring resourse leaks again

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/602#issuecomment-124046942 LGTM :+1: :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

Re: [Proposal] Continuos Integration Testing on ACS master.

Good work Bharat, Keep in mind that many people work on this in many ways and many attempts have failed due to nothing but lack of consensus. I have only glanced but will take my time with it soon. On Thu, Jul 23, 2015 at 10:50 AM, Bharat Kumar wrote: > Hi All, > > Currently we do sanity checks o

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/593#issuecomment-124045612 Hi guys, I tested the PR and it works fine. Below the steps I followed: 1. Change configuration option 2. create a new user account

[GitHub] cloudstack pull request: Added a null value exception in LibvirtBa...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/617#issuecomment-124044971 merging to master now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: [Proposal] CoreOS support

of course +1 for adding CoreOS but can we make supporting os-types more a cloud administrator task then a cloudstack maintainer task? I think some work has gone into that already. Some more work will probably be needed. On Thu, Jul 23, 2015 at 10:43 AM, Kishan Kavala wrote: > Sure Sebastian. I'll

[GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/615#issuecomment-124038730 @kishankavala the double encoding was already in before that commit (968e71a). This commit refactered some code out of the method in which the encoding happened

[GitHub] cloudstack pull request: CLOUDSTACK-8660 - StringUtilsTest.testGet...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/616#issuecomment-124037363 ?! I did not notice... I swear! :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/593#issuecomment-124036937 Perhaps a bit more of detail on the PR description, like test steps. I had to look at the diff of the code in order to find the new configuration key

[GitHub] cloudstack pull request: CLOUDSTACK-8660 - StringUtilsTest.testGet...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/616#issuecomment-124036298 LGTM (2*LGTM from one person is only one LGTM;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8664: Verify if queryAsyncJobR...

GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/619 CLOUDSTACK-8664: Verify if queryAsyncJobResult api return jobinstanceid You can merge this pull request into a Git repository by running: $ git pull https://github.com/pritisarap12/cl

[GitHub] cloudstack pull request: Dereference NULL return value

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/618#issuecomment-124034693 @kishankavala: The message has been changed. @karuturi: Added the path. Please check I have also made another change with respect to solving this problem o

[GitHub] cloudstack pull request: Dereference NULL return value

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/618#issuecomment-124034602 thanks @kansal Can you add some test cases (for null values found for instance)? LGTM --- If your project is set up for it, you can reply to this email

[PROPOSAL] Snapshot Improvements

I am working on improving snapshots experience in CloudStack. FS is available at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Snapshot+Improvements . Please review and provide comments/suggestions. Regards, Anshul

[Proposal] Continuos Integration Testing on ACS master.

Hi All, Currently we do sanity checks on master using Travis, But travis runs only simulator tests (AFAIK). I think it will be better if we can run both BVTs and regression tests on real hardware. I am woking on implementing this. Functional spec and design details. https://cwiki.apache.org/con

[GitHub] cloudstack pull request: CLOUDSTACK-8634: Made changes to test_sec...

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/586#issuecomment-124023610 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

Re: [PROPOSAL] drop old upgrade code

I am glad this has led to some discussion. I do not take a strong position into how we solve the issue but want to make sure we deal with this old code in some way. In terms of justifying the work to my sponsor, I cannot (or do not want to) afford to clean all of it nor to investigate into the exa

RE: [Proposal] CoreOS support

Sure Sebastian. I'll check OS type list and remove outdated distros. -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: 22 July 2015 08:09 PM To: dev@cloudstack.apache.org Subject: Re: [Proposal] CoreOS support +1 Can you clean that last of OS Type while you ar

[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/607#discussion_r35300288 --- Diff: test/integration/component/test_browse_templates.py --- @@ -1674,6 +1674,42 @@ def test_09_Browser_Upload_Volume_secondary_storage_resource_

[GitHub] cloudstack pull request: Added a null value exception in LibvirtBa...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/617#issuecomment-124001316 Hi Maneesha, Yep, it has... I wrote them. All the wrappers classes have in total 145 unit tests. Have a look at LibvirtComputingResourceTes,