+1 for less trivial changes that have no clear instruction on testing I would say you would have to be very interested in the component to not just -1 from the start. We are not writing code for the experts. We are writing code for the whole world to use understand and enhance.
point of a review is to sharpen the PR as well as understanding it. On Thu, Jul 23, 2015 at 12:36 PM, Wilder Rodrigues <wrodrig...@schubergphilis.com> wrote: > Hi all, > > Although we have been through those PR related discussions a lot, I would > like to add just 1 point: > > * When a PR hasn't been properly tested before submitted or when the > Committer hasn’t added any test report, that at least the test steps are > present in the PR description. > > If for every PR I review I have to go through the code to find out the tests > steps by myself, I will probably review less PRs otherwise I would have to > stop coding. > > Cheers, > Wilder -- Daan
