Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/617#issuecomment-124001316
Hi Maneesha,
Yep, it has... I wrote them.
All the wrappers classes have in total 145 unit tests. Have a look at
LibvirtComputingResourceTes, i think that's the name of the class.
As I said, due to complexity of the code that one test is poor, but most of
the wrapper classes have 100% coverage.
No worries, I'm busy with improving a couple of tests and will also do the
one for the backup snapshot.
Apply the change Rajani suggested so we can get it merged.
Cheers,
Wilder
Sent from my iPhone
On 23 Jul 2015, at 08:55, Maneesha P
<notificati...@github.com<mailto:notificati...@github.com>> wrote:
Hi Wilder,
The LibvirtBackupSnapshotCommandWrapper class has no unit
tests.Can I add test cases that covers the exception.
Regards,
P.Maneesha.
On Thu, Jul 23, 2015 at 11:35 AM, Wilder Rodrigues
<notificati...@github.com<mailto:notificati...@github.com>
> wrote:
> Hi @manuiiit <https://github.com/manuiiit>
>
> I checked the LibvirtBackupSnapshotCommandWrapper class and its coverage,
> which is still poor compared to the other classes in the KVM hypervisor
> plugin.
>
> Please, proceed with the changes @karuturi <https://github.com/karuturi>
> suggested and I will increase the tests on the class in a separate PR.
>
> It is currently 6.9% covered, which is very bad.
>
> Cheers,
> Wilder
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/617#issuecomment-123987028>.
>
â
Reply to this email directly or view it on
GitHub<https://github.com/apache/cloudstack/pull/617#issuecomment-123998699>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
