Re: Review Request 14076: New test added for template copy feature

2013-10-09 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14076/#review26860 --- This test is a duplicate of test_06_copy_template test in the scrip

Re: Review Request 14076: New test added for template copy feature

2013-10-09 Thread Ashutosh Kelkar
> On Oct. 10, 2013, 6:36 a.m., SrikanteswaraRao Talluri wrote: > > test/integration/component/test_templates.py, line 437 > > > > > > How are you populating 'destzoneid'. look at the review request > > https://reviews

Re: Review Request 14076: New test added for template copy feature

2013-10-09 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14076/#review26858 --- test/integration/component/test_templates.py

Re: [DOC] 4.2.0 Templates

2013-10-09 Thread Marty Sweet
Where will the docs commited to the master become available? This probably isn't the only case where commits have been lost? https://reviews.apache.org/r/13745/ On Thu, Oct 10, 2013 at 1:17 AM, Radhika Puthiyetath < radhika.puthiyet...@citrix.com> wrote: > 4.2 docs are from 4.2 branch. > > ---

Re: High CPU utilization on KVM hosts while doing RBD snapshot - was Re: snapshot caused host disconnected

2013-10-09 Thread Indra Pramana
Dear all, I and my colleague tried to scrutinize the source code and found the script which is performing the copying of the snapshot from primary storage to secondary storage on this file: ./plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java Specifically under

RE: Docs have moved

2013-10-09 Thread Radhika Puthiyetath
Thank you. I tried git clone https://git-wip-us.apache.org/repos/asf/cloudstack-docs, and it worked. -Original Message- From: Gavin Lee [mailto:gavin@gmail.com] Sent: Thursday, October 10, 2013 11:06 AM To: dev@cloudstack.apache.org Subject: Re: Docs have moved The repo URL should b

Re: [DISCUSS] Pluggable VM snapshot related operations?

2013-10-09 Thread Mike Tutkowski
"The work flow will be: createVMSnapshot api -> VMSnapshotManagerImpl: creatVMSnapshot -> VMSnapshotStrategy: takeVMSnapshot -> storage driver:takeVMSnapshot" I also think it's a bit weird for the storage driver to have any knowledge of VM snapshots. I would think another part of the system would

Re: [PROPOSAL] Remove Setters from *JoinVO

2013-10-09 Thread Koushik Das
Views are meant to be read only. So +1 for removing setters. On 04-Oct-2013, at 10:59 PM, "SuichII, Christopher" wrote: > *JoinVOs are used to store entries from MySQL views, which are not editable. > I think removing setters from the *JoinVOs may help avoid some potential > confusion as sett

Re: Docs have moved

2013-10-09 Thread Gavin Lee
The repo URL should be : https://git-wip-us.apache.org/repos/asf/cloudstack-docs.git Try it. On Thu, Oct 10, 2013 at 1:33 PM, Radhika Puthiyetath < radhika.puthiyet...@citrix.com> wrote: > Hi, > > I am trying to run git clone > https://git-wip-us.apache.org/repos/cloudstack-docs.git, and I get t

RE: Docs have moved

2013-10-09 Thread Radhika Puthiyetath
Hi, I am trying to run git clone https://git-wip-us.apache.org/repos/cloudstack-docs.git, and I get the following error: $ git clone https://git-wip-us.apache.org/repos/cloudstack-docs.git Cloning into 'cloudstack-docs'... fatal: https://git-wip-us.apache.org/repos/cloudstack-docs.git/info/refs

Re: Back end volume names in KVM

2013-10-09 Thread Marcus Sorensen
Yeah, existing volumes have a path thats already set in stone. It would only concern new volumes. It could cause problems down the line if people get used to them matching and decide to use uuid and path interchangeably. They're not by default identical though since the path usually contains the d

Re: Review Request 14076: New test added for template copy feature

2013-10-09 Thread Ashutosh Kelkar
> On Oct. 10, 2013, 1:37 a.m., Nitin Mehta wrote: > > Can you give me a bug number to submit this test against ? Hi Nitin, This is a very old test case so couldn't find any Bug ID related to "adding" this test case. But Here's one Bug related to this test case which was fixed long back. You ca

Re: Back end volume names in KVM

2013-10-09 Thread Mike Tutkowski
OK, now I'm really replying to this e-mail thread. :) I think this is a good idea, Marcus. It gets rid of an unnecessary translation step. On Wed, Oct 9, 2013 at 11:23 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > I'm sorry! > > I sent this e-mail to the wrong discussion thread. :

Re: [DISCUSS] Pluggable VM snapshot related operations?

2013-10-09 Thread Mike Tutkowski
Yeah, I'm not really clear how the snapshot strategy works if you have multiple vendors that implement that interface either. On Wed, Oct 9, 2013 at 10:12 PM, Darren Shepherd < darren.s.sheph...@gmail.com> wrote: > Edison, > > I would lean toward doing the coarse grain interface only. I'm havin

Re: Back end volume names in KVM

2013-10-09 Thread Mike Tutkowski
I'm sorry! I sent this e-mail to the wrong discussion thread. :) On Wed, Oct 9, 2013 at 11:05 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Yeah, I'm not really clear how the snapshot strategy works if you have > multiple vendors that implement that interface either. > > > On Wed,

Re: Back end volume names in KVM

2013-10-09 Thread Koushik Das
On 10-Oct-2013, at 9:27 AM, Marcus Sorensen wrote: > Does anyone have any reservations about changing the volume identifier in > KVM's volume creation command to be the uuid of the volume? Currently for > new volumes it generates a random uuid and passes that back to be stored in > the database.

Re: Back end volume names in KVM

2013-10-09 Thread Prasanna Santhanam
+1 - happens in lots of places in our code where a random-uuid associates with a physical resource's uuid. Will this will happen only for new volumes? Old volumes can still be listed and found using the old method? I'm specifically concerned about upgraded systems. On Wed, Oct 09, 2013 at 11:05:4

Re: master simulator build broken on ManagedContext

2013-10-09 Thread Prasanna Santhanam
Thanks Darren, the jetty start has chugged along and I'm able to bring up the server. I'd like to not have that orphaned context ideally since it gets left out often this way. But I can live with that for now. On Wed, Oct 09, 2013 at 10:55:58AM -0700, Darren Shepherd wrote: > Prasanna, > > Try no

Re: Back end volume names in KVM

2013-10-09 Thread Mike Tutkowski
Yeah, I'm not really clear how the snapshot strategy works if you have multiple vendors that implement that interface either. On Wed, Oct 9, 2013 at 9:57 PM, Marcus Sorensen wrote: > Does anyone have any reservations about changing the volume identifier in > KVM's volume creation command to be

Re: [DISCUSS] Pluggable VM snapshot related operations?

2013-10-09 Thread Darren Shepherd
Edison, I would lean toward doing the coarse grain interface only. I'm having a hard time seeing how the whole flow is generic and makes sense for everyone. With starting with the coarse grain you have the advantage in that you avoid possible upfront over engineering/over design that could wreak

Back end volume names in KVM

2013-10-09 Thread Marcus Sorensen
Does anyone have any reservations about changing the volume identifier in KVM's volume creation command to be the uuid of the volume? Currently for new volumes it generates a random uuid and passes that back to be stored in the database. From an admin perspective, the only way to link a volume on t

Re: [DISCUSS] Pluggable VM snapshot related operations?

2013-10-09 Thread Mike Tutkowski
Hey guys, I haven't been giving this thread much attention, but am reviewing it somewhat now. I'm not really clear how this would work if, say, a VM has two data disks and they are not being provided by the same vendor. Can someone clarify that for me? My understanding for how this works today

Re: why are RvR routers not HA

2013-10-09 Thread Marcus Sorensen
The main thing that came to mind was the limitation on VPC where only one network can have public load balancing. I looked into it a bit, and its because the information is passed to the system vm in such a way that a second LB config would completely overwrite previous configs. I was able to get a

Re: [PROPOSAL] Modularize Spring

2013-10-09 Thread Darren Shepherd
Sounds great. What's on the spring modularization will support this (obviously the storage framework needs to handle the canHandle logic), but it seems a lot of the storage code is being refactored, so we'll probably have to do a nasty merge. Darren On Wed, Oct 9, 2013 at 6:03 PM, SuichII, Chris

Re: why are RvR routers not HA

2013-10-09 Thread Darren Shepherd
Well, here's the deal. I'm doing analysis right now to completely revamp the management of systemvm. Basically get to a faster, more reliable, more transparent way of doing things with far, far, far less code. I'm planning on putting a thread up for discussion in about a week. I want to have a

Re: Review Request 14076: New test added for template copy feature

2013-10-09 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14076/#review26854 --- Can you give me a bug number to submit this test against ? - Nitin

Re: Review Request 14076: New test added for template copy feature

2013-10-09 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14076/#review26852 --- Ship it! Ship It! - Nitin Mehta On Oct. 8, 2013, 1:45 p.m., Ashu

Re: Review Request 14076: New test added for template copy feature

2013-10-09 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14076/#review26851 --- Ship it! Ship It! - Nitin Mehta On Oct. 8, 2013, 1:45 p.m., Ashu

Re: why are RvR routers not HA

2013-10-09 Thread Marcus Sorensen
Ooh, do you take requests? On Oct 9, 2013 7:30 PM, "Darren Shepherd" wrote: > I didn't read the whole thread yet, but at the end of the day it's sounds > like an implementation issue. So I'll just naively say I'll fix that :) > > Darren > > > On Oct 9, 2013, at 5:58 PM, Alena Prokharchyk < > ale

Re: why are RvR routers not HA

2013-10-09 Thread Darren Shepherd
I didn't read the whole thread yet, but at the end of the day it's sounds like an implementation issue. So I'll just naively say I'll fix that :) Darren > On Oct 9, 2013, at 5:58 PM, Alena Prokharchyk > wrote: > > HA redundant virtual router

Re: [PROPOSAL] Modularize Spring

2013-10-09 Thread SuichII, Christopher
Yep, that's the idea. In fact, we really need it to be dynamic so that the strategy or provider can respond depending on the action. For example, snapshotting may be supported while reverting may not be. -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms – Clou

Re: why are RvR routers not HA

2013-10-09 Thread Alena Prokharchyk
On 10/9/13 4:55 PM, "Darren Shepherd" wrote: >I don't quite understand why in the redundant VR use case you wouldn't >want the individual VRs to have HA enabled. It seems the code will >always set ha=false for RvR. I know if I loose one of the VRs, the >other takes over, so that is redundant.

RE: [DOC] 4.2.0 Templates

2013-10-09 Thread Radhika Puthiyetath
4.2 docs are from 4.2 branch. -Original Message- From: Marty Sweet [mailto:msweet@gmail.com] Sent: Thursday, October 10, 2013 3:27 AM To: dev@cloudstack.apache.org Subject: Re: [DOC] 4.2.0 Templates Hi Daan, Yeah the doc directory in the repo commited to master, where is the current

Re: [PROPOSAL] Modularize Spring

2013-10-09 Thread Darren Shepherd
I think I'm fine with that. Is the enum type return dynamically at runtime. So the API would be something like "PlugInPriority canHandle(...)"? Darren On Wed, Oct 9, 2013 at 1:13 PM, SuichII, Christopher wrote: > I think I'll look into a version of (2). The difference being that I think > usi

why are RvR routers not HA

2013-10-09 Thread Darren Shepherd
I don't quite understand why in the redundant VR use case you wouldn't want the individual VRs to have HA enabled. It seems the code will always set ha=false for RvR. I know if I loose one of the VRs, the other takes over, so that is redundant. But don't you want the lost VR to come back to life

Re: [PROPOSAL] Remove Setters from *JoinVO

2013-10-09 Thread Min Chen
+1 on this. As Chris mentioned, the intention of *JoinVOs are representation of MySQL views, which should not be editable after search. -min On 10/4/13 10:29 AM, "SuichII, Christopher" wrote: >*JoinVOs are used to store entries from MySQL views, which are not >editable. I think removing setters

Re: Doc Updates

2013-10-09 Thread Harm Boertien
I see at least 1 topic for the cloudstack collab. +1 Sent from my iPhone On 9 okt. 2013, at 23:01, "Christopher M. Ryan" wrote: > +1 on this. > I find management hard to please when I persuade changing to a new technology > only to have issues related to documentation. This prolongs deployme

Re: [DOC] 4.2.0 Templates

2013-10-09 Thread Marty Sweet
Hi Daan, Yeah the doc directory in the repo commited to master, where is the current http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.2.0/html/Admin_Guide/working-with-templates.html being built from? Marty On Wed, Oct 9, 2013 at 8:55 PM, Daan Hoogland wrote: > Marty, > > I am not s

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-10-09 Thread Mike Tutkowski
I've got the code all merged, by the way. I should be able to start in on testing soon (tonight or tomorrow). On Wed, Oct 9, 2013 at 3:51 PM, Mike Tutkowski wrote: > Will do...I'll remove it (there is similar code in two methods). > > > On Wed, Oct 9, 2013 at 3:49 PM, Marcus Sorensen wrote: >

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-10-09 Thread Mike Tutkowski
Will do...I'll remove it (there is similar code in two methods). On Wed, Oct 9, 2013 at 3:49 PM, Marcus Sorensen wrote: > Yeah, that looks like leftovers from refactoring our 4.1 code into 4.2 and > making it something more generic. It looks like it could be removed. > > > On Wed, Oct 9, 2013 a

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-10-09 Thread Marcus Sorensen
Yeah, that looks like leftovers from refactoring our 4.1 code into 4.2 and making it something more generic. It looks like it could be removed. On Wed, Oct 9, 2013 at 3:40 PM, Mike Tutkowski wrote: > Hey Marcus, > > I'm merging your changes into mine. > > It looks like I can remove your call to

RE: questions about registerIso API and updateIsoPermissions API

2013-10-09 Thread Jessica Wang
Thanks, Nitin. I just filed an API bug for this: https://issues.apache.org/jira/i#browse/CLOUDSTACK-4843 From: Nitin Mehta Sent: Wednesday, October 09, 2013 2:08 PM To: Jessica Wang; ; Alena Prokharchyk Cc: Shweta Agarwal Subject: Re: questions about registerIso API and updateIsoPermissions API

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-10-09 Thread Mike Tutkowski
Hey Marcus, I'm merging your changes into mine. It looks like I can remove your call to getPhysicalDisk (below) (and the associated KVMPhysicalDisk variable, as well). I assume you would never want to produce any side effects in your getPhysicalDisk implementation, right? Seems like that would b

Re: Doc Updates

2013-10-09 Thread Sebastien Goasguen
The docs have recently been moved into their main repo. This potentially means that we are heading towards documentation releases on a different cycle than the code release. We are not there yet but it's in the works, anyone interested and willing to contribute patches and ideas should registe

Re: Review Request 14320: add boolean option httpModeEnabled to the service offering for use in haproxy conf

2013-10-09 Thread Chiradeep Vittal
Sure. On 10/9/13 1:55 PM, "Daan Hoogland" wrote: >H Chiradeep, > >Would you considder this if I rename the option to keepAlive, adding a >API description field stating that it only has effect on HAProxy (for >now)? > >regards, >Daan > >On Tue, Oct 1, 2013 at 10:50 AM, Daan Hoogland >wrote: >> O

Re: [DISCUSS/PROPOSAL] Upgrading Driver Model

2013-10-09 Thread SuichII, Christopher
Interesting. I'm not sure how I missed this thread... I'll try to chime in where I can, then. However, everything going on in here sounds like work for post-4.3, but if we are adding revert volume snapshot to 4.3, we will need a solution to that before then. It seems like the idea I've got for t

Re: LXC and Networking

2013-10-09 Thread Francois Gaudreault
Thanks Phong about the networking answers. I will follow the KVM docs. Regarding the resource manager, we did compile the nonoss package on our own. Are you saying we require an extra deps? -- Francois Gaudreault Architecte de Solution Cloud | Cloud Solutions Architect fgaudrea...@cloudops.c

Re: questions about registerIso API and updateIsoPermissions API

2013-10-09 Thread Nitin Mehta
I think (1) is the right way to go. From: Jessica Wang mailto:jessica.w...@citrix.com>> Date: Wednesday 9 October 2013 12:47 PM To: Nitin Mehta mailto:nitin.me...@citrix.com>>, "mailto:dev@cloudstack.apache.org>>" mailto:dev@cloudstack.apache.org>>, Alena Prokharchyk mailto:alena.prokharc...@ci

RE: Doc Updates

2013-10-09 Thread Christopher M. Ryan
+1 on this. I find management hard to please when I persuade changing to a new technology only to have issues related to documentation. This prolongs deployment and doesn't help with the already difficult management decision. It took us a month to switch to CloudStack and almost a week to begin

Re: LXC and Networking

2013-10-09 Thread Phong Nguyen
The LXC cluster does not require a zone of it's own, so you should be able to run an LXC cluster with other clusters. Regarding the LXC resource manager issue, it sounds like you're missing something during server initialization. Under the hood, LXC uses Libvirt and leverages most of the KVM Libvi

Re: Review Request 14320: add boolean option httpModeEnabled to the service offering for use in haproxy conf

2013-10-09 Thread Daan Hoogland
H Chiradeep, Would you considder this if I rename the option to keepAlive, adding a API description field stating that it only has effect on HAProxy (for now)? regards, Daan On Tue, Oct 1, 2013 at 10:50 AM, Daan Hoogland wrote: > Ok Chiradeep, > > I see where you worries are. I'll study the sti

Re: [DISCUSS/PROPOSAL] Upgrading Driver Model

2013-10-09 Thread John Burwell
Kelven, As I stated in my proposal, I think it is important to recognize the distinction between components that control/interact with infrastructure and components that represent orchestration abstractions/mechanisms within the management server. Currently, these two concepts are conflated --

Re: Doc Updates

2013-10-09 Thread Daan Hoogland
Great rant Carlos, You should get it to the dev list. Actually I'll add the dev list in now. It makes sense to update the docs also after a release, when bug in the docs are found these can easily be changed without a full release cycle of the code itself. regards, Daan On Wed, Oct 9, 2013 at 10

Re: what's the reason for the placeholder nic in VPC/VR?

2013-10-09 Thread Alena Prokharchyk
Valid question and concern. Here is the history: V1.0 No notion of the NaaS yet, no networks/nics tables; guest type and all network related info - public ip, mac, netmask - for the VR is stored in domain_router table V2.1 NaaS added. Although each router has entries in the nics table, and its po

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-09 Thread Mike Tutkowski
Just sent you an e-mail chain under the subject: [DISCUSS/PROPOSAL] Upgrading Driver Model On Wed, Oct 9, 2013 at 2:17 PM, SuichII, Christopher wrote: > Well then, I think sending back a list of supported operations with > volumes would be a good start. Eventually, this could be extended to hav

Fwd: [DISCUSS/PROPOSAL] Upgrading Driver Model

2013-10-09 Thread Mike Tutkowski
Hey Chris, This e-mail chain might be of interest to you. Talk to you later, Mike -- Forwarded message -- From: John Burwell Date: Tue, Aug 20, 2013 at 3:43 PM Subject: [DISCUSS/PROPOSAL] Upgrading Driver Model To: "dev@cloudstack.apache.org" Cc: Daan Hoogland , Hugo Trippaers

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-09 Thread SuichII, Christopher
Well then, I think sending back a list of supported operations with volumes would be a good start. Eventually, this could be extended to have supported fields as well. While it does cost some overhead up front to load the supported operations from storage providers when listing volumes, I think

{Responsiveness report] users 2013w40

2013-10-09 Thread Daan Hoogland
http://markmail.org/message/vm2rmrlqdkv7fscz SecondaryStorage VM on 4.1.1 by nick.sindlin...@appcore.com http://markmail.org/message/whks4wvzuaewvnsw qemu-kvm tweaking (CloudStack-2.2.14) by Vladimir Melnik http://markmail.org/message/d7b4vozgi5gs3a5g Migrating/managing secondary storages by mailin

Re: [PROPOSAL] Modularize Spring

2013-10-09 Thread SuichII, Christopher
I think I'll look into a version of (2). The difference being that I think using an int is too large of a range and provides unnecessary granularity. If two strategies or providers both have snapshot strategies, they are both simply going to return the max int. However, if we use an enum with va

Re: what's the reason for the placeholder nic in VPC/VR?

2013-10-09 Thread Darren Shepherd
Okay, that makes sense. Another random question. Why does router_network_ref exist? Is it not sufficient to just find a DomainRouter VM that has a nic attached to the network? It seems to be for RvR? Is that right? Still I don't understand why the table is needed. Darren On Wed, Oct 9, 2013

Re: [DISCUSS] make commands.properties the exception, not the rule

2013-10-09 Thread SuichII, Christopher
I just wanted to add a little clarification from a plugin perspective. Having commands.properties as a whitelist just adds another place that plugins have to register with CloudStack. For plugins that do not intend on being a part of the CloudStack source, this is actually quite tricky. Currentl

Re: [DOC] 4.2.0 Templates

2013-10-09 Thread Daan Hoogland
Marty, I am not sure what you mean. Do you mean the doc dir in the repo? I think you need to look in https://git-wip-us.apache.org/repos/asf/cloudstack-docs.git for the 4.2 docs. regards, Daan On Sun, Oct 6, 2013 at 10:51 PM, Marty Sweet wrote: > Hi guys, > > I created a document for creating L

RE: questions about registerIso API and updateIsoPermissions API

2013-10-09 Thread Jessica Wang
Currently, at API level, a normal user is not allowed to specify "isfeatured" when registering ISO (API will ignore "isfeatured" parameter when a normal user passes it), but a normal user is allowed to specify "isfeatured" when updating ISO. Should we fix API to: (1) allow a normal user to speci

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-09 Thread Mike Tutkowski
"Has there been any thoughts to allow storage providers to indicate which features they support?" We talked about this for a while at the CloudStack Collaboration Conference in Santa Clara. Right now, this is not supported and that's a serious problem. This kind of ties in with Storage Tagging a

Re: [PROPOSAL] Remove Setters from *JoinVO

2013-10-09 Thread Mike Tutkowski
Yeah, I agree with you, Chris. I think these setters should be removed. On Wed, Oct 9, 2013 at 1:33 PM, Daan Hoogland wrote: > Chris, > > Since I see no objections, why don't you test your idea and submit a patch? > > regards, > Daan > > On Fri, Oct 4, 2013 at 7:29 PM, SuichII, Christopher > wr

Re: [PROPOSAL] Remove Setters from *JoinVO

2013-10-09 Thread Daan Hoogland
Chris, Since I see no objections, why don't you test your idea and submit a patch? regards, Daan On Fri, Oct 4, 2013 at 7:29 PM, SuichII, Christopher wrote: > *JoinVOs are used to store entries from MySQL views, which are not editable. > I think removing setters from the *JoinVOs may help avoi

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-09 Thread SuichII, Christopher
Just bumping this since there haven't been any responses. Does anyone have any thoughts on this? I'm ready and prepared to do the work, but I don't want to move on if people have concerns with this approach or can think of a better solution. -Chris -- Chris Suich chris.su...@netapp.com

Re: [DISCUSS] Transaction Hell

2013-10-09 Thread Mike Tutkowski
I think Option B is a good move. On Wed, Oct 9, 2013 at 1:00 PM, Darren Shepherd wrote: > This is blocking my spring-modularization branch as I coupled changing > the DB transactions stuff with the spring stuff (maybe not the best > idea...). So if everyone is on board with option 2, I'll look

Re: [DISCUSS] Transaction Hell

2013-10-09 Thread Darren Shepherd
This is blocking my spring-modularization branch as I coupled changing the DB transactions stuff with the spring stuff (maybe not the best idea...). So if everyone is on board with option 2, I'll look to get it done by probably Tuesday. I'll create a branch from master, independent of the spring

Re: [DISCUSS] Transaction Hell

2013-10-09 Thread Darren Shepherd
Pedro, The @DB annotation adds a guard. It doesn't actually start or end a transaction. It will check that the transaction should be rolled back if one was started and not closed and that's about it. So the only time transactions are really started is when you see txn.start() in the code. So t

Re: [DISCUSS] Transaction Hell

2013-10-09 Thread Daan Hoogland
Darren, Happy to hear your view on Spring. +1 for option B On Wed, Oct 9, 2013 at 8:06 PM, Kelven Yang wrote: > +1 > > Original Transaction class also has many tightly-coupled assumptions about > the underlying data source, lock master. Developers are usually lost on > when and where they sho

Re: System VM template caching

2013-10-09 Thread Sebastien Goasguen
and that one: http://markmail.org/message/kdmvc3frngdki5ho On Oct 9, 2013, at 2:15 PM, Chiradeep Vittal wrote: > http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.2.0/html/Releas > e_Notes/upgrade-instructions.html > > > On 10/9/13 10:11 AM, "kel...@backbonetechnology.com" > wrot

Re: System VM template caching

2013-10-09 Thread Chiradeep Vittal
http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.2.0/html/Releas e_Notes/upgrade-instructions.html On 10/9/13 10:11 AM, "kel...@backbonetechnology.com" wrote: >We tested deleting the template on primary storage, and it failed to >regenerate. > >What is the documented method for regis

Re: [DISCUSS] Transaction Hell

2013-10-09 Thread Kelven Yang
+1 Original Transaction class also has many tightly-coupled assumptions about the underlying data source, lock master. Developers are usually lost on when and where they should use @DB, for nested transactions, it does not really work as expected. Kelven On 10/9/13 10:38 AM, "Chiradeep Vittal"

RE: questions about registerIso API and updateIsoPermissions API

2013-10-09 Thread Jessica Wang
Nitin, > At the moment, I think that for Isos we should allow to edit it so would > call it an API bug. Thanks. > Register Iso does provide an option to mark an ISO featured. I see that in > the latest master. That only works for admin, but NOT normal user. If you log in as a normal user, the

Re: [DISCUSS] Transaction Hell

2013-10-09 Thread Pedro Roque Marques
Darren, I generally agree with you... just trying to point out what could be pitfalls on the way to evolve the system. On Oct 9, 2013, at 10:29 AM, Darren Shepherd wrote: > > I wish we were doing transaction per API, but I don't think that was > ever a consideration. I do think the sync portion

Re: master simulator build broken on ManagedContext

2013-10-09 Thread Darren Shepherd
Prasanna, Try now. I pushed 0d7aa931b4892661df733cd1ba20fe139d13e59b for this. The issue was that at some point the package of ConfigDepotImpl was changed in some refactoring. The applicationContext was changed for this, but apparently somebody didn't check simulatorContext. The bean should neve

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-09 Thread Kelven Yang
+1 Kelven On 10/9/13 9:18 AM, "Chip Childers" wrote: >+1 from me too. > > >On Wed, Oct 9, 2013 at 12:13 PM, Prasanna Santhanam >wrote: > >> Here's the BVT result from spring-modularization branch: Failures that >> are listed exist on master as well. So the branch doesn't break >> anything add

RE: questions about registerIso API and updateIsoPermissions API

2013-10-09 Thread Jessica Wang
Alena, > Jessica, did you mean updateIso? As updateIsoPermissions updates permissions > only. Alena, I meant UpdateIsoPermissions API, not updateIso API. If you check Java file, it's UpdateIsoPermissionsCmd.java that extends BaseUpdateTemplateOrIsoPermissionsCmd.java which takes in isextractabl

Re: [DISCUSS] Transaction Hell

2013-10-09 Thread Chiradeep Vittal
+1 to option B (for a lot of the reasons enunciated by Darren). Also, let's get this in right away so that by 1/31/2014 we are confident about the change and fixed any bugs uncovered by the new scheme. On 10/9/13 10:29 AM, "Darren Shepherd" wrote: >Pedro, > >From a high level I think we'd probab

Re: master simulator build broken on ManagedContext

2013-10-09 Thread Darren Shepherd
I'll look at that. Gimme about 15 minutes. Darren On Wed, Oct 9, 2013 at 10:12 AM, Prasanna Santhanam wrote: > Hi, > > on the simulator build in jenkins [1] on starting jetty I see the > following issue: > > ERROR [o.s.w.c.ContextLoader] (main:null) Context initialization failed > org.springfra

Re: [DISCUSS] Transaction Hell

2013-10-09 Thread Darren Shepherd
Pedro, >From a high level I think we'd probably agree. Generally I feel an IaaS platform is largely a metadata management framework that stores the "desired" state of the infrastructure and then pro-actively tries to reconcile the desired state with reality. So failures should be recovered from

master simulator build broken on ManagedContext

2013-10-09 Thread Prasanna Santhanam
Hi, on the simulator build in jenkins [1] on starting jetty I see the following issue: ERROR [o.s.w.c.ContextLoader] (main:null) Context initialization failed org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'ManagedContext' defined in class path resource [ap

Re: System VM template caching

2013-10-09 Thread kel...@backbonetechnology.com
We tested deleting the template on primary storage, and it failed to regenerate. What is the documented method for registering the new template, can you link to it? It seems many of us failed to find any documentation about updating the template period, not just in the 4.2 release doc under upg

Re: what's the reason for the placeholder nic in VPC/VR?

2013-10-09 Thread Alena Prokharchyk
I've just tested it on the latest master, don't see placeholder nic created for the VPC VR. In addition to the case Murali explained, placeholder nic is being created per Shared network case using VR as DHCP provider. Its done to preserve the same ip address for the case when VR is being expunged/

Re: System VM template caching

2013-10-09 Thread Ahmad Emneina
there might be a more sound way than swapping the template on secondary storage and hacking the db. I figure one should be able to register the template, via the documented route... wait for download to succeed, upgrade the binary bits. then when the system vm's fail to launch. delete the cached te

Re: System VM template caching

2013-10-09 Thread kel...@backbonetechnology.com
This process you mention for registering as a user VM I can't find in the upgrade guide. Do you have a link? The work around works because CloudStack defaults to re-download the system template is it is in NOT_DOWNLOADED status. How ever the database never gets updated for the life of the build

Re: [DISCUSS] Return ssh publickeys in listSSHKeyPairs

2013-10-09 Thread Ian Duffy
> AFAIK, an agent is needed in user vms. I was hoping it'd be possible via the file sharing capabilities many of the hypervisor tools offer. Although I would imagine security issues could arise from that. On 9 October 2013 15:51, Wei ZHOU wrote: > I need this as well. > > AFAIK, an agent is need

Re: [DISCUSS] Transaction Hell

2013-10-09 Thread Pedro Roque Marques
Darren, My assumption when I tried to make sense of the transaction code is that the underlying motivation is that the code is trying to create a transaction per API call and then allow multiple modules to implement that API call... i.e. the intent is do use a bit of what i would call a "web-serv

Re: System VM template caching

2013-10-09 Thread Sebastien Goasguen
Are you sure about this ? I thought we needed to register them as user vm and that the upgrade would convert them to systemVM automatically -Sebastien On 9 Oct 2013, at 17:22, "kel...@backbonetechnology.com" wrote: > I was able to create a work around and several community builders tested it

Re: System VM template caching

2013-10-09 Thread kel...@backbonetechnology.com
I was able to create a work around and several community builders tested it out for me and it works. I will not submit to docs as it's a hack, but I have updated the JIRA ticket. Work around can be found at: http://cloud.kelceydamage.com/cloudfire/blog/2013/10/08/conquering-the-cloudstack-4-2-d

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-09 Thread Chip Childers
+1 from me too. On Wed, Oct 9, 2013 at 12:13 PM, Prasanna Santhanam wrote: > Here's the BVT result from spring-modularization branch: Failures that > are listed exist on master as well. So the branch doesn't break > anything additionally. > > +1 to merge > > http://jenkins.buildacloud.org/job/t

Re: Contrail plugin

2013-10-09 Thread Pedro Roque Marques
Darren, On Oct 9, 2013, at 8:35 AM, Darren Shepherd wrote: > Pedro, > > I completely understand what you are saying as I think this is a gap > too I would like to address. I'm thinking of something a little > bigger and grander than what you would need right now so that's not > helpful, as I wo

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-09 Thread Prasanna Santhanam
Here's the BVT result from spring-modularization branch: Failures that are listed exist on master as well. So the branch doesn't break anything additionally. +1 to merge http://jenkins.buildacloud.org/job/test-matrix/571/ Xen: Test Run: #892 Logs: http://jenkins.buildacloud.org/job/test-matrix/

Re: Contrail plugin

2013-10-09 Thread Darren Shepherd
Pedro, I completely understand what you are saying as I think this is a gap too I would like to address. I'm thinking of something a little bigger and grander than what you would need right now so that's not helpful, as I won't get around to doing anything for a couple months. I do not think Even

Re: [DISCUSS] Transaction Hell

2013-10-09 Thread Darren Shepherd
Some random responses. Spring is good at two things. The core IoC container and TX mgmt. The way I use Spring for IoC is I always ensure there is no dependency on Spring itself. This means I don't really care too much about the Spring core IoC container and would be open to using a different con

Re: [DISCUSS] Return ssh publickeys in listSSHKeyPairs

2013-10-09 Thread Wei ZHOU
I need this as well. AFAIK, an agent is needed in user vms. > Is there any way to add multiple SSH Public keys to a VM without powering it down?

Re: Review Request 14549: Rename net.juniper.contrail to org.apache.cloudstack.network.contrail

2013-10-09 Thread Murali Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14549/#review26819 --- - Is there a reason why no new isolation type was not added for 'con

Re: [New Feature FS] SSL Offload Support for Cloudstack

2013-10-09 Thread Syed Ahmed
Thanks Murali for your response. > - any reason why you choose assignTo/RemoveFrom load balancer rule API's I thought this made more sense than create/updateLoadbalancerRule as we would have to call update to delete a cert which I find somewhat confusing. Also this is semantically similar to atta

Re: Latest Master DB issue

2013-10-09 Thread Darren Shepherd
I think I'll solve this with a fourth option. I don't particularly like two thing. Threads that never access the DB before are now doing it (albeit just once) and if there is any error calling the DB it does exit(1). I'm going to make the CallingContext instance that gets registered for the syst

  1   2   >