> On Oct. 10, 2013, 6:36 a.m., SrikanteswaraRao Talluri wrote:
> > test/integration/component/test_templates.py, line 437
> > <https://reviews.apache.org/r/14076/diff/2/?file=362285#file362285line437>
> >
> >     How are you populating 'destzoneid'. look at the review request 
> > https://reviews.apache.org/r/8082. those changes are needed here.
> >     
> >     add the below code snippet:
> >      #populate second zone id for iso copy
> >     194     
> >             cmd = listZones.listZonesCmd()
> >     195     
> >             zones = cls.api_client.listZones(cmd)
> >     196     
> >             if not isinstance(zones, list):
> >     197     
> >                 raise Exception("Failed to find zones.")
> >     198     
> >             if len(zones) >= 2:
> >     199     
> >                 cls.services["destzoneid"] = zones[1].id

Hi Talluri,

These changes have already been included. See below code


cmd = listZones.listZonesCmd()
289     
        zones = cls.api_client.listZones(cmd)

290     
        if not isinstance(zones, list):

291     
            raise Exception("Failed to find zones.")

292     
        if len(zones) >= 2:

293     
            cls.services["destzoneid"] = zones[1].id


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14076/#review26858
-----------------------------------------------------------


On Oct. 8, 2013, 1:45 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14076/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 1:45 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Harikrishna Patnala, and 
> Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added one missing test for test_templates.py from old QA repo to Cloudstack   
>   
> 
>         def test_02_copy_template
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_templates.py ea4b277 
>   tools/marvin/marvin/integration/lib/base.py 0d52224 
> 
> Diff: https://reviews.apache.org/r/14076/diff/
> 
> 
> Testing
> -------
> 
> Run log:
> ==> client.log <==
> 2013-10-08 00:23:44,306 - DEBUG - test_02_copy_template 
> (test_templates_fixed.TestTemplates) - Copying template from zone: 
> 79ed0a9e-469c-460d-b674-0a2
> to 10c91f7e-06ed-47e4-a1fd-26d9102e9d6f
> 
> ==> result.log <==
> skipped 'Skip'
> test_01_create_template_volume (test_templates_fixed.TestTemplates)
> Test Create template from volume ... skipped 'Skip'
> test_02_copy_template (test_templates_fixed.TestTemplates)
> Test for copy template from one zone to another ... ok
> test_03_delete_template (test_templates_fixed.TestTemplates)
> Test Delete template ... skipped 'Skip'
> test_04_template_from_snapshot (test_templates_fixed.TestTemplates)
> Create Template from snapshot ... skipped 'Skip'
> 
> ----------------------------------------------------------------------
> Ran 5 tests in 567.935s
> 
> OK (skipped=4)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Reply via email to