Re: Cutting 4.6.1 release

2018-01-17 Thread Enrico Olivelli
Il mer 17 gen 2018, 09:48 Ivan Kelly ha scritto: > A PR and an issue are almost identical in github though. What is the > advantage of having an issue, if all the discussion is on the PR? > The only problem is about creating release notes. Items are duplicated and it is difficult to create a nic

Re: Cutting 4.6.1 release

2018-01-17 Thread Ivan Kelly
A PR and an issue are almost identical in github though. What is the advantage of having an issue, if all the discussion is on the PR? On Wed, Jan 17, 2018 at 7:01 AM, Jia Zhai wrote: > +1, > From my view, it is better to "have an issue for each PR". > > On Wed, Jan 17, 2018 at 4:28 AM, Enrico Ol

Re: Cutting 4.6.1 release

2018-01-16 Thread Jia Zhai
+1, >From my view, it is better to "have an issue for each PR". On Wed, Jan 17, 2018 at 4:28 AM, Enrico Olivelli wrote: > Some news, I am on hold due to two critical bugs to be fixed. > I will resume as soon as we merge the fixes > Stay tuned > Enrico > > Il dom 14 gen 2018, 15:24 Enrico Olivell

Re: Cutting 4.6.1 release

2018-01-16 Thread Enrico Olivelli
Some news, I am on hold due to two critical bugs to be fixed. I will resume as soon as we merge the fixes Stay tuned Enrico Il dom 14 gen 2018, 15:24 Enrico Olivelli ha scritto: > This is the PR for release notes > > https://github.com/apache/bookkeeper/pull/980 > > I would like to point out tha

Re: Cutting 4.6.1 release

2018-01-14 Thread Enrico Olivelli
This is the PR for release notes https://github.com/apache/bookkeeper/pull/980 I would like to point out that now that we do not have an issue for each PR it is really messy to create release notes, or at least it is not possible to have a simple link to a list of the things that have been done,

Re: Cutting 4.6.1 release

2018-01-08 Thread Sijie Guo
Enrico, I cherry-picked a few changes from master to branch-4.6. The important fix is the index persistence manager fix that Ivan did, and other fixes that Sam fixed. I already update the release labels for the cherry-picked changes. However please also take a look before you cut the 4.6.1 relea

Re: Cutting 4.6.1 release

2018-01-07 Thread Sijie Guo
Just worth point out, even licensing change is ready, you should stick to only release server package. Because 4.6.1 is a bug fix release for 4.6.0, which should be only limited to bug fixes. Sijie On Jan 7, 2018 2:35 AM, "Enrico Olivelli" wrote: > Hi BookKeepers, > I would like to cut a releas