Il mer 17 gen 2018, 09:48 Ivan Kelly <iv...@apache.org> ha scritto:

> A PR and an issue are almost identical in github though. What is the
> advantage of having an issue, if all the discussion is on the PR?
>

The only problem is about creating release notes. Items are duplicated and
it is difficult to create a nice and useful list.
I think Flavio pointed this out several times too

Enrico

>
> On Wed, Jan 17, 2018 at 7:01 AM, Jia Zhai <zhaiji...@gmail.com> wrote:
> > +1,
> > From my view, it is better to "have an issue for each PR".
> >
> > On Wed, Jan 17, 2018 at 4:28 AM, Enrico Olivelli <eolive...@gmail.com>
> > wrote:
> >
> >> Some news, I am on hold due to two critical bugs to be fixed.
> >> I will resume as soon as we merge the fixes
> >> Stay tuned
> >> Enrico
> >>
> >> Il dom 14 gen 2018, 15:24 Enrico Olivelli <eolive...@gmail.com> ha
> >> scritto:
> >>
> >> > This is the PR for release notes
> >> >
> >> > https://github.com/apache/bookkeeper/pull/980
> >> >
> >> > I would like to point out that now that we do not have an issue for
> each
> >> > PR it is really messy to create release notes, or at least it is not
> >> > possible to have a simple link to a list of the things that have been
> >> done,
> >> > because issues and pull requests overlaps.
> >> > I can live with this anyway.
> >> >
> >> > Enrico
> >> >
> >> >
> >> > 2018-01-09 2:35 GMT+01:00 Sijie Guo <guosi...@gmail.com>:
> >> >
> >> >> Enrico,
> >> >>
> >> >> I cherry-picked a few changes from master to branch-4.6.
> >> >>
> >> >> The important fix is the index persistence manager fix that Ivan did,
> >> and
> >> >> other fixes that Sam fixed.
> >> >>
> >> >> I already update the release labels for the cherry-picked changes.
> >> However
> >> >> please also take a look before you cut the 4.6.1 release.
> >> >>
> >> >> Thanks,
> >> >> Sijie
> >> >>
> >> >> On Sun, Jan 7, 2018 at 11:27 AM, Sijie Guo <guosi...@gmail.com>
> wrote:
> >> >>
> >> >> > Just worth point out, even licensing change is ready, you should
> stick
> >> >> to
> >> >> > only release server package. Because 4.6.1 is a bug fix release for
> >> >> 4.6.0,
> >> >> > which should be only limited to bug fixes.
> >> >> >
> >> >> > Sijie
> >> >> >
> >> >> > On Jan 7, 2018 2:35 AM, "Enrico Olivelli" <eolive...@gmail.com>
> >> wrote:
> >> >> >
> >> >> >> Hi BookKeepers,
> >> >> >> I would like to cut a release from 4.6 branch.
> >> >> >> I need the bookkeeper-server-shaded artifact, this is my
> motivation.
> >> >> >> I will start the formal process in the middle of the next week if
> no
> >> >> one
> >> >> >> has objections.
> >> >> >> Please tag with 4.6.1 label any issue/pr which you want to
> include in
> >> >> 4.6
> >> >> >> branch before the release.
> >> >> >> I will take care of having all of them in.
> >> >> >> About the licensing stuff...I am going to relase the same set of
> >> >> artifacts
> >> >> >> as 4.6.0 because we are not ready to distribute the big package
> with
> >> >> all
> >> >> >> the dependencies
> >> >> >>
> >> >> >> Cheers
> >> >> >> Enrico
> >> >> >> --
> >> >> >>
> >> >> >>
> >> >> >> -- Enrico Olivelli
> >> >> >>
> >> >> >
> >> >>
> >> >
> >> > --
> >>
> >>
> >> -- Enrico Olivelli
> >>
>
-- 


-- Enrico Olivelli

Reply via email to