Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Enrico Olivelli
Jul 21, 2017 12:59 AM, "Enrico Olivelli" > > wrote: > > > > > > > > Hi, > > > > I have just file this issue > > > > https://github.com/apache/bookkeeper/issues/271 > > > > > > > > After the switch to Netty

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Sijie Guo
; > On Jul 21, 2017 12:59 AM, "Enrico Olivelli" > wrote: > > > > > > Hi, > > > I have just file this issue > > > https://github.com/apache/bookkeeper/issues/271 > > > > > > After the switch to Netty 4 I noticed this "API change", tha

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Enrico Olivelli
file this issue > > https://github.com/apache/bookkeeper/issues/271 > > > > After the switch to Netty 4 I noticed this "API change", that is very > > important to be documented and/or to be addresses. > > > > > > I think documentation is im

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Sijie Guo
On Jul 21, 2017 9:25 AM, "Enrico Olivelli" wrote: Il ven 21 lug 2017, 18:19 Sijie Guo ha scritto: > On Jul 21, 2017 12:59 AM, "Enrico Olivelli" wrote: > > Hi, > I have just file this issue > https://github.com/apache/bookkeeper/issues/271 > > After

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Enrico Olivelli
Il ven 21 lug 2017, 18:19 Sijie Guo ha scritto: > On Jul 21, 2017 12:59 AM, "Enrico Olivelli" wrote: > > Hi, > I have just file this issue > https://github.com/apache/bookkeeper/issues/271 > > After the switch to Netty 4 I noticed this "API change", that

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Sijie Guo
t; around >> memory release is new concept to Java world. >> >> >> On Fri, Jul 21, 2017 at 12:59 AM Enrico Olivelli >> wrote: >> >> > Hi, >> > I have just file this issue >> > https://github.com/apache/bookkeeper/issues/271 >> >

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Sijie Guo
On Jul 21, 2017 12:59 AM, "Enrico Olivelli" wrote: Hi, I have just file this issue https://github.com/apache/bookkeeper/issues/271 After the switch to Netty 4 I noticed this "API change", that is very important to be documented and/or to be addresses. I think documenta

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Enrico Olivelli
ept to Java world. >> >> >> On Fri, Jul 21, 2017 at 12:59 AM Enrico Olivelli >> wrote: >> >> > Hi, >> > I have just file this issue >> > https://github.com/apache/bookkeeper/issues/271 >> > >> > After the switch to Netty 4

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Enrico Olivelli
> wrote: > > > Hi, > > I have just file this issue > > https://github.com/apache/bookkeeper/issues/271 > > > > After the switch to Netty 4 I noticed this "API change", that is very > > important to be documented and/or to be addresses. > &g

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Venkateswara Rao Jujjuri
Can we also add some stats around this to track these. ? Discipline around memory release is new concept to Java world. On Fri, Jul 21, 2017 at 12:59 AM Enrico Olivelli wrote: > Hi, > I have just file this issue > https://github.com/apache/bookkeeper/issues/271 > > After the sw

ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Enrico Olivelli
Hi, I have just file this issue https://github.com/apache/bookkeeper/issues/271 After the switch to Netty 4 I noticed this "API change", that is very important to be documented and/or to be addresses. Inside LedgerEntry object we retain a ByteBuf, which is turn is automatically '

Re: Netty 4

2017-05-19 Thread Jia Zhai
👍 On Fri, May 19, 2017 at 10:26 PM, Enrico Olivelli wrote: > Here it is! > https://repository.apache.org/content/groups/snapshots/org/ > apache/bookkeeper/ > this is the pom with netty4 > https://repository.apache.org/content/groups/snapshots/org/ > apache/bookkeeper/bookkeeper/4.5.0-SNAPSHOT/bo

Re: Netty 4

2017-05-19 Thread Enrico Olivelli
Here it is! https://repository.apache.org/content/groups/snapshots/org/apache/bookkeeper/ this is the pom with netty4 https://repository.apache.org/content/groups/snapshots/org/apache/bookkeeper/bookkeeper/4.5.0-SNAPSHOT/bookkeeper-4.5.0-20170519.141622-6.pom the provider for https://prometheus.io

Re: Netty 4

2017-05-15 Thread Venkateswara Rao Jujjuri
Awesome!! On Mon, May 15, 2017 at 11:11 AM, Enrico Olivelli wrote: > Great! > I will update public snapshots asap > > Enrico > > Il lun 15 mag 2017, 19:54 Sijie Guo ha scritto: > > > I merged BOOKKEEPER-1008. It lands on master now! It is a great milestone > > for 4.5.0. > > > > Thank you every

Re: Netty 4

2017-05-15 Thread Enrico Olivelli
Great! I will update public snapshots asap Enrico Il lun 15 mag 2017, 19:54 Sijie Guo ha scritto: > I merged BOOKKEEPER-1008. It lands on master now! It is a great milestone > for 4.5.0. > > Thank you everyone for making this happen! > > - Sijie > -- -- Enrico Olivelli

Netty 4

2017-05-15 Thread Sijie Guo
I merged BOOKKEEPER-1008. It lands on master now! It is a great milestone for 4.5.0. Thank you everyone for making this happen! - Sijie

Re: SSL and Netty 4/OpenSSL news

2017-03-09 Thread Kkasiud1
gt; Sijie, >>> Most of the upcoming patches from Yahoo will need Netty 4, and at >>> Salesforce are working on Netty 4 + SSL, so the idea at the last meeting >>> was to get Netty 4.1 in in 4.5 >>> I think that most of the problem is that you local fork actually is

Re: SSL and Netty 4/OpenSSL news

2017-03-07 Thread Venkateswara Rao Jujjuri
On Tue, Mar 7, 2017 at 10:53 AM, Sijie Guo wrote: > On Mon, Mar 6, 2017 at 11:33 PM, Enrico Olivelli > wrote: > > > Sijie, > > Most of the upcoming patches from Yahoo will need Netty 4, and at > > Salesforce are working on Netty 4 + SSL, so the idea at the last meeti

Re: SSL and Netty 4/OpenSSL news

2017-03-07 Thread Sijie Guo
On Mon, Mar 6, 2017 at 11:33 PM, Enrico Olivelli wrote: > Sijie, > Most of the upcoming patches from Yahoo will need Netty 4, and at > Salesforce are working on Netty 4 + SSL, so the idea at the last meeting > was to get Netty 4.1 in in 4.5 > I think that most of the problem is

Re: SSL and Netty 4/OpenSSL news

2017-03-06 Thread Enrico Olivelli
Sijie, Most of the upcoming patches from Yahoo will need Netty 4, and at Salesforce are working on Netty 4 + SSL, so the idea at the last meeting was to get Netty 4.1 in in 4.5 I think that most of the problem is that you local fork actually is based on Netty 3, as we recently discussed about the

Re: SSL and Netty 4/OpenSSL news

2017-03-06 Thread Sijie Guo
I need to catch up a bit about this thread. for my understanding, the question is shall we include netty 4.x upgrade in BK 4.5 release or shall we push to 4.6? - Sijie On Fri, Feb 24, 2017 at 8:05 AM, Enrico Olivelli wrote: > I have just sent an email to JV > > 2017-02-24 17:03

Re: Netty 4 and linux epoll

2017-03-06 Thread Kkasiud1
6, 2017, 9:42:14 AM CST, Enrico Olivelli > wrote:Great, > so Kishore and JV, can you take this into account on the Netty 4 patch ? > > or maybe we can create a first baseline fom Kishore and than add the > "natvie EPoll" feature with a patch from Yahoo codebase. > &g

Re: Netty 4 and linux epoll

2017-03-06 Thread Bobby Evans
Sure, I am happy to add it in afterwards too. - Bobby On Monday, March 6, 2017, 9:42:14 AM CST, Enrico Olivelli wrote:Great, so Kishore and JV, can you take this into account on the Netty 4 patch ? or maybe we can create a first baseline fom Kishore and than add the "natvie EPoll&quo

Re: Netty 4 and linux epoll

2017-03-06 Thread Enrico Olivelli
Great, so Kishore and JV, can you take this into account on the Netty 4 patch ? or maybe we can create a first baseline fom Kishore and than add the "natvie EPoll" feature with a patch from Yahoo codebase. Bobby, can you put a comment on the JIRA for Netty 4 ? Thank you Enrico 2017-0

Re: Netty 4 and linux epoll

2017-03-06 Thread Bobby Evans
rch 4, 2017, 8:29:52 AM CST, Enrico Olivelli wrote:Hi all, As we are switching to netty 4.1 maybe ee can look to this too: http://netty.io/wiki/native-transports.html Even if I have been using netty 4 for some year I did not get this promising feature on linux. Did any of you ever gi

Netty 4 and linux epoll

2017-03-04 Thread Enrico Olivelli
Hi all, As we are switching to netty 4.1 maybe ee can look to this too: http://netty.io/wiki/native-transports.html Even if I have been using netty 4 for some year I did not get this promising feature on linux. Did any of you ever give it a try? Enrico -- -- Enrico Olivelli

Re: SSL and Netty 4/OpenSSL news

2017-02-24 Thread Bobby Evans
ico's >> > patch. >> > > >> > > I will request Kishore to be in next meeting. The patch kishore >> > has >> > > >> takes >> > > >> > > to Netty 4.1.7. >> > > >> > > >> >

Re: SSL and Netty 4/OpenSSL news

2017-02-24 Thread Enrico Olivelli
t; Enrico > >> > > >> > > >> > > >> > > >> > > >> > 2017-02-23 0:26 GMT+01:00 Venkateswara Rao Jujjuri < > >> > jujj...@gmail.com > >> > > >: > >> > > >> > > >> &g

Re: SSL and Netty 4/OpenSSL news

2017-02-24 Thread Enrico Olivelli
t;> > > >> > > Kishore has done bunch of work, and he is reviewing Enrico's >> > patch. >> > > >> > > I will request Kishore to be in next meeting. The patch kishore >> > has >> > > >> takes >> > > >

Re: SSL and Netty 4/OpenSSL news

2017-02-23 Thread Enrico Olivelli
s > > > >> > > to Netty 4.1.7. > > > >> > > > > > >> > > On Wed, Feb 22, 2017 at 8:39 AM, Bobby Evans > > > >> > > >> > > > > > >> > > wrote: > > > >> > > > > > >>

Re: SSL and Netty 4/OpenSSL news

2017-02-23 Thread Venkateswara Rao Jujjuri
> >> > > > I just filed BOOKKEEPER-1008 for this work. If others have a > > >> different > > >> > > > opinion on this feel free to comment here or on the JIRA. I > want > > to > > >> > make > > &

Re: SSL and Netty 4/OpenSSL news

2017-02-23 Thread Enrico Olivelli
; > > > > >> > > On Wed, Feb 22, 2017 at 8:39 AM, Bobby Evans > > >> > >> > > > > >> > > wrote: > > >> > > > > >> > > > I just filed BOOKKEEPER-1008 for this work. If others have a &

Re: SSL and Netty 4/OpenSSL news

2017-02-23 Thread Bobby Evans
ER-1008 for this work.  If others have a > >> different > >> > > > opinion on this feel free to comment here or on the JIRA.  I want > to > >> > make > >> > > > sure we have the backing of the community on this. > >> > > > >

Re: SSL and Netty 4/OpenSSL news

2017-02-23 Thread Enrico Olivelli
I want > to > >> > make > >> > > > sure we have the backing of the community on this. > >> > > > > >> > > > > >> > > > - Bobby > >> > > > > >> >

Re: SSL and Netty 4/OpenSSL news

2017-02-23 Thread Venkateswara Rao Jujjuri
- Bobby >> > > > >> > > > On Wednesday, February 22, 2017, 10:35:29 AM CST, Bobby Evans >> > > > wrote:I would be happy to give it a >> try. >> > > > Like I said we are coming up on needing to push it back anyways. >> Our >> >

Re: SSL and Netty 4/OpenSSL news

2017-02-23 Thread Venkateswara Rao Jujjuri
> > > wrote:I would be happy to give it a > try. > > > > Like I said we are coming up on needing to push it back anyways. Our > > > code > > > > is based off of 4.0.36.Final, but I can take a look at 4.1.x and see > > what > > > > d

Re: SSL and Netty 4/OpenSSL news

2017-02-23 Thread Enrico Olivelli
> > is based off of 4.0.36.Final, but I can take a look at 4.1.x and see > what > > > differences there are with the API. > > > > > > - Bobby > > > > > > On Wednesday, February 22, 2017, 9:57:52 AM CST, Enrico Olivelli < > > &g

Re: SSL and Netty 4/OpenSSL news

2017-02-23 Thread Bobby Evans
off of 4.0.36.Final, but I can take a look at 4.1.x and see what > > differences there are with the API. > > > > - Bobby > > > > On Wednesday, February 22, 2017, 9:57:52 AM CST, Enrico Olivelli < > > eolive...@gmail.com> wrote:I'm using Netty 4.1.x for

Re: SSL and Netty 4/OpenSSL news

2017-02-23 Thread Enrico Olivelli
to push it back anyways. Our > code > > is based off of 4.0.36.Final, but I can take a look at 4.1.x and see what > > differences there are with the API. > > > > - Bobby > > > > On Wednesday, February 22, 2017, 9:57:52 AM CST, Enrico Olivelli < > > eo

Re: SSL and Netty 4/OpenSSL news

2017-02-22 Thread Venkateswara Rao Jujjuri
wrote:I'm using Netty 4.1.x for all of my projects > and I am very +1 on the switch > to Netty 4 > > @Sijie what do you think ? > If we all agree to switch to Netty 4 (I hope 4.1.x) who can take care of > the first port ? > > > Enrico > > 2017-02-22 16:32

Re: SSL and Netty 4/OpenSSL news

2017-02-22 Thread Bobby Evans
using Netty 4.1.x for all of my projects and I am very +1 on the switch to Netty 4 @Sijie what do you think ? If we all agree to switch to Netty 4 (I hope 4.1.x)  who can take care of the first port ? Enrico 2017-02-22 16:32 GMT+01:00 Bobby Evans : > I really would like to get netty4 in soone

Re: SSL and Netty 4/OpenSSL news

2017-02-22 Thread Bobby Evans
wrote:I'm using Netty 4.1.x for all of my projects and I am very +1 on the switch to Netty 4 @Sijie what do you think ? If we all agree to switch to Netty 4 (I hope 4.1.x)  who can take care of the first port ? Enrico 2017-02-22 16:32 GMT+01:00 Bobby Evans : > I really would lik

Re: SSL and Netty 4/OpenSSL news

2017-02-22 Thread Enrico Olivelli
I'm using Netty 4.1.x for all of my projects and I am very +1 on the switch to Netty 4 @Sijie what do you think ? If we all agree to switch to Netty 4 (I hope 4.1.x) who can take care of the first port ? Enrico 2017-02-22 16:32 GMT+01:00 Bobby Evans : > I really would like to get n

Re: SSL and Netty 4/OpenSSL news

2017-02-22 Thread Bobby Evans
performances using native OpenSSL + netty 4. How the work is going ? Open questions are: 1) status of my current patch on SSL should I rebase, than get it merged and then continue the work from it or JV and SF guys will pick up the work entirely ? 2) switch to Netty 4: Initially we said that the switch

SSL and Netty 4/OpenSSL news

2017-02-22 Thread Enrico Olivelli
Hi all BookKeepers, At the last community meeting JV reported that a Salesforce there is some work on SSL/TLS, in particular due to better performances using native OpenSSL + netty 4. How the work is going ? Open questions are: 1) status of my current patch on SSL should I rebase, than get it