Re: Dropping 'stream' profile

2018-11-21 Thread Enrico Olivelli
Ivan drafted an issue which seems a good plan to me. https://github.com/apache/bookkeeper/issues/1822 Meanwhile we are releasing 4.8.1, the fix for this situation will be most probably on 4.9. Please refer to the issue for the details and for comments Thanks Enrico Il mar 20 nov 2018, 20:42

Re: Dropping 'stream' profile

2018-11-20 Thread Sijie Guo
Thank you for creating the issue. Created a quick fix for `standalone`: https://github.com/apache/bookkeeper/pull/1823 Integration tests requires some cleanup to refactor the structure. - Sijie On Tue, Nov 20, 2018 at 11:33 AM Ivan Kelly wrote: > > Yes. That is a problem but it is not related

Re: Dropping 'stream' profile

2018-11-20 Thread Ivan Kelly
> Yes. That is a problem but it is not related stream profile. Let's separate > unrelated issues into a different thread. > Also I would suggest creating an issue in github when a problem is > considered a bug, so the discussion can be more organized. I'll create a bug. > > I would suggest we als

Re: Dropping 'stream' profile

2018-11-20 Thread Sijie Guo
couldn't see anything. i didn't even try slack, search there is awful. > e.g. 4.8.0 rc0 vote email thread. > > > Here is the summary I don’t like dropping stream profile. > > > > I put table service and distributedlog under stream, because the whole > > stuf

Re: Dropping 'stream' profile

2018-11-20 Thread Ivan Kelly
wful. > Here is the summary I don’t like dropping stream profile. > > I put table service and distributedlog under stream, because the whole > stuff is built as an extension to bookkeeper core (ledger service). So this > extension is optionally. With that being said, the bookkeeper dis

Re: Dropping 'stream' profile

2018-11-20 Thread Sijie Guo
e explained in may different threads that I have been mentioned. Here is the summary I don’t like dropping stream profile. I put table service and distributedlog under stream, because the whole stuff is built as an extension to bookkeeper core (ledger service). So this extension is optionally. W

Re: Dropping 'stream' profile

2018-11-20 Thread Enrico Olivelli
Confirming my opinion: +1 for dropping it in 4.9 +0 for dropping it in 4.8 branch No change for 4.7 branch Enrico Il mar 20 nov 2018, 13:19 Ivan Kelly ha scritto: > Resurrecting this thread, since it seems discusssions and decisions > have been made about it, but there's no record of these anyw

Re: Dropping 'stream' profile

2018-11-20 Thread Ivan Kelly
Resurrecting this thread, since it seems discusssions and decisions have been made about it, but there's no record of these anywhere that matters. 4.8.1-rc1 is out for vote, and once again if you build it in the default way, random things do not work. Currently standalone doesn't work straight awa

Re: Dropping 'stream' profile

2018-09-17 Thread Sijie Guo
Actually let's hold on this change for now. I was actually talking with JV about this. There are two many directories (modules) at the root level. It is a bit unclear about what modules. We might consider reorganizing the modules to make it clearer. I will come back with a proposal soon. - Sijie

Re: Dropping 'stream' profile

2018-09-16 Thread Enrico Olivelli
Sijie This is a proposal It is possilble that the precommit stuff will need a follow up patch, to add a new precommit "subtask" Please check it out https://github.com/apache/bookkeeper/pull/1680 Enrico Il giorno lun 13 ago 2018 alle ore 09:57 Ivan Kelly ha scritto: > +1 for dropping the profil

Re: Dropping 'stream' profile

2018-08-13 Thread Ivan Kelly
+1 for dropping the profiles. On Mon, Aug 13, 2018 at 12:24 AM, Sijie Guo wrote: > I have no problem with this proposal. I am fine with dropping the profiles. > > Sijie > > On Sun, Aug 12, 2018 at 2:53 AM Enrico Olivelli wrote: > >> Hi, >> Currently in order to build the full code you have to ad

Re: Dropping 'stream' profile

2018-08-12 Thread Sijie Guo
I have no problem with this proposal. I am fine with dropping the profiles. Sijie On Sun, Aug 12, 2018 at 2:53 AM Enrico Olivelli wrote: > Hi, > Currently in order to build the full code you have to add -Dstream > property, this in turn will activate the 'stream' profile. > Additionally to run

Dropping 'stream' profile

2018-08-12 Thread Enrico Olivelli
Hi, Currently in order to build the full code you have to add -Dstream property, this in turn will activate the 'stream' profile. Additionally to run tests in 'stream' submodule you have to also add -DstreamTests. This is very annoying, and now that we are going to release the 'stream' storage mod