On Tue, Nov 20, 2018 at 10:42 AM Ivan Kelly <iv...@apache.org> wrote:
> > There is no decision made. However I am -1 to drop stream profile, as I > > have explained in may different threads that I have been mentioned. > > Where were these threads? I did a search in github and the list, but > couldn't see anything. i didn't even try slack, search there is awful. > e.g. 4.8.0 rc0 vote email thread. > > > Here is the summary I don’t like dropping stream profile. > > > > I put table service and distributedlog under stream, because the whole > > stuff is built as an extension to bookkeeper core (ledger service). So > this > > extension is optionally. With that being said, the bookkeeper > distribution > > should can be built with and without stream profile. > > So this is what is confusing and annoying about the profile. We say > it's optional, but then we only test with it on. We generate the > distributed binary packages with the profile. We only test end to end > functionality with the profile. So it's optional, but we always turn > the option on. > > If we are to keep the profile, then the optional stuff should be truly > optional. I.e. server-bin with the profile should be identical to > server-bin without the flag. And all integration testing that isn't > testing functionality in the extensions should be against server-bin > without the profile. Anything that requires the profile in integration > testing should be in a different directory to make it clear that it's > not testing core. > > I agree that the separation of core and extensions is good. But right > now, we're not actually enforcing it because this is an integration > problem, and we're only testing with the profile on. > I have explained that before. We need to improve integration tests. > > > All the scripts is provided to be working at two conditions: in a > released > > binary package and in a source directory. If it is running in a source > > directory and it is not built, it will run maven command to build and > > generating the classpath. > > It did this, but when I typed yes, there was no indication that it was > doing this. It looked like the process hung, so i killed it, and only > later discovered the build had continued. I would consider this a bug. > Should be noisier. > Yes. That is a problem but it is not related stream profile. Let's separate unrelated issues into a different thread. Also I would suggest creating an issue in github when a problem is considered a bug, so the discussion can be more organized. > > I would suggest we also add a switch to enable the stream profile with > -Dall to harmonize with the package naming. > I am fine with a `-Dall` > > -Ivan >
