Actually let's hold on this change for now. I was actually talking with JV about this. There are two many directories (modules) at the root level. It is a bit unclear about what modules. We might consider reorganizing the modules to make it clearer. I will come back with a proposal soon.
- Sijie On Sun, Sep 16, 2018 at 5:18 AM Enrico Olivelli <eolive...@gmail.com> wrote: > Sijie > This is a proposal > It is possilble that the precommit stuff will need a follow up patch, to > add a new precommit "subtask" > > Please check it out > https://github.com/apache/bookkeeper/pull/1680 > > Enrico > > Il giorno lun 13 ago 2018 alle ore 09:57 Ivan Kelly <iv...@apache.org> ha > scritto: > > > +1 for dropping the profiles. > > > > On Mon, Aug 13, 2018 at 12:24 AM, Sijie Guo <guosi...@gmail.com> wrote: > > > I have no problem with this proposal. I am fine with dropping the > > profiles. > > > > > > Sijie > > > > > > On Sun, Aug 12, 2018 at 2:53 AM Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > >> Hi, > > >> Currently in order to build the full code you have to add -Dstream > > >> property, this in turn will activate the 'stream' profile. > > >> Additionally to run tests in 'stream' submodule you have to also add > > >> -DstreamTests. > > >> > > >> This is very annoying, and now that we are going to release the > 'stream' > > >> storage module as first class citizen it does not make much sense. > > >> > > >> This additional profile makes it more complex project wide operations > > like > > >> the release procedure. > > >> For instance I broke master branch yesterday because I did not advance > > the > > >> version in poms in the stream submodule. > > >> > > >> It is giving a lot of problems on code coverage stuff as well, because > > we > > >> have a very complex configuration of surefire. > > >> > > >> My proposal is to drop those profiles and let the stream module to be > > built > > >> together with the other parts. > > >> > > >> > > >> For the ones like me that work only on bookkeeper-server this change > > won't > > >> affect every day work. > > >> > > >> I would prefer that Sijie do this change as he introduced those > profiles > > >> and knowns very well all the tricks. > > >> > > >> Regards > > >> Enrico > > >> -- > > >> > > >> > > >> -- Enrico Olivelli > > >> > > >
