Re: Use case for storage expansion

2021-11-01 Thread Hang Chen
Hi Jack, Currently, if we use multi directories for journal or ledger in one bookie, it will store specific ledger into target directory by `ledgerId % numberOfLedgers`. If we expand or shrink the ledgers or journal directories, it will break hash result value, which will lead to some ledgers

Re: [VOTE] Release 4.14.3 release candidate #1

2021-11-01 Thread Matteo Merli
+1 Verified: * Checksums * Building * Starting standalone bookie Matteo -- Matteo Merli On Mon, Nov 1, 2021 at 8:42 AM Matteo Merli wrote: > > I think if the issue with Java 11 is in that test, we shouldn't block > the release as this was probably already there before. > > We should instea

Re: [VOTE] Release 4.14.3 release candidate #1

2021-11-01 Thread Matteo Merli
I think if the issue with Java 11 is in that test, we shouldn't block the release as this was probably already there before. We should instead make sure the BK CI is using Java 11 to run the tests, to avoid this kind of issue. Matteo -- Matteo Merli On Mon, Nov 1, 2021 at 7:08 AM Yong Zhang w

Re: [VOTE] Release 4.14.3 release candidate #1

2021-11-01 Thread Yong Zhang
Hi Enrico, I reproduce this issue locally when using jdk11. Then I can add this options ` --add-opens java.base/jdk.internal.loader=ALL-UNNAMED` in the pom and the BookieJournalTest can pass. On Mon, 1 Nov 2021 at 15:46, Enrico Olivelli wrote: > Il Lun 1 Nov 2021, 05:04 Yong Zhang ha > scrit

Use case for storage expansion

2021-11-01 Thread Jack Vanlightly
Hi all, I thought I'd test the PR https://github.com/apache/bookkeeper/pull/2871 as I hadn't used storage expansion at all. It seemed to work but I ran a correctness test just in case and found that it "lost" 50% of my ledgers. Looking at the code to my surprise it does not repartition the data a

Re: [VOTE] Release 4.14.3 release candidate #1

2021-11-01 Thread Enrico Olivelli
Il Lun 1 Nov 2021, 05:04 Yong Zhang ha scritto: > It looks all tests are passed on the CI with JDK1.8 > https://github.com/apache/bookkeeper/tree/v4.14.3-rc1 I am talking about JDK11 In Pulsar we run by default on jdk11 Having those tests failing on JDK11 isn't very good. I will rerun my tests

Re: [VOTE] Release 4.14.3 release candidate #1

2021-11-01 Thread Yong Zhang
Noticed. I will ping Matteo to review that PR as well. On Mon, 1 Nov 2021 at 12:16, Yuri Mizushima wrote: > Yong > Thank you for being release manager. > > It is not an issue with the mentioned below thread, > but I think we should fix the issue > https://github.com/apache/bookkeeper/issues/2854