Il Lun 1 Nov 2021, 05:04 Yong Zhang <zhangyong1025...@gmail.com> ha scritto:
> It looks all tests are passed on the CI with JDK1.8 > https://github.com/apache/bookkeeper/tree/v4.14.3-rc1 I am talking about JDK11 In Pulsar we run by default on jdk11 Having those tests failing on JDK11 isn't very good. I will rerun my tests on jdk8 Can you please double check on jdk11? Enrico > > > So it shouldn't be a block for releasing 4.14.3, right? > > On Mon, 1 Nov 2021 at 11:23, Yong Zhang <zhangyong1025...@gmail.com> > wrote: > > > Thanks Enrico. I will take a look and test it locally. > > > > On Sat, 30 Oct 2021 at 00:20, Enrico Olivelli <eolive...@gmail.com> > wrote: > > > >> Yong > >> I am not able so see some tests passing on JDK11 > >> > >> I created this issue > >> https://github.com/apache/bookkeeper/issues/2872 > >> > >> probably there is some library missing in the classpath ? > >> > >> Enrico > >> > >> > >> Il giorno gio 28 ott 2021 alle ore 14:52 Nicolò Boschi < > >> boschi1...@gmail.com> > >> ha scritto: > >> > >> > +1 (non binding) > >> > > >> > Verified the followings: > >> > - checksum and signatures > >> > - build from sources > >> > - ledgers write/read with "localbookie 3" and "standalone" > >> > > >> > Il giorno gio 28 ott 2021 alle ore 09:06 Yong Zhang <y...@apache.org> > >> ha > >> > scritto: > >> > > >> > > Hi everyone, > >> > > Please review and vote on the release candidate #0 for the version > >> > 4.14.3, > >> > > as follows: > >> > > [ ] +1, Approve the release > >> > > [ ] -1, Do not approve the release (please provide specific > comments) > >> > > > >> > > The complete staging area is available for your review, which > >> includes: > >> > > * Release notes [1] > >> > > * The official Apache source and binary distributions to be deployed > >> to > >> > > dist.apache.org [2] > >> > > * All artifacts to be deployed to the Maven Central Repository [3] > >> > > * Source code tag "v4.14.3-rc1" [4] with git sha [5] > >> > > > >> > > BookKeeper's KEYS file contains PGP keys we used to sign this > release: > >> > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > >> > > > >> > > Please download these packages and review this release candidate: > >> > > > >> > > - Review release notes > >> > > - Download the source package (verify shasum, and asc) and follow > the > >> > > instructions to build and run the bookkeeper service. > >> > > - Download the binary package (verify shasum, and asc) and follow > the > >> > > instructions to run the bookkeeper service. > >> > > - Review maven repo, release tag, licenses, and any other things you > >> > think > >> > > it is important to a release. > >> > > > >> > > The vote will be open for at least 72 hours. It is adopted by > majority > >> > > approval, with at least 3 PMC affirmative votes. > >> > > > >> > > Thanks, > >> > > Release Manager > >> > > > >> > > [1] > >> > > > >> > > > >> > > >> > https://github.com/apache/bookkeeper/pull/2864/files#diff-5405f1e88785133938fb03ee37380c8df913b3cbaec94a2d9bfcda1f8bd57cd5 > >> > > [2] > >> > > > >> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.14.3-rc1/ > >> > > [3] > >> > > > >> > > >> > https://repository.apache.org/content/repositories/orgapachebookkeeper-1059 > >> > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.14.3-rc1 > >> > > [5] 11913dd7e261524427b4600a0fca970e58cc7f3b > >> > > > >> > > >> > > >> > -- > >> > Nicolò Boschi > >> > > >> > > >
