Noticed. I will ping Matteo to review that PR as well. On Mon, 1 Nov 2021 at 12:16, Yuri Mizushima <yumiz...@yahoo-corp.jp> wrote:
> Yong > Thank you for being release manager. > > It is not an issue with the mentioned below thread, > but I think we should fix the issue > https://github.com/apache/bookkeeper/issues/2854 > before including the https://github.com/apache/bookkeeper/pull/2833 > commit to the next version. > Could you please take a look? > > Regards, > -- > Yuri Mizushima > yumiz...@yahoo-corp.jp > > > "Yong Zhang" <zhangyong1025...@gmail.com> wrote: > > > It looks all tests are passed on the CI with JDK1.8 > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fbookkeeper%2Ftree%2Fv4.14.3-rc1&data=04%7C01%7Cyumizush%40yahoo-corp.jp%7C2e76b7182ead4652685f08d99cecab67%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637713363877933893%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=XjfM68TuhzAg9Umt7QN6aKhWYdd2cQkkX2KNbPV8Z7w%3D&reserved=0 > > So it shouldn't be a block for releasing 4.14.3, right? > > On Mon, 1 Nov 2021 at 11:23, Yong Zhang <zhangyong1025...@gmail.com> > wrote: > > > Thanks Enrico. I will take a look and test it locally. > > > > On Sat, 30 Oct 2021 at 00:20, Enrico Olivelli <eolive...@gmail.com> > wrote: > > > >> Yong > >> I am not able so see some tests passing on JDK11 > >> > >> I created this issue > >> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fbookkeeper%2Fissues%2F2872&data=04%7C01%7Cyumizush%40yahoo-corp.jp%7C2e76b7182ead4652685f08d99cecab67%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637713363877933893%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=W6IwDJSGq3L1EcIAZ2vR1OVdpWHVMfd4d6GMIY1W1kI%3D&reserved=0 > >> > >> probably there is some library missing in the classpath ? > >> > >> Enrico > >> > >> > >> Il giorno gio 28 ott 2021 alle ore 14:52 Nicolò Boschi < > >> boschi1...@gmail.com> > >> ha scritto: > >> > >> > +1 (non binding) > >> > > >> > Verified the followings: > >> > - checksum and signatures > >> > - build from sources > >> > - ledgers write/read with "localbookie 3" and "standalone" > >> > > >> > Il giorno gio 28 ott 2021 alle ore 09:06 Yong Zhang <y...@apache.org> > >> ha > >> > scritto: > >> > > >> > > Hi everyone, > >> > > Please review and vote on the release candidate #0 for the version > >> > 4.14.3, > >> > > as follows: > >> > > [ ] +1, Approve the release > >> > > [ ] -1, Do not approve the release (please provide specific > comments) > >> > > > >> > > The complete staging area is available for your review, which > >> includes: > >> > > * Release notes [1] > >> > > * The official Apache source and binary distributions to be deployed > >> to > >> > > dist.apache.org [2] > >> > > * All artifacts to be deployed to the Maven Central Repository [3] > >> > > * Source code tag "v4.14.3-rc1" [4] with git sha [5] > >> > > > >> > > BookKeeper's KEYS file contains PGP keys we used to sign this > release: > >> > > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Frelease%2Fbookkeeper%2FKEYS&data=04%7C01%7Cyumizush%40yahoo-corp.jp%7C2e76b7182ead4652685f08d99cecab67%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637713363877933893%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=16%2BjS4ujfLNEeappaCnfn1omBR7LLqq7sHkZsI6SSKk%3D&reserved=0 > >> > > > >> > > Please download these packages and review this release candidate: > >> > > > >> > > - Review release notes > >> > > - Download the source package (verify shasum, and asc) and follow > the > >> > > instructions to build and run the bookkeeper service. > >> > > - Download the binary package (verify shasum, and asc) and follow > the > >> > > instructions to run the bookkeeper service. > >> > > - Review maven repo, release tag, licenses, and any other things you > >> > think > >> > > it is important to a release. > >> > > > >> > > The vote will be open for at least 72 hours. It is adopted by > majority > >> > > approval, with at least 3 PMC affirmative votes. > >> > > > >> > > Thanks, > >> > > Release Manager > >> > > > >> > > [1] > >> > > > >> > > > >> > > >> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fbookkeeper%2Fpull%2F2864%2Ffiles%23diff-5405f1e88785133938fb03ee37380c8df913b3cbaec94a2d9bfcda1f8bd57cd5&data=04%7C01%7Cyumizush%40yahoo-corp.jp%7C2e76b7182ead4652685f08d99cecab67%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637713363877943887%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=P%2BBSYor2z2zxSZTTAHyNnPpAZOaOyYVCXjqVfma%2FrvA%3D&reserved=0 > >> > > [2] > >> > > > >> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fbookkeeper%2Fbookkeeper-4.14.3-rc1%2F&data=04%7C01%7Cyumizush%40yahoo-corp.jp%7C2e76b7182ead4652685f08d99cecab67%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637713363877943887%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=MoRPT6Kw6mh0qh78oKK5yuPxWYcrP%2BjG%2FHEKn4Fqxu4%3D&reserved=0 > >> > > [3] > >> > > > >> > > >> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachebookkeeper-1059&data=04%7C01%7Cyumizush%40yahoo-corp.jp%7C2e76b7182ead4652685f08d99cecab67%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637713363877943887%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=7%2BRyNETKCFfwM6Tr%2BxHfO%2FdrDJQvOuXMSBfXMJK8yp4%3D&reserved=0 > >> > > [4] > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fbookkeeper%2Freleases%2Ftag%2Fv4.14.3-rc1&data=04%7C01%7Cyumizush%40yahoo-corp.jp%7C2e76b7182ead4652685f08d99cecab67%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637713363877943887%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=6rVvlu5i54%2F40VwYQ6ghtGoFs2BTvs%2FlvOD1qXel36w%3D&reserved=0 > >> > > [5] 11913dd7e261524427b4600a0fca970e58cc7f3b > >> > > > >> > > >> > > >> > -- > >> > Nicolò Boschi > >> > > >> > > >
