Re: BookKeeper code coverage incredibly dropped in June from 72% to 54% !!

Il lun 30 lug 2018, 19:51 Sijie Guo ha scritto: > Great work, Enrico! > > Can we enable the code coverage for all modules? > In theory we are running the full suite as we are using -Dstream. I will double check Enrico > - Sijie > > On Mon, Jul 30, 2018 at 7:46 AM Enrico Olivelli > wrote: > >

Re: Changing ledger metadata to binary format

JV, 1) for the real world use case, this is the problem I have hit which I have to manually add a flag in the ledger metadata to avoid serializing ctime. https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java#L105 2) > We

Re: BookKeeper code coverage incredibly dropped in June from 72% to 54% !!

Great work, Enrico! Can we enable the code coverage for all modules? - Sijie On Mon, Jul 30, 2018 at 7:46 AM Enrico Olivelli wrote: > Code coverage report restored ! > > We are back to 72% > > see > https://coveralls.io/github/apache/bookkeeper > > Thank you JV, Sijie and Ivan !! > > Enrico >

Board report for August 2018

Hi all, We have a board report due for August 2018. Anyone is interested in drafting a board report? - Sijie

Re: Changing ledger metadata to binary format

Il lun 30 lug 2018, 17:32 Venkateswara Rao Jujjuri ha scritto: > > As far as I understand we are working on this change in order to be ready > > with a full "rollback" story, so we have to be one version ahead. > > If that is the case, I think we need to look at the entire roll-back story. > At t

Re: Changing ledger metadata to binary format

> As far as I understand we are working on this change in order to be ready > with a full "rollback" story, so we have to be one version ahead. If that is the case, I think we need to look at the entire roll-back story. At this point, I am not sure if we have identified all the pieces and if they

Re: Changing ledger metadata to binary format

Il giorno lun 30 lug 2018 alle ore 16:55 Venkateswara Rao Jujjuri < jujj...@gmail.com> ha scritto: > We have introduced customMetadata in the past and that was not mandatory. > How did we make that work with text format? > Also, my preference is to wait until we have a need to introduce a new > fi

Re: Changing ledger metadata to binary format

We have introduced customMetadata in the past and that was not mandatory. How did we make that work with text format? Also, my preference is to wait until we have a need to introduce a new field for this conversion if needed. JV On Mon, Jul 30, 2018 at 12:42 AM, Enrico Olivelli wrote: > Il gior

Re: BookKeeper code coverage incredibly dropped in June from 72% to 54% !!

Code coverage report restored ! We are back to 72% see https://coveralls.io/github/apache/bookkeeper Thank you JV, Sijie and Ivan !! Enrico Il giorno mar 24 lug 2018 alle ore 20:38 Enrico Olivelli < eolive...@gmail.com> ha scritto: > Here it is the patch > > Please Sijie take a look. > I wo

Re: Changing ledger metadata to binary format

Il giorno lun 30 lug 2018 alle ore 09:17 Ivan Kelly ha scritto: > >> Thank you for putting this together. It is also good to put this as a > BP, > >> since it is about the metadata layout. > > I'll put a BP up this week once I have initial feedback. > > >> > - When writing a metadata, check what

Re: Changing ledger metadata to binary format

>> Thank you for putting this together. It is also good to put this as a BP, >> since it is about the metadata layout. I'll put a BP up this week once I have initial feedback. >> > - When writing a metadata, check what is in /ledgers/LAYOUT. If it is >> > as above, write using the current text pr