Code coverage report restored ! We are back to 72%
see https://coveralls.io/github/apache/bookkeeper Thank you JV, Sijie and Ivan !! Enrico Il giorno mar 24 lug 2018 alle ore 20:38 Enrico Olivelli < eolive...@gmail.com> ha scritto: > Here it is the patch > > Please Sijie take a look. > I would like to restore Coveralls before releasing 4.8 > > Thanks > Enrico > > Il giorno mar 24 lug 2018 alle ore 20:10 Enrico Olivelli < > eolive...@gmail.com> ha scritto: > >> >> >> Il mar 24 lug 2018, 18:00 Venkateswara Rao Jujjuri <jujj...@gmail.com> >> ha scritto: >> >>> I don't see bookkeeper-server in the >>> https://coveralls.io/builds/17501203 >>> report. Rest looks almost identical. >>> That must be causing the overall drop. >>> >> >> Thank you. >> I have an idea, that change introduced a specific configuration for >> surefire, the maven plugin which executes tests. Maybe it is disabling >> JaCoCo agent. >> >> I will be back with news and hopefully a patch >> >> Enrico >> >> >>> On Tue, Jul 24, 2018 at 8:20 AM, Enrico Olivelli <eolive...@gmail.com> >>> wrote: >>> >>> > Hi, >>> > In June, the 14th, code coverage dropped >>> > >>> > here: 72% >>> > https://coveralls.io/builds/17447847 >>> > >>> > here: 54% >>> > https://coveralls.io/builds/17501203 >>> > >>> > This commit seems the cause (as reported by Coveralls.io) >>> > >>> https://github.com/apache/bookkeeper/commit/c5a36219bbb7cfce343137bf3c361f >>> > 7eb80bd64e >>> > >>> > Anyone has cycles to take a look ? >>> > >>> > >>> > Enrico >>> > >>> >>> >>> >>> -- >>> Jvrao >>> --- >>> First they ignore you, then they laugh at you, then they fight you, then >>> you win. - Mahatma Gandhi >>> >> -- >> >> >> -- Enrico Olivelli >> >
