Re: Bookie Http Endpoint

2017-07-18 Thread Enrico Olivelli
2017-07-19 3:27 GMT+02:00 Yiming Zang : > Hi all, > > We also have a working implementation in Twitter, we use Http Endpoint > mostly for getting quorum loss information, underreplicated ledgers, manage > bookie status etc. > > The HTTP server in Twitter is implemented in such a way that it has a

[GitHub] eolivelli closed pull request #257: Issue 256: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile failed

2017-07-18 Thread git
eolivelli closed pull request #257: Issue 256: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile failed URL: https://github.com/apache/bookkeeper/pull/257 This is an automated message from the Apache G

[GitHub] eolivelli closed issue #256: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile failed

2017-07-18 Thread git
eolivelli closed issue #256: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile failed URL: https://github.com/apache/bookkeeper/issues/256 This is an automated message from the Apache Git Service. To r

[GitHub] eolivelli commented on issue #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

2017-07-18 Thread git
eolivelli commented on issue #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244#issuecomment-316287454 @sijie @jvrao can someone of you click on "Approve button", the merge script needs at least an "approval" to work, a

Re: BookKeeper website menus not working

2017-07-18 Thread Enrico Olivelli
Thank you Jia Il mer 19 lug 2017, 05:50 Jia Zhai ha scritto: > A jira ticket for this issue: > https://issues.apache.org/jira/browse/BOOKKEEPER-1101 > Now https tabs could work: > https://bookkeeper.apache.org > > On Wed, Jul 19, 2017 at 9:19 AM, Jia Zhai wrote: > > > verified on chrome, safari

Re: BookKeeper website menus not working

2017-07-18 Thread Jia Zhai
A jira ticket for this issue: https://issues.apache.org/jira/browse/BOOKKEEPER-1101 Now https tabs could work: https://bookkeeper.apache.org On Wed, Jul 19, 2017 at 9:19 AM, Jia Zhai wrote: > verified on chrome, safari and firefox, "https" not work, while "http" > works well. > I would like to h

[jira] [Commented] (BOOKKEEPER-1101) BookKeeper website menus not working under https

2017-07-18 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092501#comment-16092501 ] Sijie Guo commented on BOOKKEEPER-1101: --- LGTM +1 > BookKeeper website menus no

[jira] [Updated] (BOOKKEEPER-1101) BookKeeper website menus not working under https

2017-07-18 Thread Jia Zhai (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jia Zhai updated BOOKKEEPER-1101: - Attachment: BOOKKEEPER-1101.patch change http://code.jquery.com/jquery.js";> into > Boo

[jira] [Created] (BOOKKEEPER-1101) BookKeeper website menus not working under https

2017-07-18 Thread Jia Zhai (JIRA)
Jia Zhai created BOOKKEEPER-1101: Summary: BookKeeper website menus not working under https Key: BOOKKEEPER-1101 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1101 Project: Bookkeeper

Re: Bookie Http Endpoint

2017-07-18 Thread Yiming Zang
Hi all, We also have a working implementation in Twitter, we use Http Endpoint mostly for getting quorum loss information, underreplicated ledgers, manage bookie status etc. The HTTP server in Twitter is implemented in such a way that it has a generic skeleton which can easily embed with differen

Re: BookKeeper website menus not working

2017-07-18 Thread Jia Zhai
verified on chrome, safari and firefox, "https" not work, while "http" works well. I would like to have a try on fix this. On Wed, Jul 19, 2017 at 8:55 AM, Sijie Guo wrote: > Yes. We might just change 'http://' to '//', so it will take whatever > protocol you are using to browse the page. It sho

Re: BookKeeper website menus not working

2017-07-18 Thread Sijie Guo
Yes. We might just change 'http://' to '//', so it will take whatever protocol you are using to browse the page. It should be a simple fix. Anyone is interested in a fix? - Sijie On Wed, Jul 19, 2017 at 7:47 AM, Edward Ribeiro wrote: > You right, Sijie. > > Since https://code.jquery.com/jquery.

Re: Question regarding Synchronization in InterleavedLedgerStorage

2017-07-18 Thread Sijie Guo
Charan, Thank you for sharing. I just took a quick glance. I have a few high-level questions: - Can you benchmark this change when you have time? It is interesting to see: (1) current logic vs new logic with 1 slot (2) current logic vs new logic with N slot repeat the above tests for - both int

Re: BookKeeper website menus not working

2017-07-18 Thread Edward Ribeiro
You right, Sijie. Since https://code.jquery.com/jquery.js works so it is a matter of change this reference, right? Eddie On Tue, Jul 18, 2017 at 8:38 PM, Sijie Guo wrote: > I checked Chrome and Safari. > > It seems that Chrome doesn't work and Safari works. > > http://bookkeeper.apache.org wor

Re: BookKeeper website menus not working

2017-07-18 Thread Sijie Guo
I checked Chrome and Safari. It seems that Chrome doesn't work and Safari works. http://bookkeeper.apache.org works but https doesn't work. I think in the latest chrome, it blocks accessing mixed content. The bookkeeper website is using http to access jquery.js. - Sijie On Wed, Jul 19, 2017 at

Re: Question regarding Synchronization in InterleavedLedgerStorage

2017-07-18 Thread Charan Reddy G
*"I am wondering if your multiple-entrylogs approach is making things complicated. I have been thinking there can be a simpler approach achieving the same goal: for example, having a ledger storage comprised of N interleaved/sorted ledger storages, which they share same LedgerCache, but having diff

Re: BookKeeper website menus not working

2017-07-18 Thread Matteo Merli
That's true, though I would swear that it was working just a couple of hours ago. :) -- Matteo Merli On Tue, Jul 18, 2017 at 4:23 PM, Edward Ribeiro wrote: > FYI, the 'Documentation', 'Get Involved' and 'Project Info' drop down menus > on https://bookkeeper.apache.org site are not working. > >

BookKeeper website menus not working

2017-07-18 Thread Edward Ribeiro
FYI, the 'Documentation', 'Get Involved' and 'Project Info' drop down menus on https://bookkeeper.apache.org site are not working. Edward

Build failed in Jenkins: bookkeeper-master #1819

2017-07-18 Thread Apache Jenkins Server
See Changes: [sijie] ISSUE #208: Improve ledger fence logic [sijie] ISSUE #228: BookKeeper Server: Index Page Management Memory Growth [sijie] Add Checkstyle to the build process (Part 1) [sijie] ISSUE #237:

[GitHub] sijie commented on a change in pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth

2017-07-18 Thread git
sijie commented on a change in pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth URL: https://github.com/apache/bookkeeper/pull/229#discussion_r128065772 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexInMemPageMgr.

[GitHub] dlg99 commented on a change in pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth

2017-07-18 Thread git
dlg99 commented on a change in pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth URL: https://github.com/apache/bookkeeper/pull/229#discussion_r128062624 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexInMemPageMgr.

Re: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile testcase broken

2017-07-18 Thread Charan Reddy G
+1 LGTM. THanks, CHaran On Tue, Jul 18, 2017 at 10:43 AM, Sijie Guo wrote: > Charan, > > Here is the pull request to address the problem: https://github.com/ > apache/bookkeeper/pull/257 > > - Sijie > > On Wed, Jul 19, 2017 at 12:49 AM, Sijie Guo wrote: > >> Sure. >> >> I was looking into that

[GitHub] eolivelli commented on issue #248: BOOKKEEPER-1027: Cleanup README

2017-07-18 Thread git
eolivelli commented on issue #248: BOOKKEEPER-1027: Cleanup README URL: https://github.com/apache/bookkeeper/pull/248#issuecomment-316148283 Can you try with a smaller one? This is an automated message from the Apache Git Ser

[GitHub] reddycharan commented on issue #257: Issue 256: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile failed

2017-07-18 Thread git
reddycharan commented on issue #257: Issue 256: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile failed URL: https://github.com/apache/bookkeeper/pull/257#issuecomment-316148039 +1 LGTM This is an auto

[GitHub] sijie commented on issue #248: BOOKKEEPER-1027: Cleanup README

2017-07-18 Thread git
sijie commented on issue #248: BOOKKEEPER-1027: Cleanup README URL: https://github.com/apache/bookkeeper/pull/248#issuecomment-316146288 @eolivelli " the logo is not displaying correctly " => what do you suggest to display? the logo is a square logo. do you want just a smaller square? ---

[GitHub] sijie opened a new pull request #259: Issue 258: BookieInitializationTest.testRegNodeExistsAfterSessionTimeOut failed

2017-07-18 Thread git
sijie opened a new pull request #259: Issue 258: BookieInitializationTest.testRegNodeExistsAfterSessionTimeOut failed URL: https://github.com/apache/bookkeeper/pull/259 Descriptions of the changes in this PR: Construct new zookeeper client to ensure the tests get new zookeeper sessio

[GitHub] sijie opened a new issue #258: BookieInitializationTest.testRegNodeExistsAfterSessionTimeOut failed

2017-07-18 Thread git
sijie opened a new issue #258: BookieInitializationTest.testRegNodeExistsAfterSessionTimeOut failed URL: https://github.com/apache/bookkeeper/issues/258 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? Run BookieInitializationTest - Wh

Re: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile testcase broken

2017-07-18 Thread Sijie Guo
Charan, Here is the pull request to address the problem: https://github.com/apache/bookkeeper/pull/257 - Sijie On Wed, Jul 19, 2017 at 12:49 AM, Sijie Guo wrote: > Sure. > > I was looking into that last night as well. I will work on that. > > - Sijie > > On Tue, Jul 18, 2017 at 4:23 PM, Charan

[GitHub] sijie opened a new pull request #257: Issue 256: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile failed

2017-07-18 Thread git
sijie opened a new pull request #257: Issue 256: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile failed URL: https://github.com/apache/bookkeeper/pull/257 Descriptions of the changes in this PR: in c49621b, we allow creating FileInfo even when disk is full to

[GitHub] sijie commented on issue #256: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile failed

2017-07-18 Thread git
sijie commented on issue #256: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile failed URL: https://github.com/apache/bookkeeper/issues/256#issuecomment-316139644 The problem of this issue: in c49621bacaa960d240afbbee83a9703b4cbc3ec2, we allow creating FileInfo

[GitHub] sijie opened a new issue #256: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile failed

2017-07-18 Thread git
sijie opened a new issue #256: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile failed URL: https://github.com/apache/bookkeeper/issues/256 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? run BookieInitializationTest.t

[GitHub] eolivelli commented on issue #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

2017-07-18 Thread git
eolivelli commented on issue #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244#issuecomment-316130160 @sijie I was writing a test case for negative entry id and I discovered the fact ---

[GitHub] sijie commented on issue #251: Define dependency versions in root pom

2017-07-18 Thread git
sijie commented on issue #251: Define dependency versions in root pom URL: https://github.com/apache/bookkeeper/issues/251#issuecomment-316129826 @eolivelli creating issue doesn't have to wait for a release. you can create an issue and leave it open to any releases. when there are contribut

Re: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile testcase broken

2017-07-18 Thread Sijie Guo
Sure. I was looking into that last night as well. I will work on that. - Sijie On Tue, Jul 18, 2017 at 4:23 PM, Charan Reddy G wrote: > Hey Sijie, > > It looks like one of your commit -https://github.com/ > reddycharan/bookkeeper/commit/c49621bacaa960d240afbbee83a9703b4cbc3ec2 > broke BookieIn

[GitHub] eolivelli closed issue #245: Enable Coverall.io and Covertura on Travis configuration file

2017-07-18 Thread git
eolivelli closed issue #245: Enable Coverall.io and Covertura on Travis configuration file URL: https://github.com/apache/bookkeeper/issues/245 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] eolivelli commented on issue #245: Enable Coverall.io and Covertura on Travis configuration file

2017-07-18 Thread git
eolivelli commented on issue #245: Enable Coverall.io and Covertura on Travis configuration file URL: https://github.com/apache/bookkeeper/issues/245#issuecomment-316100985 see comments in #246 . closing the issue This is an

[GitHub] eolivelli commented on issue #246: Issue 245 Enable Coverall.io and Covertura on Travis configuration file

2017-07-18 Thread git
eolivelli commented on issue #246: Issue 245 Enable Coverall.io and Covertura on Travis configuration file URL: https://github.com/apache/bookkeeper/pull/246#issuecomment-316100782 @sijie in order to see code coverage you have to run tests anyway. I am going to look for a jenkins based

[GitHub] eolivelli closed pull request #246: Issue 245 Enable Coverall.io and Covertura on Travis configuration file

2017-07-18 Thread git
eolivelli closed pull request #246: Issue 245 Enable Coverall.io and Covertura on Travis configuration file URL: https://github.com/apache/bookkeeper/pull/246 This is an automated message from the Apache Git Service. To res

[GitHub] eolivelli commented on issue #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

2017-07-18 Thread git
eolivelli commented on issue #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244#issuecomment-316034704 @sijie I have updated the patch with a check on LedgerHandleAdv in order to prevent the client to use addEntry (and o

[GitHub] jiazhai closed pull request #250: Issue 249: Organize findbugs and checkstyle files in buildtools module

2017-07-18 Thread git
jiazhai closed pull request #250: Issue 249: Organize findbugs and checkstyle files in buildtools module URL: https://github.com/apache/bookkeeper/pull/250 This is an automated message from the Apache Git Service. To respon

[GitHub] jiazhai closed issue #249: Organize findbugs and checkstyle files in buildtools module

2017-07-18 Thread git
jiazhai closed issue #249: Organize findbugs and checkstyle files in buildtools module URL: https://github.com/apache/bookkeeper/issues/249 This is an automated message from the Apache Git Service. To respond to the message

[jira] [Resolved] (BOOKKEEPER-980) BookKeeper Tools doesn't process the argument correctly

2017-07-18 Thread Jia Zhai (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jia Zhai resolved BOOKKEEPER-980. - Resolution: Fixed Issue resolved by merging pull request 255 [https://github.com/a

[GitHub] jiazhai closed pull request #255: BOOKKEEPER-980: BookKeeper Tools doesn't process the argument correctly

2017-07-18 Thread git
jiazhai closed pull request #255: BOOKKEEPER-980: BookKeeper Tools doesn't process the argument correctly URL: https://github.com/apache/bookkeeper/pull/255 This is an automated message from the Apache Git Service. To respo

[GitHub] jiazhai closed pull request #253: Issue 252: Enable four-letter-words zookeeper commands in localbookie

2017-07-18 Thread git
jiazhai closed pull request #253: Issue 252: Enable four-letter-words zookeeper commands in localbookie URL: https://github.com/apache/bookkeeper/pull/253 This is an automated message from the Apache Git Service. To respond

[GitHub] jiazhai closed issue #252: Enable four-letter-words zookeeper commands in localbookie

2017-07-18 Thread git
jiazhai closed issue #252: Enable four-letter-words zookeeper commands in localbookie URL: https://github.com/apache/bookkeeper/issues/252 This is an automated message from the Apache Git Service. To respond to the message,

BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile testcase broken

2017-07-18 Thread Charan Reddy G
Hey Sijie, It looks like one of your commit - https://github.com/reddycharan/bookkeeper/commit/c49621bacaa960d240afbbee83a9703b4cbc3ec2 broke BookieInitializationTest. testWithDiskFullAndAbilityToCreateNewIndexFile testcase. Can you please check that. Thanks, Charan

[GitHub] eolivelli commented on issue #251: Define dependency versions in root pom

2017-07-18 Thread git
eolivelli commented on issue #251: Define dependency versions in root pom URL: https://github.com/apache/bookkeeper/issues/251#issuecomment-315992067 @sijie I was going to create a similar issue. I was waiting for 4.6 This is