sijie commented on issue #256: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile failed URL: https://github.com/apache/bookkeeper/issues/256#issuecomment-316139644 The problem of this issue: in c49621bacaa960d240afbbee83a9703b4cbc3ec2, we allow creating FileInfo even when disk is full to allow fence requests succeed at this case. it is conflicted with Charan's change. Since there is already a setting to configure the min usable size to allow index file creation. if we configure that to be zero, it is same as allowing index file creation even disks are full. so removing the fallback logic introduced in c49621bacaa960d240afbbee83a9703b4cbc3ec2. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
