sijie commented on a change in pull request #229: Issue 228: BookKeeper Server:
Index Page Management Memory Growth
URL: https://github.com/apache/bookkeeper/pull/229#discussion_r128065772
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexInMemPageMgr.java
##########
@@ -51,14 +60,20 @@
private static class InMemPageCollection implements LEPStateChangeCallback
{
- ConcurrentMap<Long, ConcurrentMap<Long,LedgerEntryPage>> pages;
+ final ConcurrentMap<Long, ConcurrentMap<Long,LedgerEntryPage>> pages;
+ final Map<EntryKey, LedgerEntryPage> lruCleanPageMap;
+ final ConcurrentLinkedQueue<LedgerEntryPage> listOfFreePages;
Review comment:
most of the lru logic is already in place. using a list is just a simple and
straightforward step. I am not sure if apache commons pool will buy us more
here (due to my limited knowledges on apache commons pool).
also keep in mind, this is the code from two years ago. I was just porting
from twitter branch. if using apache commons pool can gain more performance,
feel free to improve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
