[GitHub] sijie opened a new pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth

sijie opened a new pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth URL: https://github.com/apache/bookkeeper/pull/229 Descriptions of the changes in this PR: ** Improvements ** - Never delete a LedgerEntryPage that has been allocated. -

[GitHub] sijie opened a new issue #228: BookKeeper Server: Index Page Management Memory Growth

sijie opened a new issue #228: BookKeeper Server: Index Page Management Memory Growth URL: https://github.com/apache/bookkeeper/issues/228 ** Improvements ** - Never delete a LedgerEntryPage that has been allocated. - Track free LedgerEntryPage in a separate list - Use pages fr

[GitHub] sijie commented on issue #227: Add missed tests for SortedLedgerStorage

sijie commented on issue #227: Add missed tests for SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/227#issuecomment-312414736 It is a trivial merge. so no separate issue is created here. This is an automat

[GitHub] sijie opened a new pull request #227: Add missed tests for SortedLedgerStorage

sijie opened a new pull request #227: Add missed tests for SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/227 Added two missed tests for SortedLedgerStorage. It was missed when we (twitter) merged the SortedLedgerStorage back. --

[GitHub] sijie opened a new pull request #226: Issue 225: Remove Parameterized from CompactionTest

sijie opened a new pull request #226: Issue 225: Remove Parameterized from CompactionTest URL: https://github.com/apache/bookkeeper/pull/226 Descriptions of the changes in this PR: - Split the CompactionTest into two, one is by bytes, while the other one is by entries. --

[GitHub] sijie opened a new issue #225: Remove Parameterized from CompactionTest

sijie opened a new issue #225: Remove Parameterized from CompactionTest URL: https://github.com/apache/bookkeeper/issues/225 **FEATURE REQUEST** 1. Please describe the feature you are requesting. CompactionTest is a parameterized test. It is a bit inconvenient to run individua

[GitHub] sijie opened a new pull request #224: BOOKKEEPER-772: Reorder Read Sequence

sijie opened a new pull request #224: BOOKKEEPER-772: Reorder Read Sequence URL: https://github.com/apache/bookkeeper/pull/224 Descriptions of the changes in this PR: - for rackware placement policy, the bookie in the same rack will be preferred. - for region-aware placeme

Re: Too many emails on the mailing list?

It seems that we still have two emails per comment at Git. Asked INFRA to take a look into it. - Sijie On Fri, Jun 30, 2017 at 9:49 AM, Sijie Guo wrote: > https://issues.apache.org/jira/browse/INFRA-14473 > > Per Daniel's comment in INFRA-14473, the notifications should be reduced > to one per

Re: Flaky tests due to jenkins slaves

Il ven 30 giu 2017, 18:53 Sijie Guo ha scritto: > A quick solution is to set diskWarnThreshold and diskThreshold to a very > large value for example 0.99, 0.. so the tests will be less impact It makes sense to me Enrico > > On Fri, Jun 30, 2017 at 1:17 AM, Enrico Olivelli > wrote: > > > H

[GitHub] eolivelli commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation

eolivelli commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation URL: https://github.com/apache/bookkeeper/pull/80#issuecomment-312327982 Thank you very much This is an automated message f

Re: Flaky tests due to jenkins slaves

A quick solution is to set diskWarnThreshold and diskThreshold to a very large value for example 0.99, 0.. so the tests will be less impacted. On Fri, Jun 30, 2017 at 1:17 AM, Enrico Olivelli wrote: > Hi, > Sometimes tests fail due to this kind of errors: > > org.apache.bookkeeper.bookie.Led

[GitHub] sijie commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation

sijie commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation URL: https://github.com/apache/bookkeeper/pull/80#issuecomment-312318237 @eolivelli I will get to this soon when I am back on porting changes related to server side improvements.

Re: Too many emails on the mailing list?

https://issues.apache.org/jira/browse/INFRA-14473 Per Daniel's comment in INFRA-14473, the notifications should be reduced to one per comment/action. I am not sure. If dev@ is getting overwhelmed because of the increasing traffic at Github, there can be two options here: - everyone can setup its

[GitHub] sijie commented on issue #217: Issue 223: Code cleanups

sijie commented on issue #217: Issue 223: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312316480 @sigee do you mind creating an issue for the checkstyle changes and move the discussion there? I will the checkstyle change can be done in smaller batches, for

Re: Starting release process for 4.5.0

Il ven 30 giu 2017, 18:04 Sijie Guo ha scritto: > On Jun 30, 2017 5:45 AM, "Enrico Olivelli" wrote: > > Yesterday at the Community Meeting we discussed about when and how > starting the release process for 4.5.0. > > First step is to choose a Release Manager. > I volunteer doing it. > Anyone els

[GitHub] eolivelli commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation

eolivelli commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation URL: https://github.com/apache/bookkeeper/pull/80#issuecomment-312307722 I would prefer to submit the patch against the master. Actually I did not start to work on a real patch, I have ju

Re: Starting release process for 4.5.0

On Jun 30, 2017 5:45 AM, "Enrico Olivelli" wrote: Yesterday at the Community Meeting we discussed about when and how starting the release process for 4.5.0. First step is to choose a Release Manager. I volunteer doing it. Anyone else would like to manage the release ? Sorry about missing the m

[GitHub] sijie commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation

sijie commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation URL: https://github.com/apache/bookkeeper/pull/80#issuecomment-312302813 Are you blocking by me? If so, I can rebase this. I wasn't trying to rebase this because currently I am focusing

[GitHub] sijie commented on issue #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

sijie commented on issue #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#issuecomment-312302182 There isn't a new middleware if you want to try the distributed log library. It is an extension to bookkeeper client to provi

[GitHub] eolivelli commented on issue #222: Issue 221: Make netty server shutdown idempotent

eolivelli commented on issue #222: Issue 221: Make netty server shutdown idempotent URL: https://github.com/apache/bookkeeper/pull/222#issuecomment-312301512 Ok for me This is an automated message from the Apache Git Service

[GitHub] sijie commented on a change in pull request #222: Issue 221: Make netty server shutdown idempotent

sijie commented on a change in pull request #222: Issue 221: Make netty server shutdown idempotent URL: https://github.com/apache/bookkeeper/pull/222#discussion_r125068900 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java ##

[GitHub] sijie commented on a change in pull request #222: Issue 221: Make netty server shutdown idempotent

sijie commented on a change in pull request #222: Issue 221: Make netty server shutdown idempotent URL: https://github.com/apache/bookkeeper/pull/222#discussion_r125068441 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java ##

[GitHub] sigee commented on issue #217: Issue 223: Code cleanups

sigee commented on issue #217: Issue 223: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312293909 @jiazhai, Opened an issue here: #223 @sijie, There was a conflict, I resolved, so at the moment this PR is mergeable if you think it is fine. I s

[GitHub] sigee opened a new issue #223: Clean up code rots

sigee opened a new issue #223: Clean up code rots URL: https://github.com/apache/bookkeeper/issues/223 **IMPROVEMENTS** The code is getting be rotten. It should be cleaned up. Eg.: - Remove unused imports - Symplify if statements - etc.

[jira] [Commented] (BOOKKEEPER-759) bookkeeper: delay ensemble change if it doesn't break ack quorum requirement

[ https://issues.apache.org/jira/browse/BOOKKEEPER-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070148#comment-16070148 ] Hudson commented on BOOKKEEPER-759: --- FAILURE: Integrated in Jenkins build bookkeeper

Build failed in Jenkins: bookkeeper-master #1801

See Changes: [sijie] ISSUE #207: change the HashSet to BitSet to handle duplicated bookies on [sijie] ISSUE #209: Introduce Speculative Read/Read LAC policy [sijie] BOOKKEEPER-759: Delay Ensemble Change & Disa

Starting release process for 4.5.0

Yesterday at the Community Meeting we discussed about when and how starting the release process for 4.5.0. First step is to choose a Release Manager. I volunteer doing it. Anyone else would like to manage the release ? The second step (in charge to the release manager) will be to choose final iss

[GitHub] eolivelli commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing

eolivelli commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing URL: https://github.com/apache/bookkeeper/issues/221#issuecomment-312219589 @reddycharan @sijie the close method of the factory is expected to be called once. I am OK with the fact that close met

[GitHub] bookkeeper issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is faili...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/issues/221 @reddycharan @sijie the close method of the factory is expected to be called once. I am OK with the fact that close methods should be idempotent too but if it is possible it is better to

[GitHub] jiazhai commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

jiazhai commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r124994267 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-al

[GitHub] bookkeeper issue #217: Code cleanups

Github user jiazhai commented on the issue: https://github.com/apache/bookkeeper/pull/217 The change looks good, Please open an issue or a Jira ticket for this PR, and at the end of this PR description, For the checks that you have done, please place "x" in the "[ ]". --- If your p

[GitHub] jiazhai commented on issue #217: Code cleanups

jiazhai commented on issue #217: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312214116 The change looks good, Please open an issue or a Jira ticket for this PR, and at the end of this PR description, For the checks that you have done, please place "x" in

[GitHub] eolivelli commented on issue #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

eolivelli commented on issue #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#issuecomment-312207462 @sijie awesome I hope that "simple clients" in the future will be able to leverage such powerful feature without havin

[jira] [Commented] (BOOKKEEPER-1095) Long Poll - Client side changes

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069689#comment-16069689 ] ASF GitHub Bot commented on BOOKKEEPER-1095: Github user eolivelli commen

[GitHub] bookkeeper issue #220: BOOKKEEPER-1095: Long Poll - Server and Client Side C...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/220 @sijie awesome I hope that "simple clients" in the future will be able to leverage such powerful feature without having to add new "coordination services middlewares". Let's discuss this in

Flaky tests due to jenkins slaves

Hi, Sometimes tests fail due to this kind of errors: org.apache.bookkeeper.bookie.LedgerDirsManager$NoWritableLedgerDirException: All ledger directories are non writable do you think that it is due to "small disks" on Jenkins slaves ? is there any way to address this problem ? -- Enrico

[GitHub] reddycharan commented on a change in pull request #222: Issue 221: Make netty server shutdown idempotent

reddycharan commented on a change in pull request #222: Issue 221: Make netty server shutdown idempotent URL: https://github.com/apache/bookkeeper/pull/222#discussion_r124985739 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java ##

Re: Too many emails on the mailing list?

2017-06-30 0:25 GMT+02:00 Sijie Guo : > Filed an INFRA ticket: https://issues.apache.org/jira/browse/INFRA-14473 Thank you Sijie I was "watching" github repo and stopped watiching it but the volume of emails is impressive -- Enrico > > On Thu, Jun 29, 2017 at 3:15 PM, Sijie Guo wrote: > >> I ha

[jira] [Commented] (BOOKKEEPER-816) use native fallocate & sync_file_range to improve journal allocation

[ https://issues.apache.org/jira/browse/BOOKKEEPER-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069670#comment-16069670 ] ASF GitHub Bot commented on BOOKKEEPER-816: --- Github user eolivelli commented

[GitHub] eolivelli commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation

eolivelli commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation URL: https://github.com/apache/bookkeeper/pull/80#issuecomment-312203976 @sijie do you have some cycle to go on with this issue ? I apologize for being "annoying" on this topic

[GitHub] bookkeeper issue #80: BOOKKEEPER-816: use native fallocate to improve journa...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/80 @sijie do you have some cycle to go on with this issue ? I apologize for being "annoying" on this topic --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] eolivelli commented on a change in pull request #222: Issue 221: Make netty server shutdown idempotent

eolivelli commented on a change in pull request #222: Issue 221: Make netty server shutdown idempotent URL: https://github.com/apache/bookkeeper/pull/222#discussion_r124984858 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java

[jira] [Commented] (BOOKKEEPER-1095) Long Poll - Client side changes

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069659#comment-16069659 ] ASF GitHub Bot commented on BOOKKEEPER-1095: Github user sijie commented

[GitHub] bookkeeper issue #220: BOOKKEEPER-1095: Long Poll - Server and Client Side C...

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/220 @eolivelli I think the best way to do 'tailing' is to using the distributedlog library. it handles fetch and deals with the switch between normal reads and long poll reads when detecting lac is adv

[GitHub] sijie commented on issue #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

sijie commented on issue #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#issuecomment-312201480 @eolivelli I think the best way to do 'tailing' is to using the distributedlog library. it handles fetch and deals with the s

[GitHub] sijie commented on issue #222: Issue 221: Make netty server shutdown idempotent

sijie commented on issue #222: Issue 221: Make netty server shutdown idempotent URL: https://github.com/apache/bookkeeper/pull/222#issuecomment-312200766 /cc @reddycharan This is an automated message from the Apache Git Serv

[GitHub] bookkeeper issue #222: Issue 221: Make netty server shutdown idempotent

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/222 /cc @reddycharan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] bookkeeper pull request #222: Issue 221: Make netty server shutdown idempote...

GitHub user sijie opened a pull request: https://github.com/apache/bookkeeper/pull/222 Issue 221: Make netty server shutdown idempotent Descriptions of the changes in this PR: (see the detailed discussion in #221 ) You can merge this pull request into a Git repository by ru

[GitHub] sijie opened a new pull request #222: Issue 221: Make netty server shutdown idempotent

sijie opened a new pull request #222: Issue 221: Make netty server shutdown idempotent URL: https://github.com/apache/bookkeeper/pull/222 Descriptions of the changes in this PR: (see the detailed discussion in #221 )

[GitHub] bookkeeper pull request #214: Fix ByteBuf refcount release

Github user eolivelli closed the pull request at: https://github.com/apache/bookkeeper/pull/214 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] eolivelli closed pull request #214: Fix ByteBuf refcount release

eolivelli closed pull request #214: Fix ByteBuf refcount release URL: https://github.com/apache/bookkeeper/pull/214 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[GitHub] bookkeeper issue #214: Fix ByteBuf refcount release

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/214 @kishorekasi I am closing this PR as the fix as been committed by @sijie Thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] eolivelli commented on issue #214: Fix ByteBuf refcount release

eolivelli commented on issue #214: Fix ByteBuf refcount release URL: https://github.com/apache/bookkeeper/pull/214#issuecomment-312199973 @kishorekasi I am closing this PR as the fix as been committed by @sijie Thank you

[GitHub] eolivelli commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

eolivelli commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#discussion_r124979057 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ###

[GitHub] eolivelli commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

eolivelli commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#discussion_r124979546 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.jav

[GitHub] sijie commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing

sijie commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing URL: https://github.com/apache/bookkeeper/issues/221#issuecomment-312199555 @reddycharan I don't think the right approach is to change to the tests. we should just make the shutdown call idempotent. -

[GitHub] bookkeeper issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is faili...

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/issues/221 @reddycharan I don't think the right approach is to change to the tests. we should just make the shutdown call idempotent. --- If your project is set up for it, you can reply to this email and h

[GitHub] reddycharan commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing

reddycharan commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing URL: https://github.com/apache/bookkeeper/issues/221#issuecomment-312199104 yes, with this change org.apache.bookkeeper.auth.TestAuth$LogCloseCallsBookieAuthProviderFactory.close is called twice.

[GitHub] reddycharan commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing

reddycharan commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing URL: https://github.com/apache/bookkeeper/issues/221#issuecomment-312199104 yes, with this change org.apache.bookkeeper.auth.TestAuth$LogCloseCallsBookieAuthProviderFactory.close is called twice.

[GitHub] bookkeeper issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is faili...

Github user reddycharan commented on the issue: https://github.com/apache/bookkeeper/issues/221 yes, with this change org.apache.bookkeeper.auth.TestAuth$LogCloseCallsBookieAuthProviderFactory.close is called twice. With or without this change BookieServer.shutdown will be ca