[jira] [Resolved] (BOOKKEEPER-1065) OrderedSafeExecutor should only have 1 thread per bucket

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Merli resolved BOOKKEEPER-1065. -- Resolution: Invalid As commented on the github PR, the current behavior is correct.

[jira] [Commented] (BOOKKEEPER-1065) OrderedSafeExecutor should only have 1 thread per bucket

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007126#comment-16007126 ] ASF GitHub Bot commented on BOOKKEEPER-1065: Github user merlimat comment

[jira] [Commented] (BOOKKEEPER-1065) OrderedSafeExecutor should only have 1 thread per bucket

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007127#comment-16007127 ] ASF GitHub Bot commented on BOOKKEEPER-1065: Github user merlimat closed

[GitHub] bookkeeper issue #152: BOOKKEEPER-1065: OrderedSafeExecutor should only have...

Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/152 I got a bit scared when I saw `ScheduledThreadPoolExecutor` is pass `MAX_INT` as the max thread pool size.. but I think the current code is correct. I just did a quick verification and

[GitHub] bookkeeper pull request #152: BOOKKEEPER-1065: OrderedSafeExecutor should on...

Github user merlimat closed the pull request at: https://github.com/apache/bookkeeper/pull/152 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (BOOKKEEPER-1065) OrderedSafeExecutor should only have 1 thread per bucket

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007109#comment-16007109 ] ASF GitHub Bot commented on BOOKKEEPER-1065: Github user eolivelli commen

[GitHub] bookkeeper issue #152: BOOKKEEPER-1065: OrderedSafeExecutor should only have...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/152 Yes recently we removed a similar line due to findbugs warning --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] bookkeeper issue #152: BOOKKEEPER-1065: OrderedSafeExecutor should only have...

Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/152 Ok, this is the error that findbugs gives: ``` [INFO] --- findbugs-maven-plugin:3.0.4:check (default-cli) @ bookkeeper-server --- [INFO] BugInstance size is 1 [INFO] Error s

[jira] [Commented] (BOOKKEEPER-1065) OrderedSafeExecutor should only have 1 thread per bucket

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007087#comment-16007087 ] ASF GitHub Bot commented on BOOKKEEPER-1065: Github user merlimat comment

Jenkins build is back to normal : bookkeeper-master-git-pullrequest #375

See

[jira] [Commented] (BOOKKEEPER-1066) Introduce GrowableArrayBlockingQueue

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006968#comment-16006968 ] ASF GitHub Bot commented on BOOKKEEPER-1066: GitHub user merlimat opened

[GitHub] bookkeeper pull request #153: BOOKKEEPER-1066: Introduce GrowableArrayBlocki...

GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/153 BOOKKEEPER-1066: Introduce GrowableArrayBlockingQueue In multiple places, (eg: journal, ordered executor, etc..), we are using `LinkedBlockingQueue` instances to pass objects between threads.

[jira] [Created] (BOOKKEEPER-1066) Introduce GrowableArrayBlockingQueue

Matteo Merli created BOOKKEEPER-1066: Summary: Introduce GrowableArrayBlockingQueue Key: BOOKKEEPER-1066 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1066 Project: Bookkeeper Iss

Build failed in Jenkins: bookkeeper-master-git-pullrequest #374

See Changes: [mmerli] BOOKKEEPER-1065: OrderedSafeExecutor should only have 1 thread per -- [...truncated 36.16 KB...] Running org.apache.bookkeeper.bookie

New project: Pravega

Hi there, I wanted to share with both communities the news that we have open-source a project that I have been working on for the past few months: Pravega. Pravega is storage for streams and we have decided to make it publicly available at an earlier stage to build a community that will help us dr

[jira] [Commented] (BOOKKEEPER-753) Bookie should run garbage collection before startup when all directories became full

[ https://issues.apache.org/jira/browse/BOOKKEEPER-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006829#comment-16006829 ] ASF GitHub Bot commented on BOOKKEEPER-753: --- Github user reddycharan comment

[GitHub] bookkeeper issue #81: BOOKKEEPER-753: Bookie should run garbage collection b...

Github user reddycharan commented on the issue: https://github.com/apache/bookkeeper/pull/81 @jvrao I haven't sent most of recent commits to community yet. one way or the other they are dependent on https://github.com/apache/bookkeeper/pull/108. I'm waiting for this commit to get merg

[jira] [Commented] (BOOKKEEPER-1065) OrderedSafeExecutor should only have 1 thread per bucket

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006820#comment-16006820 ] ASF GitHub Bot commented on BOOKKEEPER-1065: GitHub user merlimat opened

[GitHub] bookkeeper pull request #152: BOOKKEEPER-1065: OrderedSafeExecutor should on...

GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/152 BOOKKEEPER-1065: OrderedSafeExecutor should only have 1 thread per bucket You can merge this pull request into a Git repository by running: $ git pull https://github.com/merlimat/bookkeep

[jira] [Created] (BOOKKEEPER-1065) OrderedSafeExecutor should only have 1 thread per bucket

Matteo Merli created BOOKKEEPER-1065: Summary: OrderedSafeExecutor should only have 1 thread per bucket Key: BOOKKEEPER-1065 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1065 Project: Book

[jira] [Commented] (BOOKKEEPER-1064) ConcurrentModificationException in AuditorLedgerCheckerTest

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006747#comment-16006747 ] ASF GitHub Bot commented on BOOKKEEPER-1064: GitHub user merlimat opened

[GitHub] bookkeeper pull request #151: BOOKKEEPER-1064: ConcurrentModificationExcepti...

GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/151 BOOKKEEPER-1064: ConcurrentModificationException in AuditorLedgerCheckerTest As seen in: https://builds.apache.org/job/bookkeeper-master-git-pullrequest/371/ The test is iterating o

[jira] [Created] (BOOKKEEPER-1064) ConcurrentModificationException in AuditorLedgerCheckerTest

Matteo Merli created BOOKKEEPER-1064: Summary: ConcurrentModificationException in AuditorLedgerCheckerTest Key: BOOKKEEPER-1064 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1064 Project:

[jira] [Commented] (BOOKKEEPER-1057) Do not log error message after read failure in PendingReadOp

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006730#comment-16006730 ] ASF GitHub Bot commented on BOOKKEEPER-1057: Github user merlimat comment

[GitHub] bookkeeper issue #145: BOOKKEEPER-1057: Do not log error message after read ...

Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/145 > That's exactly my point. Can we use this opportunity to do the right fix instead of masking real errorcases? I was agreeing with you :) Let me think a bit how to differenti

[jira] [Commented] (BOOKKEEPER-1057) Do not log error message after read failure in PendingReadOp

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006717#comment-16006717 ] ASF GitHub Bot commented on BOOKKEEPER-1057: Github user jvrao commented

[GitHub] bookkeeper issue #145: BOOKKEEPER-1057: Do not log error message after read ...

Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/145 On Thu, May 11, 2017 at 8:09 AM Matteo Merli wrote: > @jvrao I agree with the point of separating > the recovery vs non-recovery. > > At yahoo we

[jira] [Commented] (BOOKKEEPER-1051) Fast shutdown for GarbageCollectorThread

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006619#comment-16006619 ] ASF GitHub Bot commented on BOOKKEEPER-1051: Github user merlimat comment

[GitHub] bookkeeper issue #141: BOOKKEEPER-1051: Fast shutdown for GarbageCollectorTh...

Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/141 @jvrao sorry for merging this quickly, should have waited for more feedback. The change here is to interrupt the Bookie GC thread immediately when shutting down. The interruption only

[jira] [Commented] (BOOKKEEPER-1051) Fast shutdown for GarbageCollectorThread

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006610#comment-16006610 ] ASF GitHub Bot commented on BOOKKEEPER-1051: Github user eolivelli commen

[GitHub] bookkeeper issue #141: BOOKKEEPER-1051: Fast shutdown for GarbageCollectorTh...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/141 @jvrao we can add a configuration property for "fast shutdown". IMHO I don't think that this change really impact bookies even in case of graceful shutdown. The prev version alrea

[jira] [Commented] (BOOKKEEPER-1057) Do not log error message after read failure in PendingReadOp

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006608#comment-16006608 ] ASF GitHub Bot commented on BOOKKEEPER-1057: Github user merlimat comment

[GitHub] bookkeeper issue #145: BOOKKEEPER-1057: Do not log error message after read ...

Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/145 @jvrao I agree with the point of separating the recovery vs non-recovery. At yahoo we were using log sniffer to get alerts from all error messages. If an error message is not symptom of

[jira] [Commented] (BOOKKEEPER-1057) Do not log error message after read failure in PendingReadOp

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006602#comment-16006602 ] ASF GitHub Bot commented on BOOKKEEPER-1057: Github user eolivelli commen

[GitHub] bookkeeper issue #145: BOOKKEEPER-1057: Do not log error message after read ...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/145 @jvrao I see your point. In order to achieve this goal in my company we use error collectors which gather error streams from the various machines (using Kafka/ElasticSearch and so on). Bu

[jira] [Commented] (BOOKKEEPER-1057) Do not log error message after read failure in PendingReadOp

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006571#comment-16006571 ] ASF GitHub Bot commented on BOOKKEEPER-1057: Github user jvrao commented

[GitHub] bookkeeper issue #145: BOOKKEEPER-1057: Do not log error message after read ...

Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/145 We (plan to) use error messages to do a lot of post processing. We would like to see all errors logged as it has much more information than pure log message. On Wed, May 10, 2017 at

[jira] [Commented] (BOOKKEEPER-1051) Fast shutdown for GarbageCollectorThread

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006567#comment-16006567 ] ASF GitHub Bot commented on BOOKKEEPER-1051: Github user jvrao commented

[GitHub] bookkeeper issue #141: BOOKKEEPER-1051: Fast shutdown for GarbageCollectorTh...

Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/141 Ok so you are talking about your own production issue. But I don't believe it is right thing to change production code to speed up testing. I believe we need more elaborate fix to take care of juni

Re: Next community meeting and notes

Ops I think I missed the meeting I did not find any report here https://cwiki.apache.org/confluence/display/BOOKKEEPER/Community+Meetings Can someone write some brief report of the meeting ? So let's meet on 18/5/2017 ? OK ? Sorry for the confusion -- Enrico 2017-05-11 15:56 GMT+02:00 Matteo M

Re: Next community meeting and notes

I think there has been some confusion. Some of us "met" last Thursday, since it was 2 weeks from the previous call. On Thu, May 11, 2017 at 3:46 AM Enrico Olivelli wrote: > I have just created the wiki page for next meeting > > > https://cwiki.apache.org/confluence/display/BOOKKEEPER/2017-5-11+Me

[jira] [Commented] (BOOKKEEPER-1059) Upgrade to SLF4J-1.7.25

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006396#comment-16006396 ] Hudson commented on BOOKKEEPER-1059: SUCCESS: Integrated in Jenkins build bookkee

[jira] [Commented] (BOOKKEEPER-1054) Add gitignore file

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006398#comment-16006398 ] Hudson commented on BOOKKEEPER-1054: SUCCESS: Integrated in Jenkins build bookkee

[jira] [Commented] (BOOKKEEPER-1060) Add utility to use SafeRunnable from Java8 Lambda

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006395#comment-16006395 ] Hudson commented on BOOKKEEPER-1060: SUCCESS: Integrated in Jenkins build bookkee

Re: Next community meeting and notes

I have just created the wiki page for next meeting https://cwiki.apache.org/confluence/display/BOOKKEEPER/2017-5-11+Meeting+notes I have drafted an agenda with the current pending issues to discuss from my point of view, please everyone add your issues I'm sorry I am not sure I will be able to a

[jira] [Commented] (BOOKKEEPER-1008) Move to netty4

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006129#comment-16006129 ] ASF GitHub Bot commented on BOOKKEEPER-1008: Github user jiazhai commente

[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1

Github user jiazhai commented on the issue: https://github.com/apache/bookkeeper/pull/138 Passed all the test on my Mac in 17 min. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Jenkins build is back to normal : bookkeeper-master-git-pullrequest #372

See

Build failed in Jenkins: bookkeeper-master-git-pullrequest #371

See Changes: [mmerli] BOOKKEEPER-1008 Move to Netty4.1 [mmerli] Addressing review comments - Use Netty 4.1.9 - Do not include classifier [mmerli] Addressing ref count issues in LedgerHandleAdv

[jira] [Commented] (BOOKKEEPER-1008) Move to netty4

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006047#comment-16006047 ] ASF GitHub Bot commented on BOOKKEEPER-1008: Github user eolivelli commen

[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/138 @merlimat After checking out the latest commit I am able to run the full test suite in 23min without errors findbugs and rat are OK ! --- If your project is set up for it, you can reply t

[jira] [Commented] (BOOKKEEPER-1008) Move to netty4

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006021#comment-16006021 ] ASF GitHub Bot commented on BOOKKEEPER-1008: Github user merlimat comment

[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1

Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/138 @eolivelli Thanks, it should fix the error you were seing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (BOOKKEEPER-1008) Move to netty4

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006017#comment-16006017 ] ASF GitHub Bot commented on BOOKKEEPER-1008: Github user eolivelli commen

[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/138 Sorry @merlimat I will checkout your latest changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[jira] [Commented] (BOOKKEEPER-1008) Move to netty4

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006006#comment-16006006 ] ASF GitHub Bot commented on BOOKKEEPER-1008: Github user eolivelli commen

[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/138 I am seeing this errors {code} Tests run: 120, Failures: 0, Errors: 44, Skipped: 0, Time elapsed: 64.802 sec <<< FAILURE! - in org.apache.bookkeeper.client.BookieRecoveryTest ensure