[
https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006610#comment-16006610
]
ASF GitHub Bot commented on BOOKKEEPER-1051:
--------------------------------------------
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/141
@jvrao we can add a configuration property for "fast shutdown".
IMHO I don't think that this change really impact bookies even in case of
graceful shutdown.
The prev version already called shutdownNow after a timeout.
With this change a InterruptedException will be more likely to happen, but
code should already handle this case, so it won't be an issue.
If we find cases of buggy handling of InterruptedException then we should
fix them as the InterruptedException can be thrown even without this change.
I have just commented about this new behavior just for completeness and
because I worried about this case, but from my point of view this is a safe
change
> Fast shutdown for GarbageCollectorThread
> ----------------------------------------
>
> Key: BOOKKEEPER-1051
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1051
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Matteo Merli
> Assignee: Matteo Merli
> Priority: Minor
> Fix For: 4.5.0
>
>
> Several unit tests are taking very long time to complete (eg:
> {{BookieLedgerIndexTest}} taking ~10 minutes).
> The reason is that these tests are playing with the ZK quorum shutting it
> down and after the test succeeds, the shutdown phase is taking long time,
> since we try to do graceful shutdown with 1min wait time.
> I think is better to interrupt immediately the garbage collector thread when
> shutting down the bookie.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
