[
https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006619#comment-16006619
]
ASF GitHub Bot commented on BOOKKEEPER-1051:
--------------------------------------------
Github user merlimat commented on the issue:
https://github.com/apache/bookkeeper/pull/141
@jvrao sorry for merging this quickly, should have waited for more
feedback.
The change here is to interrupt the Bookie GC thread immediately when
shutting down. The interruption only happens if that thread is waiting on
_something_. For the GC thread that means waiting on ZK reads.
I don't see any problem in shutting down that thread quickly, because the
GC anyway picks it up again after restart.
The other part is waiting until the thread is done doing its work. That we
are not doing even today, given that bookie GC can take minutes or hours.
> Fast shutdown for GarbageCollectorThread
> ----------------------------------------
>
> Key: BOOKKEEPER-1051
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1051
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Matteo Merli
> Assignee: Matteo Merli
> Priority: Minor
> Fix For: 4.5.0
>
>
> Several unit tests are taking very long time to complete (eg:
> {{BookieLedgerIndexTest}} taking ~10 minutes).
> The reason is that these tests are playing with the ZK quorum shutting it
> down and after the test succeeds, the shutdown phase is taking long time,
> since we try to do graceful shutdown with 1min wait time.
> I think is better to interrupt immediately the garbage collector thread when
> shutting down the bookie.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
