Re: [Proposal] Path to Re-enabling Build Comment Triggers

2022-07-01 Thread Danny McCormick via dev
Given the early consensus here, I tried disabling the "Can one of the admins verify this patch?" messages, and verified that it worked. If you disagree with that decision, please let me know - I expect that is the most popular part of this proposal though :) The remaining questions are: 1) Are we

Re: [Proposal] Path to Re-enabling Build Comment Triggers

2022-07-01 Thread Danny McCormick via dev
> ghprb (like blacklist)? Besides asf-ci there are also comments > from github-actions (e.g. assign reviewer or "stopping review > notifications"). In the future if we enable more github action items there > might be more bot pr comments. > > Best, > Yi > &g

Re: [Proposal] Path to Re-enabling Build Comment Triggers

2022-07-07 Thread Danny McCormick via dev
topping review >> notifications"). In the future if we enable more github action items there >> might be more bot pr comments. >> >> Best, >> Yi >> >> On Fri, Jul 1, 2022 at 8:33 AM Danny McCormick via dev < >> dev@beam.apache.org> wrote: >

Re: Update PR description template

2022-07-07 Thread Danny McCormick via dev
Hey Yi, Thanks for pushing this forward! I'm +1 on doing all 3 action items, along with making the github action a required check once auto-merge is implemented. Thanks, Danny On Thu, Jul 7, 2022 at 12:08 PM Yi Hu via dev wrote: > Hi all, > > I have drafted a document summarizing the ideas sug

Re: Trigger phrases in Github Actions

2022-07-14 Thread Danny McCormick via dev
Hey Fer, I'm not 100% sure I follow what you're trying to do, but one approach you could take is to gate everything off of an if like: ` if {{ (github.event.issue.pull_request && github.event.comment && contains(github.event.comment.body, "PHRASE")) || !github.event.comment }} Basically, that's

Re: Trigger phrases in Github Actions

2022-07-14 Thread Danny McCormick via dev
ed on a yearly basis. It also puts all the issue triggering logic in a single place which is nice. On Thu, Jul 14, 2022 at 5:07 PM Kenneth Knowles wrote: > Is this an idiomatic way to trigger GHA? > > On Thu, Jul 14, 2022 at 1:36 PM Danny McCormick via dev < > dev@beam.apache.org&

Re: Trigger phrases in Github Actions

2022-07-15 Thread Danny McCormick via dev
but when Github Actions were > added - the main reason is that you had to develop it outside your > repo, where GitHub Actions are mostly "in-repo" and you can "easily" > make a change in a PR, but this is deceptive a bit. The "simple" PR > workflows are fi

Re: Extending 2.41.0 Java snapshot TTL

2022-07-22 Thread Danny McCormick via dev
> I think you could change the TTL on the Jenkins side (That sound right to you Danny?) but I'm not sure we could preserve a specific snapshot without keeping all of them... I'm admittedly not particularly well versed in this area of our infra, but after some digging I don't see a way to do this.

Re: Extending 2.41.0 Java snapshot TTL

2022-07-22 Thread Danny McCormick via dev
I reached out to the Apache Infra team in their slack channel and have yet to hear back. Given that it's getting pretty late on a Friday here (I'm located in East US), it is unlikely that I will have a workaround by the time the snapshot is removed by the retention policy; to ensure continued funct

Re: [ANNOUNCE] New committer: John Casey

2022-07-29 Thread Danny McCormick via dev
Congrats John and welcome! This is well deserved! On Fri, Jul 29, 2022 at 4:07 PM Kenneth Knowles wrote: > Hi all, > > Please join me and the rest of the Beam PMC in welcoming a new committer: > John Casey (johnca...@apache.org) > > John started contributing to Beam in late 2021. John has quickl

Re: contributor permission for Beam Jira tickets

2022-08-15 Thread Danny McCormick via dev
Thanks for calling that out! I added a note that we're not using Jira anymore to that page and removed some outdated information (including the instructions to email the dev list). I kept the page around in case people find it useful for interacting with resolved (non-migrated) issues or for intera

Re: Benchmark tests for the Beam RunInference API

2022-08-18 Thread Danny McCormick via dev
I left a few comments, but overall this sounds like a good plan to me - thanks for the writeup! On Tue, Aug 16, 2022 at 9:36 AM Anand Inguva via dev wrote: > Hi, > > I created a doc > [1] > which outlines the

Re: [Question] Progress on BEAM-9923 and how can I help?

2022-08-29 Thread Danny McCormick via dev
Hey Ronoaldo, I believe some investigation has been done on adding a Go expansion service (written up here ), but no concrete work has been done yet. I don't know of any general guidelines

Re: Pass Custom namespaces to RunInference metrics

2022-09-12 Thread Danny McCormick via dev
Thanks for writing this up Anand! I agree with you (and Andy) that solution 1 is the best path forward. Thanks, Danny On Mon, Sep 12, 2022 at 2:11 PM Andy Ye via dev wrote: > Thanks Anand for the great summary! > > I'm leaning towards (solution 1) to allow users to pass in a custom > namespace

Re: Beam Dependency Check Report (2022-09-15)

2022-09-16 Thread Danny McCormick via dev
> I'm guessing https://github.com/apache/beam/pull/23229 I don't think so - this dependency report comes from jenkins, that only affected things running from GitHub Actions. That change is for the high priority issues report, this is supposed to be the dependency report (which doesn't seem like it

Re: PeriodImpulse not updating watermark

2022-09-20 Thread Danny McCormick via dev
Coincidentally, I was looking at the same issue in Python yesterday which also doesn't use a watermark estimator. For Python at least, the same problem exists on Dataflow. I agree that we should be providing a watermark estimate as part of periodic sequences for both Java and Python. I was plannin

Re: Avoid breaking change when adding an additional parameter to the RunInference PTransform

2022-09-29 Thread Danny McCormick via dev
Thanks for the writeup Anand, I'm +1 on your recommendation in the doc: when we want to make parameterized changes that will propagate to the ModelHandler, I think we should modify the ModelHandler constructor rather than trying to propagate extra arguments through the run_inference function. Than

Re: Inclusive terminology: "Sickbay" ==> "Disabled test"

2022-10-17 Thread Danny McCormick via dev
I'm +1 on this, sickbay was a new term for me when I joined the project. One thing I will note: we still have plenty of sickbay references in our code itself - https://github.com/apache/beam/search?p=1&q=sickbay - if we decide to take this forward we should create an issue to remove those (with the

Re: [DISCUSS] Jenkins -> GitHub Actions ?

2022-10-19 Thread Danny McCormick via dev
Thanks for kicking this conversation off. I'm +1 on migrating, but only once we've found a specific replacement for easy observability (which workflows have been failing lately, and how often) and trigger phrases (for retries and workflows that aren't automatically kicked off but should be run for

Re: pr-bot causing a very large number of empty commit emails

2022-10-26 Thread Danny McCormick via dev
I filed https://github.com/apache/beam/issues/23851 to do this. Even if we do this, the bot will still generate some noise there; in general, I'd recommend filtering that thread out if you're trying to follow all meaningful commits in the repo. Thanks, Danny On Sun, Oct 23, 2022 at 2:51 PM Daniel

Re: [ANNOUNCE] New committer: Ritesh Ghorse

2022-11-03 Thread Danny McCormick via dev
Congrats Ritesh! This is definitely well deserved! On Thu, Nov 3, 2022 at 8:08 PM Robert Burke wrote: > Woohoo! Well done Ritesh! :D > > On Thu, Nov 3, 2022, 5:04 PM Anand Inguva via dev > wrote: > >> Congratulations Ritesh. >> >> On Thu, Nov 3, 2022 at 7:51 PM Yi Hu via dev wrote: >> >>> Cong

Re: Regression Alerts for Python Performance tests

2022-11-04 Thread Danny McCormick via dev
I left some small comments, but overall this is a great proposal. I think this should help fill a really important gap in our infrastructure and will help make our perf dashboards actionable. Thanks for taking this on Anand! On Wed, Nov 2, 2022 at 12:32 PM Anand Inguva via dev wrote: > Hi, > > P

[FYI] How to disable Dependabot spam on your fork

2022-11-07 Thread Danny McCormick via dev
GitHub just shipped a feature to disable Dependabot updates on your forks[1]. If you're like me, you've found Dependabot opening PRs on your Beam fork annoying; to fix this, go to https://github.com//beam/settings/security_analysis and disable Dependabot version updates. This will automatically ge

Re: [ANNOUNCE] New committer: Yi Hu

2022-11-09 Thread Danny McCormick via dev
Congrats Yi! I've really appreciated the ways you've consistently taken responsibility for improving our team's infra and working through sharp edges in the codebase that others have ignored. This is definitely well deserved! Thanks, Danny On Wed, Nov 9, 2022 at 1:37 PM Anand Inguva via dev wrot

Re: An AI/ML landing page for Beam is available now

2022-11-10 Thread Danny McCormick via dev
Thank you to everyone who worked on this and especially to Aizhamal for coordinating the work! These resources make it much easier to build out your Beam ML workloads. Thanks, Danny On Thu, Nov 10, 2022 at 12:53 PM Aizhamal Nurmamat kyzy wrote: > Hi Beam community! > > We are happy to announce

Re: Streaming model updates for the RunInference transform.

2022-11-21 Thread Danny McCormick via dev
Thanks for the writeup Anand, this looks like a good approach. > There is a *WIP * section in the doc, where I am figuring out a better solution. I would love to hear any suggestions or a

Re: Credentials Rotation Failure on IO-Datastores cluster

2022-12-01 Thread Danny McCormick via dev
Yes, I was just starting to look into this. Looks like this is the result of this job failing - https://github.com/apache/beam/blob/ec2a07b38c1f640c62e7c3b96966f18b334a7ce9/.test-infra/jenkins/job_IODatastoresCredentialsRotation.groovy#L49 The error is: ``` *21:25:58* + gcloud container clusters

Re: Credentials Rotation Failure on IO-Datastores cluster

2022-12-01 Thread Danny McCormick via dev
Does that have potential to break other things? We could presumably also update https://github.com/apache/beam/blob/4718cdff87fed4f92636e94dbf3a04c2315d6a95/.test-infra/jenkins/job_IODatastoresCredentialsRotation.groovy#L38 to pool-1 instead. I put up https://github.com/apache/beam/pull/24466 in

Re: Credentials Rotation Failure on IO-Datastores cluster

2022-12-01 Thread Danny McCormick via dev
Update - the job has been successfully run and the permanent fix is merged. I'll follow up with a PR to fix the links in the failure email. On Thu, Dec 1, 2022 at 2:00 PM Apache Jenkins Server < jenk...@builds.apache.org> wrote: > Something went wrong during the automatic credentials rotation for

Re: Achievement unlocked: fully triaged

2022-12-05 Thread Danny McCormick via dev
> Previously, we had automation that would automatically mark self-assigned self-reported issues as triaged. That is probably a third of issues or more. I believe that automation exists now[1], but it wasn't retroactively applied to old issues. > One issue is that a lot of triage work is getting

Re: Achievement unlocked: fully triaged

2022-12-06 Thread Danny McCormick via dev
> On Mon, Dec 5, 2022 at 6:46 PM Kenneth Knowles wrote: > >> I definitely think reducing the label zoo could help. We have a lot of >> labels that are decompositions of what used to be Jira components. >> >> Kenn >> >> On Mon, Dec 5, 2022 at 12:17 PM D

Re: Achievement unlocked: fully triaged

2022-12-06 Thread Danny McCormick via dev
yground >> [ ] Beam katas >> [ ] Website >> [ ] Spark Runner >> [ ] Flink Runner >> [ ] Samza Runner >> [ ] Twister2 Runner >> [ ] Hazelcast Jet Runner >> [ ] Google Cloud Dataflow Runner >> >> We could even trim it even further to

Re: Testing Multilanguage Pipelines?

2022-12-28 Thread Danny McCormick via dev
> Given the increasing importance of multi language pipelines, it does seem that we should expand the capabilities of the DirectRunner or just go all in on FlinkRunner for testing and local / small scale development +1 - annecdotally I've found local testing of multi-language pipelines to be trick

Re: TensorFlow Hub Integration in RunInference

2023-01-03 Thread Danny McCormick via dev
Thanks Jack - I had a single question about the tfx-bsl limitations, but otherwise this looks great to me! On Tue, Jan 3, 2023 at 10:27 AM Jack McCluskey via dev wrote: > Hey everyone, > > I've put together some thoughts on how we would allow users to load > pre-trained models from TensorFlow Hu

Re: [RFC] Tensorflow model handler in Beam Repository

2023-01-26 Thread Danny McCormick via dev
Thanks Ritesh! I left a couple comments, but overall this looks like a great proposal! On Thu, Jan 26, 2023 at 10:43 AM Ritesh Ghorse via dev wrote: > Hey everyone, > > I've written a short doc to add a new tensorflow model handler to make it > easy to use for beam users and consistent with othe

Beam Release 2.46

2023-02-08 Thread Danny McCormick via dev
Hey everyone, I would like to volunteer myself to do the 2.46.0 release. I will cut the branch Feb 22 [1], and cherrypick any blocking fixes afterwards. Please review the current release blockers [2] and remove the 2.46 milestone if they don't meet the criteria at [3]. Thanks, Danny [1] https://

Re: Beam Website Feedback

2023-02-10 Thread Danny McCormick via dev
I just added https://github.com/apache/beam/pull/25425 to do this On Fri, Feb 10, 2023 at 11:42 AM Julian Ogando via dev wrote: > Hi Bruno, > Thanks for the quick response! > Yes, I already have the code running by reading the "unittest" > documentation, but it would be good to include those cha

Re: Beam Release 2.46

2023-02-15 Thread Danny McCormick via dev
> Excellent! Keep that release train rolling. >> >> On Thu, Feb 9, 2023 at 9:28 AM Ahmet Altay via dev >> wrote: >> >>> Thank you Danny! >>> >>> On Wed, Feb 8, 2023 at 6:46 AM Danny McCormick via dev < >>> dev@beam.apache.org> wrot

Re: [ANNOUNCE] New PMC Member: Jan Lukavský

2023-02-16 Thread Danny McCormick via dev
Congratulations! On Thu, Feb 16, 2023 at 11:09 AM Reza Rokni via dev wrote: > Congratulations! > > On Thu, Feb 16, 2023 at 7:47 AM Robert Burke wrote: > >> Congratulations!🎉 >> >> On Thu, Feb 16, 2023, 7:44 AM Danielle Syse via dev >> wrote: >> >>> Congrats, Jan! That's awesome news. Thank you

Re: new contributor messaging: behaviorbot/welcome

2023-02-20 Thread Danny McCormick via dev
Hey Austin, I'm +1 for adding a welcome bot, I would vote we use https://github.com/actions/first-interaction instead though. The pros I see are: - (minor) we don't need to install the bot (which would require infra approval I believe) - GitHub has generally lowered (if not completely deprecated)

Re: new contributor messaging: behaviorbot/welcome

2023-02-21 Thread Danny McCormick via dev
reate a custom GH action. I > can dig in there if that's the route needed to accomplish, but thought you > might recall the GH APIs better than my current knowledge. Thoughts? > > > On Mon, Feb 20, 2023 at 6:47 PM Danny McCormick via dev < > dev@beam.apache.org> wro

Re: Beam Release 2.46

2023-02-23 Thread Danny McCormick via dev
elease train rolling. >>> >>> On Thu, Feb 9, 2023 at 9:28 AM Ahmet Altay via dev >>> wrote: >>> >>>> Thank you Danny! >>>> >>>> On Wed, Feb 8, 2023 at 6:46 AM Danny McCormick via dev < >>>> dev@beam.apache.org> wrote

Re: Dependabot questions

2023-02-28 Thread Danny McCormick via dev
AFAIK Dependabot doesn't have a great replacement for this. I'm not sure why the dependency reports stopped, but we could probably try to fix them - looks like they stopped working in October - https://lists.apache.org/list?dev@beam.apache.org:2021-10:dependency%20report. We still have the job whic

[VOTE] Release 2.46.0, release candidate #1

2023-03-02 Thread Danny McCormick via dev
Hi everyone, Please review and vote on release candidate #1 for the version 2.46.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) Reviewers are encouraged to test their own use cases with the release candidate, and vote +1 if no issues

Re: Beam Release 2.46

2023-03-03 Thread Danny McCormick via dev
hat runs all tests against the release branch. I think we > used to include it, but I haven't seen it in recent voting threads. > > Thanks, > Valentyn > > On Thu, Feb 23, 2023 at 9:28 AM Danny McCormick via dev < > dev@beam.apache.or

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Danny McCormick via dev
no Volpato via dev < > dev@beam.apache.org> wrote: > >> > >> +1 (non-binding) > >> > >> Tested with https://github.com/GoogleCloudPlatform/DataflowTemplates > (Java SDK 11, Dataflow runner). > >> > >> > >> Thanks Danny! >

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Danny McCormick via dev
Direct Runner and > Dataflow Runner. > >> > > >> > Thanks! > >> > > >> > On Fri, Mar 3, 2023 at 11:21 AM Bruno Volpato via dev < > dev@beam.apache.org> wrote: > >> >> > >> >> +1 (non-binding) > >> >> > >

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Danny McCormick via dev
gt;> >>> >> >> It appears your public key is not published in >>> >> >> https://dist.apache.org/repos/dist/release/beam/KEYS . >>> >> >> >>> >> >> On Fri, Mar 3, 2023 at 8:33 AM Anand Inguva via dev < >>>

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Danny McCormick via dev
> > >>>> >> > On Fri, Mar 3, 2023 at 1:38 PM Robert Bradshaw < >>>> rober...@google.com> wrote: >>>> >> >> >>>> >> >> It appears your public key is not published in >>>> >> >> https://dist

[RESULT] [VOTE] Release 2.46.0, release candidate #1

2023-03-08 Thread Danny McCormick via dev
I'm happy to announce that we have unanimously approved release 2.46.0 There are 8 approving votes, 5 of which are binding: * Robert Bradshaw (binding) * Chamikara Jayalath (binding) * Ahmet Altay (binding) * Alexey Romanenko (binding) * Jan Lukavský (binding) * Bruno Volpato (non-binding) * Anand

Re: [RESULT] [VOTE] Release 2.46.0, release candidate #1

2023-03-08 Thread Danny McCormick via dev
Inguva wrote: > Thanks Danny!! > > On Wed, Mar 8, 2023 at 12:14 PM Danny McCormick via dev < > dev@beam.apache.org> wrote: > >> I'm happy to announce that we have unanimously approved release 2.46.0 >> There are 8 approving votes, 5 of which are binding: * Rober

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-08 Thread Danny McCormick via dev
rote: >>> >>> +1 (binding) - I validated python quickstarts on direct & dataflow >>> runners. >>> >>> Thank you for doing the release! >>> >>> On Sat, Mar 4, 2023 at 8:01 AM Chamikara Jayalath via dev < >>> dev@beam.apa

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-10 Thread Danny McCormick via dev
les/ >>>>> (Java SDK v8/v11/v17, Spark 3.x runner). >>>>> >>>>> --- >>>>> Alexey >>>>> >>>>> On 7 Mar 2023, at 07:38, Ahmet Altay via dev >>>>> wrote: >>>>> >>>>> +1

Re: [RESULT] [VOTE] Release 2.46.0, release candidate #1

2023-03-10 Thread Danny McCormick via dev
; wrote: > >> Thanks Danny!! >> >> On Wed, Mar 8, 2023 at 12:14 PM Danny McCormick via dev < >> dev@beam.apache.org> wrote: >> >>> I'm happy to announce that we have unanimously approved release 2.46.0 >>> There are 8 approving votes,

Re: [RESULT] [VOTE] Release 2.46.0, release candidate #1

2023-03-10 Thread Danny McCormick via dev
perly because it depends on versioning. I will >> update this thread with next steps when we know more. >> >> Thanks, >> Danny >> >> On Wed, Mar 8, 2023 at 1:02 PM Anand Inguva >> wrote: >> >>> Thanks Danny!! >>> >>> O

Re: Regarding Project proposal review and feedback

2023-03-30 Thread Danny McCormick via dev
Thanks Siddharth! I left some comments on the sentiment analysis proposal, I am probably not the best person to comment on the flink datastream api one though. Thanks, Danny On Fri, Mar 24, 2023 at 11:53 PM Siddharth Aryan < siddhartharyan...@gmail.com> wrote: > Hello , > I am Siddharth Aryan a

Re: [DISCUSS] @Experimental, @Internal, @Stable, etc annotations

2023-04-03 Thread Danny McCormick via dev
*;tldr - I'd like "evolving" to be further defined, specifically around how we will make decisions about breaking behavior and API changes* I don't particularly care what tags we use as long as they're well documented. With that said, I think the following framing needs to be documented with more

Jenkins Flakes

2023-04-11 Thread Danny McCormick via dev
*;tldr - I want to temporarily reduce the number of builds that we retain to reduce pressure on Jenkins* Hey everyone, over the past few days our Jenkins runs have been particularly flaky across the board, with errors like the following showing up all over the place [1]: java.nio.file.FileSystemE

Re: Jenkins Flakes

2023-04-11 Thread Danny McCormick via dev
rmal pre commit jobs? >> >> >> >> Kind regards, >> >> Moritz >> >> >> >> [1] >> https://github.com/apache/beam/issues?q=is%3Aissue+is%3Aopen+label%3Aflake >> <https://urldefense.com/v3/__https:/github.com/apache/beam/issues?q=

Re: Jenkins Flakes

2023-04-11 Thread Danny McCormick via dev
gt;> coverage might not be the pressing issue. Should it be disabled everywhere >>> in favor of more reliable / faster builds? Unless Devs here are willing to >>> commit on taking actions, it doesn’t seem to provide too much value >>> recording these numbers as part o

Re: Jenkins Flakes

2023-04-11 Thread Danny McCormick via dev
absolutely +1 for removing Jenkins related friction and the >>>> proposed changes sound legitimate. >>>> >>>> >>>> >>>> Also, considering the number of flaky tests in general [1], code >>>> coverage might not be the pressing iss

Re: [Python SDK] Use pre-released dependencies for Beam python unit testing

2023-04-12 Thread Danny McCormick via dev
Thanks for doing this Anand, I'm +1 on option 1 as well - I think having the clear signal of the normal suite succeeding and the prerelease one failing would be helpful and there shouldn't be too much additional code necessary. That makes it really easy to treat the prerelease suite as a (at least

Beam Release DockerHub Group

2023-04-17 Thread Danny McCormick via dev
Hey everyone, in an effort to reduce the burden of running a Beam release, a few committers (self included) have volunteered to try to take a larger role in releases (including both running them and contributing to making them better going forward). To aid in that process, I would like to request t

Re: Beam Release DockerHub Group

2023-04-17 Thread Danny McCormick via dev
ify >> the better. >> >> On Mon, Apr 17, 2023 at 11:18 AM Danny McCormick via dev < >> dev@beam.apache.org> wrote: >> >>> Hey everyone, in an effort to reduce the burden of running a Beam >>> release, a few committers (self included) h

Re: Beam Release DockerHub Group

2023-04-17 Thread Danny McCormick via dev
the group). Thanks, Danny On Mon, Apr 17, 2023 at 12:34 PM Robert Bradshaw wrote: > I think it'd be good if the intersection between this list and the PMC had > cardinality greater than 1. Ahmet might be a good person to keep there. > > On Mon, Apr 17, 2023 at 9:25 AM Dann

[RFC] RunInference Pre/Postprocessing and DLQ UX

2023-04-18 Thread Danny McCormick via dev
Hey everyone, I put up a small design doc proposing a user experience for adding DLQ and pre/post processing map operation support to RunInference. I'd appreciate any thoughts or comments. https://docs.google.com/document/d/1hr1SaWraneB9dYSFyGA99JT44oKgGNhT70wz99lmdEU/edit?usp=sharing Thanks, Dan

Re: [ANNOUNCE] New committer: Anand Inguva

2023-04-21 Thread Danny McCormick via dev
Woohoo, congrats Anand! This is very well deserved! On Fri, Apr 21, 2023 at 1:54 PM Chamikara Jayalath wrote: > Hi all, > > Please join me and the rest of the Beam PMC in welcoming a new committer: > Anand > Inguva (ananding...@apache.org) > > Anand has been contributing to Apache Beam for more

Re: [ANNOUNCE] New committer: Damon Douglas

2023-04-24 Thread Danny McCormick via dev
Congrats Damon! On Mon, Apr 24, 2023 at 4:03 PM Ahmet Altay via dev wrote: > Congratulations Damon! > > On Mon, Apr 24, 2023 at 1:00 PM Robert Burke wrote: > >> Congratulations Damon!!! >> >> On Mon, Apr 24, 2023, 12:52 PM Kenneth Knowles wrote: >> >>> Hi all, >>> >>> Please join me and the re

[Proposal] Automate Release Signing

2023-05-03 Thread Danny McCormick via dev
Hey everyone, I'm currently working on improving our release process so that it's easier and faster for us to release. As part of this work, I'd like to propose automating our release signing step (the push java artifacts step of build_release_candidate.sh

Re: [Proposal] Automate Release Signing

2023-05-03 Thread Danny McCormick via dev
t; >>>>>> +1 to automating release signing. As it stands now, this step >>>>>> requires a PMC member to add a new release manager's GPG key which can >>>>>> add >>>>>> time to getting a release started. This also result

Re: Introducing beam.MLTransform

2023-05-10 Thread Danny McCormick via dev
Thanks Anand! I left a few comments, but overall I think this is a great/well constructed proposal - this is a good way to quickly bring a suite of preprocessing operations to Beam. Thanks, Danny On Tue, May 9, 2023 at 12:52 PM Anand Inguva via dev wrote: > Hi all, > > In Apache Beam, we plan t

Re: [Notice] Jenkins seed job comment trigger no longer working, and possible solutions

2023-05-11 Thread Danny McCormick via dev
I'm +1 on just adding committers to a list manually. Having the ability to run seed jobs from a PR is nice, but adding a new committer is a rare enough event that automating is not worth the time IMO (as opposed to documenting this as something to do when you're a new committer). Plus this problem

[Benchmarks/Proposal] Loading models with multi_process_shared.py for RunInference

2023-05-15 Thread Danny McCormick via dev
Hey everyone, Right now, using RunInference with large models and on GPUs has several performance gaps. I put together a document focusing on one: when running inference with large models, we often OOM because we load several copies of the model at once. My document explores using the multi_proces

[PMC Request] Add gpg key to release keys file

2023-05-23 Thread Danny McCormick via dev
Hey everyone, as part of automating our release process (see thread here - https://lists.apache.org/thread/mw9dbbdjtkqlvs0mmrh452z3jsf68sct), could a PMC member please add the infra supplied gpg public key to our release KEYS file? I added it to our dev KEYS file

Re: [Release-2.48.0] Uploading images to dockerhub

2023-05-24 Thread Danny McCormick via dev
I'm currently in the process of publishing the containers, I will let you know when it completes. Thanks, Danny On Tue, May 23, 2023 at 8:09 PM Ritesh Ghorse via dev wrote: > Hey everyone, > > I'm at the stage of pushing docker containers to the apache repository of > [Dockerhub](https://hub.do

Re: [Release-2.48.0] Uploading images to dockerhub

2023-05-24 Thread Danny McCormick via dev
This has finished. One thing I did notice: we requested that Infra create repos for some transform service docker images (context ), but those didn't seem to get published. @Chamikara Jayalath should they be added to https://github.com/apache/beam

Re: [Release-2.48.0] Uploading images to dockerhub

2023-05-24 Thread Danny McCormick via dev
https://github.com/apache/beam/pull/26869 should fix On Wed, May 24, 2023 at 11:45 AM Chamikara Jayalath wrote: > > > On Wed, May 24, 2023 at 8:41 AM Danny McCormick > wrote: > >> This has finished. One thing I did notice: we requested that Infra create >> repos for some transform service docke

Re: [Release-2.48.0] Uploading images to dockerhub

2023-05-24 Thread Danny McCormick via dev
I pushed the missing containers as well, so we should be good to go. I also created a cherry pick PR, that only needs to be merged if we make it to RC2 though (hopefully not!) - https://github.com/apache/beam/pull/26871 Thanks, Danny On Wed, May 24, 2023 at 11:48 AM Danny McCormick wrote: > ht

Re: [VOTE] Release 2.48.0 release candidate #2

2023-05-26 Thread Danny McCormick via dev
It looks like some Dataflow containers didn't get published, so some jobs using the legacy runner (runner v2 disabled) will fail. I kicked off the container release, so that should hopefully be available later today. Thanks, Danny On Thu, May 25, 2023 at 11:19 PM Ritesh Ghorse via dev wrote: >

Re: [DISCUSS] Enable Github Discussions?

2023-06-30 Thread Danny McCormick via dev
Thanks for starting this discussion! I'm a weak -1 for this proposal. While I think that GH Discussions can be a good forum, I think most of the things that Discussions do are covered by some combination of the dev/user lists and GitHub issues, and the net outcome of this will be creating one more

Re: [Feature Proposal] Add ARM Support to Beam SDK Container Images

2023-07-19 Thread Danny McCormick via dev
Thanks Celeste! I left a few comments. Overall I like the proposal, but I think that the open question "If Beam SDK containers are still released by the release manager, how should we integrate the multiarch containers into the current Beam container release process?" needs to be answered before I

[RFC] Model Per Key RunInference

2023-07-20 Thread Danny McCormick via dev
Hey everyone! Today, many users have pipelines that choose a single model for inference from 100s or 1000s of models based on properties of the data. Unfortunately, RunInference does not support this use case. I put together a proposal for RunInference that allows a single keyed RunInference transf

[Discuss] Get rid of OWNERS files

2023-08-08 Thread Danny McCormick via dev
Hey everyone, I'd like to propose getting rid of OWNERS files from the Beam repo. Right now, I don't think they are serving a meaningful purpose: - Many OWNERS files are outdated and point to people who are no longer actively involved in the project (examples: 1

Re: [Discuss] Get rid of OWNERS files

2023-08-08 Thread Danny McCormick via dev
ast active members. > > > On Tue, Aug 8, 2023, 9:13 AM Alexey Romanenko > wrote: > >> I’m generally agree with this (initially that was a good intention imho) >> but what could be an alternative for this? Review bot also may assign >> reviewers that are no longer activ

Re: Propose to add the new security section to the Beam releases

2023-08-11 Thread Danny McCormick via dev
Thanks XQ! This should help us be cleaner with what versions we're recommending to security conscious users. On Fri, Aug 11, 2023 at 2:17 PM XQ Hu via dev wrote: > Hi All, > > We are proposing to explicitly add the security fixes to the Beam release > notes. https://github.com/apache/beam/pull/2

Re: [Discuss] Get rid of OWNERS files

2023-08-11 Thread Danny McCormick via dev
> I’m generally agree with this (initially that was a good intention > imho) but what could be an alternative for this? Review bot also may assign > reviewers that are no longer active on the project. > >> > >> — > >> Alexey > >> > >> > >

Re: Automatic signing of releases

2023-08-24 Thread Danny McCormick via dev
Hey Ismael, We've actually already been doing this since May! I started a thread for this here https://lists.apache.org/thread/mw9dbbdjtkqlvs0mmrh452z3jsf68sct and its in an Actions workflow here - https://github.com/apache/beam/blob/0c6ef7dd4788d13b3785d4e06d4552907c7200e3/.github/workflows/build

Re: [ANNOUNCE] New committer: Ahmed Abualsaud

2023-08-25 Thread Danny McCormick via dev
Congrats Ahmed! On Fri, Aug 25, 2023 at 3:16 AM Jan Lukavský wrote: > Congrats Ahmed! > On 8/25/23 07:56, Anand Inguva via dev wrote: > > Congratulations Ahmed :) > > On Fri, Aug 25, 2023 at 1:17 AM Damon Douglas > wrote: > >> Well deserved! Congratulations, Ahmed! I'm so happy for you. >> >> O

Re: Proposal for pyproject.toml Support in Apache Beam Python

2023-08-28 Thread Danny McCormick via dev
Thanks Anand! This generally sounds good to me. I left a few questions before giving a full +1, but it definitely seems like we need some migration effort here and this seems like a good route. Thanks, Danny On Mon, Aug 28, 2023 at 10:14 AM Anand Inguva via dev wrote: > Hello Beam Dev Team, > >

Re: Contribution of Asgarde: Error Handling for Beam?

2023-09-05 Thread Danny McCormick via dev
I think my only concerns here are around the toil we'll be taking on, and will we be leaving the asgarde project in a better or worse place. >From a release standpoint, we would need to release it with the same cadence as Beam. Adding asgarde into our standard release process seems fairly straight

Re: [Proposal] Enable EnricoMi/publish-unit-test-result-action

2023-09-05 Thread Danny McCormick via dev
Thanks Yi, I'm definitely +1 on adding this, this is definitely a gap in our GitHub Actions infra today. Thanks, Danny On Tue, Sep 5, 2023 at 10:35 AM Yi Hu via dev wrote: > Hi everyone, > > As you may have noticed, GitHub Action for test suites are setting up in > the Beam repository. A curren

Disabling Jenkins Jobs

2023-09-12 Thread Danny McCormick via dev
Hey everyone, I wanted to let you know that as part of the migration from Jenkins to GitHub Actions we are going to start disabling Jenkins jobs if they have a corresponding GitHub Actions job that has been running successfully for a while. We are starting with Yi's PR here - https://github.com/apa

Re: Beam ML Use Cases - Google Summer of Code 2023

2023-09-13 Thread Danny McCormick via dev
Thanks for all your hard work this summer Reeba! I've really enjoyed getting to work closely with you, and I know that Beam and its users are better off because of your contributions. Thanks, Danny On Wed, Sep 13, 2023 at 1:01 PM XQ Hu via dev wrote: > The blog looks great! Thanks for doing thi

Re: User-facing website vs. contributor-facing website

2023-09-21 Thread Danny McCormick via dev
+1 on moving the release guide. I'd argue that everything under the `contribute` tag other than the main page ( https://beam.apache.org/contribute/) and the link to CONTRIBUTING.md makes more sense on the wiki (we can keep the section wit

Re: User-facing website vs. contributor-facing website

2023-09-21 Thread Danny McCormick via dev
updated. > > Thanks, > Cham > > On Thu, Sep 21, 2023 at 9:14 AM Danny McCormick via dev < > dev@beam.apache.org> wrote: > >> +1 on moving the release guide. I'd argue that everything under the >> `contribute` tag other than the main page ( >> https://beam

Re: User-facing website vs. contributor-facing website

2023-09-21 Thread Danny McCormick via dev
meeting all those criteria needs a different > home. > > I did a quick search to see if there was a standard answer to having top > and side nav for a docs/ folder of markdown in your github repo. I guess > that is GitHub Pages? TBH I have used them happily in the distant

Re: User-facing website vs. contributor-facing website

2023-09-22 Thread Danny McCormick via dev
tax is an old thing that is not quite markdown and should >>>>> just be markdown >>>>> >>>>> Agree. >>>>> >>>>> > Wiki is yet another place to go, hard to navigate, not discoverable. >>>>> >>>>

Re: [VOTE] Release 2.51.0, release candidate #1

2023-10-03 Thread Danny McCormick via dev
+1 (non-binding) Tested python/ML execution with https://github.com/apache/beam/blob/master/examples/notebooks/beam-ml/run_inference_huggingface.ipynb (interactive runner) and https://github.com/apache/beam/blob/master/examples/notebooks/beam-ml/automatic_model_refresh.ipynb (Dataflow runner). Th

Re: [VOTE] Release 2.51.0, release candidate #1

2023-10-03 Thread Danny McCormick via dev
test on runner v1 for this release? > > Thanks in advance for the clarification, > > > > Svetak Sundhar > > Data Engineer > s vetaksund...@google.com > > > > On Tue, Oct 3, 2023 at 2:14 PM Danny McCormick via dev < > dev@beam.apache.org> wrote:

Re: [ANNOUNCE] New PMC Member: Robert Burke

2023-10-03 Thread Danny McCormick via dev
Congrats Robert, this is very well deserved! On Tue, Oct 3, 2023 at 2:50 PM Anand Inguva via dev wrote: > Congratulations!! > > On Tue, Oct 3, 2023 at 2:49 PM XQ Hu via dev wrote: > >> Congratulations, Robert! >> >> On Tue, Oct 3, 2023 at 2:40 PM Kenneth Knowles wrote: >> >>> Hi all, >>> >>> P

  1   2   3   >