libs for build

2007-10-31 Thread Kev Jackson
Hi, Thanks for the offers of sending mock libs etc. I managed to get the time to copy all the missing libs from my old laptop today and run a first 'full' build or 1.7.1 We still have problems: LocatorTest RmicAdvancedTest (Xalan problems have gone away with the addition of the correct libs)

Vista symbolic links?

2007-10-31 Thread Kev Jackson
It seems that there's some kind of symbolic link support in Vista http://wesnerm.blogs.com/net_undocumented/2006/10/symbolic_links_.html It was also mentioned on the ruby-lang mailing list. Not really important right now (with all 3 vista users), but it may become important before 1.8 Kev -

Re: Bugs in release branch

2007-11-01 Thread Kev Jackson
The windows tests will still be failing with bad paths, but now we can decide what the correct strings are and add them to the tests, then fix any locator bugs that exist. I guess they always passed on gump as it was running on linux/bsd, which is why we didn't see any problems until now. An

Ant SVN Trunk - errors in LocatorTest & RmicAdvancedTest

2007-11-01 Thread Kev Jackson
Hi, After Steve's work yesterday, I was going to pull in the changes to the release to try and get a clean build...but: (these errors occur with the svn trunk code) LocatorTest testNetworkURI Failure Expected file:\\PC03\jclasses\lib\ant-1.7.0.jar to resolve to \\PC03\jclasses\lib\ant-1.7.0

Rmic & WebLogic failure more info

2007-11-01 Thread Kev Jackson
Hi, Here's the -debug output of executing testWlrmic in isolation: D:\eclipse\workspace2\ant-core-trunk>ant -debug -f src\etc\testcases\taskdefs\rm ic\rmic.xml testWlrmic Apache Ant version 1.8.0alpha compiled on November 2 2007 Buildfile: src\etc\testcases\taskdefs\rmic\rmic.xml Adding refere

Weblogic Rmic error

2007-11-04 Thread Kev Jackson
Hi, Currently Wlrmic still has a problem on Windows. From the full build test: Error starting WebLogic rmic: D:\eclipse\workspace2\ant-core-trunk\src\etc\testcases\taskdefs\rmic\rmic.xml:174: Error starting WebLogic rmic: at org.apache.tools.ant.taskdefs.rmic.WLRmic.execute(WLRmic.java:85) a

weblogic rmic

2007-11-04 Thread Kev Jackson
Hi, It seems that Antoine came across a similar issue : http://mail-archives.apache.org/mod_mbox/ant-dev/200408.mbox/[EMAIL PROTECTED] Anyone know how it was resolved? (also I've done a full build with the weblogic*.jars in my lib/optional, but I don't have an ant-weblogic stub) Thanks, Kev

Update [was Re: weblogic rmic]

2007-11-05 Thread Kev Jackson
Hi, You probally need an old version of weblogic*.jar By this do you mean that an old version of weblogic*.jars will remove the problem I'm having getting a clean set of tests? Or do you mean that the older jars will create the ant-weblogic.jar? The error doesn't seem to be caused by a miss

Re: Update [was Re: weblogic rmic]

2007-11-06 Thread Kev Jackson
Hi, I meant the creation of the ant-weblogic.jar. Well I don't think that's a problem anyway as test case clearly calls the weblogic rmic tool and clearly executes before failing to find the test class - I guess we don't ship an ant-weblogic.jar anymore Does it work with JDK5? Nope, it

Re: Update [was Re: weblogic rmic]

2007-11-06 Thread Kev Jackson
Hi, We need to ship ant-weblogic.jar for ant 1.7.1. (Unless we vote to drop it from that release). We will not ship it in ant 1.8.0. That means that somehow I have to get the build to create the ant-weblogic.jar I can only assume that the test tests the behavior of an old version of weblo

Re: Where to place sponsorship link?

2007-11-06 Thread Kev Jackson
+1 this could absorb the Donations link as well. +1 here - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Update [was Re: weblogic rmic]

2007-11-06 Thread Kev Jackson
Hi, or we have a vote. One thing is clear: weblogic rmic was broken on ant1.7.0. nobody noticed. Well I've just tested with Ant 1.6.5 (from svn), and I get exactly the same error: [rmic] RemoteTimestampImpl must be a remote interface implementation and should exist in the classpath

concat-test.xml antunit

2007-11-07 Thread Kev Jackson
Hi, There's a problem with the concat-test.xml If you execute this on linux/unix, no problems, but on windows it fails The reason is that Windows has the stupid crlf line ending foo${br}bar${br}baz${br} So when this encodeStringDigest file is compared to the utf-16.expected file, it fails

1.7.1 nearly there - alpha

2007-11-11 Thread Kev Jackson
Hi, Today I got 3 complete builds on Windows XP + java6|java5|java1.4 Linux build fails with an assertion error in XMLCatalogTest. I tried to debug this error in eclipse, but the error doesn't exist except when executed as part of ./build.sh test IMHO that makes the code ready for alpha sta

Re: AW: 1.7.1 nearly there - alpha

2007-11-12 Thread Kev Jackson
Hi, What is with Java 1.3 - or missed I the dropping? I couldn't find a java 1.3 jdk to test with - Sun lists it as unsupported now If you have 1.3 feel free to test the build, but I didn't have a copy Thanks, Kev - To u

Re: AW: 1.7.1 nearly there - alpha

2007-11-12 Thread Kev Jackson
Hi, A binary version will be available from people.apache.org/~kevj/ant/1-7-1-alpha soon. You can test the alpha binary from http://people.apache.org/~kevj/ant/1-7-1-alpha/apache-ant-1.7.1alpha.tar.gz - built with java6, so if there are any problems please report them - unsigned (I don't hav

Re: AW: 1.7.1 nearly there - alpha

2007-11-12 Thread Kev Jackson
Hi Peter, Opps, I meant http://java.sun.com/products/archive/ Peter Thanks, I couldn't find it when I looked previously Kev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

ApacheCon Presentation

2007-11-12 Thread Kev Jackson
Hi all, As some of you probably know already, the HK OSSummit has been canceled due to lack of attendees. But as I've already prepared my presentation (which will now not be aired publicly), feel free to browse/peruse yourselves without my witty voiceover http://people.apache.org/~kevj/oss

Re: 1.7.1 nearly there - alpha

2007-11-13 Thread Kev Jackson
Hi, Could someone test the build on the following platforms: - Vista (someone has probably got a copy/image (Steve?)) Not sure of what the process is to test the build, here's what I've done: svn co http://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH/ cd ANT_17_BRANCH build On my

[Fwd: RE: svn commit: r594009 - /ant/core/branches/ANT_17_BRANCH/src/main/org/apache/tools/ant/taskdefs/TempFile.java]

2007-11-13 Thread Kev Jackson
Hi all, Some lurker ;) spotted this commit and got in touch with me. I copied over the code from the svn trunk version without looking too carefully (my bad), unless anyone can tell me that this is correct, I agree that at least semantically it's utter crap :) I think I should modify both th

Ant & Java1.3

2007-11-14 Thread Kev Jackson
Hi, I tried to build the branch on 1.3 last night. I couldn't even bootstrap. The problem was that the activation.jar was built with class file format 48.0 (1.4) - so the 1.3 jdk couldn't recognize the classes. As the bootstrap failed there, I don't know how many other of the dependency jar

Re: ApacheCon Presentation

2007-11-14 Thread Kev Jackson
Hi, I wonder whether Ant/Ivy has a "dependency fetching" mechanism like Maven has regarding "plugins". This is what I have in mind: A antlib provides tasks and macros and implements them in terms of 3rdparty libraries. Those libraries are described in dependencies (perhaps a la Maven).

Non-reflective version of DirectoryScanner refectoring

2006-08-24 Thread Kev Jackson
Hi, After thinking this through this morning on the ride into work, here is a version of the refactoring (extract method) that doesn't use any reflection (so should satisfy both Antoine and Matt ;)) Attached patch for testing purposes too. /** * Process included file. * @param name pa

Re: Use of reflection in DirectoryScanner to remove duplicated code

2006-08-24 Thread Kev Jackson
> OK. Actually I had written the pieces of code which you are > refactoring. :( It's ok, I have the advantage of hindsight, coming into a stable codebase is always easier than writing stuff from scratch - also I tend to specialise in refactoring at work - I rarely sit down and write teh origina

Re: Use of reflection in DirectoryScanner to remove duplicated code

2006-08-25 Thread Kev Jackson
I am not historically a champion of readability for its own sake ;) , but in this case I am of the general impression (without having thoroughly perused the proposed change) that it should be possible to eliminate the duplication without resorting to reflection. To rephrase, if reflection were (i

Re: Ant 1.7.0Beta1 release

2006-08-27 Thread Kev Jackson
> I found 2 errors in the tests, one in AntVersion (a number format > exception, hope it is not difficult to fix) and some errors in > testRedirector, may be due to running the tests under cygwin, > anyway looking like some strange whitespace oddity. I have reported both > in Bugzilla. Interestin

AntVersion test failing

2006-08-27 Thread Kev Jackson
Hi all, AntVersion test is failing because the current Ant version number is 1.7.0Beta1 - the Beta1 characters are causing the DeweyDecimal code to fail. It's also extremely difficult to test in isolation as the version string is set when the build is completed, so the unit tests fail with @VERSI

Re: Ant 1.7.0Beta1 release

2006-08-28 Thread Kev Jackson
Hi Antoine (and others), I've just committed a change to AntVersion which now passes the tests on my machine if the value in the version.txt file is set to 1.7.0Beta1 (it still fails with the default value of @VERSION@). Can you see if you are still experiencing a problem with the full test suite

Re: svn commit: r437589 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/condition/AntVersion.java

2006-08-28 Thread Kev Jackson
On 28 Aug 2006, at 19:09, Antoine Levy-Lambert wrote: Hi, I am not very fond of this versionString.indexOf("Ant version") +17); either. A regular expression looking for a string of digits and dots would be what we are looking for ? Unfortunately regexps aren't available in Java 1.2[1], do

Re: AntVersion test failing

2006-08-28 Thread Kev Jackson
Hi Antoine, As you requested, I've modified AntVersion to pass the failing test with the beta, without using positional indexing (brittle) code - please see commit for more details. Again if you spot a problem with this please let me know, I'll try to get it fixed asap. Thanks, Kev ---

Re: AW: Building Ant 1.7beta

2006-08-29 Thread Kev Jackson
> Especially: you know only the Ant src-version present (the current > version). > You dont know which binary-version of Ant is installed (Ant 1.6.5, 1.5, > 14?) > That means your buildfile must be "very" bwc ... Basically we improve Ant and add new features so that we can refactor the ant build.

Re: Building Ant 1.7beta

2006-08-30 Thread Kev Jackson
> To Kev: surely most Ant committers work on at least one other Ant-based > project where improvements can be seen? Or does the Apache Foundation > pay your rent? :-) :) I wish! I was (attempting humour) at suggesting that the ant developers/committers only add stuff which helps to make the an

Re: Building Ant 1.7beta

2006-08-31 Thread Kev Jackson
I know this too. To run ant testcases, either I run them individually in IDEA, or I bootstrap and rebuild and install my new version of ant, then run the tests. I just set my ANT_HOME to point to ~/projects/ant-core-trunk/build/ dist - then I'm always running the latest code and the tests

Re: [VOTE] Release Plan for .NET Antlib

2006-09-01 Thread Kev Jackson
I'm following this closely as I'd like to release the vss antlib sooner rather than later and I'll be using this .net release as a guide... > (1) Release 1.0 beta 1 ASAP. > > Since we haven't released any Antlib before and don't have any > distribution template for them, I'm going to prop

Re: VOTE: add an antlib (and optional task) loader to ant 1.7

2006-09-04 Thread Kev Jackson
On Mon, 2006-09-04 at 20:25 +0100, Steve Loughran wrote: > Peter Reilly wrote: > > Sorry for asking for another vote on the Classloader for ant issue, No problem. > I think right now I'm going to in the no category, though +0 rather than > -1. This is not because I dont think its a good idea -I

Re: [EMAIL PROTECTED]: Project dotnet-antlib-test (in module ant-antlibs) failed

2006-09-04 Thread Kev Jackson
> The test passes on both Microsoft frameworks I have installed (1.1 and > 2.0), right now my Linux box doesn't have a working Mono > installation. It is on the Antlib's TODO list. I'm sure I read that .net 3.0 is available in beta now... The framework formerly known as WinFX is now .net 3 and

[Patch] style changes to taskdefs/Rmic

2004-12-03 Thread Kev Jackson
Just some small changes that reduce the whining my IDE does :) What is the policy w.r.t TLA's in method names? e.g. getIiopOpts versus getIIOPOpts ? or setIDLOpts versus setIdlOpts ? I think the all CAPS accronym is easier to read, but I'm not sure if it breaks the style Kev Index: Rmic.java ===

Re: [Patch] style changes to taskdefs/Rmic

2004-12-03 Thread Kev Jackson
If the method is public or protected and the class has been part of Ant 1.6.2 and the method has been present, don't change its name ;-) I've got to get this "using ant programmatically" thing sorted - I'm so used to using Ant as a build tool that when I make a change, so long as it doesn't a

Re: [Patch] style changes to taskdefs/Rmic

2004-12-03 Thread Kev Jackson
Peter Reilly wrote: Kev Jackson wrote: Just some small changes that reduce the whining my IDE does :) Checkstyle whines about missing description for paramters. Sorry about that, here's an update that hopefully fixes those. Index: Rmic

[Patch] javadoc changes to ZipShort/ZipLong

2004-12-06 Thread Kev Jackson
Minor corrections plus added @param and @return where missing Index: ZipLong.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/zip/ZipLong.java,v retrieving revision 1.11 diff -u -r1.11 ZipLong.java --- ZipLong.java

[Patch]cvslib style changes and refactorings

2004-12-06 Thread Kev Jackson
Some general style changes, javadoc comments, removed c++ style variable names, changed HTML to use lowercase instead of etc Sorry no unit tests Kev Index: CVSEntry.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/

[Patch] DirectoryScanner

2004-12-08 Thread Kev Jackson
- Added javadoc (@param etc) - changed from to for XHTML compliance - removed unnecessary nesting if (condition) { return foo; } else { <-- not required - although I can see that in some ways it helps readability if (conition) { return bar; } No unit tests with this Kev -

Re: [Patch] DirectoryScanner

2004-12-08 Thread Kev Jackson
Sorry, helps if I attach the file eh? - Added javadoc (@param etc) - changed from to for XHTML compliance - removed unnecessary nesting if (condition) { return foo; } else { <-- not required - although I can see that in some ways it helps readability if (conition) { return bar; } No unit

[Patch] ChangeLogParser

2004-12-08 Thread Kev Jackson
May help with bug reported - 32583, Sorry I seem to have lost my bugzilla details and I'm in a real rush to get out the office! Kev Index: ChangeLogParser.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs

Re: [Patch] DirectoryScanner

2004-12-09 Thread Kev Jackson
/** - * gets whether or not a DirectoryScanner follows symbolic links + * Sets whether or not a DirectoryScanner follows symbolic links * - * @return flag indicating whether symbolic links should be followed + * @return whether or not symbolic links should be followed

[Patch] small changes to CBZip2*

2004-12-09 Thread Kev Jackson
just some minor tweaks - noticed two loops looping over same range with independent code, combined them - removed unneccessary casts from int to int (I left in casts from char to int as the code may rely on these casts in some obscure way, I guessed that a cast from int to int was truly unnecces

[Patch]improve visibility of private inner class variables in org...optional.depend.Depend

2004-12-09 Thread Kev Jackson
This is an Eclispe whiny fix - change visibility from private to protected for private inner classes (ClassFileInfo) rational: because Eclipse whines about it "Read access to enclosing field Depend.ClassFileInfo.isUserWarned is emulated by a synthetic accessor method. Increasing it's visibility

[Patch] javadoc and style fixes for org.apache.tools.ant.taskdefs.optional.extension.resolvers

2004-12-10 Thread Kev Jackson
- renamed variables (m_destdir ->destdir) - added javadoc for public methods and normal doc for private methods - slight tweak to remove "Unneccessary nested..." complaint from Eclipse Kev - To unsubscribe, e-mail: [EMAIL PROTECTED

[Patch] javadoc and variable names org.apache.tools.ant.taskdefs.optional.extension.resolvers

2004-12-10 Thread Kev Jackson
- added javadoc and normal doc where appropriate - renamed variables from m_* Kev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

[Patch] javadoc and variable names org.apache.tools.ant.taskdefs.optional.extension.resolvers

2004-12-10 Thread Kev Jackson
- added javadoc and normal doc where appropriate - renamed variables from m_* Kev Index: AntResolver.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/extension/resolvers/AntResolver.java,v retriev

[Patch] javadoc and style fixes for org.apache.tools.ant.taskdefs.optional.extension.resolvers

2004-12-10 Thread Kev Jackson
- renamed variables (m_destdir ->destdir) - added javadoc for public methods and normal doc for private methods - slight tweak to remove "Unneccessary nested..." complaint from Eclipse Kev Index: URLResolver.java === RCS file: /home/c

[Patch] removed deprecated methods and changed variable scope (private-protected) ProjectHelperImpl

2004-12-10 Thread Kev Jackson
- swapped out deprecated code where the replacement code was obvious - left some deprecated methods where I wasn't sure - changed visibility of class variables from private to protected still showing 1700+ warnings/errors :( Kev Index: ProjectHelperImpl.java ==

Re: cvs commit: ant/src/etc/testcases/taskdefs checksum.xml

2004-12-10 Thread Kev Jackson
If this is related to MD5 checksums, they've recently been proven to not be conclusive proof that the content of the file is the same as the checksum, ie two different files can create the same checksum under certain conditions. Not sure if this is relevant to the discussion http://developers.s

[Patch] another variable visibility change - ScriptDef

2004-12-10 Thread Kev Jackson
Just to remove whiny messages - although the compiler believes it will also help performance Kev Index: ScriptDef.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/script/ScriptDef.java,v retriev

Re: [Patch] removed deprecated methods and changed variable scope (private-protected) ProjectHelperImpl

2004-12-10 Thread Kev Jackson
We will not be changing private to protected. As much as possible all fields should be private and there should be very few protected methods. For current released code, it is not possible to change protected fields to private fields due to BC consideration. OK, I agree that all fields *should* be

[Patch] DefaultRmicAdapter style changes

2004-12-13 Thread Kev Jackson
- added javadoc - minor tweaks Index: DefaultRmicAdapter.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/rmic/DefaultRmicAdapter.java,v retrieving revision 1.34 diff -u -r1.34 DefaultRmicAdapter.java ---

[Patch] FileUtils more minor changes

2004-12-16 Thread Kev Jackson
- new generic close method - reduces duplicate code (may be useful for when we can finally remove code -> Ant2?) - minor loop tweak - buffer compare for JDK1.4+ (only runs on files < 1Mb to conserve memory during builds) +int stackSize = s.size(); while (tok.hasMoreTokens()) {

[Patch] MSVSS.java

2004-12-16 Thread Kev Jackson
- var names - style - javadoc The first of many... Index: MSVSS.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java,v retrieving revision 1.40 diff -u -r1.40 MSVSS.java --- MSVSS.java

Re: Purpose of FileUtils.close(...)

2004-12-17 Thread Kev Jackson
So what exactly *is* the intention of this method? IMHO, if an IOException was thrown when some stream was closed, it was probably for a reason, and probably something is broken, and probably the user should find out about it - and fix it - rather than have the problem be permanently suppressed

[Patch] style changes + javadoc RCSFile

2004-12-17 Thread Kev Jackson
1659 outstanding errors/warnings... Index: RCSFile.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/cvslib/RCSFile.java,v retrieving revision 1.9 diff -u -r1.9 RCSFile.java --- RCSFile.java9 Mar 20

[Patch] ChangeLogParser - hiding field

2004-12-17 Thread Kev Jackson
removed extra LOC from javadoc whilst I was there - no warnings about the whole cvslib now!! (have to make teh compiler even more strict ;) ) Index: ChangeLogParser.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/a

[Patch] StyleBook var names + javadoc

2004-12-17 Thread Kev Jackson
Index: StyleBook.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/StyleBook.java,v retrieving revision 1.16 diff -u -r1.16 StyleBook.java --- StyleBook.java 9 Mar 2004 16:48:15 - 1

[Patch] TaskLogger variable names + javadoc

2004-12-17 Thread Kev Jackson
Index: TaskLogger.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/util/TaskLogger.java,v retrieving revision 1.9 diff -u -r1.9 TaskLogger.java --- TaskLogger.java 9 Mar 2004 16:48:52 - 1.9 +++ TaskL

Re: [Patch] ChangeLogParser - hiding field

2004-12-20 Thread Kev Jackson
Jesse Glick wrote: Just jumping in here... :-) Feel free ;) kj wrote: -class ChangeLogParser { +public class ChangeLogParser { No really, just habit - company standards where I've worked in past etc. Did your company produce Java components with publicly visible APIs they were committed to prese

[Patch] StringInputStream

2004-12-28 Thread Kev Jackson
- removed unused imports - changed to On a related note: Parameter x must not be null Wouldn't it make sense to throw some kind of exception if parameter x was null? At the beginning of the method, not later on when some other method tries something and gets hit with a NullPointerException. S

[Patch] AbstractCvsTask

2004-12-28 Thread Kev Jackson
- changed a for loop - added a new private method to check for non null params - used new method in the appropriate places Unit test for two changes Kev Index: AbstractCvsTask.java === RCS file: /home/cvspublic/ant/src/main/org/apache

[Patch] removed unused imports (various classes)

2004-12-28 Thread Kev Jackson
- removed unused imports - renamed _copy to copy and changed references to this.copy in Sync task Kev Index: Checksum.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/Checksum.java,v retrieving revision 1.

FileUtils

2004-12-28 Thread Kev Jackson
Would it seriously break backwards compatibility to make the current FileUtils a static class? Looking at Expand earlier, I noticed several protected methods that passed a FileUtils object as a parameter, if the FileUtils class was static we could do away with a parameter being passed all the w

[Patch] removed unused imports

2005-01-05 Thread Kev Jackson
org.apache.tools.ant.taskdefs.optional.junit.BriefJUnitResultFormatter org.apache.tools.ant.taskdefs.optional.junit.XalanExecutor Index: BriefJUnitResultFormatter.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/ta

Re: local properties

2005-01-11 Thread Kev Jackson
Sounds good, but is it possible to get a different name than "let" ? Peter Following the VBness of "let", how about "dim"? ;) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: local properties

2005-01-13 Thread Kev Jackson
I can do that. Is "define" a good name ? Here's one vote for "my". Everyone in the programming community would get that as a scoped entity immediately. I know that we already have global properties and that this is looking at local properties, but could we no tlook further forward (toward

[Patch] oatat.cvslib* & Bug #24569

2005-01-17 Thread Kev Jackson
Made a few changes to try and resolve Bug #24569 - RCSFile checkstyle changes - Name hiding in ChangeLogParser, loc reduce - rewrite of ChangeLogWriter.printEntry() Uses a stringbuffer and prints at the end of the method, doesn't print line by line. May help with the bug, but it may indeed do not

AspectJ logging was [Re: Purpose of FileUtils.close(...)]

2005-01-20 Thread Kev Jackson
Another thought: We could create an AntThread class to tie a Thread to a Project. Most places that currently use Thread constructors would use the same AntThread constructor. The top-level AntThread could be constructed with an explicit Project; others could inherit the Project from the AntThre

Proposal

2005-01-25 Thread Kev Jackson
Hi, I'm working on a project right now with real neophyte developers, and one of the things I'm constantly having to do is to unset classpaths. They keep installing crappy software that sets a classpath variable (Oracle client being the main culprit here) and then when they use the project buil

Re: Proposal

2005-01-25 Thread Kev Jackson
Phil Weighill-Smith wrote: On Tue, 2005-01-25 at 09:22, Erik Hatcher wrote: You may consider creating a custom ant command script which unsets CLASSPATH before invoking the executable class. Exactly what we do! My point was that it shouldn't be set in the first place, unsetting it be

[Patch] manual dates

2005-01-25 Thread Kev Jackson
noticed that the dates in the manual needed to be updated Kev Index: antexternal.html === RCS file: /home/cvspublic/ant/docs/manual/antexternal.html,v retrieving revision 1.5 diff -u -r1.5 antexternal.html --- antexternal.html9 Feb

[Patch] jlink added javadoc

2005-01-25 Thread Kev Jackson
- added javadoc Kev Index: jlink.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/jlink/jlink.java,v retrieving revision 1.15 diff -u -r1.15 jlink.java --- jlink.java 9 Mar 2004 16:48:30 -

Re: Proposal

2005-01-26 Thread Kev Jackson
Matt Benson wrote: --- Steve Loughran <[EMAIL PROTECTED]> wrote: [SNIP] ant -noclasspath does what youwant we could be brutal and make that the default. That is, from ant1.7+ we ignore the classpath unless you request otherwise. We say it was too much a source of trouble and leave it at that.

[Patch] small refactor of MessageDigest

2005-01-31 Thread Kev Jackson
- removed unused code - changed the getValue method to be slightly less verbose - added unit test kev Index: DigestAlgorithm.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/types/selectors/modifiedselector/DigestA

[Patch] org.apache.tools.ant.taskdefs.Ant

2005-02-01 Thread Kev Jackson
- name hiding - html Kev Index: Ant.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/Ant.java,v retrieving revision 1.116 diff -u -r1.116 Ant.java --- Ant.java14 Jan 2005 17:23:37 - 1.116 +++ A

[Patch] Project

2005-02-02 Thread Kev Jackson
- style name hiding Kev Index: Project.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/Project.java,v retrieving revision 1.183 diff -u -r1.183 Project.java --- Project.java14 Jan 2005 10:09:23 - 1

Re: Which algorithm to recommend for ?

2005-02-16 Thread Kev Jackson
There's some mention of a hash called Whirlpool[1] that sounds like it isn't based on the same bit hash as MD5 and SHA-0/1 For ant 1.6.3, a mention that it's not safe to use checksum, but looking forward the cellautomaton hashes sound really cool - shame that they're way more CPU-cycle unfriend

Re: cvs commit: ant/docs/manual/CoreTasks checksum.html

2005-02-17 Thread Kev Jackson
But can the forged file with identical MD5 masquerade as the original file, i.e. still be a Zip file, or tar'd gzipped or bzipped file? Sure, what you describe sounds bad, but I'm trying to figure out (without too much research of my own ;-) if it's a real problem in practice. --DD In practice the

[Patch] Externalize messages

2005-02-22 Thread Kev Jackson
This patch extracts (some) of the usage messages from o.a.t.a.Main into a resource bundle for easier editing/i18n. - externalized strings (Main) - name-hiding (Main) - use StringUtils.LINE_SEP instead of locally getting line.seperator property (Main + other classes), I didn't get chance to repla

Re: 1.7 release timetable & features.

2005-02-24 Thread Kev Jackson
you know, this summer will mark the two year point since Ant 1,6.0 shipped. Which means time for Ant1.7 is nearing. That long? Should we be organised, build up a list of features and then either start doing them or scrub them from the list? I think that without a list it would be too easy to ge

[Patch] extensions - use StringUtils, name hiding, some Javadoc

2005-02-25 Thread Kev Jackson
- reduced LOC - name hiding - some JavaDoc spelling fixes - use of StringUtils.LINE_SEP - List not ArrayList for methods (use interface not concrete class suggestion from PMD) Kev Index: Extension.java === RCS file: /home/cvspublic/

[Patch] JavaCC, more name hiding etc

2005-02-25 Thread Kev Jackson
- name hiding - unused imports - old/commented code Index: JJDoc.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/javacc/JJDoc.java,v retrieving revision 1.12 diff -u -r1.12 JJDoc.java --- JJDoc.j

[Patch] modifiedselector, style, remove unused code, slightly more lazy DigestAlgorithm.getValue

2005-02-28 Thread Kev Jackson
- removed iterator code fromModifiedSelector - lazier DigestAlgorithm.getValue (includes JUnit test) - removed unncecessary nesting in EqualsComparator // // - Instantiate the interfaces - // String className = null; String pkg = "org.apache.tools.ant.ty

[Patch] modifiedselector, style, remove unused code, slightly more lazy DigestAlgorithm.getValue (now with added source code -doh!)

2005-02-28 Thread Kev Jackson
- removed iterator code fromModifiedSelector - lazier DigestAlgorithm.getValue (includes JUnit test) - removed unncecessary nesting in EqualsComparator // // - Instantiate the interfaces - // String className = null; String pkg = "org.apache.tools.ant.types.s

Re: AW: [Patch] modifiedselector, style, remove unused code, slightly more lazy DigestAlgorithm.getValue (now with added source code -doh!)

2005-02-28 Thread Kev Jackson
Why you use the for-loop instead of iterator? 1 iterator has to check underlying array bounds for every hasNext(), and every next(), checking is slow, and in this case unecessary 2 iterator call to hasNext() each time around the loop - again we can call size() once and cache the result, sinc

[Patch] condition, minor style, removed extra lines, slight javadoc tweak

2005-02-28 Thread Kev Jackson
- unnecessary nesting (if/else with early return) - -> javadoc - extra lines removed Index: Http.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/condition/Http.java,v retrieving revision 1.13 diff -u -r

Massively OT, 'Closures in Java' [was Re: AW: [Patch] modifiedselector, style, remove unused code, slightly more lazy DigestAlgorithm.getValue (now with added source code -doh!)]

2005-02-28 Thread Kev Jackson
Jose Alberto Fernandez wrote: Just one comment on your ClosureUtils.map() method. Although this code may be very good for ArrayList, I think it will behave quite bad for LinkList arguments where the cost of List.get(i) is quite expensive. When I read this, I thought "Doh! you're right none-seque

Re: Massively OT, 'Closures in Java' [was Re: AW: [Patch] modifiedselector, style, remove unused code, slightly more lazy DigestAlgorithm.getValue (now with added source code -doh!)]

2005-02-28 Thread Kev Jackson
Jose Alberto Fernandez wrote: AFAIU, LinkedList.get(N) requires traversing the list to position N on every call [O(n^2)], so usage of an iteratoe is much cheaper on this case as there is no array behind the scenes. Jose Alberto I've just worked out why it's ok to do it this way (with respect t

Re: Execute. getProcEnvironment()

2005-03-01 Thread Kev Jackson
Steve Loughran wrote: seeing the install notes for eclipse shows up what they think are troublespots with ant, one of them being that hangs: http://issues.apache.org/bugzilla/show_bug.cgi?id=26770 I think we ought to take a look at this code, and rework it some more. It is all built around ex

Ant documentation

2005-03-02 Thread Kev Jackson
Since there has been some discussion about prodcuing better docs on the list I thought I'd look into it. I've recently debugged the AspectJ teams docbook, so I've had my head in the docbook format/FOP for a couple of weeks. I've just got a basic transform to PDF done of the first section (real

Ant docs again

2005-03-02 Thread Kev Jackson
Sorry didn't seem to attach last time? I'll create a bug rep and upload to that as its probably more sensible than spamming everyone with a pdf hey. Kev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail:

Re: manual with css

2005-03-07 Thread Kev Jackson
[snip] h4 { color: #ff; background-color: #828DA6; } td { background-color: ee; color:00; } pre { background-color: efefef; } I would like to add a reference to the css file for the non-generated pages. It probablly should be a different stylesheet file that the ant

Re: AW: manual with css

2005-03-07 Thread Kev Jackson
[EMAIL PROTECTED] wrote: What do people think about this? first look is good, some differences, but I have to look deeper into that. (comparing echo-css with subant) Is ee like a soft grey? yep. RGB 00=black FF=white The generated docs are generated from the xdocs ri

Re: Ant documentation

2005-03-09 Thread Kev Jackson
I tried to use docbook and ended up hating it too. Not enough macros see, you may be describing structure rather than style , but what I want is and , independent of the structure to use. Also, as it doesnt cross-ref across docs, it is not as good as bibtex. I have stopped using it for now;

[patch] javadoc/html Upper->lowercase

2005-03-10 Thread Kev Jackson
- lowercase tags - removed some nesting I'm seeing a lot of empty default constructors. Is there a policy for keeping these? I get moans about uncommented empty blocks, but I'd rather remove them if they aren't required Kev Index: org/apache/tools/ant/ExitStatusException.java =

  1   2   3   4   >