Hi all,
Some lurker ;) spotted this commit and got in touch with me.
I copied over the code from the svn trunk version without looking too
carefully (my bad), unless anyone can tell me that this is correct, I
agree that at least semantically it's utter crap :)
I think I should modify both the svn trunk and 1.7 branch to:
public void setCreateFile(boolean createFile) {
this.createFile = createFile;
}
Thoughts?
Kev
>>>
Hi Kev,
You don't know me; I subscribe to the various ant lists (ant-user,
ant-dev, ant-cvs). I saw the below check-in and it just struck me as
wrong (I don't think createFile should be set to the value of
deleteOnExit); given that you're trying to get an alpha out, I thought
I'd bring it to your attention. If it's correct, then please forgive the
intrusion.
Rick
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Sent: Sunday, November 11, 2007 6:41 PM
To: [EMAIL PROTECTED]
Subject: svn commit: r594009 -
/ant/core/branches/ANT_17_BRANCH/src/main/org/apache/tools/ant
/taskdefs/TempFile.java
[snipped]
URL:
http://svn.apache.org/viewvc/ant/core/branches/ANT_17_BRANCH/src/main/or
g/apache/tools/ant/taskdefs/TempFile.java?rev=594009&r1=594008&r2=594009
&view=diff
========================================================================
======
[snipped]
@@ -123,6 +126,22 @@
public boolean isDeleteOnExit() {
return deleteOnExit;
}
+
+ /**
+ * If set the file is actually created, if not just a
name is created.
+ * @param createFile boolean flag.
+ */
+ public void setCreateFile(boolean createFile) {
+ this.createFile = deleteOnExit;
+ }
+
+ /**
+ * Learn whether createFile flag is set for this tempfile task.
+ * @return the createFile flag.
+ */
+ public boolean isCreateFile() {
+ return createFile;
+ }
/**
* Creates the temporary file.
--
Rick Genter
Principal Software Engineer
Silverlink Communications
[EMAIL PROTECTED]
www.silverlink.com
Office (781) 425-5763
Mobile (781) 771-9677
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
