- change visibility from private to protected for private inner classes (ClassFileInfo)
rational: because Eclipse whines about it
"Read access to enclosing field Depend.ClassFileInfo.isUserWarned is emulated by a synthetic accessor method. Increasing it's visibility will improve your performance"
There are a few of these scattered about in the code. If no-one has an issue with changing the visibility of these (within one class), then I'm happy to change them all.
Kev
Index: Depend.java
===================================================================
RCS file:
/home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java,v
retrieving revision 1.45
diff -u -r1.45 Depend.java
--- Depend.java 22 Nov 2004 09:23:33 -0000 1.45
+++ Depend.java 9 Dec 2004 11:57:52 -0000
@@ -48,16 +48,16 @@
*/
private static class ClassFileInfo {
/** The file where the class file is stored in the file system */
- private File absoluteFile;
+ protected File absoluteFile;
/** The Java class name of this class */
- private String className;
+ protected String className;
/** The source File containing this class */
- private File sourceFile;
+ protected File sourceFile;
/** if user has been warned about this file not having a source file */
- private boolean isUserWarned = false;
+ protected boolean isUserWarned = false;
}
/** The path where source files exist */--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
