[PR] IVY-1651: improved documentation regarding patterns and retrieve task [ant-ivy]

2024-11-17 Thread via GitHub
maartenc opened a new pull request, #103: URL: https://github.com/apache/ant-ivy/pull/103 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] IVY-1651: improved documentation regarding patterns and retrieve task [ant-ivy]

2024-11-17 Thread via GitHub
maartenc merged PR #103: URL: https://github.com/apache/ant-ivy/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

[GitHub] [ant] jaikiran commented on pull request #204: bz-66552 fix Depend task does not handle Dynamic constant pool entries - java.lang.ClassFormatError: Invalid Constant Pool entry Type 17

2023-09-11 Thread via GitHub
jaikiran commented on PR #204: URL: https://github.com/apache/ant/pull/204#issuecomment-1715096911 Thank you @jmichelberger for this patch, this looks OK to me and I've now merged it and I have added you to our contributors list. The patch doesn't have a test case, I'm guessing that you we

[GitHub] [ant] asfgit closed pull request #204: bz-66552 fix Depend task does not handle Dynamic constant pool entries - java.lang.ClassFormatError: Invalid Constant Pool entry Type 17

2023-09-11 Thread via GitHub
asfgit closed pull request #204: bz-66552 fix Depend task does not handle Dynamic constant pool entries - java.lang.ClassFormatError: Invalid Constant Pool entry Type 17 URL: https://github.com/apache/ant/pull/204 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [ant] jmichelberger opened a new pull request, #204: bz-66552 fix Depend task does not handle Dynamic constant pool entries - java.lang.ClassFormatError: Invalid Constant Pool entry Type 17

2023-09-11 Thread via GitHub
jmichelberger opened a new pull request, #204: URL: https://github.com/apache/ant/pull/204 In cases the Depend task scans a class file with Constant Pool entry Type 17 there was no handling, just fireing an Exception. Constant is defined since JDK11, and format is same as InvokeDynamic

[GitHub] [ant] asfgit closed pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-04-18 Thread via GitHub
asfgit closed pull request #197: Handling forked VM timeout in a similar way to junit ant task URL: https://github.com/apache/ant/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ant] jaikiran commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-04-18 Thread via GitHub
jaikiran commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1512565293 The change in this PR looks fine to me. A test can be added separately - I haven't found the time to try and help you get the test implemented/run. I'll go ahead and merge this now and will ad

[GitHub] [ant] tkowalcz commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-02-20 Thread via GitHub
tkowalcz commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1436945641 @jaikiran I'm sorry but I was unable to run the tests. After implementing your instructions the `LegacyXmlResultFormatterTest` was run but there was no mention of `JUnitLauncherTaskTest` being

[GitHub] [ant] tkowalcz commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-02-06 Thread via GitHub
tkowalcz commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1419282632 Thanks. I will give it a try and let you know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ant] jaikiran commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-02-06 Thread via GitHub
jaikiran commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1419267691 > When I build the project the tests do not seem to be executed Some of the tasks in Ant, including the `junitlauncher` aren't part of the "core". You will have to first fetch the depen

[GitHub] [ant] tkowalcz commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-02-06 Thread via GitHub
tkowalcz commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1419257202 Hi, actually I had problems running the tests in the first place. When I build the project the tests do not seem to be executed (build pass even when I introduce failing assertion). I can late

[GitHub] [ant] jaikiran commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-02-06 Thread via GitHub
jaikiran commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1419253719 Hello Tomasz, I don't want to rush you, but if writing a test is proving to be time consuming or complicated, do let me know and I'll merge this fix (which looks good to me) and I'll add a tes

Re: Pass secret to Exec task

2023-01-31 Thread Stefan Bodewig
On 2023-01-30, Gilles Querret wrote: > I have to pass a secret to an Exec task (in a custom Ant plugin), and one > way to do that is to pipe the output of another command line to this exec > task. Unfortunately there is no direct support for pipes. > I've tried setInp

Pass secret to Exec task

2023-01-30 Thread Gilles Querret
Hello, I have to pass a secret to an Exec task (in a custom Ant plugin), and one way to do that is to pipe the output of another command line to this exec task. First, is there a way to programmatically pass the output this command line to an Exec task ? Usage of my task would be something like

[GitHub] [ant] tkowalcz commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-01-16 Thread GitBox
tkowalcz commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1383728622 Thanks for review. I will make changes as you suggested and of course write a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [ant] tkowalcz commented on a diff in pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-01-16 Thread GitBox
tkowalcz commented on code in PR #197: URL: https://github.com/apache/ant/pull/197#discussion_r1071004085 ## src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/confined/JUnitLauncherTask.java: ## @@ -330,7 +330,20 @@ private void forkTest(final TestDefinition test) {

[GitHub] [ant] tkowalcz commented on a diff in pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-01-16 Thread GitBox
tkowalcz commented on code in PR #197: URL: https://github.com/apache/ant/pull/197#discussion_r1071003296 ## src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/confined/JUnitLauncherTask.java: ## @@ -330,7 +330,20 @@ private void forkTest(final TestDefinition test) {

[GitHub] [ant] jaikiran commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-01-12 Thread GitBox
jaikiran commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1381175943 Thank you Tomasz for this PR. I think this change looks fine. Could you add a test case to verify this change works as expected. We have a junitlauncher test class at `src/tests/junit/org/apa

[GitHub] [ant] jaikiran commented on a diff in pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-01-12 Thread GitBox
jaikiran commented on code in PR #197: URL: https://github.com/apache/ant/pull/197#discussion_r1068816591 ## src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/confined/JUnitLauncherTask.java: ## @@ -330,7 +330,20 @@ private void forkTest(final TestDefinition test) {

[GitHub] [ant] jaikiran commented on a diff in pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-01-12 Thread GitBox
jaikiran commented on code in PR #197: URL: https://github.com/apache/ant/pull/197#discussion_r1068816123 ## src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/confined/JUnitLauncherTask.java: ## @@ -330,7 +330,20 @@ private void forkTest(final TestDefinition test) {

[GitHub] [ant] sfllaw commented on pull request #173: Allow ant:get task to disable authentication on redirect.

2022-06-02 Thread GitBox
sed. See also: * [Bad Request (400) from S3 when downloading artifact from TeamCity in "ant get" task using basic http auth scheme (httpAuth prefix in URL) ](https://github.com/JetBrains/teamcity-s3-artifact-storage-plugin/tree/0dcc5c04d514cc23e7369b7e092924f67abfc7e8#bad-reques

[GitHub] [ant] sfllaw commented on pull request #173: Allow ant:get task to disable authentication on redirect.

2022-06-02 Thread GitBox
sfllaw commented on PR #173: URL: https://github.com/apache/ant/pull/173#issuecomment-1145242151 82f5edcf49002943773a165464e152b1d75a68a8 changed the default value of `authenticateOnRedirect` from true to false, which is backwards incompatible but is actually proper behaviour. -- This is

[GitHub] [ant] bodewig commented on pull request #173: Allow ant:get task to disable authentication on redirect.

2021-12-23 Thread GitBox
bodewig commented on pull request #173: URL: https://github.com/apache/ant/pull/173#issuecomment-1000436715 you are right @jaikiran, I'll change the default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [ant] jaikiran commented on pull request #173: Allow ant:get task to disable authentication on redirect.

2021-12-22 Thread GitBox
jaikiran commented on pull request #173: URL: https://github.com/apache/ant/pull/173#issuecomment-129159 >Therefore I didn't change the default behavior to avoid breaking existing Ant scripts. This means, "authenticateOnRedirect" defaults to "true". But maybe it would be better to chan

[GitHub] [ant] bodewig commented on pull request #173: Allow ant:get task to disable authentication on redirect.

2021-12-22 Thread GitBox
bodewig commented on pull request #173: URL: https://github.com/apache/ant/pull/173#issuecomment-999741812 many thanks @bernolanger we'd like to credit you in CONTRIBUTORS and contributors.xml. What is the name you'd want us to use? -- This is an automated message from the Apache

[GitHub] [ant] bodewig merged pull request #173: Allow ant:get task to disable authentication on redirect.

2021-12-22 Thread GitBox
bodewig merged pull request #173: URL: https://github.com/apache/ant/pull/173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.

[GitHub] [ant] bernolanger opened a new pull request #173: Allow ant:get task to disable authentication on redirect.

2021-12-20 Thread GitBox
bernolanger opened a new pull request #173: URL: https://github.com/apache/ant/pull/173 Most clients do not send the Authorization header on redirects by default; because of security issues. The ant:get task instead, always sends the Authorization header to the redirected location

[GitHub] [ant-ivy] maartenc merged pull request #95: IVY-1631: ivy:retrieve Ant task and empty FileSet bug

2021-11-24 Thread GitBox
maartenc merged pull request #95: URL: https://github.com/apache/ant-ivy/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@a

[GitHub] [ant-ivy] jaikiran commented on pull request #95: IVY-1631: ivy:retrieve Ant task and empty FileSet bug

2021-11-24 Thread GitBox
jaikiran commented on pull request #95: URL: https://github.com/apache/ant-ivy/pull/95#issuecomment-977880327 Thank you Maarten for the updated tests. They look fine to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [ant-ivy] maartenc commented on pull request #95: IVY-1631: ivy:retrieve Ant task and empty FileSet bug

2021-11-24 Thread GitBox
maartenc commented on pull request #95: URL: https://github.com/apache/ant-ivy/pull/95#issuecomment-977820162 Thanks for the review @jaikiran, the path creation is ok (we use that as a workaround for the moment), but just to be sure I've added some extra checks to the junit test. I'

[GitHub] [ant-ivy] jaikiran commented on pull request #95: IVY-1631: ivy:retrieve Ant task and empty FileSet bug

2021-11-23 Thread GitBox
jaikiran commented on pull request #95: URL: https://github.com/apache/ant-ivy/pull/95#issuecomment-977473905 Hello @maartenc, this looks good to me. One question - The `retrieve` also has a `pathId` which creates a path out of the retrieved artifacts. Is that affected by this issue too an

[GitHub] [ant-ivy] maartenc opened a new pull request #95: IVY-1631: ivy:retrieve Ant task and empty FileSet bug

2021-11-23 Thread GitBox
maartenc opened a new pull request #95: URL: https://github.com/apache/ant-ivy/pull/95 IVY-1631: when the ivy:retrieve Ant task retrieves the jars to a non-empty directory, but the retrieve task itself didn't retrieve any files, the created fileset was not empty but contained the exi

[GitHub] [ant] bodewig commented on pull request #142: Tar-task: using should preserve symlinks

2021-09-28 Thread GitBox
bodewig commented on pull request #142: URL: https://github.com/apache/ant/pull/142#issuecomment-928173847 added, thanks @mstrap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [ant] bodewig commented on pull request #142: Tar-task: using should preserve symlinks

2021-09-27 Thread GitBox
bodewig commented on pull request #142: URL: https://github.com/apache/ant/pull/142#issuecomment-928173847 added, thanks @mstrap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [ant] mstrap commented on pull request #142: Tar-task: using should preserve symlinks

2021-09-27 Thread GitBox
mstrap commented on pull request #142: URL: https://github.com/apache/ant/pull/142#issuecomment-927796386 Thanks, @bodewig ! Please use "Marc Strapetz". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [ant] bodewig commented on pull request #142: Tar-task: using should preserve symlinks

2021-09-25 Thread GitBox
bodewig commented on pull request #142: URL: https://github.com/apache/ant/pull/142#issuecomment-927106646 many thanks @mstrap I'd like to add you to the contributors list (CONTRIBUTORS and contributors.xml), which name shall I use? -- This is an automated message from the Apache

[GitHub] [ant] asfgit merged pull request #142: Tar-task: using should preserve symlinks

2021-09-25 Thread GitBox
asfgit merged pull request #142: URL: https://github.com/apache/ant/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.a

Re: Upcoming Java 17 release will have an impact on our javadoc task

2021-09-04 Thread Jaikiran Pai
penjdk.java.net/browse/JDK-8200363 (-Xwerror in JDK8 and -Werror on recent versions). I wanted to try and use it in our javadoc task, but it turned out not to be straightforward since we need to add javadoc tool version checks to get it to work in all versions of the tool. Plus, even after adding

Re: new warnings produced by task under Open JDK 17-ea+28-2534

2021-06-29 Thread Rick Hillegas
whole security manager based implementation will be impacted and needs a rethink. For the java task, we by default apply certain permissions when run without "fork". That's what is triggering this warning. It has been there in the build 26 EA of JDK 17 as well - of course, th

Re: new warnings produced by task under Open JDK 17-ea+28-2534

2021-06-28 Thread Jaikiran Pai
r on this front before coming up with any proposal in the Ant project on how to deal with this. Clearly our permissions[2] type and the whole security manager based implementation will be impacted and needs a rethink. For the java task, we by default apply certain permissions when run without

Re: new warnings produced by task under Open JDK 17-ea+28-2534

2021-06-28 Thread Rick Hillegas
front before coming up with any proposal in the Ant project on how to deal with this. Clearly our permissions[2] type and the whole security manager based implementation will be impacted and needs a rethink. For the java task, we by default apply certain permissions when run without "for

Re: new warnings produced by task under Open JDK 17-ea+28-2534

2021-06-27 Thread Jaikiran Pai
this. Clearly our permissions[2] type and the whole security manager based implementation will be impacted and needs a rethink. For the java task, we by default apply certain permissions when run without "fork". That's what is triggering this warning. It has been there in the buil

new warnings produced by task under Open JDK 17-ea+28-2534

2021-06-27 Thread Rick Hillegas
Open JDK 17 build 17-ea+28-2534 causes the ant 1.10.6 task to produce the following warnings when you DON'T fork the JVM: WARNING: A terminally deprecated method in java.lang.System has been called WARNING: System::setSecurityManager has been called by org.apache.tools.ant.types.Permis

Re: Upcoming Java 17 release will have an impact on our javadoc task

2021-06-27 Thread Stefan Bodewig
d expect that build tools try to parse output when we've never provided a Java API to run a typical build task? Sorry. > So right now I don't have specific proposals for fixing this but just > a note that we will have to look into this one for the upcoming JDK 17 > release. I g

Upcoming Java 17 release will have an impact on our javadoc task

2021-06-16 Thread Jaikiran Pai
lease the behaviour has changed in the javadoc tool and it now logs those messages to STDERR. This change was discussed in the OpenJDK mailing list[1] and it has been noted that this is an intentional change in the tool. Specifically for the javadoc task in Ant project, it has a "fai

[GitHub] [ant] mstrap opened a new pull request #142: Tar-task: using should preserve symlinks

2020-12-10 Thread GitBox
mstrap opened a new pull request #142: URL: https://github.com/apache/ant/pull/142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: Script task specification

2020-07-01 Thread Alexey Solofnenko
idReferences.put(id, value); > >> } > >> > >> But I haven't found a place where this private field is read... > >> > >> > >> Jan > >> > >> > >> > >> > -Ursprüngliche Nachricht- > >>

Re: Script task specification

2019-11-01 Thread Gintautas Grigelionis
idReferences.put(id, value); >> } >> >> But I haven't found a place where this private field is read... >> >> >> Jan >> >> >> >> > -Ursprüngliche Nachricht- >> > Von: Jan Matèrne (jhm) [mailto:apa...@materne.de]

Re: Script task specification

2019-10-30 Thread Gintautas Grigelionis
value); > } > > But I haven't found a place where this private field is read... > > > Jan > > > > > -Ursprüngliche Nachricht- > > Von: Jan Matèrne (jhm) [mailto:apa...@materne.de] > > Gesendet: Dienstag, 29. Oktober 2019 08:48 > >

AW: Script task specification

2019-10-29 Thread jhm
t found a place where this private field is read... Jan > -Ursprüngliche Nachricht- > Von: Jan Matèrne (jhm) [mailto:apa...@materne.de] > Gesendet: Dienstag, 29. Oktober 2019 08:48 > An: 'Ant Developers List' > Betreff: AW: Script task specification > >

AW: Script task specification

2019-10-29 Thread jhm
An: 'Ant Developers List' > Betreff: AW: Script task specification > > It seems that the task must be executed before. > If you add a >depends="sub"< on the main target, that works. > > So the question is: when are id's stored? > The parsing is

AW: Script task specification

2019-10-29 Thread jhm
It seems that the task must be executed before. If you add a >depends="sub"< on the main target, that works. So the question is: when are id's stored? The parsing is done via ProjectHelper's and their SAX-Parser-Handlers. On the first view I would say, that the id is

Re: Script task specification

2019-10-28 Thread Stefan Bodewig
On 2019-10-28, Gintautas Grigelionis wrote: > The documentation of the script task states: > "All items (tasks, targets, etc) of the running project are accessible from > the script, using either their name or id attributes (as long as their > names are considered valid Java ide

Script task specification

2019-10-28 Thread Gintautas Grigelionis
The documentation of the script task states: "All items (tasks, targets, etc) of the running project are accessible from the script, using either their name or id attributes (as long as their names are considered valid Java identifiers, that is). " However, the follo

Re: (source/target/release) argument passing to javac task is broken in master

2019-08-25 Thread jkf
project build no longer honours the source, target and release attributes of the javac task for versions of javac that support it. For example when building with Java 11 our "compile" target in build.xml although has the correct attribute values, those values never get passed to the underly

Re: (source/target/release) argument passing to javac task is broken in master

2019-08-25 Thread Jaikiran Pai
ect build no longer honours the source, target and >> release attributes of the javac task for versions of javac that support >> it. For example when building with Java 11 our "compile" target in >> build.xml although has the correct attribute values, those values never &g

Re: (source/target/release) argument passing to javac task is broken in master

2019-08-25 Thread jkf
attributes of the javac task for versions of javac that support it. For example when building with Java 11 our "compile" target in build.xml although has the correct attribute values, those values never get passed to the underlying javac call. As a result, the compiled classes use an incor

(source/target/release) argument passing to javac task is broken in master

2019-08-25 Thread Jaikiran Pai
Hello Martijn, I was in the process of running some tests to decide if we are in a state to do a release of Ant project. While doing so, I ran into an issue where our project build no longer honours the source, target and release attributes of the javac task for versions of javac that support it

[GitHub] [ant] jaikiran commented on issue #89: Added version and mainClass attributes to task.

2019-03-28 Thread GitBox
jaikiran commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-477867207 While you are here, a quick suggestion/question - given that these changes are related to Java modules in general and there probably will be

[GitHub] [ant] asfgit commented on issue #89: Added version and mainClass attributes to task.

2019-03-28 Thread GitBox
asfgit commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-477866471 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/115

[GitHub] [ant] asfgit commented on issue #89: Added version and mainClass attributes to task.

2019-03-28 Thread GitBox
asfgit commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-477865927 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/121

[GitHub] [ant] jaikiran commented on issue #89: Added version and mainClass attributes to task.

2019-03-28 Thread GitBox
jaikiran commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-477864675 Thanks @craigpell, this is a very good enhancement and the code looks very good too. I do have some suggestions/questions about some of the

[GitHub] [ant] jaikiran commented on a change in pull request #89: Added version and mainClass attributes to task.

2019-03-28 Thread GitBox
jaikiran commented on a change in pull request #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#discussion_r270277284 ## File path: manual/Tasks/jar.html ## @@ -217,6 +217,23 @@ Parameters include META-INF unless

[GitHub] [ant] asfgit commented on issue #89: Added version and mainClass attributes to task.

2019-03-24 Thread GitBox
asfgit commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-476032427 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/120

[GitHub] [ant] asfgit commented on issue #89: Added version and mainClass attributes to task.

2019-03-24 Thread GitBox
asfgit commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-476032382 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/114

[GitHub] [ant] jaikiran commented on issue #89: Added version and mainClass attributes to task.

2019-03-24 Thread GitBox
jaikiran commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-476030934 this is ok to test This is an automated message from the Apache Git Service

[GitHub] [ant] twogee commented on a change in pull request #89: Added version and mainClass attributes to task.

2019-03-24 Thread GitBox
twogee commented on a change in pull request #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#discussion_r268423686 ## File path: src/main/org/apache/tools/ant/util/jarattr/Constant.java ## @@ -0,0 +1,147 @@ +/* Review

[GitHub] [ant] twogee commented on a change in pull request #89: Added version and mainClass attributes to task.

2019-03-24 Thread GitBox
twogee commented on a change in pull request #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#discussion_r268423359 ## File path: src/main/org/apache/tools/ant/util/jarattr/ClassFormatException.java ## @@ -0,0 +1,59

[GitHub] [ant] twogee commented on a change in pull request #89: Added version and mainClass attributes to task.

2019-03-24 Thread GitBox
twogee commented on a change in pull request #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#discussion_r268423028 ## File path: manual/Tasks/jar.html ## @@ -385,6 +402,40 @@ service a JAR file has more that one

[GitHub] [ant] twogee commented on a change in pull request #89: Added version and mainClass attributes to task.

2019-03-24 Thread GitBox
twogee commented on a change in pull request #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#discussion_r268422972 ## File path: manual/Tasks/jar.html ## @@ -217,6 +217,23 @@ Parameters include META-INF unless

[GitHub] [ant] twogee commented on a change in pull request #89: Added version and mainClass attributes to task.

2019-03-24 Thread GitBox
twogee commented on a change in pull request #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#discussion_r268422972 ## File path: manual/Tasks/jar.html ## @@ -217,6 +217,23 @@ Parameters include META-INF unless

[GitHub] [ant] asfgit commented on issue #89: Added version and mainClass attributes to task.

2019-03-23 Thread GitBox
asfgit commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-475891810 Can one of the admins verify this patch? This is an automated message from the

[GitHub] [ant] asfgit commented on issue #89: Added version and mainClass attributes to task.

2019-03-23 Thread GitBox
asfgit commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-475891809 Can one of the admins verify this patch? This is an automated message from the

[GitHub] [ant] asfgit commented on issue #89: Added version and mainClass attributes to task.

2019-03-23 Thread GitBox
asfgit commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-475891807 Can one of the admins verify this patch? This is an automated message from the

[GitHub] [ant] asfgit commented on issue #89: Added version and mainClass attributes to task.

2019-03-23 Thread GitBox
asfgit commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-475891806 Can one of the admins verify this patch? This is an automated message from the

[GitHub] [ant] craigpell opened a new pull request #89: Added version and mainClass attributes to task.

2019-03-23 Thread GitBox
craigpell opened a new pull request #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89 Added version and mainClass attributes to task, to set binary attributes of a modular jar file. For Ant 1.10.x. Addresses these tickets: https

Re: ant git commit: bz-62890 Make sure the sync task considers the case sensitivity of the destination directory's filesystem while looking for orphan files to delete

2018-11-12 Thread Jaikiran Pai
Hi Stefan, On 12/11/18 11:26 PM, Stefan Bodewig wrote: > On 2018-11-08, wrote: > >> +private static final Map fileSystemCaseSensitivity >> = new HashMap<>(); > I understand it may be expensive to determine whether a filesystem is > case-sensitive, but I'm a bit hesitant about the cache as it

Re: ant git commit: bz-62890 Make sure the sync task considers the case sensitivity of the destination directory's filesystem while looking for orphan files to delete

2018-11-12 Thread Stefan Bodewig
On 2018-11-08, wrote: > +private static final Map fileSystemCaseSensitivity > = new HashMap<>(); I understand it may be expensive to determine whether a filesystem is case-sensitive, but I'm a bit hesitant about the cache as it never gets cleared if things run for a long time. Stefan

[GitHub] ant issue #76: bz-43144 - Improve the performance of the tar task when it us...

2018-11-06 Thread jaikiran
lections in some places. You are right, plus unlike the `tar` task, the way `Resource`(s) are passed around, it isn't that straightforward to keep track of them. I might still find a way similar to this to get those covered too. I'll spend some more time on this

[GitHub] ant issue #76: bz-43144 - Improve the performance of the tar task when it us...

2018-11-04 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/76 Quite a bit of code :-) Looks as if you had found a solution with minimal API impact that can be extended to cases other than just `tar` although I'm afraid we are using resource collections wrapping

[GitHub] ant issue #76: bz-43144 - Improve the performance of the tar task when it us...

2018-11-04 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/76 Quite a bit of code :-) Looks as if you had found a solution with minimal API impact that can be extended to cases other than just `tar` although I'm afraid we are using resource collections wrapping

[GitHub] ant issue #76: bz-43144 - Improve the performance of the tar task when it us...

2018-11-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/76 I'm going to put this on hold for a bit and won't merge it yet, for the reasons noted in the recent comments in the linked issue. --- -

[GitHub] ant pull request #76: bz-43144 - Improve the performance of the tar task whe...

2018-11-01 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/76 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #76: bz-43144 - Improve the performance of the tar task when it us...

2018-10-31 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/76 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/82/ --- --

[GitHub] ant issue #76: bz-43144 - Improve the performance of the tar task when it us...

2018-10-31 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/76 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/88/ ---

[GitHub] ant pull request #76: bz-43144 - Improve the performance of the tar task whe...

2018-10-31 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/76 bz-43144 - Improve the performance of the tar task when it uses a zipfileset https://bz.apache.org/bugzilla/show_bug.cgi?id=43144 is an issue where users have reported that the tar task is extremely

[GitHub] ant pull request #68: bz-62655 throw a BuildException from augment task

2018-08-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant/pull/68 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #68: bz-62655 throw a BuildException from augment task

2018-08-25 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/68 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/84/ ---

[GitHub] ant issue #68: bz-62655 throw a BuildException from augment task

2018-08-25 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/68 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/78/ --- --

[GitHub] ant pull request #68: bz-62655 throw a BuildException from augment task

2018-08-25 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/68 bz-62655 throw a BuildException from augment task Reference https://bz.apache.org/bugzilla/show_bug.cgi?id=62655 The manual of the augment task[1] states that it's supposed to th

Re: junitlauncher task - support for system properties in a non-forked execution

2018-08-21 Thread Jaikiran Pai
Hi Stefan, On 22/08/18 12:00 AM, Stefan Bodewig wrote: > On 2018-08-16, Jaikiran Pai wrote: > >> However, I would like some inputs on whether such support for setting >> the system properties in a non-forked execution should be at the >> junitlauncher task level

Re: junitlauncher task - support for system properties in a non-forked execution

2018-08-21 Thread Stefan Bodewig
On 2018-08-16, Jaikiran Pai wrote: > While working on the documentation of the junitlauncher task, for fork > support, I realized that when we first released this task, due to an > oversight, I did not add support for setting system properties or > environment variables through th

junitlauncher task - support for system properties in a non-forked execution

2018-08-16 Thread Jaikiran Pai
While working on the documentation of the junitlauncher task, for fork support, I realized that when we first released this task, due to an oversight, I did not add support for setting system properties or environment variables through this task. The fork element now supports that[1] in the

Re: mail task

2018-08-13 Thread Jaikiran Pai
Thank you for reporting the issue and testing the fix, Simon. -Jaikiran On 14/08/18 1:39 AM, Simon IJskes - QCG wrote: > fix works. Thanks! > > On 08/13/2018 09:55 PM, Simon IJskes - QCG wrote: >> https://bz.apache.org/bugzilla/show_bug.cgi?id=62621 >> >> On 08/13/2018 06:07 PM, Jaikiran Pai wro

Re: mail task

2018-08-13 Thread Simon IJskes - QCG
fix works. Thanks! On 08/13/2018 09:55 PM, Simon IJskes - QCG wrote: https://bz.apache.org/bugzilla/show_bug.cgi?id=62621 On 08/13/2018 06:07 PM, Jaikiran Pai wrote: Hi Simon, Yes, you can file a bug. I'll update it to record that it's been handled in an upcoming release. As usual, our nightl

Re: mail task

2018-08-13 Thread Simon IJskes - QCG
https://bz.apache.org/bugzilla/show_bug.cgi?id=62621 On 08/13/2018 06:07 PM, Jaikiran Pai wrote: Hi Simon, Yes, you can file a bug. I'll update it to record that it's been handled in an upcoming release. As usual, our nightly builds are available[1] to test this fix, till the release is ready.

Re: mail task

2018-08-13 Thread Jaikiran Pai
ches to include a >> change which should bring in the right jars as part of the fetch. >> >> In near future, I'll try and update our mail task tests to be a bit more >> robust for checking the basic usage of this task. >> >> -Jaikiran >> >> >>

Re: mail task

2018-08-13 Thread Simon IJskes - QCG
near future, I'll try and update our mail task tests to be a bit more robust for checking the basic usage of this task. -Jaikiran On 13/08/18 7:17 PM, Jaikiran Pai wrote: Yes, it looks like one of our changes broke this. We seem to just fetch the mail API jar(s) and no longer fetch the jars

Re: mail task

2018-08-13 Thread Jaikiran Pai
I pushed a commit to both our 1.9.x and master branches to include a change which should bring in the right jars as part of the fetch. In near future, I'll try and update our mail task tests to be a bit more robust for checking the basic usage of this task. -Jaikiran On 13/08/18 7:

Re: mail task

2018-08-13 Thread Jaikiran Pai
Yes, it looks like one of our changes broke this. We seem to just fetch the mail API jar(s) and no longer fetch the jars which includethe provider implementation(s). Can you please file a bug for this, in the Ant bugzilla? -Jaikiran On 13/08/18 7:13 PM, Simon IJskes - QCG wrote: > It looks like

  1   2   3   4   5   6   7   8   9   10   >