twogee commented on a change in pull request #89: Added version and mainClass attributes to <jar> task. URL: https://github.com/apache/ant/pull/89#discussion_r268423686
########## File path: src/main/org/apache/tools/ant/util/jarattr/Constant.java ########## @@ -0,0 +1,147 @@ +/* Review comment: There is another implementation in `org.apache.tools.ant.taskdefs.optional.depend.constantpool`; perhaps that could be reused? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
