Hi Stefan,
On 22/08/18 12:00 AM, Stefan Bodewig wrote: > On 2018-08-16, Jaikiran Pai wrote: > >> However, I would like some inputs on whether such support for setting >> the system properties in a non-forked execution should be at the >> junitlauncher task level or whether it should be configured within >> each <test> and <testclasses> level. Or should we allow it to >> configured at the task level as well as the individual >> <test>/<testclasses> level? >> junit task currently does it only at the task level. > If you really need to have different env variables for different tests > then I think the effort of configuring this properly isn't much less > than having to configure two instances of the junitlaucher task. IMHO > setting them at the task level should be enough, at least until anybody > makes a good case for more granular control. That's a good point. I think that will also make the implementation of this task much simpler. I won't add the sysproperty support for non-forked mode now and let users try it out in the forked mode. As you note, only if there's some real usecase/request for supporting this in non-forked mode, I will revisit the feature. Thank you for your inputs. -Jaikiran --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
