Re: Policy Change Proposal: Running the upstream test suite

2024-08-19 Thread Graham Inggs
On Sun, 18 Aug 2024 at 21:14, Louis-Philippe Véronneau wrote: > Can you be more explicit on the reasons why you dislike the second sentence? > > It only says you should document why tests aren't ran in a package and > encourages you to open a bug report. I thought the second sentence was: "As suc

Re: Policy Change Proposal: Running the upstream test suite

2024-08-18 Thread Louis-Philippe Véronneau
On 2024-08-16 6 h 44 p.m., Pierre-Elliott Bécue wrote: Hi, Louis-Philippe Véronneau wrote on 15/08/2024 at 00:09:15+0200: On 2024-07-29 4 h 53 a.m., Louis-Philippe Véronneau wrote: Hello, As discussed during the DebConf24 Python BoF, I'm submitting this change to the policy to require the u

Re: Policy Change Proposal: Running the upstream test suite

2024-08-16 Thread Pierre-Elliott Bécue
Hi, Louis-Philippe Véronneau wrote on 15/08/2024 at 00:09:15+0200: > On 2024-07-29 4 h 53 a.m., Louis-Philippe Véronneau wrote: >> Hello, >> As discussed during the DebConf24 Python BoF, I'm submitting this >> change to the policy to require the use of the upstream test suite, >> both during th

Re: Policy Change Proposal: Running the upstream test suite

2024-08-16 Thread Andreas Tille
Am Wed, Aug 14, 2024 at 06:09:15PM -0400 schrieb Louis-Philippe Véronneau: > It's been about 2 weeks since the policy change has been proposed. I believe > I have taken in account the feedback and the discussion seems to have died > down. > > As the response from the team member was largely positi

Re: Policy Change Proposal: Running the upstream test suite

2024-08-14 Thread Louis-Philippe Véronneau
On 2024-07-29 4 h 53 a.m., Louis-Philippe Véronneau wrote: Hello, As discussed during the DebConf24 Python BoF, I'm submitting this change to the policy to require the use of the upstream test suite, both during the build process and as an autopkgtest. You can find the MR here: https://sals

Re: Policy Change Proposal: Running the upstream test suite

2024-07-31 Thread Simon McVittie
On Wed, 31 Jul 2024 at 19:01:05 +0500, Andrey Rakhmatullin wrote: > On Wed, Jul 31, 2024 at 09:46:27AM +0100, Simon McVittie wrote: > > If we want to run upstream test-suites as autopkgtests, then I think > > ideally we want the same test coverage as autopkgtest-pkg-python, > > *and* the same test

Re: Policy Change Proposal: Running the upstream test suite

2024-07-31 Thread Andrey Rakhmatullin
On Tue, Jul 30, 2024 at 10:47:59AM +0200, PICCA Frederic-Emmanuel wrote: > Yes, I want to be sure that all the runtime dependencies are rightfully > declared in the Depends of the python module package. Depending on what do you mean by "all" this is not always what we want. We often don't put all

Re: Policy Change Proposal: Running the upstream test suite

2024-07-31 Thread Andrey Rakhmatullin
On Tue, Jul 30, 2024 at 03:59:04PM +0100, Julian Gilbey wrote: > > > Maybe we should install only the python binaries and the dependencies > > > marked . > > > > In a typical simple case all B-Ds except sphinx stuff will be > > as you don't need anything beyond the build system to "build" a pur

Re: Policy Change Proposal: Running the upstream test suite

2024-07-31 Thread Andrey Rakhmatullin
On Wed, Jul 31, 2024 at 09:46:27AM +0100, Simon McVittie wrote: > > > My use case, is to check that all the Dependencies computer by dh_python3 > > > from the build tools are indeed listed in the Depends of the binary > > > package. > > > > Maybe we indeed want a "minimal" autopkgtest environmen

Re: Policy Change Proposal: Running the upstream test suite

2024-07-31 Thread Simon McVittie
On Mon, 29 Jul 2024 at 18:55:26 +0500, Andrey Rakhmatullin wrote: > On Mon, Jul 29, 2024 at 03:30:39PM +0200, PICCA Frederic-Emmanuel wrote: > > My use case, is to check that all the Dependencies computer by dh_python3 > > from the build tools are indeed listed in the Depends of the binary package

Re: Policy Change Proposal: Running the upstream test suite

2024-07-30 Thread Julian Gilbey
On Tue, Jul 30, 2024 at 01:30:57PM +0500, Andrey Rakhmatullin wrote: > > Maybe we should install only the python binaries and the dependencies > > marked . > > In a typical simple case all B-Ds except sphinx stuff will be > as you don't need anything beyond the build system to "build" a pure >

Re: Policy Change Proposal: Running the upstream test suite

2024-07-30 Thread PICCA Frederic-Emmanuel
> Those will correspond to build dependencies in a typical simple case, as > the upstream tests need all those optional deps, assuming you mean the > tests dependencies (and not the runtime dependencies which should already > be in Depends). Yes the runtime dependencies should be listed in the pyt

Re: Policy Change Proposal: Running the upstream test suite

2024-07-30 Thread Andrey Rakhmatullin
On Mon, Jul 29, 2024 at 05:14:33PM +0200, PICCA Frederic-Emmanuel wrote: > > Maybe we indeed want a "minimal" autopkgtest environment, but many > > upstream tests will fail in those and I don't see an automatic way to test > > a random package in this way. > > Even if not minimal, at least corresp

Re: Policy Change Proposal: Running the upstream test suite

2024-07-30 Thread thomas
> >Fair enough. I also made that change. > > Thanks, > > Scott K You have my +1 with the current wording. Cheers, Thomas Goirand (zigo)

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Scott Kitterman
On July 30, 2024 4:27:48 AM UTC, "Louis-Philippe Véronneau" wrote: >On 2024-07-30 12:58, Scott Kitterman wrote: >> >> >> On July 30, 2024 2:47:08 AM UTC, "Louis-Philippe Véronneau" >> wrote: >>> On 2024-07-30 11:09, Scott Kitterman wrote: On July 30, 2024 12:49:50 AM UTC,

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Louis-Philippe Véronneau
On 2024-07-30 12:58, Scott Kitterman wrote: On July 30, 2024 2:47:08 AM UTC, "Louis-Philippe Véronneau" wrote: On 2024-07-30 11:09, Scott Kitterman wrote: On July 30, 2024 12:49:50 AM UTC, "Louis-Philippe Véronneau" wrote: On 2024-07-29 21:07, Scott Kitterman wrote: On July 29, 2024

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Scott Kitterman
On July 30, 2024 2:47:08 AM UTC, "Louis-Philippe Véronneau" wrote: >On 2024-07-30 11:09, Scott Kitterman wrote: >> >> >> On July 30, 2024 12:49:50 AM UTC, "Louis-Philippe Véronneau" >> wrote: >>> On 2024-07-29 21:07, Scott Kitterman wrote: On July 29, 2024 8:53:11 AM UTC,

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Louis-Philippe Véronneau
On 2024-07-30 11:09, Scott Kitterman wrote: On July 30, 2024 12:49:50 AM UTC, "Louis-Philippe Véronneau" wrote: On 2024-07-29 21:07, Scott Kitterman wrote: On July 29, 2024 8:53:11 AM UTC, "Louis-Philippe Véronneau" wrote: Hello, As discussed during the DebConf24 Python BoF, I'm submi

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Scott Kitterman
On July 30, 2024 12:49:50 AM UTC, "Louis-Philippe Véronneau" wrote: >On 2024-07-29 21:07, Scott Kitterman wrote: >> >> >> On July 29, 2024 8:53:11 AM UTC, "Louis-Philippe Véronneau" >> wrote: >>> Hello, >>> >>> As discussed during the DebConf24 Python BoF, I'm submitting this change to >

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Louis-Philippe Véronneau
On 2024-07-29 23:08, Pierre-Elliott Bécue wrote: Hey, Louis-Philippe Véronneau wrote on 29/07/2024 at 10:53:11+0200: Hello, As discussed during the DebConf24 Python BoF, I'm submitting this change to the policy to require the use of the upstream test suite, both during the build process and

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Louis-Philippe Véronneau
On 2024-07-29 21:07, Scott Kitterman wrote: On July 29, 2024 8:53:11 AM UTC, "Louis-Philippe Véronneau" wrote: Hello, As discussed during the DebConf24 Python BoF, I'm submitting this change to the policy to require the use of the upstream test suite, both during the build process and as

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Julian Gilbey
On Mon, Jul 29, 2024 at 12:07:27PM +, Scott Kitterman wrote: > I understand the theory and why it's a good idea to run the test suite. I > don't think it ought to be a hard requirement. I have several packages where > there's a test suite, but I don't run it: > [...] Here's another case: t

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Scott Kitterman
On July 29, 2024 3:14:33 PM UTC, PICCA Frederic-Emmanuel wrote: >> Maybe we indeed want a "minimal" autopkgtest environment, but many >> upstream tests will fail in those and I don't see an automatic way to test >> a random package in this way. > >Even if not minimal, at least correspond to th

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread PICCA Frederic-Emmanuel
> Maybe we indeed want a "minimal" autopkgtest environment, but many > upstream tests will fail in those and I don't see an automatic way to test > a random package in this way. Even if not minimal, at least correspond to the upstream declares dependencies. by 'declare' I am not even sure of the

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Simon McVittie
On Mon, 29 Jul 2024 at 12:07:27 +, Scott Kitterman wrote: > While I agree that running tests is good, it's not a universally > reasonable requirement. I agree. In a project as large as Debian, most requirements similar to this one at least need the qualifier "... unless there is a reason why w

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Pierre-Elliott Bécue
Hey, Louis-Philippe Véronneau wrote on 29/07/2024 at 10:53:11+0200: > Hello, > > As discussed during the DebConf24 Python BoF, I'm submitting this > change to the policy to require the use of the upstream test suite, > both during the build process and as an autopkgtest. > > You can find the MR

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Andrey Rakhmatullin
On Mon, Jul 29, 2024 at 03:30:39PM +0200, PICCA Frederic-Emmanuel wrote: > My use case, is to check that all the Dependencies computer by dh_python3 > from the build tools are indeed listed in the Depends of the binary package. Maybe we indeed want a "minimal" autopkgtest environment, but many up

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread PICCA Frederic-Emmanuel
My use case, is to check that all the Dependencies computer by dh_python3 from the build tools are indeed listed in the Depends of the binary package. I think about package whcih provide oiptional dependencies via the extra. In that case the extra should be declare when calling dh_python3. So I

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Scott Kitterman
On July 29, 2024 8:53:11 AM UTC, "Louis-Philippe Véronneau" wrote: >Hello, > >As discussed during the DebConf24 Python BoF, I'm submitting this change to >the policy to require the use of the upstream test suite, both during the >build process and as an autopkgtest. > >You can find the MR he

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread Martin
Quoting PICCA Frederic-Emmanuel : It install by default the build dependencies. which is not what peoples are doing when they install the packages. It should be possible to define the autopkgtest dependencies. This way we could catch missing dependencies in python- dependencies. Is it pos

Re: Policy Change Proposal: Running the upstream test suite

2024-07-29 Thread PICCA Frederic-Emmanuel
I have one concerne when using pybuild autopkgtest. It install by default the build dependencies. which is not what peoples are doing when they install the packages. It should be possible to define the autopkgtest dependencies. This way we could catch missing dependencies in python- dependencies