Hi Otto,
On 18/01/25 8:26 am, Otto Kekäläinen wrote:
> IRC and mailing lists are very bad for code reviews, so no, they don't
> happen much and I hope they don't happen at all now that we have
> proper code review tooling and UIs to be way more efficient in
> reviewing and re-reviewing changes.
W
Thanks everybody for feedback!
Nice to see a lot of people participated in the discussion this week.
Based on the and some people being against having merge requests as
part of the recommended workflow, and some also objected having Salsa
CI as part of the team workflow, I decided to split that n
Quoting Otto:
> On Tue, 14 Jan 2025 at 12:45, Nilesh Patra wrote:
> >
> > > Seems you think code reviews are a time waste?
> >
> > Wow. That's a strong statement and assumption.
> >
> > To be clear, I never said that. Please take my statements at face-value.
> > Just that I personally would not ha
Hi,
Thanks everyone for the feedback, I have updated
https://salsa.debian.org/go-team/go-team.pages.debian.net/-/merge_requests/7
Direct link to artifact:
https://otto.pages.debian.net/-/go-team.pages.debian.net/-/jobs/6923949/artifacts/build/workflow-changes.html
On Tue, 14 Jan 2025 at 12:45, Ni
> Seems you think code reviews are a time waste?
Wow. That's a strong statement and assumption.
To be clear, I never said that. Please take my statements at face-value.
Just that I personally would not have time for reviewing other's MR/PRs.
> You catch issues earlier and avoid extra work that y
Thorsten Alteholz writes:
> 1.5.
> I am against making this mandatory. It just slows down things.
>
> 1.6.
> As we have to share Salsa between all DDs, I am against making this
> mandatory. It just slows down things even more.
I think the wording could be tweaked. I don't think it is really
pos
Hi,
so, here are my two cents:
1.1.
I am fine with dh-make-golang introducing something new.
I agree that it might be nice to change branch names when packages get
an update. I wouldn't like this to become mandatory.
I am afraid I have no time nor motivation to update old packages just
due to
Thanks Nilesh and Simon for the feedback here, and thanks Maytham and
Taavi for posting feedback on the MR!
> About the "Give and get reviews" in your MR: to clarify, that is, in no way,
> mandatory right?
> I guess that from work "should" instead of "must".
The MR text says: "Reviews are recomm
About the "Give and get reviews" in your MR: to clarify, that is, in no way,
mandatory right?
I guess that from work "should" instead of "must".
I personally would not do it. ENOTIME. Would like to take care of my packages
and team
packages as I find time.
-n
I read through the latest build artifact and support these changes.
I do generally dislike all this complexity, but harmonizing the Go team
process with other DEP14 processes _reduces_ complexity for me.
Otherwise I have to deal with the complexity of the modern DEP14
approach AND the complexity o
Hi!
In line with what I have already been doing, I now published a draft
for workflow changes at
https://salsa.debian.org/go-team/go-team.pages.debian.net/-/merge_requests/7
Direct link to latest build artifact for convenience:
https://otto.pages.debian.net/-/go-team.pages.debian.net/-/jobs/69171
11 matches
Mail list logo
