Thorsten Alteholz <deb...@alteholz.de> writes: > 1.5. > I am against making this mandatory. It just slows down things. > > 1.6. > As we have to share Salsa between all DDs, I am against making this > mandatory. It just slows down things even more.
I think the wording could be tweaked. I don't think it is really possible to "mandate" anything, but I can see how it is read that way. How about replacing "All Go team packages should run Salsa CI at least once before upload to Debian archives to ensure the package has no easily testable regressions." with "Salsa CI pipeline is useful to perform more complete package QA testing and it is now possible to use it for Go packages, to catch easily testable regressions." ? Re 1.5 I understand, my workflow doesn't involve checking Salsa MR regulary and I don't plan to change my workflow in the near term. I look at things when I'm about to make an upload, but rarely otherwise. > What extra work is avoided when doing code reviews before an upload > compared to code reviews after an upload? I think it is fine to make uploads as a way to trigger code review. /Simon
signature.asc
Description: PGP signature
