Re: [PATCH v2] Refactor to avoid nonnull checks on "this" pointer.

2016-04-01 Thread Corinna Vinschen
k and look at what happens. So, here's the question: What error message does G++ 6 generate in case of an `if (this)' test in a member function, and why on earth should it care and do that? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Ma

Re: [PATCH] Add without-library-checks

2016-04-01 Thread Corinna Vinschen
ct something along the lines of "cross-build", "bootstrap", and "stage 1", IMO. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 0/6] Protect fork() against dll- and exe-updates.

2016-04-01 Thread Corinna Vinschen
uld be ok. What I'm concerned about is the size of the patches required to make this stuff work. I have to review this carefully but I need some time. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 4/6] forkables: Protect fork against dll-, exe-updates.

2016-04-01 Thread Corinna Vinschen
Have the security implications of this been considered? > > Which security implications do you think of? > > Removed but in-use binaries are available in the recycle bin anyway, > and can manually be hardlinked to wherever one likes... Permissions on the parent dirs a

Re: [PATCH 1/4] Remove leftover cruft from config.h.in

2016-04-01 Thread Corinna Vinschen
ver letter (e.g. git format-patch --cover-letter). Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH v2] Refactor to avoid nonnull checks on "this" pointer.

2016-04-01 Thread Corinna Vinschen
On Apr 1 08:12, Yaakov Selkowitz wrote: > On 2016-04-01 07:13, Corinna Vinschen wrote: > >On Mar 31 12:18, Peter Foley wrote: > >>G++ 6.0 asserts that the "this" pointer is non-null for member functions. > >>Refactor methods that check if this is non-null

Re: [PATCH v2] Refactor to avoid nonnull checks on "this" pointer.

2016-04-01 Thread Corinna Vinschen
is, I'm all ears. As I mentioned in my first reply, I'd prefer if the callers check the pointer explicitly. Changing the methods to static methods seems ... wrong. Ugly, if you don't mind me saying so. Thanks, Corinna -- Corinna Vinschen Pl

Re: [PATCH] Add without-library-checks

2016-04-01 Thread Corinna Vinschen
On Apr 1 09:31, Peter Foley wrote: > On Fri, Apr 1, 2016 at 8:16 AM, Corinna Vinschen > wrote: > > Can we please fold the --without-mingw-progs and --without-library-checks > > into a single option? Given the task is basically the same, the option > > name should ref

Re: [RFC PATCH v3] Refactor to avoid nonnull checks on "this" pointer.

2016-04-01 Thread Corinna Vinschen
Audio_out::default_buf_info(p, audiofreq_, audiobits_, audiochannels_); Other than that, please go ahead. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 0/4] Various fixes for 2.5.0

2016-04-04 Thread Corinna Vinschen
On Apr 1 17:52, Yaakov Selkowitz wrote: > An assortment of unrelated patches discovered in the process of rebuilding > GCC with 2.5.0-0.10. Ok. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygw

Re: [PATCH v2] Rename without-mingw-progs to with-cross-bootstrap

2016-04-04 Thread Corinna Vinschen
hangeLog > configure.ac: don't check AC_WINDOWS_LIBS when using with-cross-bootstrap > configure: regenerate > winsup/cygwin/ChangeLog > configure.ac: don't check AC_WINDOWS_LIBS when using with-cross-bootstrap > configure: regenerate Patch applied. Thanks, Cori

Re: [PATCH v3] Refactor to avoid nonnull checks on "this" pointer.

2016-04-04 Thread Corinna Vinschen
une_request): remove non-null check on "this", as > this method is only called from pinfo.cc after null checks > pinfo.cc (_pinfo::pipe_fhandler): remove non-null check on "this", as > this method is only called from pipe.cc (fhandler_pipe::open) after a null > check

Re: [PATCH v3] Refactor to avoid nonnull checks on "this" pointer.

2016-04-05 Thread Corinna Vinschen
On Apr 4 16:52, Corinna Vinschen wrote: > On Apr 2 11:36, Peter Foley wrote: > > G++ 6.0 asserts that the "this" pointer is non-null for member > > functions. > > Refactor methods that check if "this" is non-null to resolve this. > > > > wins

Re: [PATCH] Be truthful about reporting whether readahead is available

2016-04-05 Thread Corinna Vinschen
{ > -return shared_console_info->con.cons_rapoi != NULL; > +return shared_console_info->con.cons_rapoi != NULL && > + *shared_console_info->con.cons_rapoi; >} > >select_record *select_read (select_stuff *); > -- > 2.8.0.windows.1

Re: Fwd: Re: [PATCH] Be truthful about reporting whether readahead is available

2016-04-05 Thread Corinna Vinschen
On Apr 5 18:50, Thomas Wolff wrote: > > >>Von: Corinna Vinschen > >>An: cygwin-patches@cygwin.com > >>Cc: Thomas Wolff > >>Datum: 5. April 2016 um 15:55 > >>Betreff: Re: [PATCH] Be truthful about reporting whether readahead is > >>

Re: [PATCH] Re: Cygwin select() issues and improvements

2016-05-18 Thread Corinna Vinschen
Hi John, On May 8 16:43, john hood wrote: > On 3/29/16 8:49 AM, Corinna Vinschen wrote: > > John, ping? > > Sorry it took so long to reply, but I finally got around to cleaning up > the patchset, I've mailed it separately. I don't see the patchset anywhere. Did I m

Re: [PATCH] Re: Cygwin select() issues and improvements

2016-05-20 Thread Corinna Vinschen
On May 18 20:02, john hood wrote: > On 5/18/16 3:23 PM, Corinna Vinschen wrote: > > Hi John, > > > > On May 8 16:43, john hood wrote: > >> On 3/29/16 8:49 AM, Corinna Vinschen wrote: > >>> John, ping? > >> > >> Sorry it took so lon

Re: [PATCH 1/4] Use high-resolution timebases for select().

2016-05-20 Thread Corinna Vinschen
that locally and applied your patches, excluding the debug additions from patch 3 for now. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] cygwin: include sys/types.h in sys/xattr.h

2016-06-03 Thread Corinna Vinschen
ef _SYS_XATTR_H > #define _SYS_XATTR_H > > +#include > #include > > #endif /* _SYS_XATTR_H */ ACK, please apply. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: Fix 'make distclean'

2016-06-06 Thread Corinna Vinschen
ng it failed. This fixes an annoying build problem if gentls_offsets fails to compile cygtls.h. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: Declaration of crypt

2016-06-09 Thread Corinna Vinschen
X_VISIBLE >= 199209 > size_t _EXFUN(confstr, (int __name, char *__buf, size_t __len)); > #endif > +#if __BSD_VISIBLE && defined(__CYGWIN__) > +#include > +#endif > #if __XSI_VISIBLE && __XSI_VISIBLE < 700 > char * _EXFUN(ctermid, (char *__s )); > #endif > -- > 2.8.3 > Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: Declaration of crypt

2016-06-09 Thread Corinna Vinschen
On Jun 9 08:05, Ken Brown wrote: > On 6/9/2016 5:00 AM, Corinna Vinschen wrote: > > Hi Ken, > > > > On Jun 8 17:18, Ken Brown wrote: > > > According to Posix, including should bring in the declaration > > > of > > > crypt. The glibc a

Re: Declaration of crypt

2016-06-09 Thread Corinna Vinschen
On Jun 9 10:07, Ken Brown wrote: > On 6/9/2016 8:32 AM, Corinna Vinschen wrote: > > Can you please define crypt, encrypt and setkey explicitely in unistd.h > > per POSIX, rather than including crypt.h? This would not only be target > > independent, it would also be mor

Re: [setup] move view from left to right

2016-06-15 Thread Corinna Vinschen
I agree, but the idea makes sense. If you ever have fun to hack on this, please feel free. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [setup] move view from left to right

2016-06-15 Thread Corinna Vinschen
On Jun 15 16:52, Marco Atzeri wrote: > On 15/06/2016 16:37, Marco Atzeri wrote: > > On 15/06/2016 14:49, Corinna Vinschen wrote: > > > Hi Marco, > > > > > > > > > in theory patches to setup should go to the cygwin-apps list, but > > > never

Re: [setup] move view from left to right

2016-06-16 Thread Corinna Vinschen
On Jun 16 13:13, Marco Atzeri wrote: > On 15/06/2016 17:39, Corinna Vinschen wrote: > > On Jun 15 16:52, Marco Atzeri wrote: > > > On 15/06/2016 16:37, Marco Atzeri wrote: > > > > On 15/06/2016 14:49, Corinna Vinschen wrote: > > > What about this: > &

Re: [setup] move view from left to right

2016-06-16 Thread Corinna Vinschen
On Jun 16 14:32, Marco Atzeri wrote: > On 16/06/2016 14:07, Corinna Vinschen wrote: > > On Jun 16 13:13, Marco Atzeri wrote: > > > On 15/06/2016 17:39, Corinna Vinschen wrote: > > > > On Jun 15 16:52, Marco Atzeri wrote: > > > > > On 15/06/2016 16:37,

Re: [PATCH] Update FAQ listing required packages for building Cygwin

2016-06-28 Thread Corinna Vinschen
On Jun 28 13:39, Jon Turney wrote: > docbook2X is now required for building documentation > libiconv differences between x86_64 and x86 no longer exist Please apply. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Main

Re: [PATCH] Update FAQ listing required packages for building Cygwin

2016-06-29 Thread Corinna Vinschen
Hi Jon, On Jun 28 15:21, Corinna Vinschen wrote: > On Jun 28 13:39, Jon Turney wrote: > > docbook2X is now required for building documentation > > libiconv differences between x86_64 and x86 no longer exist > > Please apply. Sorry, but that was not quite correct. Apparent

Re: [PATCH] Update FAQ listing required packages for building Cygwin

2016-06-29 Thread Corinna Vinschen
On Jun 29 15:18, Jon Turney wrote: > On 29/06/2016 09:04, Corinna Vinschen wrote: > > Hi Jon, > > > > On Jun 28 15:21, Corinna Vinschen wrote: > > > On Jun 28 13:39, Jon Turney wrote: > > > > docbook2X is now required for building documentation > >

Re: [PATCH 0/3] Small documentation fixes

2016-07-05 Thread Corinna Vinschen
ions(+), 11 deletions(-) Looks good, please apply. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] Fix 32-bit SSIZE_MAX

2016-07-14 Thread Corinna Vinschen
#x27;t have to jump through hoops. */ > #undef SSIZE_MAX > +#if __WORDSIZE == 64 > #define SSIZE_MAX (__LONG_MAX__) > +#else > +#define SSIZE_MAX (__INT_MAX__) > +#endif > > > /* Runtime Invariant Values */ Looks good, please apply. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 01/01] machine/_types.h: __blkcnt_t should be signed

2016-07-14 Thread Corinna Vinschen
et update operation is negative, instead it > calculated a huge positive number. > > [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html Patch applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer

Re: [PATCH] Fix 32-bit SSIZE_MAX

2016-07-14 Thread Corinna Vinschen
On Jul 14 12:39, Eric Blake wrote: > On 07/14/2016 09:09 AM, Corinna Vinschen wrote: > > On Jul 13 15:02, Eric Blake wrote: > >> POSIX requires that SSIZE_MAX have the same type as ssize_t, but > >> on 32-bit, we were defining it as a long even though ssize_t > &

Re: [PATCH 1/2] Add pthread_getname_np and pthread_setname_np

2016-07-28 Thread Corinna Vinschen
{ > + ret = EFAULT; > +} > + __endtry > + > + return ret; > +} > + > +#undef NAMELEN > + > +extern "C" int > +pthread_setname_np (pthread_t thread, const char *name) > +{ > + char *oldname, *cp; > + > + if (!pthread::is_good_object (&thread)

Re: [PATCH 2/2] Send thread names to debugger

2016-07-28 Thread Corinna Vinschen
d->parent_sigmask; >thread->set_tls_self_pointer (); > > + // Give thread default name > + SetThreadName(GetCurrentThreadId(), program_invocation_short_name); ^^^^^^ space? space? > + >thread->mutex.lock (); > >// if thread is detached force cleanup on exit > @@ -2622,6 +2625,8 @@ pthread_setname_np (pthread_t thread, const char *name) >oldname = thread->attr.name; >thread->attr.name = cp; > > + SetThreadName(GetThreadId(thread->win32_obj_id), thread->attr.name); ^^^^^^ space? space? > + >if (oldname) > free(oldname); ^^^ space? Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 2/2] Send thread names to debugger

2016-07-29 Thread Corinna Vinschen
On Jul 29 14:17, Jon Turney wrote: > On 28/07/2016 20:34, Corinna Vinschen wrote: > > On Jul 28 12:43, Jon Turney wrote: > > > GDB with the patch from [1] can report and use these names. > > > > This is still WIP, right? > > Yes, that's right.

Re: [PATCH 1/2] Add pthread_getname_np and pthread_setname_np

2016-08-23 Thread Corinna Vinschen
Hi Jon, On Aug 22 19:08, Jon Turney wrote: > +#define NAMELEN 16 Please use a more descriptive name here, say THR_NAMEMAX or so, and add a "for Linux compat" comment. With this change the patch is ok to apply. Thanks, Corinna -- Corinna Vinschen Pleas

Re: Documentation patch: Clarify Cygwin's support for Win32 paths

2016-08-23 Thread Corinna Vinschen
On Aug 23 13:30, Ken Brown wrote: > The attached patch is the one promised in > > https://www.cygwin.com/ml/cygwin/2016-08/msg00431.html > > Ken Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer

Re: [PATCH 1/4] dlopen: switch to new pathfinder class

2016-08-31 Thread Corinna Vinschen
nder class, rather than having to create some additional allocator class? I'm probably not the most diligent C++ hacker, but to me this additional allocator is a bit confusing. The rest of the patch looks good. I'll look further into the patchset later tomorrow. Thanks, Corinna -

Re: [PATCH 3/4] dlopen: on x/lib search x/bin if exe is in x/bin

2016-09-01 Thread Corinna Vinschen
!strcmp (cpath + dirlen - 4, "/bin")) > + finder.add_searchdir (cpath, exedirlen); > + } > + > /* search the specified dir */ > - finder.add_searchdir (name, basename - 1 - name); > + finder.add_searchdir (name, dirlen); > } >else > { > -- > 2.7.3 Rest looks ok. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 1/4] dlopen: switch to new pathfinder class

2016-09-01 Thread Corinna Vinschen
On Sep 1 13:05, Michael Haubenwallner wrote: > On 08/31/2016 09:12 PM, Corinna Vinschen wrote: > > Hi Michael, > > > > On Aug 31 20:07, Michael Haubenwallner wrote: > >> Instead of find_exec, without changing behaviour use new pathfinder > >> class with new

Re: [PATCH 2/4] dlopen (pathfinder): try each basename per dir

2016-09-01 Thread Corinna Vinschen
me != basenames_.end (); > +++name) > if (criterion.test (dir, name)) > { > debug_printf ("(%s), take %s%s", critname, > -- > 2.7.3 This one's fine, of course. Thanks, Corinna -- Corinna Vinschen Please, send mails regar

Re: [PATCH 4/4] dlopen: on unspecified lib dir search exe dir

2016-09-01 Thread Corinna Vinschen
_searchdir (cpath, exedirlen); > + > /* Finally we better have some fallback. */ > finder.add_searchdir ("/usr/bin", 8); > finder.add_searchdir ("/usr/lib", 8); > -- > 2.7.3 Still not quite sure if that's the right thing to do.

Re: [PATCH 1/4] dlopen: switch to new pathfinder class

2016-09-02 Thread Corinna Vinschen
On Sep 2 10:05, Michael Haubenwallner wrote: > On 09/01/2016 04:03 PM, Corinna Vinschen wrote: > > On Sep 1 13:05, Michael Haubenwallner wrote: > >> On 08/31/2016 09:12 PM, Corinna Vinschen wrote: > >>> On Aug 31 20:07, Michael Haubenwallner wrote: > >>&g

Re: [PATCH 3/4] dlopen: on x/lib search x/bin if exe is in x/bin

2016-09-02 Thread Corinna Vinschen
On Sep 2 10:46, Michael Haubenwallner wrote: > Hi Corinna, > > On 09/01/2016 03:32 PM, Corinna Vinschen wrote: > > You could just use the global variable program_invocation_name. If in > > doubt, use the Windows path global_progname and convert it to full POSIX >

Re: [PATCH 1/4] dlopen: switch to new pathfinder class

2016-09-08 Thread Corinna Vinschen
On Sep 2 13:36, Michael Haubenwallner wrote: > On 09/02/2016 10:52 AM, Corinna Vinschen wrote: > > On Sep 2 10:05, Michael Haubenwallner wrote: > >> Moving the allocator into pathfinder would work then, but still the > >> tmp_pathbuf instance to use has to be provided

Re: [PATCH 1/4] dlopen: switch to new pathfinder class

2016-09-09 Thread Corinna Vinschen
On Sep 9 10:19, Michael Haubenwallner wrote: > On 09/08/2016 01:58 PM, Corinna Vinschen wrote: > > On Sep 2 13:36, Michael Haubenwallner wrote: > >> On 09/02/2016 10:52 AM, Corinna Vinschen wrote: > >>> On Sep 2 10:05, Michael Haubenwallner wrote: > >>

Re: Add _PC_CASE_INSENSITIVE flag to pathconf

2016-10-21 Thread Corinna Vinschen
e or directory > pathconf ("/cygdrive/c/cygwin", _PC_CASE_INSENSITIVE) returns 1 > pathconf ("/", _PC_CASE_INSENSITIVE) returns 0 > pathconf (".", _PC_CASE_INSENSITIVE) returns 0 > > This test was done, obviously, on a system with the obcaseinsensitive

Re: Return the correct value for sysconf(_SC_PAGESIZE)

2016-11-15 Thread Corinna Vinschen
go. This has been discussed on the cygwin-developers mailing list years ago. The problem is the POSIX assumption that the allocation granularity equals the page size. The only working solution which does not break assumptions is to return the allocation granularity as page size. Corinna -- Cori

Re: Return the correct value for sysconf(_SC_PAGESIZE)

2016-11-15 Thread Corinna Vinschen
On Nov 15 16:47, Erik Bray wrote: > On Tue, Nov 15, 2016 at 3:58 PM, Corinna Vinschen > wrote: > > On Nov 15 14:51, Erik Bray wrote: > >> Greetings, > >> > >> Currently sysconf(_SC_PAGESIZE) returns the value of > >> wincap.allocation_granularity(

Re: Return the correct value for sysconf(_SC_PAGESIZE)

2016-11-17 Thread Corinna Vinschen
uot;normal" in Cygwin (for the > reasons stated by Corinna) then it's an acceptable trade-off? It is. From the POSIX POV we have a 64K page size, from the Windows POV we have a bastard of 4K pages which can only be allocated in chunks of 16. The latter simply do

Re: [PATCH 3/6] forkables: Create forkable hardlinks, yet unused.

2016-11-17 Thread Corinna Vinschen
ls.cygport prep build'. If you do this thrice, once without your patch, once with your patch but without utilizing it, and once with your patch and utilizing it, how do they compare? Do you have numbers? Thanks, Corinna -- Corinna Vinschen Please, send

Re: [PATCH] Fix some broken links in Cygwin FAQ

2016-12-14 Thread Corinna Vinschen
a mirror. Ack. Please apply. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 0/3] Add support for /proc//environ

2017-01-09 Thread Corinna Vinschen
tself. Did you try `cat /proc/self/environ'? I'm getting a "Bad address" error when trying that. - A few formatting issues, see my next replies. Other than that, thanks for this nice addition! Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 1/3] Move the core environment parsing of environ_init into a new win32env_to_cygenv function.

2017-01-09 Thread Corinna Vinschen
d..7bd87da 100644 > --- a/winsup/cygwin/environ.h > +++ b/winsup/cygwin/environ.h > @@ -45,4 +45,6 @@ extern "C" char __stdcall **cur_environ (); > char ** __reg3 build_env (const char * const *envp, PWCHAR &envblock, > int &envc, bool need_en

Re: [PATCH 2/3] Add a _pinfo.environ() method analogous to _pinfo.cmdline(), and others.

2017-01-09 Thread Corinna Vinschen
function, your choice, but I'd get rid of the curly braces for oneliners here. > + > + NtClose (proc); > +} > + else if (pid != myself->pid) > +{ > + commune_result cr = commune_request (PICOM_ENVIRON); > + n = cr.n; > + return cr.s; > +} >

Re: [PATCH] Return the correct value for getsockopt(SO_REUSEADDR) after setting setsockopt(SO_REUSEADDR, 1).

2017-01-09 Thread Corinna Vinschen
n of this block is wrong. Still, good catch. I fixed the above manually and applied the patch as obvious (otherwise we're still needing your BSD sign-off). Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: Limited Internet speeds caused by inappropriate socket buffering in function fdsock (winsup/net.cc)

2017-01-10 Thread Corinna Vinschen
to add your comment as NOTE 4 into the same comment, so the history is in one place. - Not a requirement, but it would be nice to get the patch in the typical `git format-patch' fashion. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Ma

Re: [PATCH 0/3] Add support for /proc//environ

2017-01-10 Thread Corinna Vinschen
On Jan 10 11:48, Erik Bray wrote: > On Mon, Jan 9, 2017 at 3:43 PM, Corinna Vinschen > wrote: > > Hi Erik, > > > > On Jan 5 18:39, erik.m.b...@gmail.com wrote: > >> From: "Erik M. Bray" > >> > >> Per this discussion started in thi

Re: [PATCH 2/3] Add a _pinfo.environ() method analogous to _pinfo.cmdline(), and others.

2017-01-10 Thread Corinna Vinschen
On Jan 10 11:56, Erik Bray wrote: > On Mon, Jan 9, 2017 at 3:58 PM, Corinna Vinschen > wrote: > > On Jan 5 18:39, Erik M. Bray wrote: > >> diff --git a/winsup/cygwin/pinfo.cc b/winsup/cygwin/pinfo.cc > >> index 1ce6809..a3e376c 100644 > >> --- a/winsup/c

Re: [PATCH 0/3] Updated patches for /proc//environ

2017-01-10 Thread Corinna Vinschen
winsup/cygwin/pinfo.cc| 83 +- > winsup/cygwin/pinfo.h | 4 +- > 5 files changed, 157 insertions(+), 38 deletions(-) Patchset applied. The formatting in pinfo.cc was still not entirely correct, but I tweaked it manually. Please have

Re: [PATCH] FAST_CWD: adjust the initial search scope

2017-01-11 Thread Corinna Vinschen
tdll, where the 0xe8 byte is > now found at offset 40, not the 32-bit version. However, let's just > double the area we search for said byte for good measure. any chance to convince the powers that be to open up access to this datastructures without such hacky means? Thanks, Cor

Re: [PATCH] FAST_CWD: adjust the initial search scope

2017-01-12 Thread Corinna Vinschen
On Jan 11 20:48, Johannes Schindelin wrote: > Hi Corinna, > > On Wed, 11 Jan 2017, Corinna Vinschen wrote: > > > On Jan 11 14:21, Johannes Schindelin wrote: > > > A *very* recent Windows build adds more code to the preamble of > > > RtlGetCurrentDirector

Re: Limited Internet speeds caused by inappropriate socket buffering in function fdsock (winsup/net.cc)

2017-01-14 Thread Corinna Vinschen
know the results. I'm really looking forward to it! > In the mean time I will apply your recommendations to my patch and repost it. Same here. Thanks a lot for fixing another of those pesky "Cygwin is slow" problems :))) Corinna -- Corinna Vinschen Please,

Re: Limited Internet speeds caused by inappropriate socket buffering in function fdsock (winsup/net.cc)

2017-01-26 Thread Corinna Vinschen
Hi Daniel, any news? Thanks, Corinna On Jan 14 16:17, Corinna Vinschen wrote: > On Jan 11 16:38, Daniel Havey wrote: > > Hi Corinna, > > I can see your email on the archive, but, I never received it in my > > gmail account (not even in a spam folder). I think the

Re: [PATCH] Fix cygcheck -p's handling of '+'

2017-01-31 Thread Corinna Vinschen
These do not need to be escaped in application/x-www-form-urlencoded */ > +static const char safe_chars[] = "$-_.!*'(),"; > > /* the URL to query. */ > static const char base_url[] = > -- > 2.8.3 Thanks, please apply. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] Make anchors stable in generated Cygwin HTML documentation

2017-02-06 Thread Corinna Vinschen
On Feb 5 13:45, Jon Turney wrote: > Give more elements ids, so random ids aren't assigned to them, so anchors > are stable between builds. ACK, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT

Re: (fixup) [PATCH] forkables: use dynloaded dll's IndexNumber as dirname

2017-02-12 Thread Corinna Vinschen
016-12/msg6.html Applied to the (rebased) topic/forkables branch. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] fix parallel build for version.cc and winver.o

2017-02-16 Thread Corinna Vinschen
On Feb 16 16:57, Michael Haubenwallner wrote: > Creating both version.cc and winver.o at once really should run once only. Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red

Re: (fixup) [PATCH] forkables: use dynloaded dll's IndexNumber as dirname

2017-02-23 Thread Corinna Vinschen
Hi Michael, I'm inclined to promote the "forkables" code to master. I just have a few points before we do that: - Revert bumping of CYGWIN_VERSION_SHARED_DATA. We only have to do that if the shared region changes in an incompatible way. But this is just adding a member to the end. - I'm

Re: [PATCH] Preserve order of dlopen'd modules in dll_list::topsort

2017-02-27 Thread Corinna Vinschen
se resend the `git format-patch' output as attachment? - While you're at it, please reformat your patch so the line length is not longer than 80 chars. - Last but not least. You add code to topsort so the loaded DLLs are handled first. The subsequent code is untouched. However,

Re: [PATCH] Preserve order of dlopen'd modules in dll_list::topsort

2017-02-28 Thread Corinna Vinschen
Hi David, thanks for the new patch. On Feb 27 17:13, David Allsopp wrote: > Corinna Vinschen wrote: > > On Feb 25 16:27, David Allsopp wrote: > > > This patch (below - I hope I have managed to format this email > > > correctly) alters the behaviour of dll_li

Re: [PATCH] Preserve order of dlopen'd modules in dll_list::topsort

2017-02-28 Thread Corinna Vinschen
Hi David, On Feb 28 11:48, David Allsopp wrote: > Corinna Vinschen wrote: > > On Feb 27 17:13, David Allsopp wrote: > > > Corinna Vinschen wrote: > > > > On Feb 25 16:27, David Allsopp wrote: > > > > > This patch (below - I hope I have managed to form

Re: (fixup) [PATCH] forkables: use dynloaded dll's IndexNumber as dirname

2017-03-02 Thread Corinna Vinschen
Hi Michael, On Mar 1 20:18, Michael Haubenwallner wrote: > Hi Corinna, > > On 02/23/2017 03:03 PM, Corinna Vinschen wrote: > > Hi Michael, > > > > I'm inclined to promote the "forkables" code to master. I just have a > > few points

Re: [PATCH] Implement dladdr() (partially)

2017-03-08 Thread Corinna Vinschen
| 1 + > winsup/cygwin/dlfcn.cc| 34 ++ > winsup/cygwin/include/dlfcn.h | 18 ++ > winsup/doc/posix.xml | 4 > 4 files changed, 57 insertions(+) Thwe API minor version bump is missing. With this addition, please apply. Thanks, Corinna -- Corinna Vins

Re: [PATCH] forkables: hardlink without WRITE_ATTRIBUTES first

2017-03-10 Thread Corinna Vinschen
S_TRANSACTION_NOT_ACTIVE. Patch applied to topic/forkables (which I rebased so pull -f). I'm planning to make a 2.8.0 release and then pull over the forkables stuff to master for the next release. Maybe we should bump the DLL version to 3.0 then. It's a pretty big functionality extension.

Re: [PATCH] Implement getloadavg()

2017-03-20 Thread Corinna Vinschen
e|hurt} to call it once in the initalization of Cygwin's shared mem in shared_info::initialize? As for the declaration problem on x86, what about moving the declarations to the start of loadavg.cc, until we get a new w32api-headers package? JonY, any chance for a quick update of w32ap

Re: [PATCH] Implement getloadavg()

2017-03-20 Thread Corinna Vinschen
On Mar 20 13:05, JonY wrote: > On 03/20/2017 10:37 AM, Corinna Vinschen wrote: > > > > JonY, any chance for a quick update of w32api-headers to include the > > patch from https://sourceforge.net/p/mingw-w64/mailman/message/35727667/? > > > > Sure, I'll t

Re: [PATCH] Implement getloadavg()

2017-03-20 Thread Corinna Vinschen
On Mar 20 15:04, Jon Turney wrote: > On 20/03/2017 10:37, Corinna Vinschen wrote: > > On Mar 17 17:50, Jon Turney wrote: > > The load average is global, non-critical data. So what about storing it > > in shared_info instead? This way, only the first call of the first >

Re: [PATCH] declaration of ppoll() by poll.h should be guarded by _GNU_SOURCE

2017-03-27 Thread Corinna Vinschen
int ppoll __P ((struct pollfd *fds, nfds_t nfds, > const struct timespec *timeout_ts, > const sigset_t *sigmask)); > +#endif > > __END_DECLS > > -- > 2.8.3 Please apply. Thanks, Corinna -- Corinna Vinschen Please, send mails re

Re: [PATCH] Implement getloadavg() [v3]

2017-03-27 Thread Corinna Vinschen
t; Remove unused autoload > Mark inititalized flags as NO_COPY for correct behaviour in fork child > > Signed-off-by: Jon Turney > --- Looks good, pleae apply. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer

Re: [PATCH] Make ldd stop after any non-continuable exception

2017-04-05 Thread Corinna Vinschen
what situation occurs this? Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: Remove "function" from line to avoid dash objecting to this bash-ism

2017-04-06 Thread Corinna Vinschen
22:20:09 -0700 > Subject: [PATCH] Remove "function" from line to avoid dash objecting to this > bash-ism. Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] Avoid decimal point localization in /proc/loadavg

2017-04-10 Thread Corinna Vinschen
t)loadavg[2], HUNDRETHS(loadavg[2]), > + running, (unsigned int)pids.npids); > } > > static off_t > -- > 2.8.3 Looks good. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] Avoid decimal point localization in /proc/loadavg

2017-04-10 Thread Corinna Vinschen
> Would it be more prudent to update top to be locale aware? Not that it hurts to tweak top, but the linux kernel prints this with decimal points independently of the locale of the current user, too. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin

Re: [PATCH] strace: Fix crash caused over-optimization

2017-04-18 Thread Corinna Vinschen
l_memset (buf, 0, sizeof (buf)); > > I'm actually really glad for your response and that I played with this > because I need to make sure that this problem doesn't exist in gcc7. I have > changes going into gcc8 shortly and this could mask problems from my test > pro

Re: [PATCH v2] strace: Fix "over-optimization" flaw in strace.

2017-04-19 Thread Corinna Vinschen
@ main (int argc, char **argv) > registry setting to 0x10 (TOP_DOWN). */ >char buf[CYGTLS_PADSIZE]; > > - memset (buf, 0, sizeof (buf)); > + RtlSecureZeroMemory (buf, sizeof (buf)); >exit (main2 (argc, argv)); > } > > -- > 2.11.0 Pushed. Thanks

Re: [PATCH v2] strace: Fix "over-optimization" flaw in strace.

2017-04-20 Thread Corinna Vinschen
is, is that the right address > > for mailing list problems? > > Actually, any email I send with corinna-cyg...@cygwin.com in the To header > is bounced. Yes, it's a write-only mail address. Please send stuff only to the respective mailing list. Thanks, Corinna -- Corin

Re: [PATCH] Update URLs for Cygwin packaging information

2017-04-20 Thread Corinna Vinschen
On Apr 20 15:28, Jon Turney wrote: > Also: > Remove obsolete reference to g-b-s > Remove mention of ancient pre-invisiconsole behaviour of setup scripts > > Signed-off-by: Jon Turney Looks good. Please apply. Thanks, Corinna -- Corinna Vinschen Please, send

Re: cygwin-doc html/ missing docbook.css and index dups cygwin-{api,ug-net}

2017-04-22 Thread Corinna Vinschen
On Apr 22 03:30, Brian Inglis wrote: > On 2017-04-22 02:59, Corinna Vinschen wrote: > > But this is going to become part of the Cygwin repo (the cygwin-docs > > package is created from there), so I need a BSD copyright waiver > > from you. See https://cygwin.com/contrib.html

Re: [PATCH] Fix stat.st_blocks for files compressed with CompactOS method

2017-04-22 Thread Corinna Vinschen
| FILE_ATTRIBUTE_SPARSE_FILE)) Are you saying these files actually have no FILE_ATTRIBUTE_COMPRESSED bit set??? Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] Fix stat.st_blocks for files compressed with CompactOS method

2017-04-22 Thread Corinna Vinschen
On Apr 22 16:34, Christian Franke wrote: > Corinna Vinschen wrote: > > Hi Christian, > > > > On Apr 22 14:50, Christian Franke wrote: > > > Cygwin 2.8.0 returns stat.st_blocks = 0 if a file is compressed with > > > CompactOS method (at least on Win10 1

Re: [PATCH] Possibly correct fix to strace phantom process entry

2017-04-24 Thread Corinna Vinschen
sing its procinfo. No problem for strace and ldd, apparently, but other processes...? We could try it for a while. I'm off all of May anyway and I could create a test build for that time... Btw., would you mind to send a BSD waiver per https://cygwin.com/contrib.html and https://cygwin.com/gi

Re: [PATCH] Possibly correct fix to strace phantom process entry

2017-04-24 Thread Corinna Vinschen
On Apr 24 14:19, Corinna Vinschen wrote: > Hi Daniel, > > On Apr 24 04:37, Daniel Santos wrote: > > The root cause of problem with strace causing long delays when any > > process enumerates the process database appears to be calling > > myself.thisproc () from chi

Re: [PATCH] Possibly correct fix to strace phantom process entry

2017-04-25 Thread Corinna Vinschen
On Apr 24 18:14, Daniel Santos wrote: > On 04/24/2017 07:19 AM, Corinna Vinschen wrote: > > Hi Daniel, > > > > On Apr 24 04:37, Daniel Santos wrote: > > > The root cause of problem with strace causing long delays when any > > > process enumerates the

Re: [PATCH] Possibly correct fix to strace phantom process entry

2017-04-25 Thread Corinna Vinschen
On Apr 24 19:00, Daniel Santos wrote: > On 04/24/2017 10:38 AM, Corinna Vinschen wrote: > > > I'm going with my patch for now. Mainly because I added some debug > > output to see if we need the Sleep loop at all. Right now I don't see > > any situ

Re: [PATCH] Ensure that a blocking send() on a socket returns (with success) if a signal is handled mid-transition and SA_RESTART is not set.

2017-06-06 Thread Corinna Vinschen
the log message a bit more detailed. Would you like to provide another patch along these lines? Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] Add COMODO Internet Security and ConEmu to BLODA

2017-06-09 Thread Corinna Vinschen
rapport";>its home > page > +IBM Security Trusteer Rapport (see url="http://www-03.ibm.com/software/products/en/trusteer-rapport";>its home > page) > > Sometimes these problems can be worked around, by temporarily or > partially > disabling the offendi

Re: [PATCH] Add COMODO Internet Security and ConEmu to BLODA

2017-06-09 Thread Corinna Vinschen
odgy apps. I don't think it's necessary, but feel free to add some words here. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

<    1   2   3   4   5   6   7   8   9   10   >