Re: [Patch] cygcheck: warn about empty path-components

2004-10-12 Thread Igor Pechtchanski
On Tue, 12 Oct 2004, Christopher Faylor wrote: > On Tue, Oct 12, 2004 at 06:26:36PM -0400, Igor Pechtchanski wrote: > >On Tue, 12 Oct 2004, Christopher Faylor wrote: > > > >> On Wed, Oct 13, 2004 at 12:11:05AM +0200, Bas van Gompel wrote: > >> >Op Sun, 10 Oct 2004 13:13:23 -0400 schreef Christophe

Re: [Patch] cygcheck: warn about empty path-components

2004-10-12 Thread Christopher Faylor
On Tue, Oct 12, 2004 at 06:26:36PM -0400, Igor Pechtchanski wrote: >On Tue, 12 Oct 2004, Christopher Faylor wrote: > >> On Wed, Oct 13, 2004 at 12:11:05AM +0200, Bas van Gompel wrote: >> >Op Sun, 10 Oct 2004 13:13:23 -0400 schreef Christopher Faylor: >> >: On Sun, Oct 10, 2004 at 08:36:38AM +0200,

Re: [Patch] cygcheck: warn about empty path-components

2004-10-12 Thread Igor Pechtchanski
On Tue, 12 Oct 2004, Christopher Faylor wrote: > On Wed, Oct 13, 2004 at 12:11:05AM +0200, Bas van Gompel wrote: > >Op Sun, 10 Oct 2004 13:13:23 -0400 schreef Christopher Faylor: > >: On Sun, Oct 10, 2004 at 08:36:38AM +0200, Bas van Gompel wrote: > >: > Op Sat, 9 Oct 2004 19:18:13 -0400 schreef

Re: [Patch] cygcheck: warn about empty path-components

2004-10-12 Thread Christopher Faylor
On Wed, Oct 13, 2004 at 12:11:05AM +0200, Bas van Gompel wrote: >Op Sun, 10 Oct 2004 13:13:23 -0400 schreef Christopher Faylor >in <[EMAIL PROTECTED]>: >: On Sun, Oct 10, 2004 at 08:36:38AM +0200, Bas van Gompel wrote: >: > Op Sat, 9 Oct 2004 19:18:13 -0400 schreef Christopher Faylor >: > So cygch

Re: [Patch] cygcheck: warn about empty path-components

2004-10-12 Thread Bas van Gompel
Op Sun, 10 Oct 2004 13:13:23 -0400 schreef Christopher Faylor in <[EMAIL PROTECTED]>: : On Sun, Oct 10, 2004 at 08:36:38AM +0200, Bas van Gompel wrote: : > Op Sat, 9 Oct 2004 19:18:13 -0400 schreef Christopher Faylor : > So cygcheck will have the same problem... : : Right, but cygcheck can rely

Re: [Patch] cygcheck: warn about empty path-components

2004-10-11 Thread Corinna Vinschen
On Oct 9 19:18, Christopher Faylor wrote: > When I was at Red Hat, I tended to be slightly more lenient about > assignment obligations for things in the utils directory. I certainly don't object if we keep it this way. > Corinna, do you think you could ask you-know-who if we could get a > waiver

Re: [Patch] cygcheck: warn about empty path-components

2004-10-09 Thread Christopher Faylor
On Sun, Oct 10, 2004 at 12:41:20AM +0200, Bas van Gompel wrote: >Op Thu, 7 Oct 2004 20:17:55 -0400 schreef Christopher Faylor >: Of course, if someone can use cygcheck to diagnose their own problems >: then, that's great. I don't see any reason to alarm someone with a >: warning about a minor i

Re: [Patch] cygcheck: warn about empty path-components

2004-10-09 Thread Bas van Gompel
Op Thu, 7 Oct 2004 20:17:55 -0400 schreef Christopher Faylor in <[EMAIL PROTECTED]>: : On Fri, Oct 08, 2004 at 01:42:05AM +0200, Bas van Gompel wrote: : > : > : Why are we bothering with this? : > : > : > : > If I may attempt to answer this one... Many people may not know of : > : > this usage, y

Re: [Patch] cygcheck: warn about empty path-components

2004-10-07 Thread Christopher Faylor
On Fri, Oct 08, 2004 at 01:42:05AM +0200, Bas van Gompel wrote: >: > : Why are we bothering with this? >: > >: > If I may attempt to answer this one... Many people may not know of >: > this usage, yet may have their windows path ending on a ';'. >: >: I'm sure the same thing is true on UNIX and

Re: [Patch] cygcheck: warn about empty path-components

2004-10-07 Thread Bas van Gompel
Op Wed, 6 Oct 2004 22:15:58 -0400 schreef Christopher Faylor in <[EMAIL PROTECTED]>: : On Thu, Oct 07, 2004 at 04:05:14AM +0200, Bas van Gompel wrote: [...] : > s/-v/-h/. (I'm waiting for the other (trailing slash) patch to be : > applied or rejected, before submitting this.) : : I missed the

Re: [Patch] cygcheck: warn about empty path-components

2004-10-06 Thread Christopher Faylor
On Thu, Oct 07, 2004 at 04:05:14AM +0200, Bas van Gompel wrote: >Op Wed, 6 Oct 2004 10:58:05 -0400 schreef Christopher Faylor >in <[EMAIL PROTECTED]>: >: On Wed, Oct 06, 2004 at 10:49:09AM +0200, Bas van Gompel wrote: > >[Empty path-components resolving to current dir.] > >: > (Maybe the message c

Re: [Patch] cygcheck: warn about empty path-components

2004-10-06 Thread Bas van Gompel
Op Wed, 6 Oct 2004 11:49:39 +0200 schreef Corinna Vinschen in <[EMAIL PROTECTED]>: : On Oct 6 10:49, Bas van Gompel wrote: : > Op Tue, 5 Oct 2004 16:46:49 +0200 schreef Corinna Vinschen : > in <[EMAIL PROTECTED]>: : > : > [Empty path-components resolving to current dir.] [...] : > Are you apply

Re: [Patch] cygcheck: warn about empty path-components

2004-10-06 Thread Bas van Gompel
Op Wed, 6 Oct 2004 10:58:05 -0400 schreef Christopher Faylor in <[EMAIL PROTECTED]>: : On Wed, Oct 06, 2004 at 10:49:09AM +0200, Bas van Gompel wrote: [Empty path-components resolving to current dir.] : > (Maybe the message could get a ``-v'' addition like: ``This will : > resolve to the current

Re: [Patch] cygcheck: warn about empty path-components

2004-10-06 Thread Christopher Faylor
On Wed, Oct 06, 2004 at 10:49:09AM +0200, Bas van Gompel wrote: >Op Tue, 5 Oct 2004 16:46:49 +0200 schreef Corinna Vinschen >in <[EMAIL PROTECTED]>: > >[Empty path-components resolving to current dir.] > >: Oh, interesting. I never even thought about using an empty path. > >Nor I. Thw described b

Re: [Patch] cygcheck: warn about empty path-components

2004-10-06 Thread Corinna Vinschen
On Oct 6 10:49, Bas van Gompel wrote: > Op Tue, 5 Oct 2004 16:46:49 +0200 schreef Corinna Vinschen > in <[EMAIL PROTECTED]>: > > [Empty path-components resolving to current dir.] > > : Oh, interesting. I never even thought about using an empty path. > > Nor I. Thw described behaviour makes th

Re: [Patch] cygcheck: warn about empty path-components

2004-10-06 Thread Bas van Gompel
Op Tue, 5 Oct 2004 16:46:49 +0200 schreef Corinna Vinschen in <[EMAIL PROTECTED]>: [Empty path-components resolving to current dir.] : Oh, interesting. I never even thought about using an empty path. Nor I. Thw described behaviour makes the warning even more useful (when cygcheck is run from a

Re: [Patch] cygcheck: warn about empty path-components

2004-10-05 Thread Corinna Vinschen
On Oct 5 10:34, Christopher Faylor wrote: > On Tue, Oct 05, 2004 at 09:09:31AM -0500, Brian Ford wrote: > >The current directory is specified by a null path name, which can appear > >immediately after the equal sign, between two colon delimiters anywhere in > >the path list, or at the end of the p

Re: [Patch] cygcheck: warn about empty path-components

2004-10-05 Thread Christopher Faylor
On Tue, Oct 05, 2004 at 09:09:31AM -0500, Brian Ford wrote: >On Tue, 5 Oct 2004, Corinna Vinschen wrote: > >> Chris, I might be missing something but that looks like a bug in >> conv_path_list to me. Why is conv_fn called with "." for empty >> strings instead of ignoring the empty path? >> >> Is a

Re: [Patch] cygcheck: warn about empty path-components

2004-10-05 Thread Brian Ford
On Tue, 5 Oct 2004, Corinna Vinschen wrote: > Chris, I might be missing something but that looks like a bug in > conv_path_list to me. Why is conv_fn called with "." for empty > strings instead of ignoring the empty path? > > Is an empty path component a windowzism I don't know about? I don't kn

Re: [Patch] cygcheck: warn about empty path-components

2004-10-05 Thread Corinna Vinschen
On Oct 5 07:15, Bas van Gompel wrote: > Hi, > > This little patch makes cygcheck warn about empty path-components > (leading/trailing/double ':'/';' in $PATH). > > > ChangeLog-entry: > > 2004-10-05 Bas van Gompel <[EMAIL PROTECTED]> > > * cygcheck.cc (dump_sysinfo): Warn about empty p

[Patch] cygcheck: warn about empty path-components

2004-10-04 Thread Bas van Gompel
Hi, This little patch makes cygcheck warn about empty path-components (leading/trailing/double ':'/';' in $PATH). ChangeLog-entry: 2004-10-05 Bas van Gompel <[EMAIL PROTECTED]> * cygcheck.cc (dump_sysinfo): Warn about empty path-components. --- src/winsup/utils/cygcheck.cc4