Hi Jeremy,
On Mon, 7 Jul 2025, Jeremy Drake wrote:
> On Mon, 7 Jul 2025, Johannes Schindelin wrote:
>
> > fix by a regression test in `winsup/testsuite/`?
> >
> > For several days, I tried to find a way to reproduce a way to reproduce
> > the SSH hang using combi
Hi Takashi,
On Thu, 3 Jul 2025, Takashi Yano wrote:
> On Thu, 3 Jul 2025 11:15:44 +0200 (CEST)
> Johannes Schindelin wrote:
> >
> > On Thu, 3 Jul 2025, Takashi Yano wrote:
> >
> > > I noticed this patch needs additional fix. Please apply also
> > > h
Hi Takashi,
On Thu, 3 Jul 2025, Takashi Yano wrote:
> On Tue, 1 Jul 2025 14:01:45 +0200 (CEST)
> Johannes Schindelin wrote:
> >
> > thank you so much for this patch! I released a new Git for Windows
> > version including it:
> > https://github.com/git-for-wi
s: 746c8116dd4f ("Cygwin: console: Allow pasting very long text input.")
> Reported-by: Johannes Schindelin
> Signed-off-by: Takashi Yano
> ---
> winsup/cygwin/fhandler/console.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/winsup/
conflicts with the SSH hang fix (because you
dug deeper and identified a different part of the code as needing to be
fixed), I'd be very happy if you fast-tracked this patch.
Thank you,
Johannes
>
> Reviewed-by: Johannes Schindelin
> Signed-off-by: Takashi Yano
> ---
> wins
Hi Takashi,
On Fri, 27 Jun 2025, Takashi Yano wrote:
> ... rather than 1 when the pipe space estimation fails, so that
> select() and raw_wrie() can perform appropriate fallback handling.
> In select(), even if pipe space is unknown, return writable to avoid
> deadlock. Even with select() return
rformed
> even if NtQueryInformationFile() returns non-zero value so that
> the amount of the writable space in the pipe is always estimated
> correctly.
>
> Addresses: https://github.com/git-for-windows/git/issues/5682
> Fixes: 7ed9adb356df ("Cygwin: pipe: Switch pipe mode t
Hi Takashi,
while I usually would like code comments to be in sync with the code (and
therefore have it be changed in the same commit), in this instance I
totally agree that it made sense to refactor them out into their own patch
because they are quite extensive and would otherwise have drowned ou
Hi Takashi,
On Fri, 27 Jun 2025, Takashi Yano wrote:
> On Fri, 27 Jun 2025 12:25:18 +0200 (CEST)
> Johannes Schindelin wrote:
>
> > > Also, pipe_data_available() returns PDA_UNKNOWN rather than 1 when the
> > > pipe space estimation fails so that select()
unrelated? Would this not rather be in a separate patch, to
make it substantially easier to review for correctness?
> Addresses: https://github.com/git-for-windows/git/issues/5682
> Fixes: 7ed9adb356df ("Cygwin: pipe: Switch pipe mode to blocking mode by
> default")
> Reporte
ttps://github.com/git-for-windows/git/issues/5682#issuecomment-2997428207
> Fixes: 7ed9adb356df ("Cygwin: pipe: Switch pipe mode to blocking mode by
> default")
> Reported-by: Andrew Ng (nga888 @github)
You may want to use Andrew Ng instead.
Other than that, this patch
Hi Takashi,
On Thu, 26 Jun 2025, Takashi Yano wrote:
> On Wed, 25 Jun 2025 14:55:35 +0200 (CEST)
> Johannes Schindelin wrote:
> >
> > On Wed, 25 Jun 2025, Takashi Yano wrote:
> >
> > > Reviewed-by:
> > > Signed-off-by: Takashi Yano
> >
> >
Hi Takashi,
On Thu, 26 Jun 2025, Takashi Yano wrote:
> On Thu, 26 Jun 2025 22:59:26 +0900
> Takashi Yano wrote:
> > On Thu, 26 Jun 2025 14:22:49 +0900
> > Takashi Yano wrote:
> > > On Wed, 25 Jun 2025 17:57:56 +0200 (CEST)
> > > Johannes Schindelin wrote:
>
Hi Takashi,
On Wed, 25 Jun 2025, Takashi Yano wrote:
> On Wed, 25 Jun 2025 20:51:02 +0900
> Takashi Yano wrote:
> > On Wed, 25 Jun 2025 19:55:34 +0900
> > Takashi Yano wrote:
> > > Hi Johannes,
> > >
> > > On Wed, 25 Jun 2025 09:38:17 +0200 (CEST
Hi Takashi,
On Wed, 25 Jun 2025, Takashi Yano wrote:
> On Wed, 25 Jun 2025 14:07:15 +0200 (CEST)
> Johannes Schindelin wrote:
> > Hi Takashi,
> >
> > On Wed, 25 Jun 2025, Takashi Yano wrote:
> >
> > > On Wed, 25 Jun 2025 19:55:34 +0900
> > > Tak
Hi Takashi,
On Wed, 25 Jun 2025, Takashi Yano wrote:
> Reviewed-by:
> Signed-off-by: Takashi Yano
This is way too terse. There is a difference between being succinct and
leaving things unsaid.
Also, please make sure that v2 is a reply to v1 of the patch. I almost
commented on v1 by mistake.
>
Hi Takashi,
On Wed, 25 Jun 2025, Takashi Yano wrote:
> pipe_data_available() is called in the raw_write() and if the pipe
> is real_non_blocking_mode in raw_write(), the pipe mode can be
> accidentally reverted to blocking mode in some cases by calling
> pipe_data_available().
Okay, let's unpack
Hi Takashi,
On Wed, 25 Jun 2025, Takashi Yano wrote:
> On Wed, 25 Jun 2025 07:59:54 +0200 (CEST)
> Johannes Schindelin wrote:
>
> > On Wed, 25 Jun 2025, Takashi Yano wrote:
> >
> > > I found the patch blocks non-blocking write in some condition.
> >
Hi Takashi,
On Wed, 25 Jun 2025, Takashi Yano wrote:
> On Wed, 25 Jun 2025 09:38:17 +0200 (CEST)
> Johannes Schindelin wrote:
>
> > On Wed, 25 Jun 2025, Johannes Schindelin wrote:
> >
> > > On Wed, 25 Jun 2025, Takashi Yano wrote:
> > >
> > &
Hi Takashi,
On Wed, 25 Jun 2025, Takashi Yano wrote:
> On Wed, 25 Jun 2025 19:55:34 +0900
> Takashi Yano wrote:
> >
> > On Wed, 25 Jun 2025 09:38:17 +0200 (CEST)
> > Johannes Schindelin wrote:
> > >
> > > On Wed, 25 Jun 2025, Johannes Schindelin
Hi Takashi,
On Wed, 25 Jun 2025, Johannes Schindelin wrote:
> On Wed, 25 Jun 2025, Takashi Yano wrote:
>
> > I'd revise the patch as follows. Could you please test if the
> > following patch also solves the issue?
>
> Will do.
For the record, in my tests, this fi
Hi Takashi,
On Wed, 25 Jun 2025, Johannes Schindelin wrote:
> On Wed, 25 Jun 2025, Takashi Yano wrote:
>
> > I found the patch blocks non-blocking write in some condition.
>
> Could you please describe these conditions?
I had _guessed_ from looking at the diff that on
Hi Takashi,
On Wed, 25 Jun 2025, Takashi Yano wrote:
> I found the patch blocks non-blocking write in some condition.
Could you please describe these conditions?
> I'd revise the patch as follows. Could you please test if the
> following patch also solves the issue?
Will do.
Thank you,
Johann
tch).
Fixes: cbfaeba4f7 (Cygwin: pipe: Fix incorrect write length in raw_write(),
2024-11-06)
Co-authored-by: Takashi Yano
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/tag/fix-ssh-hangs-reloaded-v2
Fetch-It-Via: git fetch https://github.com/d
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/tag/fix-dotdot-native_symlink-relnote-v1
Fetch-It-Via: git fetch https://github.com/dscho/msys2-runtime
fix-dotdot-native_symlink-relnote-v1
Here you go, sorry for missing that
wever, the following `while` loop expects `len - chunk` (which is
assigned to `len1`) not to be positive in non-blocking mode.
Let's reinstate that clamping logic and implicitly fix this SSH hang.
Fixes: cbfaeba4f7 (Cygwin: pipe: Fix incorrect write length in raw_write(),
2024-11-06)
Signed-o
prefix of the parent
directory of the link itself.
Let's fix that.
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/tag/fix-dotdot-native_symlink-v1
Fetch-It-Via: git fetch https://github.com/dscho/msys2-runtime
fix-dotdot-native_symlink
_windows: skip LookupAccountSid for SIDs
known to fail, 2025-04-10) intact.
Reported-by: Robert Fensterman
Fixes: e04891d67a (Cygwin: fetch_account_from_windows: skip LookupAccountSid
for SIDs known to fail, 2025-04-10)
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho
t; Fixes: 0bfd91d57863 ("Cygwin: console: tty::restore really restores the
> previous mode")
> Reported-by: Johannes Schindelin
> Signed-off-by: Takashi Yano
Thank you! I can confirm that this re-fixes the problem fixed in
3312f2d21f (Cygwin: console: Redesign mode set strate
Hi Takashi,
On Fri, 4 Apr 2025, Takashi Yano wrote:
> On Fri, 4 Apr 2025 14:13:57 +0200 (CEST)
> Johannes Schindelin wrote:
> > On Fri, 4 Apr 2025, Takashi Yano wrote:
> > > On Fri, 04 Apr 2025 07:27:09 +0200 Johannes Schindelin wrote:
> > >
> > > > Is
Hi Takashi,
On Fri, 4 Apr 2025, Takashi Yano wrote:
> On Fri, 04 Apr 2025 07:27:09 +0200 Johannes Schindelin wrote:
>
> > Is Jeremy's guess "if raw_write doesn't need to wait (ie, there's room
> > in the pipe for the write) it doesn't hit the signal stu
-0700 (PDT)
Jeremy Drake wrote:
> On Thu, 3 Apr 2025, Johannes Schindelin wrote:
>
> > I still have a question that I would like to be answered in the commit
> > message, too:
> >
> > If `signal_arrived` is only initialized in `fixup_after_fork()` but user
> > callbacks
Hi Takashi,
On Thu, 3 Apr 2025, Takashi Yano wrote:
> Previously, the callback registered by pthread_atfork() is called
> before _my_tls.fixup_after_fork(). This causes misbehaviour if the
> callback uses tls related functions. Due to this problem, subprocess
> of cmake (> 3.29.x) sometimes fails
rrect write length in raw_write())
Helped-by: Corinna Vinschen
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/tag/fix-ninja-hang-v1
Fetch-It-Via: git fetch https://github.com/dscho/msys2-runtime fix-ninja-hang-v1
As per Corinna's requ
Hi Jeremy,
first of all: thank you for doing this! I had planned on investing some
time to figure out a "cheap" way to determine opcode lengths and skip
uninteresting ones, and it would invariably have been a lot hackier than
the solution you came up with, and I would probably have taken six month
rsp`, etc, and focuses on finding the `lea`, `call
ntdll!RtlEnterCriticalSection` and `mov ..., rbx` instructions, much
like it was prototyped out for ARM64 at
https://gist.github.com/jeremyd2019/aa167df0a0ae422fa6ebaea5b60c80c9
Signed-off-by: Johannes Schindelin
---
Published-As:
https://githu
Hi Jeremy,
On Tue, 12 Nov 2024, Jeremy Drake via Cygwin-patches wrote:
> From: Jeremy Drake
>
> This addresses an extremely difficult to debug deadlock when running
> under emulation on ARM64.
>
> A relatively easy way to trigger this bug is to call `fork()`, then within the
> child process imme
Hi Corinna and Takashi,
On Mon, 2 Sep 2024, Corinna Vinschen wrote:
> On Aug 30 23:15, Takashi Yano wrote:
> > If a cygwin app is executed from a non-cygwin app and the cygwin
> > app exits, read pipe remains on non-blocking mode because of the
> > commit fc691d0246b9. Due to this behaviour, the
on block in fhandler_pipe::get_query_hdl_per_process.
> Therefore, stop to try to get query_hdl for non-cygwin apps.
>
> Addresses: https://github.com/msys2/msys2-runtime/issues/202
>
> Fixes: b531d6b06eeb ("Cygwin: pipe: Introduce temporary query_hdl.")
> Reported-
Hi Takashi,
On Sat, 3 Feb 2024, Takashi Yano wrote:
> If disable_master_thread flag is set between the code checking that
> flag not be set and the code acquiring input_mutex, input record is
> processed once after setting disable_master_thread flag. This patch
> prevents that.
>
> Fixes: d4aacd5
Hi Takashi,
On Sat, 3 Feb 2024, Johannes Schindelin wrote:
> On Fri, 2 Feb 2024, Takashi Yano wrote:
>
> > If non-cygwin process is executed in console, the exit code is not
> > set correctly. This is because the stub process for non-cygwin app
> > cra
le: Make the console accessible from other
> terminals.")
> Reported-by: Johannes Schindelin
> Signed-off-by: Takashi Yano
Thank you for fixing this so swiftly. I still wish the logic was
drastically simpler to understand so that even mere humans like myself
would stand a chance to f
ly, this returns a valid path in path_ret. That
> > in turn allows to remove the additional path generation code
> > from the callers.
> >
> > Fixes: fa84aa4dd2fb ("Cygwin: fix errno values set by readlinkat")
> > Reported-by: Johannes Schindelin
>
Hi Takashi,
On Tue, 4 Jul 2023, Takashi Yano wrote:
> On Mon, 3 Jul 2023 12:52:25 +0200
> Corinna Vinschen wrote:
> >
> > On Jun 27 22:28, Takashi Yano wrote:
> > >
> > > diff --git a/winsup/cygwin/dtable.cc b/winsup/cygwin/dtable.cc
> > > index 18e0f3097..9427e238e 100644
> > > --- a/winsup/cygw
Hi Jeremy,
On Wed, 28 Jun 2023, Jeremy Drake wrote:
> On Tue, 27 Jun 2023, Johannes Schindelin wrote:
>
> > In 4b8222983f (Cygwin: fix errno values set by readlinkat, 2023-04-18)
> > the code of `readlinkat()` was adjusted to align the `errno` with Linux'
> > behavio
Hi Corinna,
On Mon, 3 Jul 2023, Corinna Vinschen wrote:
> Hi Johannes,
>
> On Jun 27 22:51, Johannes Schindelin wrote:
> > In 4b8222983f (Cygwin: fix errno values set by readlinkat, 2023-04-18)
> > the code of `readlinkat()` was adjusted to align the `errno` with Linux'
annot change mode to rwxr-xr-x: Not a directory
With this here fix, things start working as expected again.
Fixes: 4b8222983f (Cygwin: fix errno values set by readlinkat, 2023-04-18)
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/tag/fix-t
like `readlinkat()`: `fchmodat()` and `fstatat()`.
Therefore, these two callers need to be changed to expect `ENOTDIR` in
case of an empty `pathname`, too.
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/tag/fix-tar-xf-with-symlinks-cygwin-v1
Fetch-I
Reportedly Windows 11 build 25*** from Insider changed the current
working directory logic a bit, and Cygwin's "magic" (or:
"technologically sufficiently advanced") code needs to be adjusted
accordingly.
This fixes https://github.com/git-for-windows/git/issues/4429
y to include
absolute paths with drive prefixes, but also UNC paths.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc
index 5e2d88bcd7..21d729d5dc 100644
--- a/
ce these IIS APPPOOL accounts are relatively similar to AzureAD
accounts in this scenario, let's imitate the latter to support also the
former.
Reported-by: David Ebbo
Helped-by: Corinna Vinschen
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 107
We should not blindly set the home directory of the SYSTEM account (or
of Microsoft accounts) to `/home/`, especially
`/etc/nsswitch.conf` defines `db_home: env`, in which case we want to
respect the `HOME` variable.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 6 +-
1
ntation-fixes-by: Corinna Vinschen
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/local_includes/cygheap.h | 3 +-
winsup/cygwin/uinfo.cc | 51 ++
winsup/doc/ntsec.xml | 20 +-
3 files changed, 72 insertions(+), 2 deletion
ome that this only affects the
_current_ user's home directory
- Using the `PUSER_INFO_3` variant of `get_home()`
- Adjusted the commit messages
- Added another patch, to support "ad-hoc cloud accounts"
Johannes Schindelin (4):
Allow deriving the current user's home directory
Hi Corinna,
On Thu, 6 Apr 2023, Corinna Vinschen wrote:
> On Apr 4 17:07, Johannes Schindelin wrote:
> > In the very early code path where `dll_crt0_1 ()` calls
> > `user_shared->initialize ()`, the Cygwin runtime calls `internal_pwsid ()`
> > to initialize the user
Hi Corinna,
On Mon, 3 Apr 2023, Corinna Vinschen wrote:
> On Apr 3 16:45, Johannes Schindelin wrote:
> > We should not blindly set the home directory of the SYSTEM account (or
> > of Microsoft accounts) to `/home/`, especially
> > `/etc/nsswitch.conf` defines `db_home: e
Hi Corinna,
On Mon, 3 Apr 2023, Corinna Vinschen wrote:
> On Apr 3 16:44, Johannes Schindelin wrote:
> > This patch hails from Git for Windows (where the Cygwin runtime is used
> > in the form of a slightly modified MSYS2 runtime), where it is a
> > well-established techni
Hi Corinna,
On Mon, 3 Apr 2023, Corinna Vinschen wrote:
> On Apr 3 15:57, Johannes Schindelin wrote:
> > On Mon, 3 Apr 2023, Corinna Vinschen wrote:
> > > > So here is what is going on:
> > > >
> > > > - The domain is 'IIS APPPOOL'
> &g
separator of
that `/etc/passwd`-formatted line, and instead of a Windows path, we now
have a mere drive letter.
Let's detect when the `HOME` value is still in Windows format in
`fetch_home_env ()`, and convert it in that case.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 8 ++
ce these IIS APPPOOL accounts are relatively similar to AzureAD
accounts in this scenario, let's imitate the latter to support also the
former.
Reported-by: David Ebbo
Helped-by: Corinna Vinschen
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 107
We should not blindly set the home directory of the SYSTEM account (or
of Microsoft accounts) to `/home/`, especially
`/etc/nsswitch.conf` defines `db_home: env`, in which case we want to
respect the `HOME` variable.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 6 +-
1
ntation-fixes-by: Corinna Vinschen
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/local_includes/cygheap.h | 3 +-
winsup/cygwin/uinfo.cc | 51 ++
winsup/doc/ntsec.xml | 20 +-
3 files changed, 72 insertions(+), 2 deletion
he
`GetEnvironmentVariableW()`/`cygwin_conv_path()` dance
- Adjusted the documentation to drive home that this only affects the
_current_ user's home directory
- Using the `PUSER_INFO_3` variant of `get_home()`
- Adjusted the commit messages
- Added another patch, to support "ad-hoc c
ll receive the return
value -1, and the subsequent `getpwuid()` call (whose return value's
`pw_dir` is used as home directory) needs to be forced to respect
`db_home: env`, which this here patch does.
Reported-by: David Ebbo
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 1
We should not blindly set the home directory of the SYSTEM account (or
of Microsoft accounts) to `/home/`, especially
`/etc/nsswitch.conf` defines `db_home: env`, in which case we want to
respect the `HOME` variable.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 6 +-
1
ntation-fixes-by: Corinna Vinschen
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/local_includes/cygheap.h | 3 +-
winsup/cygwin/uinfo.cc | 51 ++
winsup/doc/ntsec.xml | 20 +-
3 files changed, 72 insertions(+), 2 deletion
t_home()`
- Adjusted the commit messages
- Added another patch, to support "ad-hoc cloud accounts"
Johannes Schindelin (3):
Allow deriving the current user's home directory via the HOME variable
Respect `db_home` setting even for SYSTEM/Microsoft accounts
Respect `db_home: env`
Hi Corinna,
On Mon, 3 Apr 2023, Corinna Vinschen wrote:
> On Apr 3 15:12, Johannes Schindelin wrote:
>
> > On Mon, 3 Apr 2023, Johannes Schindelin wrote:
> >
> > > On Tue, 28 Mar 2023, Corinna Vinschen wrote:
> > >
> > > > On Mar 28 10:17, Johanne
Hi Corinna,
On Mon, 3 Apr 2023, Corinna Vinschen wrote:
> On Apr 3 08:36, Johannes Schindelin wrote:
> > Hi Corinna,
> >
> > On Tue, 28 Mar 2023, Corinna Vinschen wrote:
> >
> > > On Mar 28 10:17, Johannes Schindelin wrote:
> > > > We should
Hi Corinna,
On Mon, 3 Apr 2023, Johannes Schindelin wrote:
> On Tue, 28 Mar 2023, Corinna Vinschen wrote:
>
> > On Mar 28 10:17, Johannes Schindelin wrote:
>
> > > diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc
> > > index d493d29b3b..b01bcff5cb
Hi Corinna,
On Mon, 3 Apr 2023, Johannes Schindelin wrote:
> On Tue, 28 Mar 2023, Corinna Vinschen wrote:
>
> > On Mar 28 10:17, Johannes Schindelin wrote:
> > > In particular when we cannot figure out a uid for the current user, we
> > > should still respect the
Hi Corinna,
On Tue, 28 Mar 2023, Corinna Vinschen wrote:
> On Mar 28 10:17, Johannes Schindelin wrote:
> > In particular when we cannot figure out a uid for the current user, we
> > should still respect the `db_home: env` setting. Such a situation occurs
> > for example whe
Hi Corinna & Jon,
On Wed, 29 Mar 2023, Corinna Vinschen wrote:
> On Mar 28 15:31, Corinna Vinschen wrote:
> > On Mar 28 13:34, Jon Turney wrote:
> > > On 28/03/2023 11:35, Corinna Vinschen wrote:
> > > > Apart from the doc change, the patch is ok now.
> > >
> > > The preceding text says "Four sch
Hi Corinna,
On Tue, 28 Mar 2023, Corinna Vinschen wrote:
> On Mar 28 10:17, Johannes Schindelin wrote:
> > We should not blindly set the home directory of the SYSTEM account (or
> > of Microsoft accounts) to /home/SYSTEM, especially not
Hi Brian,
On Fri, 25 Feb 2022, Brian Inglis wrote:
> On 2022-02-21 06:36, Johannes Schindelin wrote:
> > These symbolic links are crucial e.g. to support process substitution
> > (Bash's
> > very nice `<(SOME-COMMAND)` feature).
> >
> > For various reaso
Hi Corinna,
On Mon, 28 Feb 2022, Corinna Vinschen wrote:
> On Feb 28 10:24, Corinna Vinschen wrote:
> > On Feb 25 16:46, Johannes Schindelin wrote:
> > > On Tue, 22 Feb 2022, Corinna Vinschen wrote:
> > > > On Feb 21 14:36, Johannes Schindelin wrote:
> >
Hi Jon,
On Wed, 14 Dec 2022, Jon Turney wrote:
> On 11/12/2022 14:45, Johannes Schindelin wrote:
> > On December 11, 2022 2:54:02 PM GMT+01:00, Jon Turney
> > wrote:
> > > On 05/12/2022 15:23, Johannes Schindelin wrote:
> > > > On Mon, 28 Nov 2022, Corinna Vi
Hi Corinna,
On Mon, 21 Nov 2022, Corinna Vinschen wrote:
> On Nov 18 09:18, Johannes Schindelin wrote:
> > Hi Corinna,
> >
> > On Thu, 10 Nov 2022, Corinna Vinschen wrote:
> > > On Nov 10 16:16, Johannes Schindelin wrote:
> > > > With this context in
We should not blindly set the home directory of the SYSTEM account (or
of Microsoft accounts) to /home/SYSTEM, especially not when that value
disagrees with what is configured via the `db_home` line in the
`/etc/nsswitch.conf` file.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc
a cloud scenario.
Reported by David Ebbo.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc
index d493d29b3b..b01bcff5cb 100644
--- a/winsup/cygwin
tioned above: `$HOMEDRIVE$HOMEPATH` or
`$USERPROFILE`. This has the additional advantage that it is much
faster than querying the Windows user database.
Of course this scheme needs to be opt-in. For that reason, it needs
to be activated explicitly via `db_home: env` in `/etc/nsswitch.conf`.
Signed-of
VariableW()`/`cygwin_conv_path()` dance
- Adjusted the documentation to drive home that this only affects the
_current_ user's home directory
- Using the `PUSER_INFO_3` variant of `get_home()`
- Adjusted the commit messages
- Added another patch, to support "ad-hoc cloud accounts&quo
ected,
link to it in addition to `libbfd`.
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/tag/do-link-libsframe-if-available-v1
Fetch-It-Via: git fetch https://github.com/dscho/msys2-runtime
do-link-libsframe-if-available-v1
winsup/configu
On December 11, 2022 2:54:02 PM GMT+01:00, Jon Turney
wrote:
>On 05/12/2022 15:23, Johannes Schindelin wrote:
>> On Mon, 28 Nov 2022, Corinna Vinschen wrote:
>>> On Nov 28 13:00, Jon Turney wrote:
>>>> On 15/11/2022 10:46, Corinna Vinschen wrote:
>>>>
Hi,
On Mon, 28 Nov 2022, Corinna Vinschen wrote:
> On Nov 28 13:00, Jon Turney wrote:
> > On 15/11/2022 10:46, Corinna Vinschen wrote:
> > >
> > > It would be great if we could get used to using the same syntax as the
> > > Linux kernel project to document stuff. I'm trying to follow their lead
Hi Corinna,
On Mon, 24 Oct 2022, Corinna Vinschen wrote:
> However, two points:
>
> - I'm wondering if the patch (both of yours) doesn't actually just cover
> a problem in child_info_spawn::worker(). Different runpath values,
> depending on the app path being "cmd" or "cmd.exe"? That sounds
Hi Corinna,
On Thu, 10 Nov 2022, Corinna Vinschen wrote:
> On Nov 10 16:16, Johannes Schindelin wrote:
>
> > On Mon, 24 Oct 2022, Corinna Vinschen wrote:
> >
> > > On Oct 23 23:04, Johannes Schindelin wrote:
> > > > On Tue, 18 Oct 2022, Corinna Vinschen wr
Hi Corinna,
On Mon, 24 Oct 2022, Corinna Vinschen wrote:
> On Oct 23 23:04, Johannes Schindelin wrote:
> > On Tue, 18 Oct 2022, Corinna Vinschen wrote:
> > [...]
> > > That means, the results from the "env" method is equivalent to the
> > > "windo
Hi Corinna,
On Tue, 18 Oct 2022, Corinna Vinschen wrote:
> On Sep 21 13:58, Johannes Schindelin wrote:
> > Hi Corinna,
> >
> > sorry for the blast from the past, but I am renewing my efforts to
> > upstream Git for Windows' patches that can be upstreamed.
>
Hi Takashi,
On Sat, 22 Oct 2022, Takashi Yano wrote:
> On Sat, 22 Oct 2022 07:55:53 +0200
> Johannes Schindelin wrote:
> > It's not very nice to simply drop my work, and then not even link to your
> > "counter".
>
> I am sorry, however, your patch can
Hi Takashi,
On Sat, 22 Oct 2022, Takashi Yano wrote:
> On Sat, 22 Oct 2022 07:58:37 +0200
> Johannes Schindelin wrote:
> > On October 22, 2022 7:34:20 AM GMT+02:00, Takashi Yano
> > wrote:
> > >- If the command executed is 'cmd.exe /c [...]', runpath in
On October 22, 2022 7:34:20 AM GMT+02:00, Takashi Yano
wrote:
>- If the command executed is 'cmd.exe /c [...]', runpath in spawn.cc
> will be NULL. In this case, is_console_app(runpath) check causes
> access violation. This case also the command executed is obviously
> console app., therefore,
On October 22, 2022 7:37:09 AM GMT+02:00, Takashi Yano
wrote:
>On Sat, 22 Oct 2022 10:54:06 +0900
>Takashi Yano wrote:
>> On Sat, 22 Oct 2022 10:36:39 +0900
>> Takashi Yano wrote:
>> > On Fri, 21 Oct 2022 23:37:35 +0200 (CEST)
>> > Johannes Schindelin wrot
`Bad address` error.
Let's guard the code properly so that it does not try to look at the
file name suffix of `(WCHAR *)NULL`.
This fixes https://github.com/msys2/msys2-runtime/issues/108
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/t
Hi Corinna,
On Thu, 17 Dec 2015, Corinna Vinschen wrote:
> On Dec 17 19:05, Johannes Schindelin wrote:
> > We should not blindly set the home directory of the SYSTEM account to
> > /home/SYSTEM, especially not when that value disagrees with what is
> > configured via the
Hi Corinna,
sorry for the blast from the past, but I am renewing my efforts to
upstream Git for Windows' patches that can be upstreamed.
On Thu, 17 Dec 2015, Corinna Vinschen wrote:
> On Dec 17 19:05, Johannes Schindelin wrote:
> > [...]
> > diff --git a/winsup/cygwin/uinf
a cloud scenario.
Reported by David Ebbo.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc
index 5e4243fa4e..b79c2b265d 100644
--- a/winsup/cygwin
We should not blindly set the home directory of the SYSTEM account (or
of Microsoft accounts) to /home/SYSTEM, especially not when that value
disagrees with what is configured via the `db_home` line in the
`/etc/nsswitch.conf` file.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc
tioned above: `$HOMEDRIVE$HOMEPATH` or
`$USERPROFILE`. This has the additional advantage that it is much
faster than querying the Windows user database.
Of course this scheme needs to be opt-in. For that reason, it needs
to be activated explicitly via `db_home: env` in `/etc/nsswitch.conf`.
Signed-of
mit messages
- Added another patch, to support "ad-hoc cloud accounts"
Johannes Schindelin (3):
Allow deriving the current user's home directory via the HOME variable
Respect `db_home` setting even for SYSTEM/Microsoft accounts
Respect `db_home: env` even when no ui
1 - 100 of 151 matches
Mail list logo
