Hi Takashi, On Wed, 25 Jun 2025, Takashi Yano wrote:
> On Wed, 25 Jun 2025 09:38:17 +0200 (CEST) > Johannes Schindelin wrote: > > > On Wed, 25 Jun 2025, Johannes Schindelin wrote: > > > > > On Wed, 25 Jun 2025, Takashi Yano wrote: > > > > > > > I'd revise the patch as follows. Could you please test if the > > > > following patch also solves the issue? > > > > > > Will do. > > > > For the record, in my tests, this fixed the hangs, too. > > Thanks for testing. > However, I noticed that this patch changes the behavior Corinna was > concerned about. > > After trying various things, I found yet another solution for the issue. > > diff --git a/winsup/cygwin/fhandler/pipe.cc b/winsup/cygwin/fhandler/pipe.cc > index e35d523bb..e36aa57fc 100644 > --- a/winsup/cygwin/fhandler/pipe.cc > +++ b/winsup/cygwin/fhandler/pipe.cc > @@ -647,7 +647,7 @@ fhandler_pipe_fifo::raw_write (const void *ptr, size_t > len) > } > if (!NT_SUCCESS (status)) > break; > - if (io.Information > 0 || len <= PIPE_BUF || short_write_once) > + if (io.Information > 0 || len <= PIPE_BUF) > break; > /* Independent of being blocking or non-blocking, if we're here, > the pipe has less space than requested. If the pipe is a > > Johannes, could you please test this patch as well? Do you mean on top of v2? Or without its changes? And what is the explanation that the commit message should carry? Sorry, this is too terse. Ciao, Johannes
